zkbot
54ce3c46dd
Auto merge of #1323 - bitcartel:zc.v0.11.2.latest_update_payment_api_doc, r=ebfull
...
Update payment-api.md
Add z_getoperationresult to documentation.
@ebfull This document might be updated again with a few notes, so let's merge closer to release. Thanks.
2016-08-31 20:06:34 +00:00
Jack Grigg
0736fa14fc
Keep any existing cached witnesses when updating transactions
2016-08-31 21:16:59 +12:00
Jack Grigg
be86b6c332
Add test for GetNoteDecryptor()
2016-08-31 18:57:32 +12:00
Jack Grigg
1551db870a
Add transactions to wallet if we spend notes in them
2016-08-31 18:28:00 +12:00
Jack Grigg
38a6e7a74d
Set witness cache size equal to coinbase maturity duration
...
Both constants have the same implicit assumption: that the blockchain will very
rarely undergo a reorganisation of that size.
2016-08-31 15:26:49 +12:00
Jack Grigg
ad20f2149a
mapNullifiers -> mapNullifiersToNotes for clarity
2016-08-31 15:11:35 +12:00
Jack Grigg
4086e5ce98
Replace vAnchorCache with a cache size counter
...
The anchor is obtained from the returned witnesses; since all witnesses are to
the same point (the latest blockchain tip), they all have the same root.
2016-08-31 15:03:42 +12:00
bitcartel
6555546edf
Update payment-api.md
2016-08-30 19:57:16 -07:00
zkbot
f9c02827d4
Auto merge of #1300 - ThisIsNotOfficialCodeItsJustForks:t915-add-wformat-security.2, r=ebfull
...
Add -Wformat -Wformat-security
Closes #915 . Supersedes #1267 (because of weird rebase/github/zkbot bug).
2016-08-30 22:31:48 +00:00
Simon
5d50130bc9
Closes #1315 . RPC getblocksubsidy height parameter is now optional and
...
a test has been added to verify parameter input and results.
2016-08-30 15:11:07 -07:00
zkbot
835588a629
Auto merge of #1314 - str4d:fix-getblock-solution-output, r=ebfull
...
Output Equihash solution in RPC results as a hex string
When the Equihash solution was changed to a compact form in #1175 , the block header changed from storing a vector of indices to a vector of chars. `blockToJSON()` was not updated, which meant that RPC calls like `getblock` returned the solution as a list of 1344 integers.
This PR changes `blockToJSON()` to output the Equihash solution as a hex string, identical to how it appears in the block header.
2016-08-30 18:40:19 +00:00
zkbot
6731665a12
Auto merge of #1313 - bitcartel:zc.v0.11.2.z9_1122, r=ebfull
...
Fixes #1122 where json_spirit could stack overflow
See #1122 for details.
2016-08-30 18:00:11 +00:00
Jack Grigg
3fac1020e7
Remove GetNoteDecryptors(), lock inside FindMyNotes() instead
2016-08-31 02:09:17 +12:00
Jack Grigg
de42390f90
Pass ZCIncrementalMerkleTree to wallet to prevent race conditions
2016-08-31 02:00:11 +12:00
Jack Grigg
3e3da44c71
Test solution output of blockToJSON()
2016-08-30 14:42:49 +12:00
zkbot
e0fa312756
Auto merge of #1307 - str4d:remove-debug-pow-code, r=ebfull
...
Undo debugging change from 5be6abbf84
This was unintentionally committed, and caused Equihash verification of blocks
without parents to be skipped. This only affects the genesis block on the test
network, but also causes the "time verifyequihash" benchmark to incorrectly
appear instantaneous.
2016-08-29 22:09:17 +00:00
Jack Grigg
769e031c1a
Update cached incremental witnesses when the active block chain tip changes
2016-08-30 00:29:49 +12:00
Jack Grigg
be74c80deb
Add caching of incremental witnesses for spendable notes
2016-08-30 00:29:49 +12:00
Jack Grigg
8db7e25c3f
Create mapping from nullifiers to received notes
...
This is used in the same way as CTxIn.prevout (e.g. to mark transactions dirty).
2016-08-30 00:29:49 +12:00
Jack Grigg
0f1060478f
Keep track of spent notes, and detect and report conflicts
2016-08-30 00:29:49 +12:00
Jack Grigg
c3a7307a69
Store mapping between notes and PaymentAddresses in CWalletTx
2016-08-30 00:29:49 +12:00
Jack Grigg
02e674555e
Add wallet method for finding spendable notes in a CTransaction
2016-08-30 00:29:49 +12:00
Jack Grigg
5db5e42ec3
Add optional bool to disable computation of proof in JSDescription constructor
2016-08-30 00:29:49 +12:00
Simon
1f882153b6
Throw a domain error as json_spirit is a third-party library.
2016-08-27 09:14:25 -07:00
Jack Grigg
e1dde421c3
Output Equihash solution in RPC results as a hex string
2016-08-27 23:58:11 +12:00
Simon
df3af446e7
Fixes #1122 where json_spirit could stack overflow because there
...
was no maximum limit set on the number of nested compound elements.
2016-08-26 23:35:45 -07:00
Sean Bowe
7ee82c4361
Deallocate the public parameters during Shutdown.
2016-08-26 16:55:43 -06:00
Taylor Hornby
6dcb706734
Use -Wformat in the test for -Wformat-security
2016-08-26 10:14:33 -06:00
Jack Grigg
488e61e852
Undo debugging change from 5be6abbf84
...
This was unintentionally committed, and caused Equihash verification of blocks
without parents to be skipped. This only affects the genesis block on the test
network, but also causes the "time verifyequihash" benchmark to incorrectly
appear instantaneous.
2016-08-26 14:09:25 +12:00
zkbot
77a99f4a2a
Auto merge of #1285 - ralphtheninja:zc.v0.11.2.latest, r=daira
...
update FormatException()
changed module name from "bitcoin" to "Zcash" in FormatException()
2016-08-26 02:06:23 +00:00
Daira Hopwood
e7f12c2057
Update steps after D
2016-08-25 21:21:33 +01:00
zkbot
8b139c2441
Auto merge of #1303 - daira:z9-version-number, r=daira
...
Update version number and add release notes for z9.
refs #1290
2016-08-25 19:32:20 +00:00
Daira Hopwood
727ed5ffa3
Update pchMessageStart for the z9 testnet. ⚧Ⓐ
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-25 15:55:51 +01:00
Daira Hopwood
d3f6eed98b
Update doc/README.md and add z9 release notes.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-25 15:07:53 +01:00
Daira Hopwood
bda0693aab
Increment version number for z9 release.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2016-08-25 15:07:16 +01:00
zkbot
f8b73015bc
Auto merge of #1208 - bitcartel:z8_rpc_keys, r=daira
...
RPC calls to manage zkey creation, management and backup
Rebased on PR #1205 for keystore functionality.
For #1197 , implements:
z_getnewaddress
z_importkey
z_exportkey
For #1198 , spending key support added to:
z_exportwallet
z_importwallet
Example dump file containing zkeys:
https://gist.github.com/bitcartel/d7013b30b19419c6a550bc5d6ff6cc47
Also adds:
z_listaddresses
Tests in:
gtest/test_wallet_zkeys
test/rpc_wallet_tests
2016-08-25 13:49:05 +00:00
zkbot
cca52f36df
Auto merge of #1301 - bitcartel:zc.v0.11.2.latest_701_md_formatting, r=daira
...
Fix formatting of first paragraph of payment API document
The description of taddr and zaddr were bunched up one line. This PR fixes the issue.
Self-ACK. Please merge.
2016-08-25 10:09:56 +00:00
Simon
d1f16ffe85
Fix formatting.
2016-08-24 21:47:46 -07:00
Taylor Hornby
5d37904b9c
Add -Wformat -Wformat-security
2016-08-24 16:38:37 -06:00
Simon
3bff998b38
Rename methods to avoid using prefix of _ underscore which is reserved.
...
Added logging of explicit exception rather than a catch all.
Removed redundant spending key check.
Updated user facing help message.
2016-08-24 11:55:26 -07:00
Simon
4b2e557181
Fix comments.
2016-08-24 11:19:34 -07:00
Simon
309b0ecd80
Add "zkey" to list of key types (used by the wallet to decide
...
whether or not it can be recovered if it detects bad records).
2016-08-24 11:19:34 -07:00
Simon
79d769a382
Remove one line of dead code.
2016-08-24 11:19:34 -07:00
Simon
2e0cc87acf
Fix comment.
2016-08-24 11:19:34 -07:00
Simon
badb9a9c2f
Add test coverage for RPC call z_getnewaddress.
2016-08-24 11:19:34 -07:00
Simon
60f762a549
Added wallet rpc tests to cover:
...
z_importwallet, z_exportwallet
z_importkey, z_exportkey
z_listaddresses
2016-08-24 11:19:34 -07:00
Simon
0feffd1424
Don't mark wallet as dirty if key already exists.
...
Fix incorrect method name used in error message.
2016-08-24 11:19:33 -07:00
Simon
4cea36bef3
Add gtest to cover new methods in:
...
CWallet
- GenerateNewZKey()
- AddZKey()
- LoadZKey()
- LoadZKeyMetadata()
CWalletDB
- WriteZKey()
2016-08-24 11:19:33 -07:00
Simon
e709997ff2
Implemented z_listaddresses to return all the zaddr in the wallet.
2016-08-24 11:19:33 -07:00
Simon
92444edc00
Add z_importwallet and z_exportwallet to handle keys for both
...
taddr and zaddr. Restore behaviour of dumpwallet and importwallet
to only handle taddr.
2016-08-24 11:19:33 -07:00