73bc7a068d
Replace uses of boost::filesystem with fs
...
Step two in abstracting away boost::filesystem.
To repeat this, simply run:
```
git ls-files \*.cpp \*.h | xargs sed -i 's/boost::filesystem/fs/g'
```
2020-10-22 01:11:37 +01:00
7044e39a57
Replace includes of boost/filesystem.h with fs.h
...
This is step one in abstracting the use of boost::filesystem.
2020-10-22 01:11:37 +01:00
082f530d6e
Add fs.cpp/h
2020-10-22 01:11:37 +01:00
dafc0d35eb
Move GetTempPath() to testutil.
2020-10-22 01:11:37 +01:00
42929fae9d
Add a source file for unit test utils.
2020-10-22 01:11:37 +01:00
cafc622a22
Auto merge of #4757 - str4d:update-secp256k1, r=str4d
...
Update secp256k1
This migrates us to the same dependency version that upstream Bitcoin
Core migrated to in bitcoin/bitcoin#19944 .
Also enables the endomorphism optimization now that the patents have
expired.
2020-10-21 16:55:47 +00:00
43ab084854
Auto merge of #4611 - str4d:c++17, r=str4d
...
Require and build with C++17
Closes zcash/zcash#4607 .
2020-10-20 14:28:42 +00:00
d0cb0b74aa
Switch from std::random_shuffle to std::shuffle
...
std::random_shuffle is removed in C++17; it is replaced by std::shuffle,
which was introduced in C++11. The new ZcashRandomEngine class provides
the Uniform Random Number Generator interface, as inferred from
std::random_device.
2020-10-20 13:58:23 +01:00
c656ae1303
Add new copyright entries for build-aux/m4/ax_cxx_compile_stdcxx.m4
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-20 13:55:14 +01:00
9052751c21
depends: Build C++ dependencies with C++ 17
2020-10-20 13:55:14 +01:00
9d1a11a0e4
build: Require and build with C++ 17
2020-10-20 13:55:14 +01:00
40a5bdfc76
build: Update AX_CXX_COMPILE_STDCXX macro
2020-10-20 13:55:14 +01:00
de5c28b4b7
Auto merge of #4613 - str4d:claaaaaang, r=daira
...
Pin Clang for all compilation
fixes #2513 , fixes #4697 , fixes #4698 , fixes #4699 . refs #4607 , #4292
2020-10-20 11:15:47 +00:00
8fa19fd50d
Auto merge of #4794 - LarryRuane:allow-getaddressutxos, r=daira
...
allow getaddressutxos if -lightwalletd
The wallets need to be able to retrieve, via lightwalletd, the UTXO set for a given address, see https://github.com/zcash/lightwalletd/issues/312 . The `getaddressutxos` rpc that was added for Insight Explorer is perfect for this, but this rpc is disabled when only `-lightwalletd` is enabled (that is, it requires `-insightexplorer`, which is a superset of `-lightwalletd`). However, the `DB_ADDRESSUNSPENTINDEX` index that supports this rpc is present when only `-lightwalletd` is enabled. This was probably a (fortuitous, as it turns out) oversight. So all that's required is to allow this rpc when `-lightwalletd` is enabled.
2020-10-20 09:31:39 +00:00
0dc05a7722
Auto merge of #4790 - therealyingtong:add-addresses-getblocksubsidy, r=daira
...
Add funding stream addresses to getblocksubsidy RPC output
Closes #4728 .
2020-10-20 08:18:01 +00:00
eaed8d5797
depends: Add untested note to FreeBSD host
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 20:19:00 +01:00
162de8b260
Auto merge of #4800 - daira:contextualchecktx-cleanups, r=str4d
...
Comment and error message cleanups for transaction checks
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 19:14:03 +00:00
083a05b04f
allow getaddressutxos if -lightwalletd
2020-10-19 11:26:16 -06:00
0940bc0c23
Remove void declaration of ScriptPubKeyToJSON()
2020-10-19 23:41:13 +08:00
2d2dc2c888
Auto merge of #4799 - daira:fix-gtests-displayduration, r=str4d
...
Fix integer types in DisplayDuration
After this, `src/zcash-gtest --gtest_filter='Metrics*'` passes on a native macOS build.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 15:27:40 +00:00
72a0107708
Comment and error message cleanups for transaction checks.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 14:56:59 +01:00
f2d7fd6323
contrib/devtools/symbol-check.py: add info about Fedora-based distributions.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 14:47:29 +01:00
d54d4d083e
Update contrib/devtools/symbol-check.py
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 14:47:29 +01:00
e0b3913356
Rename `time` to `duration` in `DisplayDuration`.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 12:05:47 +01:00
a6822edfd8
Fix integer types in DisplayDuration.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-19 11:51:55 +01:00
6f3c29e9b7
Only return address instead of CScript
2020-10-19 10:04:19 +08:00
921e886748
Auto merge of #4797 - daira:log2-cleanup, r=str4d
...
log(x)/log(2.0) can be written as log2(x)
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-18 14:20:36 +00:00
7a1ed861c2
log(x)/log(2.0) can be written as log2(x).
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-18 15:03:30 +01:00
e60c2bf17c
Apply suggestions from code review
...
Co-authored-by: Larry Ruane <larry@z.cash>
2020-10-17 13:27:38 +08:00
1c91003a51
Auto merge of #4787 - benzcash:ci-builders-libtinfo5, r=str4d
...
Added libtinfo5 to ci builder containers
- Updated apt list for Debian and Ubuntu images.
- made the image creation script executable
- Fixed `bbworker-buildbot.tac` in Centos Dockerfile
This is to support Clang 8 https://github.com/zcash/zcash/pull/4613
You can test it with the images on Docker Hub now something like:
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-debian9
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-debian10
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-ubuntu18.04
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-ubuntu20.04
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-centos8
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
```
docker run --rm -ti --entrypoint bash electriccoinco/zcashd-bbworker-arch
git clone https://github.com/str4d/zcash.git
cd zcash/
git checkout claaaaaang
./zcutil/build.sh -j4
```
2020-10-16 23:49:44 +00:00
4e50b700e9
Minor cleanups
2020-10-17 03:13:19 +08:00
719c117f1c
Handle shielded address case
2020-10-17 03:08:37 +08:00
6c41d1da05
Fix CScript encoding
2020-10-17 02:35:39 +08:00
ceb642550b
Auto merge of #4789 - daira:4785-macos-tests, r=str4d
...
Test suite portability fixes for macOS
Fixes zcash/zcash#4785
2020-10-16 17:06:40 +00:00
cec67e90c5
Add funding stream addresses to getblocksubsidy RPC output
2020-10-16 23:57:04 +08:00
98daea8153
Auto merge of #4791 - str4d:pyflakes-fixes, r=str4d
...
test: Fix various pyflakes warnings
These started being detected after updates to the CI workers.
2020-10-16 15:50:30 +00:00
11baa4d49d
doc: Add Clang and libc++ migration to release notes
2020-10-16 16:48:56 +01:00
ee079a683b
test: Fix various pyflakes warnings
2020-10-16 16:00:02 +01:00
ea7d57aa47
QA: Add native_clang and libcxx to updatecheck.py
2020-10-16 15:43:50 +01:00
c06cc5854e
qa/zcash/full_test_suite.py: print immediately if a test fails.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-16 03:58:31 +01:00
f85ed2741c
qa/zcash/full_test_suite.py: changes needed for macOS. fixes #4785
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-16 03:57:57 +01:00
172b26991e
Build python for debian9 and ubuntu16.04
2020-10-15 19:50:29 -04:00
c6f9215c04
Fixed Centos and Arch python requirements
2020-10-15 17:24:21 -04:00
1271afa354
Added Arch and Centos to script, added libtinfo5 for arch
2020-10-15 12:19:28 -04:00
bf450b2607
qa: Disable FORTIFY_SOURCE checks
...
FORTIFY_SOURCE does mostly nothing for Clang before 10, which we don't
pin yet (and won't before we next upgrade Rust).
2020-10-14 21:52:32 +01:00
03e68a3ed8
Auto merge of #4782 - oxarbitrage:issue4769, r=str4d
...
simplify `TestBlockValidity()`
Closes https://github.com/zcash/zcash/issues/4769
2020-10-14 15:33:42 +00:00
b598691668
Added libtinfo5 to ci builder containers
2020-10-14 10:55:08 -04:00
52270f60ee
update function comment
...
Co-authored-by: str4d <thestr4d@gmail.com>
2020-10-14 11:08:21 -03:00
5bd2df92a5
Auto merge of #4784 - LarryRuane:auto-GetConsensus, r=str4d
...
performance: auto params = CChainParams::GetConsensus()
Closes #4676
For consistency, this PR fixes all occurrences (most are in test code).
2020-10-14 12:11:51 +00:00
ea4c665daf
simplify TestBlockValidity
2020-10-14 08:14:18 -03:00
Wladimir J. van der Laan
Mustafa
Homu
Jack Grigg
Daira Hopwood
str4d
Larry Ruane
therealyingtong
Ben Wilson
Alfredo Garcia