93c625397f
Update py3 division
2020-02-09 08:18:00 -08:00
c7113bd6f1
Update json to simplejson to remove unicode and str issue from py2 to py3
2020-02-09 08:18:00 -08:00
3eb6512b78
cleanups and fixing odd casting
2020-02-09 08:18:00 -08:00
b2752948c0
fix url and port issue
2020-02-09 08:18:00 -08:00
08cfd935d6
clean up
2020-02-09 08:17:32 -08:00
4801c316fc
clean up
2020-02-09 08:17:32 -08:00
ff5a47acfa
clean up
2020-02-09 08:17:32 -08:00
44834ed01c
Clean up import calls
2020-02-09 08:17:32 -08:00
3ae42f1e75
Fix decimal 0 issues
2020-02-09 08:17:32 -08:00
0b1a644d54
remove u encoding
2020-02-09 08:17:32 -08:00
f26269c512
clean up to minimize diff
2020-02-09 08:17:32 -08:00
2d4f4f0b13
remove debug lines from prior commits
2020-02-09 08:17:32 -08:00
89307b131a
update type for decimal 0
2020-02-09 08:15:43 -08:00
8240f73c68
clean up initiliaze statements from imports
2020-02-09 08:15:43 -08:00
4a6aac2c5c
fix initialize statements for imports
2020-02-09 08:15:43 -08:00
198b70aa09
fix type issue
2020-02-09 08:15:43 -08:00
51c020bc68
Use upstream encoding for encodeDecimal
2020-02-09 08:15:43 -08:00
af903084c7
clean up
2020-02-09 08:15:43 -08:00
7b81c00ee4
clean-up imports, keep string notation consistent, remove spacing
2020-02-09 08:15:43 -08:00
5ae91f2dcb
Update qa/rpc-tests/addressindex.py
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2020-02-09 08:15:43 -08:00
75c199ead4
correct update to python3
2020-02-09 08:15:43 -08:00
623f3eb9da
make import urlparse module consistent,httplib update to py3
2020-02-09 08:15:43 -08:00
a9aa622359
Remove semi colons
2020-02-09 08:15:43 -08:00
59068ea071
fix except bug for undefined url
2020-02-09 08:15:43 -08:00
785c3abf05
Clean up code from upstream we dont use
2020-02-09 08:15:43 -08:00
6ed23daf6f
Use more meaningful assert_equal from our original codebase
2020-02-09 08:15:43 -08:00
80e4406ee1
update remaining encoding issues, add pyblake2
2020-02-09 08:15:43 -08:00
3f751205b1
update io module, fix py3 division, and string encoding
2020-02-09 08:15:43 -08:00
bc14f56398
Clean up code not needed from upstream
2020-02-09 08:15:43 -08:00
99e8292538
Update to py3, ISSUE with encoding in create_block
2020-02-09 08:15:43 -08:00
57ec715d4c
Update to py3, ISSUE with encoding in create_block
2020-02-09 08:15:43 -08:00
344ea4433b
Update to py3, ISSUE with encoding
2020-02-09 08:15:43 -08:00
2c8b85f612
Update to py3, ISSUE with encoding
2020-02-09 08:15:43 -08:00
c36414896e
Update io modules for py3, ISSUE with create_transaction function
2020-02-09 08:15:43 -08:00
7648ebf57e
update to py3 conventions, BUG with last assert_equal
2020-02-09 08:15:43 -08:00
4c887d528b
Update type to be decimal
2020-02-09 08:15:43 -08:00
c92cac4776
update encoding, decoding, serialize funcs for py3
2020-02-09 08:15:43 -08:00
09fa601617
update to py3 encodings
2020-02-09 08:15:43 -08:00
843df2a31d
update to py3 conventions, clean up code to be upstream consistent
2020-02-09 08:15:43 -08:00
be0d6ea8c2
update to py3 conventions, update functions to be upstream consistent
2020-02-09 08:15:43 -08:00
f4dcf02062
update to py3 env path
2020-02-09 08:14:21 -08:00
04d218f49d
Add keyerror execption
2020-02-09 08:14:21 -08:00
c0d7fde366
clean up binascii call
2020-02-09 08:14:21 -08:00
45915145cf
update str cast to prevent address assert issues
2020-02-09 08:14:21 -08:00
4403515487
update to py3 conventions, preserve ipv6 patch
2020-02-09 08:14:21 -08:00
1e71f89ffd
update to py3 conventions, update cmp to be py3 compatible, update map to return list for py3
2020-02-09 08:14:21 -08:00
c3de8a7da5
update to py3 convention, update execfile to py3 call
2020-02-09 08:14:21 -08:00
f09e57395f
update to py3 conventions, update range to return list for py3
2020-02-09 08:14:21 -08:00
64d767314a
Update to py3 conventions, update filter to return list
2020-02-09 08:14:21 -08:00
4fb6d38c38
Update to py3 conventions, update decimal calls to be consistent
2020-02-09 08:14:21 -08:00
6644c70c64
Update py2 modules to py3, update encoding to be py3 compatible
2020-02-09 08:14:21 -08:00
65a02f0984
Standard py2 to py3 updates
2020-02-09 08:14:21 -08:00
e241df647f
Update cmp to py3 functions, update map return to list for py3
2020-02-09 08:14:21 -08:00
d093e45db4
Update py2 env path, remove py2 assert, update http module and assert encoding
2020-02-09 08:14:21 -08:00
32d0583c92
Update py2 env path, remove py2 assert, update filter to return list for py3
2020-02-09 08:14:21 -08:00
efc5455d91
Update py2 env path, remove py2 assert
2020-02-09 08:14:21 -08:00
10b25c2b53
Update py2 env path, remove py2 assert
2020-02-09 08:14:21 -08:00
78e6f25820
Update py2 conventions to py3, update Decimal calls
2020-02-09 08:14:21 -08:00
a7381d24ee
Update py2 conventions to py3, remove py2 env and assert
2020-02-09 08:14:21 -08:00
cb81b81576
Update py3 env path, remove py2 assert
2020-02-09 08:14:21 -08:00
e017e5c93f
Update hexlify for encoding, update to py3 io module
2020-02-09 08:14:21 -08:00
79484ef854
Update python3 env path, remove python 2.7 assert
2020-02-09 08:14:21 -08:00
0123af354b
Update ignored testScriptsExt to Python3
2020-02-09 08:14:21 -08:00
82162e7d20
Update rpc-test/test_framework to Py3 convention,modules,encoding
2020-02-09 08:14:21 -08:00
bda88213a6
update test_framework modules
2020-02-09 08:09:31 -08:00
3dde472c96
update /usr/bin/env; fix print conventions
2020-02-09 08:09:31 -08:00
e93586a0c4
Auto merge of #4331 - zcash:hotfix-v2.1.1-1, r=ebfull
...
Hotfix v2.1.1-1
The commits in this PR have been reviewed internally by our team.
2020-02-07 04:50:43 +00:00
5199ecdf41
test: Update RPC test cache generation to handle new consensus rule
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-02-04 23:12:36 +00:00
ca55eb4794
Auto merge of #3870 - defuse:update-check-script, r=str4d
...
Add Python script for checking if dependencies have updates.
2020-01-30 18:27:56 +00:00
1ecf2bae48
Make updatecheck.py compatible with python2
2020-01-30 11:11:37 -07:00
877707798c
test: Check z_viewtransaction output in wallet_listreceived RPC test
2020-01-29 16:05:44 +00:00
5274f322b6
Cache releases to reduce network usage and improve performance
2020-01-28 14:53:36 -07:00
992de545f9
Wrap long lines
2020-01-28 14:45:13 -07:00
0f5ef52d2e
add estimatedheight to getblockchaininfo
...
Co-authored-by: Aditya Kulkarni <adityapk@gmail.com>
2020-01-25 13:24:18 -03:00
76a43b6790
Return address and type of imported key in z_importkey
...
Co-authored-by: Dagur Valberg Johannsson <dagurval@pvv.ntnu.no>
2020-01-22 14:41:02 -03:00
3fb8af512c
change regex
2020-01-21 21:24:21 -03:00
7cb45243fe
change convention
2020-01-20 12:23:52 -03:00
fce6000f76
allow negative index to getblockhash
2019-12-31 09:35:37 -03:00
3ac6dd5f5d
add negative height to getblock
2019-12-31 09:16:29 -03:00
d7108d36b1
Update list of dependencies to check
2019-12-19 14:33:51 -07:00
49f94dbe3d
Add GitHub API credential
2019-12-19 14:33:41 -07:00
d83e8a6a44
Add Python script for checking if dependencies have updates.
2019-12-19 13:58:36 -07:00
0a31c163c6
Auto merge of #4252 - str4d:wallet-interface-refactor, r=str4d
...
Wallet interface refactor
This refactors the logic introduced in #4144 to improve the separation between the node and wallet. The notifier thread now lives next in `src/validationinterface.cpp` directly next to the existing `CMainSignals` node-wallet interface.
Part of #3877 .
2019-12-18 22:48:26 +00:00
f93db1219b
test: Update wallet RPC test with change to "absurdly high fee" limit
2019-12-18 15:40:50 -06:00
e77e8660e3
test: Add missing sync_all point
...
This file was renamed in master, so it was missed in the first commit.
2019-12-18 15:06:54 -06:00
4f6b477fb6
test: Reverse hashtx and hashblock ordering at start of ZMQ RPC test
...
The "hashtx" message was previously triggered synchronously inside
ConnectBlock, while the "hashblock" message is triggered in ConnectTip
immediately after ConnectBlock returns. Thus ZMQ would see a "hashtx"
for every relevant transaction, followed by a "hashblock".
Now, "hashtx" is triggered asynchronously once the cs_main lock is
dropped, which does not occur until after ConnectTip returns. Thus ZMQ
will see a "hashblock" immediately after the block is connected, and
then a "hashtx" for relevant transactions at some point afterwards.
2019-12-18 15:06:54 -06:00
d57af95802
test: Remove genesis-block Sapling activation from shorter_block_times
...
Sapling can't be activated in the genesis block without recomputing it,
and we already activate Sapling by default in block 1, which is fine for
this RPC test.
2019-12-18 15:06:54 -06:00
f7eaf921bc
test: Add sync_all points after block generation to RPC tests
...
Previously we only required synchronization points where blocks were
sent between nodes; now we need them between action and query operations
on the same node, because wallet notification of mined blocks no longer
occurs in real-time.
2019-12-18 15:06:54 -06:00
03db5c8ca3
Tie sync_blocks in RPC tests to notifier thread
2019-12-18 15:06:54 -06:00
6d2629dd64
[doc] Fix markdown
2019-12-17 12:18:50 -06:00
910ff448d6
remove SignatureHash from python rpc tests
2019-12-11 14:46:56 -03:00
f0003239f8
Change "protect" terminology to "shield"
2019-12-04 23:17:06 +02:00
868c63f92d
Auto merge of #2390 - str4d:2132-mapargs-prep, r=str4d
...
Misc upstream PRs
Cherry-picked from the following upstream PRs:
- https://github.com/bitcoin/bitcoin/pull/6077
- Second commit only (first was already applied to 0.11.X and then reverted)
- https://github.com/bitcoin/bitcoin/pull/6284
- https://github.com/bitcoin/bitcoin/pull/6489
- https://github.com/bitcoin/bitcoin/pull/6235
- https://github.com/bitcoin/bitcoin/pull/6905
- https://github.com/bitcoin/bitcoin/pull/6780
- Excluding second commit (QT) and third commit (requires https://github.com/bitcoin/bitcoin/pull/6993 )
- https://github.com/bitcoin/bitcoin/pull/6961
- Excluding QT parts, and a small `src/policy/policy.cpp` change which depends on a bunch of other PRs, which we'll have to remember to come back to.
- https://github.com/bitcoin/bitcoin/pull/7044
- https://github.com/bitcoin/bitcoin/pull/8856
- https://github.com/bitcoin/bitcoin/pull/9002
Part of #2074 and #2132 .
2019-12-04 19:20:44 +00:00
1088866455
pyflakes fixes
2019-12-04 19:16:20 +00:00
f4d9e06a90
Added additional config option for multiple RPC users.
2019-12-04 17:18:43 +00:00
9a06ea5ab8
Auto merge of #4221 - rex4539:typo, r=mdr0id
...
Fix typo
2019-12-03 22:12:39 +00:00
2383d1b1de
Auto merge of #4211 - dagurval:rm-mempooltxinputlimit, r=mdr0id
...
Remove option mempooltxinputlimit
This option is no longer used after Overwinter. Fixes #4209 .
2019-12-03 20:07:20 +00:00
7e946d7ccb
add blockheight, blockindex and blocktime to z_listreceivedbyaddress
2019-12-03 11:24:30 -03:00
5e26d48a39
Auto merge of #4226 - str4d:2074-wallet-1, r=mdr0id
...
Bitcoin 0.12 wallet PRs 1
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6057
- bitcoin/bitcoin#6415
Part of #2074 . Closes #3700 .
2019-12-03 06:53:27 +00:00
cc807987c9
Auto merge of #4244 - charlieok:add_check_depends_build_step, r=mdr0id
...
Add check-depends step to STAGE_COMMANDS list
Added to the beginning of the list of stage commands
2019-12-03 03:11:32 +00:00
017682f993
Update to stop random race error from assert
2019-12-02 17:39:00 -08:00
acea0f7715
Update z_sendmany calls passing int 0, instead of Decimal('0')
2019-12-02 15:37:10 -08:00
62f5bdfbdc
Update `import *` to unblock pyflakes from failing
2019-12-02 11:38:33 -08:00
de47393848
fix rpc testcase
2019-11-29 18:27:41 -03:00
d4f70e5536
Add check-depends step to STAGE_COMMANDS list
2019-11-27 14:12:18 -08:00
e427f70a8c
make proxy_test work on servers without ipv6
2019-11-27 10:38:14 -08:00
fe1ff82a7d
Remove option mempooltxinputlimit
...
This option is no longer used after Overwinter. Fixes #4209 .
2019-11-19 10:35:39 +01:00
60dc0a9e8e
Implement watchonly support in fundrawtransaction
...
Some code and test cases stolen from
Bryan Bishop <bryan@ledgerx.com> (pull #5524 ).
2019-11-14 15:46:07 +00:00
a0d211537c
Add p2sh option to importaddress to import redeemScripts
2019-11-14 14:48:21 +00:00
40609b95ff
Fix typo
2019-11-12 12:51:45 +02:00
fd8444d0b7
Auto merge of #4178 - oxarbitrage:issue3731, r=str4d
...
Remove z_mergetoaddress from experimental state
Closes #3731 .
2019-11-11 01:57:21 -08:00
01998bdc9e
remove zmergetoaddress from experimental state in rpc-tests
2019-11-06 10:57:10 -03:00
1ddc9ff231
Show time elapsed when running RPC tests
2019-10-23 15:04:14 -06:00
40a7156026
Remove dots and underscores from parameter names
2019-10-21 09:20:17 -06:00
64fc25ed6e
Update parameter names to match ZIP
2019-10-17 16:39:32 -06:00
2033395e51
minor rpc test clean up
2019-10-17 12:37:05 -06:00
b680185f48
mempool_limit rpc test cleanup
2019-10-09 12:50:00 -06:00
a515b0057a
No need to activate Overwinter/Sapling in rpc test
2019-10-07 14:43:44 -06:00
1a06727c0c
Performance: Store weighted transactions in a tree
2019-10-07 14:23:42 -06:00
0b2c5cfcc2
Grammatical fixes
...
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-10-07 14:23:41 -06:00
a48b1ba7e2
Rebuild weighted list on removal and fix size calculation
2019-10-07 14:23:41 -06:00
ae9ecf09e8
DoS protection: Weighted random drop of txs if mempool full
2019-10-07 14:23:41 -06:00
7167dc9b2c
Test setting an expiry height of 0.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-09-26 20:43:52 +01:00
961c0d58ec
Auto merge of #4060 - str4d:remove-libsnark, r=daira
...
Remove libsnark
Closes #167 . Closes #416 . Closes #418 . Closes #437 .
Closes #521 . Closes #743 . Closes #750 . Closes #894 .
Closes #903 . Closes #1125 . Closes #1136 . Closes #1240 .
Closes #1264 . Closes #1516 . Closes #1517 . Closes #1651 .
Closes #2064 . Closes #2158 . Closes #3478 . Closes #3652 .
Closes #3744 .
2019-09-26 11:21:40 -07:00
62dc5f0821
Auto merge of #4144 - zcash:hotfix-v2.0.7-3, r=str4d
...
Release v2.0.7-3
2019-09-24 16:02:35 -07:00
9d8322a341
Enable RPC tests to wait on mempool notifications
2019-09-20 21:41:49 +01:00
982e924e98
tests: Clean up use of repr() in mininode
2019-09-16 12:23:46 +01:00
06507722ac
Auto merge of #4088 - LarryRuane:3708-insightexplorer-formatting, r=Eirik0
...
insightexplorer: formatting, pyflakes cleanups
These changes were too late (post-review) for the Insight Explorer PRs, see #3708 . No functional differences.
2019-09-04 10:57:56 -07:00
8669cb692d
test: Update RPC tests to use a minimum of Sapling
...
The p2p_nu_peer_management and rewind_index RPC tests still start from
Sprout, because they are explicitly (and only) testing network behaviour
across network upgrades.
The mempool_tx_input_limit test is removed because the flag has been
ignored since Sapling activation, and will be removed at some point in
the near future.
2019-08-22 17:26:54 +01:00
d7d4dd8a0f
test: Add hashFinalSaplingProxy to create_block
2019-08-22 15:44:18 +01:00
0097df5c7a
test: Add Sapling v4 transactions to mininode framework
2019-08-22 15:44:16 +01:00
3019c0be14
test: Require minimum of Sapling for all RPC tests
2019-08-22 15:42:54 +01:00
1f38ad2536
Remove libsnark unit tests from full test suite
2019-08-22 15:42:54 +01:00
b54725fbed
Remove constant
...
Co-Authored-By: str4d <thestr4d@gmail.com>
2019-08-19 12:30:24 -06:00
5ac48d8ebc
Updated location to new download server, fixing #4100
2019-08-18 14:38:49 +01:00
94f642c80a
Enable shorter block times rpc test
2019-08-16 13:21:33 -06:00
f58bc7b638
Add RPC test and test framework constants for Sapling->Blossom activation.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-08-16 20:19:18 +01:00
cfdf040332
test: Fix AuthServiceProxy closed conn detection
2019-08-16 20:19:18 +01:00
929b302e40
Updated location to new download server
2019-08-14 11:42:31 -07:00
7c5a791b73
insightexplorer: formatting, pyflakes cleanups
2019-08-09 15:27:52 -06:00
5fd1f5afc0
Auto merge of #3972 - LarryRuane:3708-getblockhashesrpc, r=str4d
...
3708 getblockhashesrpc
Part of #3708
2019-08-09 08:00:17 -07:00
2528af69ff
Auto merge of #4025 - bitcartel:shorter_block_target_interval_zip208, r=daira
...
Implement ZIP 208: Shorter Block Target Spacing
Closes #3690 .
2019-08-09 02:35:30 -07:00
2e505df351
add timestampindex related RPC getblockhashes
2019-08-08 14:35:07 -06:00
86b23f37ad
add spentindex RPC for bitcore block explorer
2019-08-07 14:23:42 -06:00
2f00729061
Add copyright info
2019-08-05 19:05:11 -06:00
42a21ef004
Test clean up and fixes
2019-08-05 14:52:34 -06:00
65df6225a6
Do not create transactions that will expire after the next epoch
2019-08-02 16:01:20 -06:00
c68511b876
Auto merge of #3926 - LarryRuane:3708-getaddressrpcs, r=str4d
...
add addressindex RPC for bitcore block explorer
Addresses #3708
2019-08-01 05:43:29 -07:00
2300b911f8
Auto merge of #4035 - Eirik0:use-committransaction, r=str4d
...
Use CommitTransaction
This enables `-walletbroadcast` to correctly control transactions created with `z_*` APIs. It also addresses some TODOs in the code and consolidates some repeated logic.
Closes #4077 (because `CommitTransaction` calls `KeepKey` on the transparent change address).
2019-08-01 03:04:06 -07:00
907554be3a
test: Fix pyflakes warnings
2019-08-01 10:43:03 +01:00
8e48ca1fb2
test: Fix permissions on wallet_changeaddresses RPC test
2019-08-01 10:21:27 +01:00
68e174e22b
add addressindex related RPCs
2019-07-31 10:31:16 -06:00
6bc69c39cb
test: Check for change t-addr reuse in z_sendmany
2019-07-31 12:11:14 +01:00
07851670b4
Temporarily disable test
2019-07-29 15:04:34 -06:00
102dafdf89
Update block subsidy halving for zip208
2019-07-29 13:44:53 -06:00
5306121e5c
Auto merge of #4075 - Eirik0:4059-fix-migration-test, r=Eirik0
...
Fix nondeterministic failure in sapling migration test
Fixes #4059
2019-07-26 01:06:55 -07:00
a63ec6e717
Shorter block times rpc test
2019-07-25 12:49:15 -06:00
5fc227c7dd
Apply suggestions from code review
...
Show migration status in assertion failures
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
2019-07-25 12:35:10 -06:00
6a3f9d8260
Clean up and fix typo
2019-07-24 15:43:08 -06:00
6da42887f1
Auto merge of #3944 - daira:update-license-info, r=daira
...
Update license info
Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.
Fixes #2827 .
2019-07-24 04:07:03 -07:00
ded45b90d7
Fix nondeterministic failure in sapling migration test
2019-07-20 14:36:08 -06:00
2fe59a5681
qa/zcash/checksec.sh is under a BSD license, with a specialized non-endorsement clause.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:31:39 +01:00
bc909a7a7f
Replace http with https: in links to the MIT license.
...
Also change MIT/X11 to just MIT, since no distinction was intended.
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-07-18 15:26:01 +01:00
1c899f5a83
Auto merge of #4044 - Eirik0:fix-mergetoaddress-test-comment, r=Eirik0
...
Fix comment in mergetoaddress RPC test
2019-07-18 06:12:22 -07:00
f57f76d789
Rename vjoinsplit to vJoinSplit
2019-06-16 19:13:49 +03:00
c9d14272af
Fix comment in mergetoaddress RPC test
2019-06-11 14:32:57 -06:00
f381d4e085
add spentindex to getrawtransaction RPC results
2019-06-11 10:29:51 -06:00
a8055cfe10
Fix z_mergetoaddress sending from ANY_SPROUT/ANY_SAPLING when the wallet contains both note types
2019-06-10 13:21:25 -06:00
bb0a3e1cb5
Remove old mergetoaddress RPC test
2019-05-22 16:01:50 -06:00
23d9826ef9
Fix LogPrint statements
2019-05-10 17:25:30 -06:00
7470ae8885
Do not automatically remove async migration operations and return txids
2019-05-10 17:19:56 -06:00
e7529049fb
Test the expiry height of migration transactions.
...
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2019-05-10 13:48:43 +01:00
7cf4749d0d
Correctly account for migration transactions in the mempool
...
Co-authored-by: LarryRuane <larry@z.cash>
2019-05-05 12:59:43 -06:00
345177cfc1
Do not look at vin/vout when determining migration txs and other cleanup
2019-04-30 09:52:53 -06:00
e9530f40f2
use -valueBalance rather than vpub_new to calculate migrated amount
2019-04-29 17:00:26 -06:00
108e587c14
Fix typos and update documentation
2019-04-29 15:29:29 -06:00
2276133bb3
Test migration using both the parameter and the default Sapling address
2019-04-29 15:29:29 -06:00
6e82d72852
Add rpc to get Sprout to Sapling migration status
2019-04-29 15:28:35 -06:00
6acb37bcee
Check for full failure message in test case
2019-04-26 19:01:23 -06:00
5519d16997
Set min depth when selecting notes to migrate
2019-04-25 13:43:23 -06:00
d2a584e35a
Refactor wait_and_assert_operationid_status to allow returning the result
2019-04-24 11:31:14 -06:00
699288b4b4
Documentation cleanup
2019-04-24 11:31:14 -06:00
81a45d6984
Add rpc to enable and disable Sprout to Sapling migration
2019-04-24 11:31:14 -06:00
d6b47948bf
Add qa test for experimental feature: -developersetpoolsizezero
2019-04-23 15:05:15 -07:00
3cb20f26a1
test: Make expected_utxos optional in get_coinbase_address()
2019-03-06 09:03:55 +13:00
b0f1d643aa
test: Fetch coinbase address from coinbase UTXOs
...
After upstream PR bitcoin/bitcoin#5994 , the first call to getnewaddress after
startup does not return the address being used by the miner.
2019-03-06 09:03:51 +13:00
48b7dea5a8
Auto merge of #3639 - leto:size_on_disk, r=bitcartel
...
Port getblockchaininfo.size_on_disk from BTC master
Closes #3630 .
2019-02-25 10:08:44 -08:00
ecde950bac
Add Sapling benchmarks to benchmark runner
2019-02-16 18:44:16 +00:00
a482e4c9fa
Strategically sync to prevent intermittent failures
2019-01-17 15:00:57 -07:00
32212cbad7
Extract helper methods
2019-01-17 15:00:57 -07:00
5e654035a6
fail test if pong is not received
2019-01-17 15:00:57 -07:00
3dab742638
Check entire contents of mempool
2019-01-17 15:00:52 -07:00
57dcc9e6bf
Make variables local
2019-01-17 14:58:50 -07:00
73859fd218
Move common code to helper
2019-01-17 14:58:46 -07:00
23b329d912
flake8 cleanup
2019-01-14 14:00:24 -07:00
4ca5def62f
Make pythonisms consistent
2018-12-18 12:16:23 -08:00
067b6f9373
For ZEC-013. Update qa tests broken by expiring soon threshold.
2018-11-17 09:02:10 -08:00
4484c76202
For ZEC-013. RPC createrawtransaction returns error if tx expiring soon.
2018-11-17 09:02:10 -08:00
cc1ab2db55
For ZEC-013. Don't propagate txs which are expiring soon in p2p messages.
...
When responding to "mempool" message, do not include the txid of an
expiring soon transaction in the "inv" message reply.
When responding to "getdata" message, do not reply with a "tx" message
for a transaction which is expiring soon.
2018-11-17 09:02:00 -08:00
f8cd79c2de
For ZEC-013. Mitigate potential tx expiry height related DoS vector.
...
Don't accept transactions which are about to expire (next 3 blocks).
Don't set a ban score if a peer does propragate these transactions.
See ZEC-013 for more detail.
2018-11-17 09:01:49 -08:00
43040e9384
Add support for "notfound" message to mininode.
2018-11-17 08:27:41 -08:00
a47e1fda73
Auto merge of #3684 - str4d:load-sapling-chain-value, r=bitcartel
...
Load sapling chain value into memory
`CBlockIndex::nSaplingValue` has been correctly set and written to disk since before Sapling activated, meaning that all nodes now are correctly tracking the Sapling shielded pool value on-disk. However, on restart the per-block values are not being read into memory, and so the in-memory pool value appears to be zero on every restart. Setting `nSaplingValue` in-memory during block index loading fixes the problem.
2018-11-16 21:07:46 -08:00
e0b89f59f9
Adjust z_mergetoaddress assertions in Sapling rpc test
2018-11-16 18:14:58 -07:00
0adb77d32e
Add locking for Sapling notes
2018-11-16 18:14:58 -07:00
487c9020bd
Add Sapling support to z_mergetoaddress
2018-11-16 18:14:58 -07:00
e0c491c073
Extend Sprout mergetoaddress rpc test to also work for Sapling
2018-11-16 18:14:57 -07:00
fe393e8a2f
Add fail method to rpc test utils
2018-11-16 18:00:05 -07:00
12a1267a4a
Update qa tests for new "sapling" default for z_getnewaddress.
2018-11-16 14:22:23 -08:00
4e117579c5
Test Sapling value pool accounting
2018-11-16 16:14:52 +00:00
6c1bf4e7ed
Add size_on_disk test
...
Co-authored-by: Simon <simon@bitcartel.com>
2018-11-14 15:04:05 -08:00
97fccdbac5
Auto merge of #3605 - LarryRuane:3604-memo-zeros, r=daira
...
3604 fix sapling default memo - 0xF6 plus zeros
Closes #3604 . For Sapling outputs, set the default memo to `no_memo` instead of all zeros. (See section 5.5 of the Sapling protocol specification.)
2018-10-28 03:15:07 -07:00
882a4f577f
Fix potentially misleading test failures
2018-10-24 13:53:25 -06:00
245db9c8a6
update bug in wallet_listreceived.py, now it highlights the fix
2018-10-24 08:13:56 -06:00
d810703431
Auto merge of #3588 - bitcartel:hash_final_sapling_root_verification, r=bitcartel
...
Add test to verify final sapling root in block header is updated.
2018-10-18 17:52:11 -07:00
61caa46619
For #3359 . Return error if Sapling addresses passed to RPC z_mergetoaddress.
...
RPC z_mergetoaddress does not support Sapling yet but the existing error
reporting was not clear to users.
2018-10-13 08:10:10 -07:00
de1b86a429
For #3359 . RPCs transferring funds return error if Sapling addresses are used before Sapling activation.
2018-10-12 23:14:06 -07:00
527b7feef5
Auto merge of #3592 - Eirik0:z-sendmany-better-error, r=bitcartel
...
Better error message when sending to both sprout and sapling
When trying to send to both Sprout and Sapling (not currently supported with z_sendmany) we were getting the following error in our operation result: `general exception: boost::bad_get: failed value get using boost::get`.
This PR changes this to fail with a better error message before the async operation begins:
```
error code: -8
error message:
Cannot send to both Sprout and Sapling addresses using z_sendmany
```
2018-10-12 15:30:34 -07:00
0917c84d9a
Better error message when sending to both sprout and sapling
...
Co-authored-by mdr0id <marshall@z.cash>
2018-10-12 14:12:21 -06:00
01918e8742
Update test to verify Sapling nullifiers and witnesses persist correctly.
2018-10-11 21:52:56 -07:00
eb0bf23751
add test for sapling spend with transparent recipient
2018-10-11 15:22:20 +02:00
56765e24cb
Add test to verify final sapling root in block header is updated.
2018-10-10 17:30:58 -07:00
3f824a908b
Fix HDSeed comment
2018-10-10 16:00:59 -06:00
732e167043
Auto merge of #3450 - leto:rpctest-readme, r=str4d
...
Fix some typos in rpc-tests readme
2018-10-09 13:18:07 -07:00
c2bb0ec67f
Auto merge of #3517 - mdr0id:3388_persist_wallet, r=str4d
...
Sapling support for persisting wallet to disk
Closes #3388 . Closes #3061 .
2018-10-08 09:53:34 -07:00
01282e4fa6
Update wallet_persistence test to verify spending notes after restart.
2018-10-07 16:22:33 -07:00
08f1baaaca
Update wallet_persistence test to verify wallet txs are persisted across restarts.
2018-10-06 22:53:24 -07:00
5537bf5cdb
Fix file permissions of QA test wallet_persistence.py
2018-10-06 21:05:30 -07:00
2fcf06077f
Persist Sapling key material in the wallet to disk
2018-10-06 00:01:14 +01:00
87ae893d75
Revert "wallet: Comment out HDSeed and CHDChain persistence to disk"
...
This reverts commit b7f9a7ae02
2018-10-05 17:46:43 +01:00
625797a037
Auto merge of #3518 - str4d:3216-z_shieldcoinbase, r=str4d
...
Add Sapling support to z_shieldcoinbase
Part of #3216 .
2018-10-05 03:33:16 -07:00
089ec92e7b
Fix pyflakes warnings
2018-10-05 11:32:22 +01:00
967bbbc486
Auto merge of #3561 - bitcartel:3560_update_sapling_note_data, r=bitcartel
...
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-04 15:37:34 -07:00
f09aae037c
Update wallet_listreceived test for now-correct empty Sapling memos
2018-10-04 22:46:15 +01:00
4ba35551d4
Auto merge of #3510 - arcalinea:3378_z_listunspent, r=bitcartel
...
Sapling support for z_listunspent
Closes #3378 .
2018-10-04 11:39:14 -07:00
f0dcfceb81
Closes #3560 . Update Sapling note data correctly when importing a key.
2018-10-03 15:40:50 -07:00
5f91a95641
Add Sapling support to z_shieldcoinbase
...
Part of #3216 .
2018-10-03 12:16:18 +01:00
bcdb4344f0
Auto merge of #3548 - Eirik0:3546-sapling-coin-priority, r=bitcartel
...
Use max priority for all shielded transactions
Addresses https://github.com/zcash/zcash/issues/3546#issuecomment-425184034
2018-10-01 10:13:15 -07:00
b7549f2aec
Add test that Sapling shielded transactions have MAX_PRIORITY
2018-09-30 17:23:53 -07:00
5f57babd08
Cleanup to address review comments.
2018-09-28 22:11:05 -07:00
d7d6480ce3
z_listunspent rpc unit test: add testing for Sapling
2018-09-28 15:23:24 -07:00
011f9a02ef
Add rpc test for sprout txs z_listunspent
2018-09-28 15:19:10 -07:00
e4f0d6a8de
Sapling support for z_listreceivedbyaddress
2018-09-27 16:59:29 -06:00
4c4e1718b1
Update qa test as offline regtest nodes need branch id passed in.
2018-09-21 17:16:44 -07:00
18f8abb62d
Closes #3534 . Do not use APPROX_RELEASE_HEIGHT to get consensus branch
...
id when in regtest mode.
Co-authored-by: Larry Ruane <larryruane@gmail.com>
2018-09-21 11:10:15 -07:00
36243f41f1
Auto merge of #3520 - Eirik0:3327-sign-offline, r=bitcartel
...
Fix signing raw transactions with unsynced offline nodes
This PR address the issue in two different ways:
- In `signrawtransaction` we determine the consensus branch ID (which we then later use to construct the transaction) using the chain height. We now also consider the `APPROX_RELEASE_HEIGHT` as this is a better estimation than 0 for the height of the chain if we are unsynced. (This in and of itself solves the Overwinter signing issue).
- We have added an additional parameter to `signrawtransaction` to allow manually overriding the consensus branch ID that zcashd determines we are on. This allows users to work around corner cases where the first strategy is still insufficient.
Closes #3327 .
2018-09-19 15:02:52 -07:00
c10249f3de
Remove unused import
2018-09-19 14:41:02 -06:00
25c3f903c1
Auto merge of #3491 - Eirik0:3218-sapling-import-export-wallet, r=str4d
...
Add Sapling support to z_importwallet and z_exportwallet
Includes code adapted from upstream PR https://github.com/bitcoin/bitcoin/pull/8323
Closes #3218 .
2018-09-19 12:15:48 -07:00
379c7439a0
Auto merge of #3479 - Eirik0:rpc-test-cleanup, r=bitcartel
...
Rpc test cleanup
The main purpose of this PR was to inline the method 'wait_for_async_operation_id' from util.py in tests where we were doing this manually. To make it work in all cases, I had to change the method to return the result in the case where the call failed. I also did a bit of general clean up (removing semicolons) in the files which I changed.
2018-09-18 20:05:39 -07:00
e95bdeabbf
Auto merge of #3521 - bitcartel:sapling_json_data, r=str4d
...
Add Sapling fields to JSON RPC output using TxToJSON.
Related to #3063 to add Sapling support to wallet RPCs.
2018-09-18 12:13:14 -07:00
3501519bc8
Update qa test to check for Sapling related JSON fields.
2018-09-17 10:01:50 -07:00
mdr0id
Marshall Gaucher
Homu
Jack Grigg
Taylor Hornby
Alfredo Garcia
MarcoFalke
Dimitris Apostolou
Gregory Sanders
Charlie O'Keefe
Wladimir J. van der Laan
Dagur Valberg Johannsson
Matt Corallo
Eirik Ogilvie-Wigley
Eirik Ogilvie-Wigley
Daira Hopwood
zebambam
Larry Ruane
Simon
Jonathan "Duke" Leto
arielgabizon
Jay Graber