ccf31edf62
[copyright] add MIT license headers to .sh scripts where missing
...
Years are set according to 'git log' history
Zcash: Only the scripts we have that are missing the header.
2020-11-09 22:59:04 +00:00
84a5830aaa
Auto merge of #4829 - str4d:backport-lints, r=str4d
...
Backport useful lints from upstream
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6892
- bitcoin/bitcoin#11151
- bitcoin/bitcoin#11300
- bitcoin/bitcoin@96d91b79bd
- bitcoin/bitcoin#12097
- bitcoin/bitcoin#12098
- bitcoin/bitcoin#12442
- bitcoin/bitcoin#12572
- bitcoin/bitcoin#12757
- bitcoin/bitcoin#11878
- bitcoin/bitcoin#12933
- bitcoin/bitcoin#12871
- bitcoin/bitcoin#12972
- bitcoin/bitcoin#13281
- bitcoin/bitcoin#13385
- bitcoin/bitcoin#13041
- bitcoin/bitcoin#13454
- bitcoin/bitcoin#13448
- bitcoin/bitcoin#13510
- bitcoin/bitcoin#13851
- bitcoin/bitcoin#13863
- bitcoin/bitcoin#14115
- bitcoin/bitcoin#14831
- bitcoin/bitcoin#15164
- bitcoin/bitcoin#15170
- bitcoin/bitcoin#15166
- bitcoin/bitcoin#16036
- bitcoin/bitcoin#16768
- bitcoin/bitcoin#13494
Several of the lints fail for our current codebase; these will be addressed in a
subsequent PR.
2020-11-09 21:20:55 +00:00
1e6d1837a0
lint: Remove some subtrees from exclusion
...
Either they don't violate the lints, or can be easily fixed.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 20:06:45 +00:00
5b543b15eb
lint: Allow stoi in src/rpc/blockchain.cpp
...
This instance is ok because it's guarded by a strict regex.
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 20:03:22 +00:00
bd5ff7c889
Auto merge of #4835 - str4d:bctest-backports, r=str4d
...
bitcoin-util-test.py backports
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#8829
- bitcoin/bitcoin#8830
- bitcoin/bitcoin#8836
- bitcoin/bitcoin#8881
- bitcoin/bitcoin#9032
- bitcoin/bitcoin#9023
- bitcoin/bitcoin#9069
- bitcoin/bitcoin#9945
2020-11-09 19:57:48 +00:00
95ad6fc6bf
test: Fix pyflakes warning in bitcoin-util-test.py
2020-11-09 19:56:16 +00:00
9dbf535441
lints: Add a missing copyright header
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 17:17:08 +00:00
4b69b94bba
Small documentation fixes
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2020-11-09 17:15:46 +00:00
80a658fbdf
Auto merge of #4844 - ebfull:release-v4.1.0, r=daira
...
Release v4.1.0
2020-11-03 09:59:03 +00:00
08fd678be2
Update approximate release height
...
Co-authored-by: ying tong <yingtong@z.cash>
2020-11-03 09:56:22 +00:00
90493623a0
Fix a comment about postponement of Clang upgrade
2020-11-03 09:55:02 +00:00
4f331d0f7f
Update doc/release-notes/release-notes-4.1.0.md
...
Co-authored-by: ying tong <yingtong@z.cash>
2020-11-03 09:52:59 +00:00
f8c9a1f2d6
Update doc/release-notes/release-notes-4.1.0.md
...
Co-authored-by: ying tong <yingtong@z.cash>
2020-11-03 09:51:08 +00:00
fe681d2cc6
make-release.py: Updated release notes and changelog for 4.1.0.
2020-11-02 13:40:54 -07:00
453dacccf8
make-release.py: Updated manpages for 4.1.0.
2020-11-02 13:40:54 -07:00
75a8a6c25f
make-release.py: Versioning changes for 4.1.0.
2020-11-02 13:38:03 -07:00
34c2a4b380
Postpone clang and libc++ dependency updates until after the 4.1.0 release.
2020-11-02 13:36:34 -07:00
2a78e35171
Auto merge of #4837 - daira:fix-gitian, r=daira
...
Fixes for Gitian builds
Remove manual CFLAGS and CXXFLAGS from descriptor.
2020-10-29 12:24:27 +00:00
6cbaa65b55
Gitian builds: Remove manual CFLAGS and CXXFLAGS from descriptor.
...
Before Zcash launched, we were heavily relying on `zcutil/build.sh` to
apply our Zcash-specific hardening flags. The Gitian deterministic build
system obviously didn't use our script, so the corresponding flags were
manually added to `gitian-linux.yml`.
Since then, we have migrated all of our flags into `configure.ac`.
Manually setting them in the Gitian descriptor is no longer necessary,
and should have been removed at the same time. This didn't cause any
noticeable issues, however, leaving it undetected until we migrated to
Clang in zcash/zcash#4613 , and performed a Gitian build for 4.1.0-rc1.
The Gitian failure was caused by linker flags specific to C++ being used
in configuration tests for secp256k1 (a C library). This causes ldd to
emit warnings, which are then converted to errors by the -Werror flags
that were added to CFLAGS and CXXFLAGS by `gitian-linux.yml`. CI did not
encounter this because it uses the standard `--enable-werror` config flag,
which adds `-Werror` to CXXFLAGS but not CFLAGS.
Co-authored-by: Jack Grigg <jack@z.cash>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2020-10-29 11:15:59 +00:00
e289f812d2
Improve logging in bctest.py if there is a formatting mismatch
2020-10-28 16:20:53 +00:00
abd7840c22
Clean up bctest.py and bitcoin-util-test.py
...
- remove newlines
- change tabs for spaces, to align with convention in other py files
- add comments
- add 'Bitcoin Core Developers' copyright notice
2020-10-28 16:20:53 +00:00
5508f14437
Add logging to bitcoin-util-test.py
...
- Use the python standard logging library
- Run all tests and report all failing test-cases (rather than stop after one test case fails)
- If output is different from expected output, log a contextual diff.
2020-10-28 16:20:53 +00:00
3e2460b6f8
test: Add format-dependent comparison to bctest
...
This splits the output comparison for `bitcoin-tx` into two steps:
- First, check for data mismatch, parsing the data as json or hex
depending on the extension of the output file
- Then, check if the literal string matches
For either of these cases give a different error.
This prevents wild goose chases when e.g. a trailing space doesn't match
exactly, and makes sure that both test output and examples are valid
data of the purported format.
2020-10-28 16:20:53 +00:00
2079d495f6
add verbose mode to bitcoin-util-test.py
2020-10-28 16:07:25 +00:00
e9c1703ba6
bitcoin-util-test.py should fail if the output file is empty
2020-10-28 16:07:25 +00:00
cbce715c00
Add option to run bitcoin-util-test.py manually
2020-10-28 16:07:25 +00:00
25193f0fa0
Add bitcoin-tx JSON tests
...
Zcash: Modified for us, and excluding test cases we don't have.
2020-10-28 16:02:36 +00:00
7c42009ddd
lints: Match `export LC_ALL="C"` in lint-shell-locale
...
checksec.sh uses this format.
2020-10-28 13:19:27 +00:00
69d3d38445
Follow-up to #13454 : Fix broken build by exporting LC_ALL=C
2020-10-28 13:14:39 +00:00
32fe88362b
lints: Update expected Boost imports
2020-10-27 23:14:08 +00:00
f318ab3776
lints: Use Zcash-specific include guards for new files
2020-10-27 23:05:19 +00:00
d89f31dc43
Make lint-includes.sh work from any directory
2020-10-27 23:05:19 +00:00
bdaccd0f06
Run all lint scripts
...
The description reads:
```
# This script runs all contrib/devtools/lint-*.sh files, and fails if any exit
# with a non-zero status code.
```
This runs all scripts and returns with a non-zero exit code if any failed.
2020-10-27 23:05:19 +00:00
1be9fa9aeb
Remove no longer needed shellcheck suppressions
2020-10-27 23:05:19 +00:00
68393a4b73
Fix warnings introduced in shellcheck v0.6.0
...
Zcash: Only for shell scripts we have backported.
2020-10-27 23:05:19 +00:00
8ed37f5f40
Remove repeated suppression. Fix indentation.
2020-10-27 23:05:19 +00:00
37604a1990
refactor/lint: Add ignored suggestions to an array
...
This avoids duplicating the codes between command and comments.
2020-10-27 23:05:19 +00:00
653f6dc7e7
qa: Ignore shellcheck warning SC2236
...
With shellcheck 0.6.0 the warning `SC2236 - Use -n instead of ! -z` is raised.
This change adds that warning to the ignored list.
2020-10-27 23:05:19 +00:00
27f924108c
Scripts and tools & Docs: Used #!/usr/bin/env bash instead of obsolete #!/bin/bash, added linting for .sh files shebang and updated the Developer Notes.
2020-10-27 23:05:19 +00:00
5b11b94d27
macOS fix: Add excludes for checks added in the newer shellcheck version installed by brew
2020-10-27 23:05:19 +00:00
73a6c29bcd
macOS fix: Work around empty (sub)expression error when using BSD grep
2020-10-27 23:05:19 +00:00
52f45ad9a4
use export LC_ALL=C.UTF-8
2020-10-27 23:05:19 +00:00
b90433afd3
fix locale for lint-shell
2020-10-27 23:05:19 +00:00
be186b8112
Obsolete #!/bin/bash shebang
2020-10-27 23:05:18 +00:00
f98ced2aba
Add linter: Make sure we explicitly open all text files using UTF-8 or ASCII encoding in Python
2020-10-27 23:05:02 +00:00
0eef155a4a
Explicitly specify encoding when opening text files in Python code
2020-10-27 23:05:02 +00:00
1b32acdd52
Add linter: Make sure all shell scripts opt out of locale dependence using "export LC_ALL=C"
2020-10-27 23:05:02 +00:00
745ac0ae6d
Add "export LC_ALL=C" to all shell scripts
...
Zcash: Only for lint-* scripts we have backported from upstream.
2020-10-27 23:05:02 +00:00
aade01b184
docs: Mention lint-locale-dependence.sh in developer-notes.md
2020-10-27 23:05:02 +00:00
40316e9359
build: Add linter for checking accidental locale dependence
2020-10-27 23:05:02 +00:00
isle2983
Homu
str4d
Jack Grigg
Daira Hopwood
Sean Bowe
John Newbery
Wladimir J. van der Laan
practicalswift
Kristaps Kaupe
Julian Fleischer
Vidar Holen
João Barbosa
vim88
Julian Fleischer
DesWurstes