609373f205
Merge pull request #5346 from nuttycom/fix/remove_dead_code
...
Remove unused `AddDestData` method.
2021-10-08 10:47:09 +13:00
7b40f87404
Update release notes for v4.5.1-1 to reflect the addition of `listaddresses`
2021-10-07 14:25:50 -06:00
6b1d290789
Group legacy_hdseed Sapling addresses by account ID.
2021-10-07 13:48:55 -06:00
f8350ce93d
Apply suggestions from code review
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-10-07 07:41:15 -06:00
ee8a8e67e8
Merge pull request #5345 from str4d/nu5-standard-tx
...
Mark v5 transaction format as standard for NU5
2021-10-07 14:14:24 +01:00
6fd177c2de
Merge pull request #5333 from str4d/5302-update-debian-copyright
...
Update Debian copyright file
2021-10-08 00:54:51 +13:00
33e449fcd1
Apply suggestions from code review
...
Co-authored-by: str4d <jack@electriccoin.co>
2021-10-06 20:43:48 -06:00
6be880fe34
Correctly handle imported Sapling addresses
...
Update the tests to reflect the new listaddresses result
structure.
2021-10-06 20:39:52 -06:00
ad35b89e05
contrib: Add space between URL and period
...
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
2021-10-07 11:38:37 +13:00
eb85b06c5a
Fix comment
...
We switched testnet to follow standard rules in zcash/zcash#1604 , in
order to find bugs such as the one fixed in the previous commit.
2021-10-06 20:47:34 +00:00
a165733372
Mark v5 transaction format as standard for NU5
...
Without this change, mainnet and testnet nodes following standard rules
will not accept v5 transactions into their mempools, causing them to be
ignored.
2021-10-06 20:47:34 +00:00
9a11ac73a4
Categorize listaddresses result by source type.
...
Addresses managed by the zcashd wallet may be generated using
multiple different sources of randomness and/or the wallet's
HD seeds. Depending upon how addresses are generated, they may
divided into multiple sets, each associated with a separate
spend authority and treated as an independent pool of funds.
In the future, the root spend authority for a wallet will
be a mnemonic seed phrase; the API represented by this PR
anticipates that future and attempts to provide functionality
that will serve both current and future needs, as well as the
transition between them.
2021-10-06 14:24:35 -06:00
b608a6af48
Remove unused `AddDestData` method.
2021-10-06 13:56:04 -06:00
64ecf700fc
Add `listaddresses` RPC method.
...
Closes #5328
Fixes #5338
2021-10-06 13:55:26 -06:00
4606038086
Merge pull request #5309 from nuttycom/feature/wallet_bip44_type
...
Add network information to persisted wallet state.
2021-10-05 10:47:17 +13:00
92d36b5a43
Disable IBD for all boost tests
...
Disable IBD for all the boost unit tests, because that's the more common
(default) mode of operation. The full boost test suite passes with this
commit, both when run all together or run separately. Any future tests
that need IBD to be active can always call TestSetIBD(true).
2021-10-03 16:16:57 -06:00
5ad669baca
Update reduce-traffic.md - add one word
...
Added one word "a" at line 49
2021-10-02 07:52:45 -07:00
af6b18b3ba
add TestSetIBD(bool) for testing
2021-09-30 10:26:08 -06:00
f9656e2637
Add a check to test that wallet load fails if we're on the wrong network.
2021-09-29 14:15:07 -06:00
7132b27723
Persist network id string instead of bip44 coin type.
2021-09-29 10:15:43 -06:00
68c3bd8eaa
Add BIP 44 coin type to persisted wallet state.
2021-09-29 10:15:43 -06:00
f574047387
contrib: Add license information for libc++ and libevent
...
Closes zcash/zcash#5302 .
2021-09-29 13:43:55 +01:00
a672318b4d
contrib: Update Debian copyright file to follow the v1 format
...
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
2021-09-29 13:42:01 +01:00
3ab6e1b3d9
Merge pull request #5315 from charlieok/add_buster_gitian_suite
...
Add buster to the list of suites used by gitian
2021-09-30 00:21:50 +13:00
e86a1f4927
Merge pull request #5332 from str4d/release-v4.5.1
...
Release v4.5.1
2021-09-29 15:22:22 +13:00
4bfbdfa4ef
make-release.py: Updated release notes and changelog for 4.5.1.
2021-09-29 01:49:51 +01:00
283fd6feda
make-release.py: Updated manpages for 4.5.1.
2021-09-29 01:49:50 +01:00
3822c716fd
make-release.py: Versioning changes for 4.5.1.
2021-09-29 01:40:44 +01:00
68096bf846
Merge pull request #5331 from str4d/postpone-updates
...
depends: Postpone native_ccache 4.4.2
2021-09-28 17:40:05 -07:00
a7342cff71
depends: Postpone native_ccache 4.4.2
2021-09-29 01:36:35 +01:00
9d78cecede
Merge pull request #5330 from str4d/nu5-testnet-update
...
Fix bugs in testnet Orchard circuit
2021-09-29 13:30:30 +13:00
6e90c84be7
Fix bugs in testnet Orchard circuit
...
The consensus branch ID is updated (as the NU5 consensus rules are
altered). The testnet NU5 activation height is also reset.
2021-09-28 22:56:37 +01:00
33a963f3ce
Merge pull request #5326 from str4d/5325-cwallettx-isfromme-fix
...
wallet: Check spent shielded notes in CWalletTx::IsFromMe
2021-09-29 01:30:52 +13:00
fd49f78042
wallet: Check spent shielded notes in CWalletTx::IsFromMe
...
The "IsFromMe" logic was implemented in several places in the Bitcoin
Core wallet. We had correctly updated CWallet::IsFromMe(CTransaction)
(which was used in most places in the wallet) to check for shielded
notes being spent, but did not notice that CWalletTx::IsFromMe also
needed this check.
This bug has existed since before Zcash launched. It went unnoticed
because CWalletTx::IsFromMe was previously only called from code
used to either create purely-transparent transactions, or provide
informational output on non-critical RPC methods.
Closes zcash/zcash#5325 .
2021-09-28 02:51:04 +01:00
4f43b694c4
Merge pull request #5322 from str4d/release-v4.5.0
...
Release v4.5.0
2021-09-23 22:40:49 +12:00
4fb372efdd
Add notable changes to v4.5.0 release notes
2021-09-23 05:09:55 +01:00
872e95a599
Set testnet activation height for NU5
2021-09-23 05:09:42 +01:00
a1d17292b4
make-release.py: Updated release notes and changelog for 4.5.0.
2021-09-23 04:20:16 +01:00
5ceb64682c
make-release.py: Updated manpages for 4.5.0.
2021-09-23 04:20:15 +01:00
1bd9152daa
make-release.py: Versioning changes for 4.5.0.
2021-09-23 04:12:06 +01:00
343c4342de
Merge pull request #5320 from str4d/final-deps-4.5.0
...
Final dependecy updates for 4.5.0
2021-09-23 15:06:44 +12:00
00724c9f5a
Update halo2 and orchard dependencies with BOSL Zcash exception
2021-09-22 23:10:57 +01:00
660e938499
cargo update
...
Includes pasta_curves 0.2.1, which relicenses to MIT OR Apache-2.0.
2021-09-22 22:51:26 +01:00
9338ecd0d6
Merge pull request #5305 from str4d/rust-deps
...
contrib: Add script for generating a graph of our Rust dependencies
2021-09-23 09:48:56 +12:00
5ef1b9b8cc
Merge pull request #5312 from str4d/fix-connectblockslow-bench
...
bench: Add Orchard logic to zcbenchmarks
2021-09-23 06:45:45 +12:00
db8abb7a54
Add buster to the list of suites used by gitian
2021-09-22 10:58:34 -06:00
5731ba431c
bench: Add Orchard logic to zcbenchmarks
...
The missing `ORCHARD` case in `FakeCoinsViewDB::GetBestAnchor` caused
an exception to be thrown during the `connectblockslow` benchmark.
2021-09-22 17:32:17 +01:00
38bdae6df9
Merge pull request #5311 from str4d/wallet-load-orchard-perf
...
Fix regression in wallet load performance
2021-09-23 04:22:38 +12:00
03ecb13300
rust: Skip running the Orchard batch validator on an empty batch
...
An empty batch will always succeed, but costs a 2-base multi-scaler
multiplication.
2021-09-22 14:52:47 +01:00
092ffed2cc
wallet: Batch-validate all Orchard signatures in the wallet on load
...
A batch item is 128 bytes, so for a wallet with 200k Orchard actions
this would require around 25MiB, which is reasonable.
2021-09-22 14:01:53 +01:00
str4d
Kris Nuttycombe
Kris Nuttycombe
Daira Hopwood
str4d
Jack Grigg
Larry Ruane
sgmoore
Marshall Gaucher
Charlie O'Keefe