Homu
dfa4ed19bb
Auto merge of #2440 - bitcartel:1360_reduce_info_leakage_vpub_new, r=str4d
...
Fix intermediate vpub_new leakage in multi joinsplit tx
Resolves information leakage discussed here https://github.com/zcash/zcash/issues/1360#issuecomment-284561331
Example output in debug.log showing how intermediate vpub_new is now 0
https://gist.github.com/bitcartel/86ca316b74f0b1ec6d8de3ac132006da
When reviewing, note that the indentation of a large chunk of code (scenario 3 part 2) changed, so use `git diff -w` (or similar) or append `?w=1` to the Github URL e.g. https://github.com/zcash/zcash/pull/2440/files?w=1
2017-06-15 21:33:01 -07:00
Homu
3440de74ee
Auto merge of #2386 - str4d:2385-consensus-correction, r=str4d
...
Correct consensus logic in ContextualCheckInputs
Closes #2385 .
2017-06-15 18:50:03 -07:00
Jack Grigg
30006a2e79
Correct consensus logic in ContextualCheckInputs
...
Closes #2385 .
2017-06-16 13:45:19 +12:00
Jack Grigg
1b786a93c3
Add test for incorrect consensus logic
2017-06-16 13:45:14 +12:00
Homu
0a80a1cea3
Auto merge of #2227 - str4d:2074-ignore-virtual-cores, r=str4d
...
Use real number of cores, ignore virtual cores
Cherry-picked from the following upstream PRs:
- bitcoin/bitcoin#6361
- bitcoin/bitcoin#6370
Part of #2074 .
2017-06-15 17:05:02 -07:00
Homu
6189c70caa
Auto merge of #1747 - str4d:fix-spendingkey-locking, r=str4d
...
Fix incorrect locking in CCryptoKeyStore
2017-06-15 16:02:07 -07:00
Homu
35bf9e73ff
Auto merge of #2420 - kozyilmaz:disable-libs, r=str4d
...
option to disable building libraries (zcutil/build.sh)
option to disable building libraries (zcutil/build.sh)
2017-06-15 07:31:46 -07:00
Simon
c93a0872e8
Fix intermediate vpub_new leakage in multi joinsplit tx ( #1360 )
2017-06-13 23:21:53 -07:00
Homu
a23fdf862d
Auto merge of #2245 - daira:2244.remove-old-peer-workarounds, r=str4d
...
Delete old protocol version constants and simplify code that used them.
fixes #2244
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
2017-06-13 23:10:19 -07:00
Homu
0ecd0642e1
Auto merge of #2412 - kozyilmaz:linker, r=str4d
...
[macOS] system linker does not support “--version” option but only “-v”
To build Zcash on macOS Sierra I use a self-built gcc-6.3/g++-6.3 but macOS linker (/usr/bin/ld). macOS linker does not support “--version” option but “-v”
On Ubuntu 16.04
```
$ ld --version
GNU ld (GNU Binutils for Ubuntu) 2.26.1
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
$ ld -v
GNU ld (GNU Binutils for Ubuntu) 2.26.1
```
On macOS Sierra
```
$ ld --version
ld: unknown option: --version
$ ld -v
@(#)PROGRAM:ld PROJECT:ld64-278.4
configured to support archs: armv6 armv7 armv7s arm64 i386 x86_64 x86_64h armv6m armv7k armv7m armv7em (tvOS)
LTO support using: LLVM version 8.1.0, (clang-802.0.42)
TAPI support using: Apple TAPI version 1.33.11
```
2017-06-13 20:16:13 -07:00
Homu
992abfac6f
Auto merge of #2429 - hajdbo:master, r=daira
...
documentation z_validateaddress was missing param
2017-06-09 14:48:28 -07:00
Boris Hajduk
8a38e6c1d0
documentatin z_validateaddress was missing param
2017-06-07 15:49:49 +08:00
kozyilmaz
c63417bbe7
option to disable building libraries (zcutil/build.sh)
2017-06-04 19:46:35 +03:00
kozyilmaz
cf4f400ca8
[macOS] system linker does not support “--version” option but only “-v”
2017-05-31 10:38:02 +03:00
Homu
a410f124b2
Auto merge of #2402 - nathan-at-least:release-v1.0.9, r=nathan-at-least
...
Release v1.0.9
2017-05-24 14:21:43 -07:00
Nathan Wilcox
8b922a4ad4
make-release.py: Updated release notes and changelog for 1.0.9.
2017-05-24 12:51:06 -07:00
Nathan Wilcox
98574ff599
make-release.py: Updated manpages for 1.0.9.
2017-05-24 12:51:06 -07:00
Nathan Wilcox
de9c56c88a
make-release.py: Versioning changes for 1.0.9.
2017-05-24 12:50:05 -07:00
Homu
8566d45d6b
Auto merge of #2401 - nathan-at-least:doc-1.0.9-deprecation-policy, r=nathan-at-least
...
Define the deprecation policy for 1.0.9.
This explicitly avoids naming any release-specific data so we can leave
this text unchanged for upcoming releases.
ref: #2398
2017-05-24 08:31:57 -07:00
Nathan Wilcox
e895b8631a
Clarify that the feature is automated *shutdown*.
2017-05-24 08:15:03 -07:00
Nathan Wilcox
ce7e7cafbf
Define the deprecation policy for 1.0.9.
...
This explicitly avoids naming any release-specific data so we can leave
this text unchanged for upcoming releases.
2017-05-24 07:37:10 -07:00
Homu
6bcaaabdbc
Auto merge of #2399 - ebfull:g1-at-infinity, r=nathan-at-least
...
Check that pairings work properly when the G1 point is at infinity.
2017-05-24 02:58:15 -07:00
Homu
25d47f46ae
Auto merge of #2280 - str4d:2279-disable-proton-js-binding, r=nathan-at-least
...
Disable building Proton JavaScript bindings and other non-essential stuff
Closes #2279 .
2017-05-23 22:45:56 -07:00
Sean Bowe
9eb9eebbb8
Check that pairings work properly when the G1 point is at infinity.
2017-05-23 16:31:41 -06:00
Homu
57c7838d5f
Auto merge of #2393 - nathan-at-least:2391.make-release-script, r=nathan-at-least
...
make-release.py script
ref #2391
This is a new `make-release.py` script which automates creation of the 'release PR' branch.
It has partial unittest coverage (large around version parsing/sorting/serializing) and always runs unittests prior to doing actual work. Most of the testing was done manually by using the ``--repo`` arg on a test repo, then reseting its state each time I needed a new test (to get around git checks). There is no other 'dry run' functionality.
2017-05-22 21:28:26 -07:00
Nathan Wilcox
88bf7eb050
Add a few more version strings to positive parser test.
2017-05-22 21:23:11 -07:00
Nathan Wilcox
187e64c7ab
Consider both beta and rc versions to be `IS_RELEASE == false`.
2017-05-22 20:42:00 -07:00
Nathan Wilcox
92333721e5
Examine all future versions which are assumed to follow the same Version parser schema.
2017-05-22 20:38:22 -07:00
Nathan Wilcox
73a3f7dc02
Include release version in commit comments.
2017-05-22 20:38:06 -07:00
Nathan Wilcox
7f10df4785
Fix `release-process.md` doc usage for `make-release.py` to have correct arguments and order.
2017-05-22 20:24:42 -07:00
Homu
8b1384ca29
Auto merge of #2397 - nathan-at-least:performance-benchmarks-fixes, r=nathan-at-least
...
Performance benchmarks fixes
Addresses #2395 and #2392 .
2017-05-22 18:57:57 -07:00
Nathan Wilcox
5a027a4a6e
Do not use `-rpcwait` on all `zcash_rpc` invocations, only block when starting zcashd.
2017-05-22 17:51:23 -07:00
Nathan Wilcox
4e47698633
Reuse zcash_rpc.
2017-05-22 17:47:36 -07:00
Nathan Wilcox
453c74743c
Fix a variable name typo.
2017-05-22 17:46:26 -07:00
Nathan Wilcox
0cfc9d65fa
Enable set -u mode.
2017-05-22 17:46:13 -07:00
Nathan Wilcox
0df82709b4
First full-release-branch version of script; rewrite large swatch of release-process.md. [Manually tested.]
2017-05-22 12:34:00 -07:00
Homu
7ea88c9513
Auto merge of #2389 - str4d:2388-bench-archive-determinism, r=nathan-at-least
...
Remove additional sources of nondeterminism from benchmark archive
Closes #2388 .
2017-05-22 11:05:36 -07:00
Nathan Wilcox
c66c5ab21f
Tidy up / systematize logging output a bit more.
2017-05-19 18:20:00 -07:00
Nathan Wilcox
08d66a9c01
Polish logging a bit more.
2017-05-19 18:09:35 -07:00
Nathan Wilcox
c62edf9471
Generate manpages; commit that; improve error output in sh_log.
2017-05-19 18:05:02 -07:00
Nathan Wilcox
785244020a
Commit the version changes and build.
2017-05-19 18:05:02 -07:00
Nathan Wilcox
f6b9ffefb7
Shorten the arg log line.
2017-05-19 18:05:02 -07:00
Nathan Wilcox
14b2a420d3
Switch from `sh_out_logged` to `sh_log`.
2017-05-19 17:35:20 -07:00
Nathan Wilcox
cf97f66987
Remove portions of `./doc/release-process.md` now implemented in `make-release.py`.
2017-05-19 17:16:59 -07:00
Nathan Wilcox
4dbb6c0b1d
Modify the `APPROX_RELEASE_HEIGHT`.
2017-05-19 17:09:37 -07:00
Jack Grigg
08dc7889d2
Remove additional sources of determinism from benchmark archive
...
The archive has also been moved from .tar.gz to .tar.xz for a
33% reduction in size.
Closes #2388 .
2017-05-20 11:59:16 +12:00
Nathan Wilcox
ab55424763
Generalize buildnum patching for both `clientversion.h` and `configure.ac`.
2017-05-19 16:45:01 -07:00
Nathan Wilcox
482291582e
Implement the IS_RELEASE rule for betas.
2017-05-19 16:35:44 -07:00
Nathan Wilcox
68ab915a24
Implement `PathPatcher` abstraction, `clientversion.h` rewrite, and build numbering w/ unittests.
2017-05-19 16:32:09 -07:00
Homu
c7e1e4f29a
Auto merge of #2364 - emilrus:tordoc, r=nathan-at-least
...
Trivial: Replace bitcoind with zcashd in tor doc
2017-05-19 15:34:08 -07:00