zecfoundation
/
zcashd
mirror of https://github.com/ZcashFoundation/zcashd.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
16,315 Commits 27 Branches 108 Tags 109 MiB
Commit Graph

16315 Commits

Author SHA1 Message Date
sasha fccc66d844 Port btest rpc_z_shieldcoinbase_internals to gtest suite WalletRPCTests 2022-04-26 15:24:34 -07:00
sasha 996e6dde9e Create a new gtest group WalletRPCTests 2022-04-26 15:24:20 -07:00
sasha 84197d858f Port btest test_basic_joinsplit_verification to gtest suite Joinsplit 
Also, we downgrade transaction_tests to BasicTestingSetup since there's
no proofs here any more
 2022-04-26 15:24:20 -07:00
sasha 15e6e53738 Remove proof parameter loading from btests 2022-04-20 21:19:03 -07:00
sasha b865437e1e Make a LoadGlobalWallet and UnloadGlobalWallet for gtests 2022-04-20 21:18:25 -07:00
sasha 04f1b299c6 remove JoinSplitTestingSetup from sighash_tests -- it doesn't need it 2022-04-20 21:18:25 -07:00
Kris Nuttycombe cb1d6a02f7
Merge pull request #5900 from nuttycom/bug/mempool_nu_activation_test 
Fix missing initialization for `hasActions` in Orchard builder.
 2022-04-20 15:22:56 -06:00
Kris Nuttycombe 4a1fbe990e Fix boolean initialization in Orchard transaction builder. 2022-04-20 13:54:59 -06:00
Charlie O'Keefe a440e219d9
Merge pull request #5875 from zcash/update_boost 
Update boost and native_b2 dependencies to version 1.79.0
 2022-04-18 09:17:28 -06:00
Kris Nuttycombe 244276d244
Merge pull request #5721 from superbaud/loadproofs-in-gtest-utils 
Move LoadProofParameters to gtest/utils.cpp
 2022-04-14 18:28:45 -06:00
Kris Nuttycombe 57d9d9ee05 Update boost dependencies to version 1.79.0 2022-04-14 13:31:14 -06:00
Marshall Gaucher 958bcf2dac
Merge pull request #5870 from daira/make-reindex-imply-rescan 
Make -reindex and -reindex-chainstate imply -rescan
 2022-04-14 11:11:52 -07:00
Marshall Gaucher ea16573580
Merge pull request #5878 from superbaud/tx-orchard-duplicate-nullifiers 
add tx-orchard-duplicate-nullifiers.h to Makefile.gtest.include
 2022-04-14 11:02:03 -07:00
Kris Nuttycombe 3ee9c3accd
Merge branch 'master' into make-reindex-imply-rescan 2022-04-14 10:47:24 -06:00
Charlie O'Keefe e00a1215c0
Merge pull request #5871 from daira/clean-before-build 
zcutil/build.sh: Run zcutil/clean.sh before building
 2022-04-14 10:46:31 -06:00
sasha 35ed2ba344 add tx-orchard-duplicate-nullifiers.h to Makefile.gtest.include 2022-04-14 09:01:23 -07:00
Charlie O'Keefe 259b0e3643
Merge pull request #5872 from teor2345/patch-2 
Fix typo in getaddressbalance RPC help
 2022-04-14 09:18:01 -06:00
Charlie O'Keefe 57c1704b77
Merge pull request #5877 from daira/fix-4.7.0-release-notes 
[4.7.0 release notes] testnet nodes that upgrade prior to height 1,842,420 still need to run with -reindex and -rescan
 2022-04-14 09:17:38 -06:00
Daira Hopwood af7d883854 Make `-reindex` and `-reindex-chainstate` imply `-rescan` 
(provided that the wallet is enabled and pruning is disabled,
and unless `-rescan=0` is specified explicitly).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-04-14 14:53:29 +01:00
Daira Hopwood 2807c3f1a1 zcutil/build.sh: Run zcutil/clean.sh before building. 
fixes #3625

We use clean.sh rather than distclean.sh because the checksumming
and redownloading of C++ dependencies is pretty robust.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-04-14 14:51:49 +01:00
Daira Hopwood 265d02fa1e Fix to 4.7.0 release notes: testnet nodes that upgrade prior to height 1,842,420 
actually still need to run with -reindex and -rescan.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-04-14 14:35:06 +01:00
Kris Nuttycombe 8793f68e5e
Merge pull request #5876 from zcash/release-v4.7.0 
Release v4.7.0
 2022-04-14 06:44:57 -06:00
Kris Nuttycombe 44d0cf0c7c make-release.py: Updated release notes and changelog for 4.7.0. 2022-04-13 22:14:59 -06:00
Kris Nuttycombe ec42f38cfc make-release.py: Updated manpages for 4.7.0. 2022-04-13 22:04:00 -06:00
Kris Nuttycombe b384e411c4 make-release.py: Versioning changes for 4.7.0. 2022-04-13 21:48:12 -06:00
sasha 14fc356505
Merge pull request #5874 from zcash/pre-4.7.0-postpone-deps 
qa: postpone native_clang, libcxx, boost and native_b2 upgrades before 4.7.0 release. tested that it correctly shows current versions as either up-to-date or postponed.
 2022-04-13 20:33:20 -07:00
Kris Nuttycombe f8f698086b qa: postpone native_clang, libcxx, boost, and native_b2 upgrades before 4.7.0 release 2022-04-13 20:49:32 -06:00
sasha cf4de9d03d
Merge pull request #5741 from zcash/nu5-consensus 
NU5 consensus changes; merge requested by @nuttycom
 2022-04-13 18:09:21 -07:00
teor 05c9fe8c1c
Fix typo in getaddressbalance RPC help 
In JSON, the colon needs to be outside the field name.
 2022-04-14 09:33:20 +10:00
Kris Nuttycombe 7cf4d34801
Merge pull request #5868 from zcash/nu5_testnet_reactivation 
Set NU5 testnet reactivation height.
 2022-04-13 17:08:17 -06:00
Kris Nuttycombe 825d8e8781 Push back NU5 testnet release height to 1842420 2022-04-13 17:01:17 -06:00
Kris Nuttycombe a9e75ed10d Apply suggestions from code review 
Co-authored-by: Larry Ruane <larry@z.cash>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Steven <57410303+steven-ecc@users.noreply.github.com>
 2022-04-13 17:01:17 -06:00
Kris Nuttycombe 254122f9d2 Update the release notes to describe consensus changes since v4.6.0 2022-04-13 12:28:36 -06:00
Charlie O'Keefe cf579c2e4f
Merge pull request #5869 from superbaud/fix-taddr-2 
fix smoke_tests.py accounting math to remove the warning before test 4r
 2022-04-13 10:13:03 -06:00
Kris Nuttycombe 9ca0a41cf7 Update protocol version to 170050 for v4.7.0 release. 2022-04-13 08:22:56 -06:00
sasha d153f27f52 fix smoke_tests.py accounting math to remove the warning before test 4r 
the warning before test 4r is generated by the check_z_mergetoaddress
at line 459, which moves all the sapling funds into taddr_2 and thus
expects (sapling_balance - DEFAULT_FEE) to show up into taddr_2.

However, the check_z_mergetoaddress_parallel at line 418 had already
funded taddr_2 (with the sum of taddr_1 and taddr_3), and so we need to
add that to the amount of money that check_z_mergetoaddress at line 459
expects to find.
 2022-04-12 23:21:38 -07:00
Kris Nuttycombe 40487c079d Set NU5 testnet reactivation height. 2022-04-12 21:42:47 -06:00
sasha c07a4ab08c
Merge pull request #5862 from nuttycom/bug/reindex_wait 
Don't advance the wallet init timer until we're done reindexing. merge requested by @nuttycom
 2022-04-12 11:16:27 -07:00
Kris Nuttycombe 0b02d66bba Defensively check for a null pindex in `FindFork` 2022-04-12 09:39:45 -06:00
Kris Nuttycombe 72fc17ffc7 Don't advance the wallet init timer until past reindex. 2022-04-12 09:39:45 -06:00
Charlie O'Keefe 6205075970
Merge pull request #5866 from daira/revert-span-reload 
Partially revert #4909, in order to avoid a use-after-free after calling setlogfilter
 2022-04-12 09:00:26 -06:00
Charlie O'Keefe f46c64565c
Merge pull request #5861 from superbaud/smoketests-walletrequirebackup 
add walletrequirebackup=false to the zcash argument list in smoke_tests.py
 2022-04-12 09:00:03 -06:00
Daira Hopwood 9aed2a9f11 Revert "rpc: Reload CNode spans after reloading the log filter". 
fixes #5863

The span reloading was causing a use-after-free bug at the point
the old span was exited.

This reverts commit b517be4334.
As a result, `setlogfilter` will not be able to change whether
the peer tracing span is enabled (or whether IP addresses are
logged) for existing peers. That can be fixed later (#5867).

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
 2022-04-12 14:01:08 +01:00
sasha af36f184ab
Merge pull request #5859 from nuttycom/bug/pindexlasttip_null_init 
Fix missing null initialization of `pindexLastTip` pointer in ThreadStartWalletNotifier; merged as requested by @nuttycom
 2022-04-11 13:35:22 -07:00
sasha ce6e8fd5f4 add walletrequirebackup=false to the zcash argument list in smoke_tests.py 2022-04-11 13:16:41 -07:00
Kris Nuttycombe 21de7f1108 Fix uninitialized sleep variable. 2022-04-11 12:39:52 -06:00
Kris Nuttycombe 7ede9af587 Fix missing null initialization of `pindexLastTip` pointer in ThreadStartWalletNotifier 2022-04-11 11:36:15 -06:00
Charlie O'Keefe 327f61b5a8
Merge pull request #5851 from oxarbitrage/getaddresstxids_error_msg 
Change error message in getHeightRange
 2022-04-10 10:51:06 -06:00
Kris Nuttycombe 2fdff822f0
Merge pull request #5855 from str4d/update-deps-4.7.0 
Update dependencies for 4.7.0
 2022-04-09 12:46:30 -06:00
Jack Grigg 8e805f5d75 depends: Remove direct `tokio` dependency 
We still depend on it indirectly, but we don't use it directly anymore
since we upstreamed our patch to `metrics-exporter-prometheus`.

`thiserror` is also only used by the wallet tool, so has been reordered
accordingly.
 2022-04-09 15:06:29 +00:00