FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

set hasFirmwareErrorFlag as early as possible

This commit is contained in:
Matthew Kennedy 2024-03-12 15:29:44 -07:00
parent 498824eff4
commit 60967399cc
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
firmware/controllers/core/error_handling.cpp
View File

@ -215,6 +215,8 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
#if EFI_PROD_CODE #if EFI_PROD_CODE
if (hasFirmwareErrorFlag) if (hasFirmwareErrorFlag)
return; return;
hasFirmwareErrorFlag = true;
getLimpManager()->fatalError(); getLimpManager()->fatalError();
engine->engineState.warnings.addWarningCode(code); engine->engineState.warnings.addWarningCode(code);
#ifdef EFI_PRINT_ERRORS_AS_WARNINGS #ifdef EFI_PRINT_ERRORS_AS_WARNINGS
@ -227,7 +229,6 @@ void firmwareError(ObdCode code, const char *fmt, ...) {
turnAllPinsOff(); turnAllPinsOff();
enginePins.communicationLedPin.setValue(1); enginePins.communicationLedPin.setValue(1);
hasFirmwareErrorFlag = true;
if (indexOf(fmt, '%') == -1) { if (indexOf(fmt, '%') == -1) {
/** /**
* in case of simple error message let's reduce stack usage * in case of simple error message let's reduce stack usage