is this just dead?

This commit is contained in:
Matthew Kennedy 2023-03-03 02:05:50 -08:00
parent 2f5bc850c6
commit cd6b770945
3 changed files with 1 additions and 15 deletions

View File

@ -220,12 +220,6 @@ static Logging logicAnalyzerLogger("logic analyzer", logicAnalyzerBuffer, sizeof
* todo: is this mostly dead code?
*/
void updateDevConsoleState(void) {
// todo: make SWO work
// char *msg = "hello\r\n";
// for(int i=0;i<strlen(msg);i++) {
// ITM_SendChar(msg[i]);
// }
#if EFI_PROD_CODE
// todo: unify with simulator!
if (hasFirmwareError()) {
@ -342,7 +336,7 @@ class CommunicationBlinkingTask : public PeriodicTimerController {
enginePins.communicationLedPin.setValue(1);
#if EFI_ENGINE_CONTROL
if (lowVBatt || isTriggerErrorNow() || isIgnitionTimingError()) {
if (lowVBatt || isTriggerErrorNow()) {
// todo: at the moment warning codes do not affect warning LED?!
enginePins.warningLedPin.setValue(1);
}

View File

@ -30,14 +30,8 @@ extern bool verboseMode;
extern bool printFuelDebug;
#endif // EFI_PRINTF_FUEL_DETAILS
static cyclic_buffer<int> ignitionErrorDetection;
static const char *prevSparkName = nullptr;
int isIgnitionTimingError(void) {
return ignitionErrorDetection.sum(6) > 4;
}
static void fireSparkBySettingPinLow(IgnitionEvent *event, IgnitionOutputPin *output) {
#if SPARK_EXTREME_LOGGING
efiPrintf("spark goes low %d %s %d current=%d cnt=%d id=%d", getRevolutionCounter(), output->name, (int)getTimeNowUs(),

View File

@ -13,5 +13,3 @@ void fireSparkAndPrepareNextSchedule(IgnitionEvent *event);
int getNumberOfSparks(ignition_mode_e mode);
percent_t getCoilDutyCycle(int rpm);
void initializeIgnitionActions();
int isIgnitionTimingError(void);