Commit Graph

176 Commits

Author SHA1 Message Date
Matthew Kennedy 2ebd882722
Ignition outputs use a mask like fuel (#553)
* remove skipped spark check

* this test no longer does anything

* ignition mask outputs

* tests

* extract function to calculate mask

* don't even store the mask
2025-02-13 20:31:09 -08:00
Matthew Kennedy 7d7dd86f93 real obd codes are hex 2025-01-10 13:48:58 -08:00
Matthew Kennedy 02714916e8 sensor check oil temp 2025-01-07 15:14:29 -08:00
Matthew Kennedy 8fe18697da check oil pressure sensor 2025-01-07 15:12:11 -08:00
Matthew Kennedy 04a6a2c7d2 sensor checker knows about 5v sensor supply voltage 2025-01-03 18:32:48 -08:00
Matthew Kennedy d35d734a7f crust cleanup 2025-01-02 22:15:34 -08:00
Matthew Kennedy 43e759593c detect main relay faults 2025-01-02 21:34:59 -08:00
Matthew Kennedy a4dfd4c080 unnecessary assertion 2024-12-12 15:41:35 -08:00
Matthew Kennedy 6af46b59a9 MAP averaging can use common math for cyl offset calc 2024-08-28 02:58:21 -07:00
Matthew Kennedy 28cc1f2ede cleanup 2024-07-22 12:14:29 -07:00
Matthew Kennedy b36474888b Merge branch 'master' of https://github.com/fome-tech/fome-fw 2024-07-22 10:39:45 -07:00
Matthew Kennedy d19db63d0e dead error code 2024-07-21 22:22:14 -07:00
Matthew Kennedy aeec11078c adc cleanup 2024-07-21 13:22:28 -07:00
mi-hol 1d5c7fd220
clarify OBD error code CUSTOM_ERR_6566 to CUSTOM_ERR_CYL_ANGLE (#330)
* Update engine_math.cpp

* Update obd_error_codes.h

As suggested in https://github.com/FOME-Tech/fome-fw/pull/223#issuecomment-1684889630
2024-01-06 09:21:53 -08:00
Matthew Kennedy 38c873252e
smarter injector duty cycle limiting (#215)
* config for duty cycle limiting

* implement timeout duty cycle limiting

* comment

* make overlapping injections actually work!

* missed one

* test

* call addFuelEvents from fast callback

* update comment about why we call it again in main trigger callback

* one more extra call

* undo addFuelEvents change

* cleanup

* minor encapsulation

* fix

* changelog

* dead obd code
2023-10-14 14:27:19 -07:00
Matthew Kennedy f1e84220e0 another dead code while we're here 2023-10-12 23:27:19 -07:00
mi-hol fcf0da4798
comment unused OBD codes (#223) 2023-09-25 01:10:46 -07:00
mi-hol 0975c783bd
fix apparent CopyPaste error assigning OBD fault (#194) 2023-07-17 02:35:35 -07:00
mi-hol 5b349c9bac
comment unused obd_error_codes (#186)
* comment unused  obd_error_codes

* remove duplicated values
2023-07-09 13:22:06 -07:00
Matthew Kennedy 98a4d9eda8
bench test uses a semaphore instead of flags+sleep (#110)
* bench test uses a semaphore instead of sleeping

* s

* dead error code

* guards

* set priority

* comment
2023-06-29 14:14:07 -07:00
Matthew Kennedy ade14a956f make spark and fuel more similar 2023-06-25 01:37:45 -07:00
Matthew Kennedy d98e9d1d54 warn about fuel pressure sensor instead of error #111 #117 2023-06-23 01:27:24 -07:00
Matthew Kennedy d5f9479f28
ObdCode is enum class (#77)
* change ObdCode to enum class builds firmware

* test builds

* don't need this line at all

* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy 778289455b this warning is not useful fix #79 2023-04-12 19:42:44 -07:00
Matthew Kennedy d6534157a0 rename obd_code_e -> ObdCode 2023-04-11 16:32:47 -07:00
Matthew Kennedy eb23fd5771 cherry pick wow unique IDs are not enforced?! 2023-04-11 15:47:18 -07:00
Matthew Kennedy 404c0a8550 cleanup 2023-02-26 17:16:13 -08:00
Matthew Kennedy c551aef780 no reason to warn about injection pins, I think you already know 2023-02-24 23:57:15 -08:00
Matthew Kennedy 959f14fae6 more dead 2023-02-21 11:54:24 -08:00
Matthew Kennedy eee53678bd fire a warning in case of wideband fault (#5109)
* fire a warning in case of wideband fault

* s
2023-02-20 03:42:40 -05:00
Matthew Kennedy 54e711a705 detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
rusefillc 609608e025 findTriggerZeroEventIndex() failed fix #4935 2023-01-04 13:15:45 -05:00
Nathan Schulte 76bc7f22fd misc tidy (#4926)
* FrequencySensor: code-style

* smart_gpio: fix indent, tidy BOARD_EXT_GPIOCHIPS

tidy _GPIOCHIPS for #pragma message(STRING(BOARD_EXT_GPIOCHIPS output

* obd_error_codes: fix indent
2023-01-01 15:51:31 -05:00
Matthew Kennedy 29db8e2474 Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
rusefillc ac03dc55d8 CUSTOM_INSTANT_MAP_DECODING 2022-09-15 15:07:31 -04:00
rusefillc 64ab64d7de "Blip" with trigger error on several boards #4552
exploratory watchdog
2022-09-09 18:27:16 -04:00
Matthew Kennedy fba0906942 more granular trigger error messages (#4526)
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
2022-09-04 09:15:24 -04:00
rusefillc bf15c5bc8a ISO-TP does not work on real car #4427 2022-08-09 13:12:51 -04:00
Matthew Kennedy f49f6494fb report injector, ignition faults (#4408)
* report injector, ignition faults

* guard
2022-08-01 15:41:47 -04:00
Matthew Kennedy d4721bee89 implement sensor checker (#4395)
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
Matthew Kennedy 16a39badff Error handling cleanup (#4332)
* dead code in stm32

* rusefi.cpp can have some noreturn

* handle lua panic

* unused error codes

* simplifications of error_handling.cpp

* comment

* put that back

* guard
2022-07-07 23:49:02 -04:00
Matthew Kennedy 6267b8621a big delete ICU (#4270)
* big delete

* icu vestiges

* changelog
2022-07-07 15:27:59 -04:00
Matthew Kennedy 840bf6fb27 wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy 735b4899e2 allow setting injection phase by start or center of injection (#4068)
* allow SOI/COI

* other change

* renames and simplify

* clean up ownIndex

* double check in spark logic
2022-04-15 10:22:36 -04:00
Matthew Kennedy 72dabf4057 Flex fuel cranking improvements (#4043)
* improve flex cranking

* call it e85

* don't re-warn

* warning name

* ui
2022-04-04 17:41:36 -04:00
Matthew Kennedy 57525283ac Remove FSIO, byeeeeeeeee (#3865)
* vestigial config

* replace last functionality

* engine/board configs include

* files that didn't need to include this

* remove FSIO implementation

* stragglers

* random little bits

* s

* s

* ConfigDefinition

* jar

* s
2022-02-02 02:03:31 -05:00
Matthew Kennedy 9bd8a19564 oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
Andrey 14aac56c41 warning(CUSTOM_PID_DTERM, "PID: unexpected dTime") 2021-10-29 18:31:43 -04:00
rusefillc ee0db90107 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-23 23:00:04 -04:00
rusefillc fec25e0a39 Nick has RPM spikes and engine hiccups #3269 2021-10-03 01:48:34 -04:00