Scott Smith
659cc68be1
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Matthew Kennedy
7296593448
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
rusefillc
5ddd516860
refactoring - magic constant bad
2021-11-07 00:09:17 -04:00
rusefi
353782ad9c
this warning should be promoted to fatal!
2021-10-26 17:10:53 -04:00
Matthew Kennedy
dab377d15d
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
rusefillc
613ef6fe21
OBD error renames
2021-10-03 01:30:42 -04:00
rusefillc
dc8caa20bc
more firing orders!
2021-09-18 00:18:06 -04:00
Matthew Kennedy
3a8d92f879
Dwell voltage correction ( #3234 )
...
* cfg + impl
* ui
* value_or
* changelog
* fix
2021-09-15 08:07:33 -04:00
rusefillc
f33132af9e
firing order for some 911
2021-08-24 07:31:55 -04:00
rusefillc
76dc085abf
firing order for some 911
2021-08-24 07:28:56 -04:00
Matthew Kennedy
d3ec2b21d1
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
Andrey
35f631984d
VH41DE (Japaneese Y32 Variant) firing order
2021-07-20 21:16:51 -04:00
Matthew Kennedy
e3849b95d5
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
Andrey
cbe407f465
VAG canned tunes
2021-07-08 20:42:35 -04:00
Matthew Kennedy
110322d353
store cylinder count as plain number ( #2915 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* no need to be a typedef
* paste in actual cylinder count
2021-07-07 08:31:05 -04:00
Matthew Kennedy
717d4dd7ac
Unified cyl count macro ( #2914 )
...
* update test framework
* eh
* hey look it's fewer warnings
* unwind
* fix
* config
* configs
* logic
* even java had some
* console needs help
2021-07-06 20:14:08 -04:00
Matthew Kennedy
322f69474f
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
Matthew Kennedy
047f62b2b9
remove deprecated getEngineLoadT ( #2676 )
...
* remove
* few more
2021-05-10 08:30:41 -04:00
Matthew Kennedy
76f2f063d2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
Andrey G
7da6b4fa67
use cylinders_count_t in loops through cylinders ( #2563 )
...
to supress signed vs usigned warnings
2021-04-18 08:58:56 -04:00
Andrey G
a0053d5845
hip9011 and friends ( #2527 )
...
* engine math: extrant getFiringOrderTable for reuse
* engine math: getNextFiringCylinderId helper
* introduce knock_logic: first member is getCylinderKnockBank()
moved from software_knock.cpp
* hip9011: support two inputs/banks
* fix CI
* Board Subaru EG33: populated with TPIC8101 with Advanced mode
* hip9011: test communication in advanced mode
* hip9011: handle situation when chip is already in advanced mode
* Board Subaru EG33: cylinder to knock bank mapping
* hip9011: count spi transactions in advansed mode too
* hip9011: reset incalid responce counter after chip initialization
* hip9011: make debug output more structured
2021-04-04 18:13:21 -04:00
slowriot
9a8c2516ee
Add two new V8 firing orders ( #2423 )
...
* fix typos, spelling
* add two V8 firing orders
* use the available number of CPU cores, not just 4
* add new firing orders to config
* updating generated files to include new v8 firing orders
* reverting update of auto-generated files
* correct firing order labels for new firing orders
2021-03-05 19:28:17 -05:00
Matthew Kennedy
dbebc353a2
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
Andrey G
052e2e558b
Supress annoing unused warnings ( #2216 )
2021-01-11 08:49:20 -05:00
Matthew Kennedy
c870215c46
part of 2217 which may fix it alone ( #2220 )
2021-01-11 08:01:54 -05:00
Matthew Kennedy
add0dcd390
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
Matthew Kennedy
91a549736f
fix ( #2109 )
2020-12-20 19:31:14 -05:00
rusefi
93160c6abb
LM_ALPHA_N_2 rename
2020-11-27 15:44:31 -05:00
Matthew Kennedy
fc02c2bdf4
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
rusefi
c476cd3b95
refactoring
2020-09-03 19:29:15 -04:00
rusefi
470a9f5a5a
VVT support for VAG trigger #883
2020-08-25 12:45:18 -04:00
rusefi
7d53f5859d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
Matthew Kennedy
1a14c3cde7
no bins
2020-08-03 12:21:49 -07:00
Matthew Kennedy
7009c82993
Merge remote-tracking branch 'upstream/master' into remove-plain-maf
2020-07-31 14:56:29 -07:00
Matthew Kennedy
dbad10a253
remove
2020-07-29 01:35:17 -07:00
Matthew Kennedy
ea487327e1
Merge remote-tracking branch 'upstream/master' into remove-plain-maf
2020-07-28 20:25:16 -07:00
Matthew Kennedy
eda3fd020a
alphan
2020-07-25 01:14:35 -07:00
Matthew Kennedy
d19e2b2499
refacto
2020-07-24 18:26:24 -07:00
Matthew Kennedy
b1747ea48b
goodbye plain maf
2020-07-23 02:46:45 -07:00
Matthew Kennedy
c21b60eeb8
add reset
2020-07-14 23:54:41 -07:00
Matthew Kennedy
a79153bbea
correct batch fuel cylinder pairing ( #1595 )
...
* correct batch fuel cylinder pairing
* param
* only change behavior on two wire batch
* Add tests for two wire batch & sequential
* improve testing a little bit
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
Matthew Kennedy
c60b425ef0
plumb new load channels ( #1573 )
...
* wire up new channels
* add deprecation comment
* add gauges
* these tables are indeed used in those modes
* simplify
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-05 16:25:19 -04:00
Matthew Kennedy
cf624a7ab1
support 1-3-2 firing order ( #1537 )
...
* support 1-3-2
* oops
* correct TS
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-26 09:07:43 -04:00
Matthew Kennedy
9ecb0a4e55
refactor ( #1481 )
2020-06-03 21:12:12 -04:00
rusefi
5d39e3e088
partial rollback
2020-05-23 19:17:15 -04:00
rusefi
6f5592ed2a
partial rollback
2020-05-23 18:11:04 -04:00
rusefi
44b4c4bf25
partial rollback
2020-05-23 18:01:40 -04:00
rusefi
d75a50fde5
partial rollback
2020-05-23 18:00:20 -04:00
Matthew Kennedy
a2313a853c
switch some firmware warnings to errors ( #1465 )
...
* warnings as errors
* throw instead of exit
* test massaging
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi
4015c600e9
MRE pre-sets
2020-05-21 20:44:14 -04:00
rusefi
a390ec744e
no comments
2020-05-21 18:28:35 -04:00
Matthew Kennedy
10903c4659
remove "plain MAP" mode ( #1398 )
...
* consumers
* enums, input, config
* java
* default config cleanup
2020-05-05 15:04:55 -04:00
rusefi
65fde14800
Add firing order fix #1385
2020-04-29 16:46:59 -04:00
Matthew Kennedy
606a7fff0d
More TPS consumers: VE lookup ( #1256 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
Matthew Kennedy
0ac3e06149
cleanup extern mess ( #1237 )
...
* cleanup
* move outside define
2020-03-29 19:06:03 -04:00
Matthew Kennedy
a2a5b40ced
Support disabling most/all features ( #1162 )
...
* this flag did nothing
* guard features properly
2020-02-26 18:16:35 -05:00
Matthew Kennedy
fa8553b00d
Stricter compile options ( #1132 )
...
* stricter
* don't warn on that one
* this code was dead
2020-02-08 08:05:40 -03:00
rusefi
a222ecdfe1
happy new year unification
2020-01-13 21:57:43 -05:00
rusefi
bcec694eb1
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
rusefi
07b7b62bca
refactoring
2019-12-02 23:08:18 -05:00
rusefi
c5e60a7f93
improving API?
2019-11-24 00:15:44 -05:00
Matthew Kennedy
0a7535fb1f
Use templated array references ( #1027 )
...
* update defs
* consumers, use default params
* setArrayValues in tests
* floats
* test fixing
2019-11-22 23:27:24 -05:00
rusefi
12f65748b3
typo
2019-11-17 09:18:43 -05:00
rusefi
92d1842bd0
refactoring
2019-11-05 23:17:44 -05:00
rusefi
be9a67e67e
IM_TWO_COILS
2019-10-27 16:19:59 -04:00
rusefi
a8a0bc007a
docs
2019-10-26 21:53:22 -04:00
rusefi
9776d3c57d
better handling of corner case
2019-10-10 07:07:59 -04:00
rusefi
46e1ff671a
refactoring: better field name
2019-10-08 00:54:19 -04:00
rusefi
7d68b3d829
firing order 1-2-7-8-4-5-6-3
2019-09-28 10:25:57 -04:00
rusefi
0a92693729
Most important feature: VAG W12 firing order
2019-09-14 14:47:22 -04:00
rusefi
91bcd035af
reducing unit test noise
2019-08-25 01:15:18 -04:00
rusefi
6c45dfbc50
new 4 cylinder firing order!
2019-08-15 19:36:16 -04:00
rusefi
f6971c2bea
WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
...
refactoring to begin with, zero logic change
2019-08-08 00:19:09 -04:00
Matthew Kennedy
e4a0a0ae91
Fix some maf logic ( #880 )
...
* fix maf
* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
Matthew Kennedy
0b52f5b542
Template-ize bin/value length for interpolation ( #878 )
...
* update consumers
* tests
* whitespace
* format
2019-07-09 21:16:36 +03:00
rusefi
998345ef9e
unit tests should not have global context, including mock values
2019-05-27 15:56:12 -04:00
rusefi
884c54a185
defined(__DOXYGEN__) ? #748
2019-04-12 22:07:03 -04:00
rusefi
e28ce71bb8
unifying_file_naming
2019-03-29 09:11:13 -04:00
rusefi
cffac9b28e
better conditional compilation
2019-01-31 18:30:40 -05:00
rusefi
f475fb1691
better conditional compilation
2019-01-31 17:55:23 -05:00
rusefi
175a9f8ca5
#656 trying a new idea
2019-01-28 03:25:28 -05:00
rusefi
db9a99b0c5
#656 global is not great
2019-01-28 02:29:13 -05:00
rusefi
ad64e1b410
refactoring around GET_RPM
2019-01-21 20:33:21 -05:00
rusefi
6244cda6b4
better method name and docs related to improved craking logic
2019-01-20 11:33:40 -05:00
rusefi
c1509dd0b7
The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
2019-01-10 19:25:07 -05:00
Matthew Kennedy
a75e5fb007
const ( #648 )
2019-01-05 08:06:18 -05:00
rusefi
7ba963ab3b
#635
2019-01-01 14:05:11 -05:00
rusefi
095d9d4417
#625 big step - no more engine dependency from TriggerShape
2018-12-25 22:47:29 -05:00
rusefi
fdddbc976b
#635
2018-12-25 12:27:34 -05:00
rusefi
553969dc72
refactoring
2018-09-16 22:26:57 -04:00
rusefi
70b91d2295
names for error codes
2018-09-10 22:00:13 -04:00
rusEfi
55d6e252c8
wider macro usage
2018-07-28 19:16:58 -04:00
rusefi
c313cdc0b1
making error condition less fatal
...
#598
2018-07-28 15:36:47 -04:00
rusefi
fee08b0199
#598 better state initialization
2018-07-28 14:28:52 -04:00
rusefi
529fe56c02
#598
2018-07-28 14:01:28 -04:00
rusefi
e27becc8e4
#598 really strage error
2018-07-28 13:58:19 -04:00
rusefi
2f95cd1e0d
step towards more unique codes
2018-07-25 23:30:00 -04:00
rusefi
60b3aa8e60
unique error codes #598
2018-07-25 23:03:04 -04:00
rusefi
1af16c58dd
#598
2018-07-24 20:40:44 -04:00