Matthew Kennedy
2be0c8c916
NB trigger decoder maintains sync through rapid speed changes while cranking
2025-05-05 22:53:54 -07:00
Matthew Kennedy
f4b1b00e56
getShaftSynchronized can be const
2025-05-05 22:42:55 -07:00
Matthew Kennedy
2268520b4e
turn on the CEL when the engine is stopped
2025-01-07 16:45:11 -08:00
Matthew Kennedy
ae35062a99
deprecating EFI_ERROR_CODE
2024-12-28 14:13:50 -08:00
Matthew Kennedy
66576f0d61
Use batch fuel until cam sync happens
2024-12-24 19:32:30 -08:00
Matthew Kennedy
4d74ef4eb2
Live data: trigger error counter
2024-12-12 17:02:38 -08:00
Matthew Kennedy
95e474e7f8
revamp trigger/vvt logging
2024-12-12 16:42:10 -08:00
Matthew Kennedy
28e9f8a015
enum class-ify TriggerEvent
2024-12-12 15:37:14 -08:00
Matthew Kennedy
ce2198270e
avoid some misc shadowing
2023-11-01 13:58:39 -07:00
Matthew Kennedy
d7681bf194
no TriggerValue for vvt: #55
2023-02-28 02:11:28 -08:00
Matthew Kennedy
1440647ba5
better self stim behavior: allow sync w/ NB trigger
2023-02-22 23:16:01 -08:00
Andrey
0337cb44ac
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Matthew Kennedy
7b47e77e58
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
Andrey
77caa77b4b
trigger refactoring: instance RPM fix #4740
2022-11-06 12:03:55 -05:00
Andrey
65f5c00616
trigger refactoring: instance RPM #4740
2022-11-06 11:56:18 -05:00
Andrey
9edfda7f72
trigger refactoring: instance RPM #4740
2022-11-06 11:45:51 -05:00
Andrey
ba17b83bea
trigger refactoring: instance RPM #4740
2022-11-06 11:12:20 -05:00
Andrey
f8cce72779
trigger refactoring: instance RPM #4740
2022-11-06 10:58:04 -05:00
rusefillc
2d96fb3ef6
minor trigger refactoring
2022-11-06 00:32:38 -04:00
rusefillc
4c3c34518a
minor trigger refactoring
2022-11-05 22:42:33 -04:00
rusefillc
cb9e33d501
dead lines
2022-11-05 17:21:30 -04:00
Andrey G
cc9b1517ac
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
dbf8a1ea2a
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Matthew Kennedy
556769b181
terrible horrible typo ( #4597 )
2022-09-20 12:39:16 -04:00
Andrey
f5a5764429
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey G
2b4012b279
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 5274cffff3
* Get rid of efitime_t.
Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.
* Fix unit tests
* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
Andrey G
bbb71c4e7d
Supress tons of warning from triggers ( #4565 )
2022-09-11 15:25:58 -04:00
rusefillc
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00
rusefillc
f9b849dd8f
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
Andrey
3c1cc0b857
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
8253156233
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
Matthew Kennedy
670c2e4afe
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
Matthew Kennedy
fba0906942
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Matthew Kennedy
dfd340e8c3
log the state of hasSynchronizedPhase() ( #4478 )
...
* s
* log whether we've synced phase
* trigger_state_primary
* need that file
* engine state is not the right spot
2022-08-24 18:11:05 -04:00
Matthew Kennedy
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit 5454b8f509
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00
Matthew Kennedy
54c339c0a4
remove trigger duty cycle calculation ( #4213 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
* remove duty cycle thing
2022-05-30 22:39:57 -04:00
Matthew Kennedy
5f1801f9d6
trigger configuration refactoring for clarity ( #4212 )
...
* This field was ignored.
* move pad out
* gone
* make trigger configuration a little clearer
* even simpler!
* format
* test fix
2022-05-30 19:36:47 -04:00
Matthew Kennedy
d85ed5f3c0
trigger decoder returns a result ( #4206 )
2022-05-28 09:01:45 -04:00
Matthew Kennedy
65db5aacaa
Fix trigger error indicator ( #4185 )
...
* test and fix
* more shards!
2022-05-19 09:43:42 -04:00
Matthew Kennedy
cf89b42716
move logic in to trigger decoder ( #4162 )
...
* move logic in to trigger decoder
* status loop
* minor cleanup
* s
2022-05-10 23:55:28 +03:00
Matthew Kennedy
b243d3fca0
TriggerState -> TriggerDecoder ( #4157 )
2022-05-10 11:41:39 +03:00
Matthew Kennedy
05dd33ddb3
switch back to flag ( #4155 )
2022-05-10 07:52:29 +03:00
Matthew Kennedy
55fdd3f3c7
encapsulate stuff properly ( #4154 )
2022-05-09 15:46:36 -04:00
rusefillc
e64c8cfccb
synchronized Phase handling improvements fix #4099
2022-05-09 04:36:03 -04:00
rusefillc
394d1fe961
refactoring: bringing method names up to date
2022-05-08 09:04:27 -04:00
rusefillc
b2771f9b44
Remove value copy from controller into outputChannels #4095
2022-05-08 08:50:27 -04:00
rusefillc
b555d9e82b
toothed previous time #4019
2022-03-21 20:41:09 -04:00
Matthew Kennedy
d90d6705cf
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00