Commit Graph

210 Commits

Author SHA1 Message Date
Matthew Kennedy 041a3e12a3 extract isSyncPoint function (#3726)
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* clean up noise from test case

* clarify and comment
2021-12-30 11:39:04 -05:00
Matthew Kennedy b392a7120e improved noFiringUntilVvtSync logic (#3696)
* s

* poke

* poke again for science

* kick for science

* kick

* kick

* comment kick

* s

* don't try to compare the array decay pointer to 0 (!)

* collateral damage

* adjust miata sync

* reset trigger states correctly on engine stop

* s

* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc 71542ea6b9 live data this 2021-12-09 22:02:47 -05:00
Matthew Kennedy b9f8409f59 correctly compute engine revolution number (#3586)
* add param

* first revolution is revolution 0, not revolution 1

* would you look at that, we sync one rev quicker!

* changelog

* rpm value
2021-11-21 09:01:27 +03:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560)
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
2021-11-16 16:52:11 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Matthew Kennedy bd04dc8352 less macro, more c++ (#3549)
* less macro

* s
2021-11-15 12:44:40 +01:00
Scott Smith 9b40e68155 Save ~2800 bytes of RAM by not caching angle->trigger mapping (#3506)
Memory seems more valuable than CPU; use the O(lg n) lookup by angle.  A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Matthew Kennedy e3e5e57eac instant rpm uses full engine cycle (#3077)
* instant rpm uses full engine cycle

* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Andrey e8aef0dcd3 VVT position of first cam is off on first cycle fix #2987 2021-07-22 01:02:37 -04:00
Andrey c433c20a36 simplify quad vvt test #3018
better parameter name and explicit constraint clarification
2021-07-21 17:45:35 -04:00
rusefillc 206bf7adc8 reducing warnings 2021-07-13 14:50:10 -04:00
Andrey ab3a862f19 reducing code duplication 2021-07-06 00:09:35 -04:00
Andrey 8f13e5711a Nissan VVT trigger decoder #2887 2021-07-05 23:39:39 -04:00
rusefillc 32a813339d Nissan 2021-07-05 18:37:53 -04:00
Andrey 9ad5ec8044 refactoring: getShaftSynchronized 2021-07-03 10:37:03 -04:00
Matthew Kennedy 737ee444b8 rip the bandaid: find-replace most of scheduleMsg (#2572)
* biiiig find replace

* more trivial find replace

* pwm

* almost all of them

* few more

* gpio

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
rusefi 3d89cc2093 trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 15:17:01 -04:00
rusefillc 9c26a84be9 trigger and VVT duty cycle integration into limp manager #2523 2021-04-07 01:21:28 -04:00
Matthew Kennedy d5bc14719e trigger decoder timer (#2427)
* part 2

* stale comment

* include

* why was this a macro

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-07 16:35:58 -05:00
Matthew Kennedy 5bfee13c21 fix instant rpm (#2180)
* consumers

* impl

* instant rpm in idle timing
2021-01-14 20:45:55 -05:00
Matthew Kennedy e112bbd07e remove virtual calls from hot path (#1857)
* const ref-ify

* no virtual 

* even more const

* tests

* fix tests
2020-10-05 16:42:50 -04:00
Matthew Kennedy 060cfbd778 const ref-ify trigger (#1856)
* const ref-ify

* tests
2020-10-05 14:22:59 -04:00
Matthew Kennedy ebc884e8d5 trigger decode cleanup and perf (#1853)
* trigger decode cleanup

* test config ptr patchup

* disable CDM by default
2020-10-04 19:29:26 -04:00
rusefi b19ffa7075 TriggerConfiguration getPrintPrefix 2020-08-29 17:25:42 -04:00
rusefi 35702163ee const 2020-08-26 17:37:15 -04:00
rusefi f268af5165 const 2020-08-26 17:30:13 -04:00
rusefi b64c9bd9d3 VVT support for VAG trigger #883 2020-08-25 13:14:46 -04:00
rusefi 470a9f5a5a VVT support for VAG trigger #883 2020-08-25 12:45:18 -04:00
rusefi 7d53f5859d VVT support for VAG trigger #883 2020-08-25 00:59:07 -04:00
rusefi 4e333dac1c VVT support for VAG trigger #883 2020-08-24 02:07:58 -04:00
rusefi bdbee0d38b VVT support for VAG trigger #883 2020-08-24 02:01:50 -04:00
rusefi 0f9e8bf83e VVT support for VAG trigger #883 2020-08-24 01:21:42 -04:00
Matthew Kennedy 24b0c85a9e fix warnings (#1282)
* warnings

* don't need to template those
2020-04-12 09:39:14 -04:00
Matthew Kennedy a2a5b40ced Support disabling most/all features (#1162)
* this flag did nothing

* guard features properly
2020-02-26 18:16:35 -05:00
rusefi ae228dff0e trigger refactoring 2020-01-26 14:20:55 -05:00
rusefi 9bd796ab6b trigger refactoring 2020-01-26 12:02:54 -05:00
rusefi 98c6198f1d reducing code duplication 2020-01-26 06:28:33 -05:00
rusefi 23631b5970 trigger refactoring 2020-01-26 06:12:01 -05:00
rusefi d1a4b39a5a refactoring: de-coupling trigger decoder and engine 2020-01-26 03:48:25 -05:00
rusefi dfa8d9ccc9 refactoring trigger 2020-01-26 03:33:45 -05:00
rusefi 59c293b548 trigger refactoring 2020-01-25 11:22:25 -05:00
rusefi 43eb2ef9d0 refactoring trigger 2020-01-24 13:42:09 -05:00
rusefi c7875876e5 refactoring - de-coupling trigger 2020-01-22 13:25:35 -05:00
rusefi f6ce9397db refactoring 2020-01-22 01:22:44 -05:00
rusefi a89e20a647 refactoring 2020-01-22 00:40:26 -05:00
rusefi 63e3e84e08 happy new year 2020-01-08 00:02:40 -05:00
rusefi cf0b13041f random refactoring: hopefully not changing byte size of any variables but clarifying/fixing type between ticks, US and MS 2019-12-21 21:11:09 -05:00
rusefi bcec694eb1 just a trivial massive rename: TriggerState > TriggerWaveform 2019-12-08 01:09:39 -05:00
rusefi a5ee6b13d5 Refactor Trigger System #635
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
rusefi edabed50f5 Refactor Trigger System #635
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
rusefi 889ee45c16 typo 2019-12-06 00:07:27 -05:00
rusefi 0952b84aad unit tests progress 2019-09-19 21:41:52 -04:00
rusefi fe6b5d8c56 Live Data: trigger current gap 2019-09-03 19:30:51 -04:00
rusEfi 2aee194f3b Live Data VVT counter 2019-09-02 14:47:05 -04:00
rusEfi 92f371c121 new feature: check engine light to blink on trigger synchronization 2019-08-18 15:53:38 -04:00
Matthew Kennedy 515ab03688 const, explicit, and override (#831)
* const, explicit, and override

* more const

* more const

* missed a spot
2019-06-08 09:51:36 -04:00
rusefi 8b74476c1b BUG: phase sensor validation attending - detect missing CAM signal fix #659 2019-05-11 00:21:37 -04:00
rusefi 884c54a185 defined(__DOXYGEN__) ? #748 2019-04-12 22:07:03 -04:00
rusefi f475fb1691 better conditional compilation 2019-01-31 17:55:23 -05:00
rusefi ae88cbf7eb Trigger rabbit hole (#682)
fix #681

* this did not work right

* progress: spinning is detected sooner now

* and now things are much better?

* and now reducing RAM usage
2019-01-24 21:12:55 -05:00
rusefi c7cf1d0151 trigger refactoring: extracting methods to improve readability 2019-01-23 22:31:16 -05:00
rusefi 352886e69c trigger refactoring: extracting methods to improve readability 2019-01-23 22:06:42 -05:00
rusefi e630b10503 trigger code minor clean-up 2019-01-23 21:43:27 -05:00
rusefi 4877931613 C++11 and unique method name 2019-01-22 19:07:36 -05:00
rusefi eba0278fdd The Big Refactoring of 2019: configuration version should not be a global variable #656 2019-01-15 21:18:44 -05:00
rusefi 86a0d67d70 learning C++ 2019-01-15 20:24:36 -05:00
rusefi 02fcc40b8b enjoying C++11 2019-01-13 23:20:19 -05:00
rusefi 095d9d4417 #625 big step - no more engine dependency from TriggerShape 2018-12-25 22:47:29 -05:00
rusefi 7aca2d35a5 fixing popular typo 2018-10-23 03:47:30 -04:00
rusefi 20d7c655df refactoring trigger sync layer 2018-10-21 14:03:51 -04:00
rusefi fbb7f65a00 refactoring trigger sync layer 2018-10-21 12:29:41 -04:00
rusefi 1a4b3af134 refactoring trigger sync layer 2018-10-21 12:18:15 -04:00
rusefi bd54f6cba3 refactoring trigger sync layer 2018-10-21 12:03:08 -04:00
rusefi 3c3de0f527 refactoring trigger sync layer 2018-10-21 11:27:14 -04:00
rusefi 553969dc72 refactoring 2018-09-16 22:26:57 -04:00
rusefi d9bac2fb1b typo 2018-07-29 10:23:07 -04:00
andreika-git eb27c6b6e4 Impl. faster engine spin-up mode (alpha-version) (#567)
* Impl. faster engine spin-up mode (alpha-version)

* A comment for RPM_LOW_THRESHOLD

* Faster engine stop detection

* Safety check for instant RPM on spinning-up

* rusefi.xml

* unit-tests & relevant fixes
2018-03-10 20:58:51 -05:00
rusefi 43df4f83c6 refactoring: extract method 2018-03-03 19:26:59 -05:00
rusefi 61bb2a0475 docs & names 2018-02-06 01:16:34 +03:00
rusEfi 1eed1b02b3 #58 2017-12-13 21:08:34 -05:00
rusefi 79bc6c48a4 removing dead code 2017-12-12 18:04:54 -05:00
rusefi 6ade790bd3 removing dead code 2017-12-12 17:51:44 -05:00
rusefi 4eb18fb467 removing unused parameters 2017-12-04 00:04:47 -05:00
rusefi 852554088a #58 2017-12-03 23:58:48 -05:00
rusefi 135d98837f #58 2017-05-18 16:39:04 -04:00
rusefi 8d5502ae4e #58 2017-05-18 16:16:55 -04:00
rusefi 73c1f29cf9 better macro name 2017-05-15 23:33:22 -04:00
rusefi 7e0d8ed6ba SR20VE trigger 2017-03-18 21:36:51 -04:00
rusefi 90e6a61aff SR20VE trigger 2017-03-18 21:22:56 -04:00
rusefi 300637fef5 SR20VE trigger 2017-03-18 21:14:12 -04:00
rusefi ad43478b27 SR20VE trigger 2017-03-18 20:59:52 -04:00
rusefi c19e08a04a progress #363 2017-03-01 22:37:10 -05:00
rusefi 75b33a8842 #363 new flag for softer error handling 2017-02-23 08:44:10 -05:00
rusEfi 88b83e6b2f auto-sync 2017-01-03 17:01:42 -05:00
rusEfi 6edfc90330 auto-sync 2017-01-03 16:02:43 -05:00
rusEfi 552c664a23 auto-sync 2017-01-03 06:05:22 -05:00
rusEfi bced8873ab auto-sync 2016-10-31 22:02:12 -04:00
rusEfi c447a7165b auto-sync 2016-08-23 22:02:18 -04:00
rusEfi 00f45cf809 auto-sync 2016-08-22 23:04:55 -04:00