FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,954 Commits 28 Branches 12 Tags 605 MiB
Commit Graph

2351 Commits

Author SHA1 Message Date
Andrey a699e29c02 Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy 56aa0fe367 improve iat ignition table (#4948) 
* iat ignition table

* changelog
 2023-01-06 21:59:34 -05:00
Andrey ae13e1a000 Mitsubishi 4G93 Trigger issues #4918 
a good case for NAN?
 2023-01-03 21:17:32 -05:00
Andrey 0337cb44ac Mitsubishi 4G93 Trigger issues #4918 
adding more info on the trigger images
 2023-01-03 15:44:13 -05:00
Andrey 7c10ac7507 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey bdffec4ce5 let's try again 2023-01-03 08:38:42 -05:00
Andrey eb9c096ab7 a bit of dead code 2023-01-03 07:49:17 -05:00
Andrey 00e8cc4262 test coverage for antilag #4920 
fuel correction bugfix & test
 2022-12-31 14:48:25 -05:00
Andrey 36573a3044 test coverage for antilag #4920 
bugfix?
 2022-12-30 12:21:04 -05:00
Andrey cd6e3bc179 Merge branch 'master' of https://github.com/rusefi/rusefi 2022-12-30 12:18:53 -05:00
Andrey 6a3c7d20e7 test coverage for antilag #4920 2022-12-30 12:17:53 -05:00
Andrey 13c3699415 test coverage for antilag #4920 2022-12-30 12:11:57 -05:00
rusefillc 9b3c6a16b2 test coverage for antilag #4920 2022-12-30 11:53:47 -05:00
rusefillc 6ec6b0b82a refactoring: method name 2022-12-27 00:13:13 -05:00
rusefillc 886ec74442 antilag and anti-lag #2403 
TurboMarian is the ALS boss
 2022-12-21 20:12:00 -05:00
rusefillc 1e04153867 random Frankenso clean-up 2022-12-14 19:29:01 -05:00
Matthew Kennedy 2118aaff60 Allow scheduling_s to come from a pool (#4841) 
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-12-10 17:55:51 -05:00
Matthew Kennedy 29db8e2474 Combine angle based event (#4884) 
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
 2022-12-10 17:07:02 -05:00
Matthew Kennedy 016b71babe switch hpfp and aux valves to AngleBasedEventNew (#4882) 
* switch hpfp to AngleBasedEventNew

* aux valves too!
 2022-12-10 16:15:11 -05:00
rusefillc c0daffda1d reduce flash footprint by smarter code generation #4163 2022-12-03 00:51:41 -05:00
GitHub build-unit-tests Action 432842ddbd Trigger wheel definitions 2022-12-02 12:46:20 +00:00
Matthew Kennedy ecee1dd02d ETB error counter logic (#4854) 
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
 2022-11-30 22:20:09 -05:00
Andrey db8f7c48f3 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey 9641d08d67 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 20:08:19 -05:00
Andrey a6432feae7 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
rusefi 475c177f78 x2 spelling 2022-11-30 17:14:16 -05:00
Andrey 47aac2b46e ETB duty cycle jitter #4833 
need whole output not just closed loop part
 2022-11-30 15:25:50 -05:00
Matthew Kennedy 5576065eb9 default fuel cleanup and injection phase change (#4836) 
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-11-29 23:41:49 -05:00
Andrey 4a7a48779d ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 7547edb566 mock invalid & current state of ETB error counter 2022-11-29 20:36:03 -05:00
Andrey b97745496e refactoring: extracting method 2022-11-29 20:11:34 -05:00
Andrey ca63f37d9e ETB duty cycle jitter #4833 
do-you-TDD
 2022-11-29 16:05:36 -05:00
Andrey 8a3727de3e ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 73e309da03 ETB duty cycle jitter #4833 2022-11-29 14:02:44 -05:00
Andrey 82a3074cbd ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey 651944152f ETB JNI test progress 
Coffee is important!
 2022-11-29 10:25:15 -05:00
Andrey e31f042603 ETB JNI test progress 
I am pretty confused :(
 2022-11-29 10:17:05 -05:00
Andrey 2c13af3324 ETB JNI test progress 2022-11-29 09:58:35 -05:00
Andrey 1d4a454f0c ETB JNI test progress 2022-11-29 02:21:36 -05:00
Andrey d8e808ad13 ETB JNI test progress 2022-11-29 01:03:29 -05:00
Andrey 0c69adaa1f ETB JNI test progress 2022-11-29 00:38:59 -05:00
Andrey bcbe06d210 ETB JNI test progress 2022-11-29 00:10:46 -05:00
Andrey d7cdf75e22 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey a14fb947c2 exp average is pretty cool 2022-11-28 19:22:45 -05:00
Andrey ac12287ab0 ETB duty cycle jitter #4833 
weird, whatever for now :(
 2022-11-27 21:16:50 -05:00
Andrey c5a5d7f6eb ETB duty cycle jitter #4833 
weird, whatever for now :(
 2022-11-27 20:55:10 -05:00
Andrey e1d3647401 ETB duty cycle jitter #4833 
a step back to safety
 2022-11-27 19:26:28 -05:00
Matthew Kennedy 9e60b52ed4 fix warnings (#4840) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-11-27 10:11:14 -05:00
Andrey 638c7fdc6d Target AFR table Y axis stuck at 0 #4826 
sweet coverage :)
 2022-11-26 20:22:40 -05:00
Andrey 45a52e3ae2 progress 2022-11-26 17:39:25 -05:00
rusefillc c729b10bbe refactoring: constexpr fuel computer (#4830) 
* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

* refactoring: constexpr fuel computer

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-11-26 12:25:04 -05:00
rusefillc d63f1af40d without ValueProvider3D interface how do we mock? (#4829) 
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
 2022-11-26 11:23:54 -05:00
Andrey f32ae379f5 nissan 2022-11-23 23:45:25 -05:00
rusefillc 261222bb04 avoid ctime in GPS UART (#4824) 
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
 2022-11-23 13:20:36 -05:00
Nathan Schulte d4cc3caeab code style, GPS fixes (test, firmware) (#4822) 
* tidy NMEA

* const in nmea

* correct gps test output

* fix GPS UART print statements

* cleanup feature toggles in settings

* fix comment typos, misc whitespace
 2022-11-23 07:01:34 -04:00
rusefillc ba3d482340 What is "Aux PID"? #4807 2022-11-21 00:10:35 -05:00
GitHub build-unit-tests Action 5b03455dae Trigger wheel definitions 2022-11-16 20:54:55 +00:00
Andrey 7afc95a241 refactoring: default parameter, global replace 2022-11-16 14:28:43 -05:00
GitHub build-unit-tests Action 1ede71f987 Trigger wheel definitions 2022-11-16 16:48:00 +00:00
Andrey G 85f46318a4 SENT updates (#4774) 
* SENT: simplify

* SENT: add crc6 routine, check crc for slow channels enhanced messages

* SENT: helper to get Slow Channel values

* SENT: getTickTime() report tick unit time

* unit_tests: SENT: update tests
 2022-11-12 16:57:20 -05:00
Andrey 05b46b1b12 Nissan 2022-11-12 13:06:55 -05:00
Andrey G 9b0fa7ec43 SENT unit tests (#4769) 
* unit_tests: sent: zero-init

* sent: SENT_SLOW_CHANNELS_MAX to header

* unit_tests: sent: clock, falling edges

* SENT: support and autodetect if device sends pause pulse

Also rework tick time calculation

* unit_tests: SENT: verbose debug on request

* unit_tests: SENT: actual checks

* unit_tests: SENT: extract common code for reuse

* unit_test: SENT: add test with fuel pressue captured data

* unit_test: SENT: add test with Ford ETB CLOSED captured data
 2022-11-11 17:25:02 -05:00
GitHub build-unit-tests Action b52c80ad6b Trigger wheel definitions 2022-11-09 03:08:46 +00:00
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621) 
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
 2022-11-08 21:48:39 -05:00
Matthew Kennedy e801ffc979 fix vvt logging logic (#4747) 
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
 2022-11-07 10:52:17 -05:00
Andrey cebb3e1847 Ford SENT ETB bench test in NJ #4745 
we shall unit test SENT
 2022-11-07 00:06:42 -05:00
rusefillc 1e10055279 Ford SENT ETB bench test in NJ #4745 
we shall unit test SENT
 2022-11-06 23:21:54 -05:00
rusefi 5c32f75c2c reducing ugly 2022-11-06 21:28:38 -05:00
rusefi 80e02de00b https://rusefi.com/forum/viewtopic.php?p=46603#p46603 
calling 'setTimeout' on bad self (cpp class not export)
 2022-11-06 20:09:01 -05:00
Andrey e42939560f sensor_chart into unit tests 2022-11-06 11:28:25 -05:00
Andrey 25d292c462 trigger refactoring: instance RPM #4740 2022-11-06 11:05:57 -05:00
rusefillc cc7af64ed3 minor trigger refactoring 2022-11-06 00:59:29 -04:00
Matthew Kennedy 32b170810e duplicate log field names (#4730) 
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-11-05 20:23:09 -04:00
Matthew Kennedy acfde29c60 remove idle timing deadzone (#4731) 
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-11-04 15:02:20 -04:00
Andrey ea0a054dfc Nissan defaults 2022-11-02 12:05:51 -04:00
rusefi 8d0ac7a5be huh, we can pole larger method here 2022-10-26 12:08:27 -04:00
rusefillc 2aabff5c8f so much weird 2022-10-24 23:02:39 -04:00
Matthew Kennedy 890a8e0fed implement "ford mode" injector correction (#4686) 
* implement "ford mode"

* missed the enum value
 2022-10-20 22:25:39 -04:00
Matthew Kennedy 1cc46a1b83 simplify initializeSkippedToothTrigger (#4674) 2022-10-17 16:05:27 -04:00
GitHub build-unit-tests Action 1c74ddfc68 Trigger wheel definitions 2022-10-16 16:21:57 +00:00
GitHub build-unit-tests Action ad55f3fad1 Trigger wheel definitions 2022-10-16 14:42:22 +00:00
rusefillc 9c75704412 triggerImage: todo: support symmetrical crank 2022-10-16 10:33:38 -04:00
GitHub build-unit-tests Action 0abfdd8df1 Trigger wheel definitions 2022-10-16 14:31:28 +00:00
rusefillc 5590b55273 triggerImage: todo: support symmetrical crank 2022-10-16 02:59:57 -04:00
GitHub build-unit-tests Action a1b0b76fcd Trigger wheel definitions 2022-10-16 06:57:03 +00:00
rusefillc fc66b45ce4 triggerImage: todo: support symmetrical crank 2022-10-16 02:44:57 -04:00
Matthew Kennedy 7116670fd0 build tweaks for size (#4661) 
* don't align on non-cached mcu

* lua decimal point

* no snprintf

* sort sections by alignment

* unit tests
 2022-10-13 20:30:30 -04:00
GitHub build-unit-tests Action 060849c364 Trigger wheel definitions 2022-10-10 01:31:12 +00:00
Matthew Kennedy 14b92612e2 fix 36-2-1 trigger (#4645) 
* fix

* test files

* test real 4b11

* test.mk

* better angle error math

* test GM too

* changelog
 2022-10-09 21:22:05 -04:00
GitHub build-unit-tests Action 795b3cff84 Trigger wheel definitions 2022-10-06 02:10:48 +00:00
Matthew Kennedy f07c00548b 2jz test (#4638) 2022-10-05 20:48:28 -04:00
Andrey 3d329639ea Mark is asking for VIN number field #3967 2022-10-04 21:12:51 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628) 
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
 2022-10-04 20:36:03 -04:00
Matthew Kennedy 60fc30d34d remove 898 (#4634) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-10-04 20:12:57 -04:00
Matthew Kennedy f2c8a0192c fix instant rpm clearing bug (#4629) 
* improve instant rpm

* changelog
 2022-09-29 07:15:59 -04:00
Matthew Kennedy 9cd5553617 plumbing parts of 4621 (#4622) 
* plumbing parts of 4621

* show error list

* exit on error too!

* this test has some unhealthy undefined behavior

* no uninitialized values

* no that doesn't work

* remove the invalid data and the bug becomes obvious
 2022-09-25 18:49:54 -04:00
Matthew Kennedy 90489edb96 schedule ignition charge by angle instead of tooth (#4513) 
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
 2022-09-25 11:00:55 -04:00
GitHub build-unit-tests Action 9996f3c562 Trigger wheel definitions 2022-09-25 13:23:24 +00:00
Matthew Kennedy 6f5bed28d9 better k gaps (#4623) 2022-09-25 09:14:29 -04:00
Matthew Kennedy dbf8a1ea2a #4619 (#4620) 2022-09-25 07:40:28 -04:00
Andrey 24cf41c5f7 Honda K cam wheels #3405 2022-09-25 00:26:42 -04:00
Andrey df0bb3ebc5 Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Andrey 178fe15760 more inclusive configuration name 2022-09-24 23:49:41 -04:00
Andrey 4653cde601 K progress 2022-09-24 23:18:57 -04:00
Andrey cd2da05443 progress 2022-09-24 23:07:55 -04:00
Andrey 63fe1120bd fancy default and reusing constant 2022-09-24 23:01:42 -04:00
Andrey 3730a4650c renaming stuff 2022-09-24 22:55:54 -04:00
Andrey 533d30efd1 fancy 2022-09-24 22:54:58 -04:00
Andrey d497d99a8c K 2022-09-24 15:37:51 -04:00
Andrey e7e9742ba9 refactoring: extract constant 2022-09-24 15:33:01 -04:00
rusefillc 35bf947f06 insist on setBoardConfigOverrides fix #4614 (#4615) 
* insist on setBoardConfigOverrides fix #4614

* insist on setBoardConfigOverrides fix #4614

* insist on setBoardConfigOverrides fix #4614

* insist on setBoardConfigOverrides fix #4614

* insist on setBoardConfigOverrides fix #4614
 2022-09-24 07:35:19 -04:00
Matthew Kennedy 02aad24c59 explicitly pass which edges we sync trigger on (#4607) 
* require sync edge type

* s

* fix neon

* info printing

* put enums back

* auto gen enum fiddling
 2022-09-23 20:39:41 -04:00
GitHub build-unit-tests Action e1cebcef4f Trigger wheel definitions 2022-09-24 00:25:12 +00:00
rusefillc c6a2f2657b honda K enum rename 2022-09-23 20:13:14 -04:00
rusefillc 08499c7252 K20 2022-09-23 20:13:14 -04:00
rusefillc 04ac7fcd3b K20 2022-09-23 18:25:24 -04:00
Matthew Kennedy 0dfba2a655 remove ignitionPin (#4608) 
* remove ignitionPin

* now that's gone

* BMW test
 2022-09-23 17:30:10 -04:00
Matthew Kennedy 4e78c4c922 two modes trigger scheduler (#4598) 
* two modes trigger scheduler

* asOld

* hpfp
 2022-09-20 05:28:23 -04:00
rusefillc 70dc03a821 B6 2022-09-17 23:49:24 -04:00
Andrey 579f3df7ad deep rabbit holes are the best ones! 
refactoring: encapsulation
 2022-09-14 01:53:17 -04:00
Andrey b439f27284 inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey 34f87a3683 inline method to reduce confusion 2022-09-14 01:24:19 -04:00
Andrey b1451e229c GM 2022-09-14 00:03:38 -04:00
Andrey 32c6aef746 code formatting 2022-09-13 23:44:38 -04:00
Andrey G 2b4012b279 dead code, reduce typedefs (#4566) 
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 5274cffff3

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
 2022-09-11 16:08:11 -04:00
Andrey G 1ca5988877 time routines refactor (#4563) 
* Extract time helpers from engine_controller_misc to efitime.cpp

* Rename currentTimeMillis() to getTimeNowMs()

We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.

find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;

* Rename getTimeNowSeconds() to getTimeNowS()

To align with Nt, Us, Ms versions.

* Some comments about getTimeNowLowerNt()
 2022-09-11 13:06:03 -04:00
rusefillc 921b97431f refactoring: type safety 2022-09-11 03:46:50 -04:00
rusefillc cb3c070928 refactoring: type safety 2022-09-11 02:57:35 -04:00
Andrey 50b1d03001 E38 2022-09-09 14:04:22 -04:00
Andrey 73150de8df E38 2022-09-09 01:15:55 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547) 
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
 2022-09-08 16:15:36 -04:00
Andrey 3c1cc0b857 trigger: in corner cases like NB2 and VQ35 those are not revolutions 2022-09-07 22:24:28 -04:00
Andrey 31dbf06c84 os_access.h dead? 2022-09-07 16:00:13 -04:00
Andrey f243f1608c B6 2022-09-06 15:12:43 -04:00
Matthew Kennedy 1efe511be8 add hysteresis to limp rpm, boost, injector duty (#4541) 
* add hysteresis

* changelog
 2022-09-05 20:56:32 -04:00
Andrey c8cdc50877 wow Leiderman-Khlystov 2022-09-05 20:23:40 -04:00
Andrey 07c08947ba wow Leiderman-Khlystov 2022-09-05 20:02:33 -04:00
Andrey ab3d92b995 tear down Engine god object #4511 
just trying different things
 2022-09-05 04:24:17 -04:00
Andrey 1eb1f1a101 tear down Engine god object #4511 
just trying different things
 2022-09-05 04:00:24 -04:00
Andrey 76b74a85ba tear down Engine god object #4511 
just trying different things
 2022-09-05 02:44:06 -04:00
Andrey 82fa9b191a refactoring: let's use different names for different things 2022-09-05 01:16:24 -04:00
Andrey 75b1549853 refactoring: moving field 2022-09-05 01:15:45 -04:00
Andrey 7706e2d4ae wow Leiderman-Khlystov 2022-09-04 18:29:13 -04:00
rusefi 0f828f19a7 wow Leiderman-Khlystov 2022-09-04 15:58:46 -04:00
rusefi 2cc625871a B6 2022-09-04 11:47:57 -04:00
rusefi ee90371837 B6 2022-09-04 11:29:18 -04:00
Matthew Kennedy fba0906942 more granular trigger error messages (#4526) 
* granular trigger error messages

* adjust test expectations

* explicitly test behavior
 2022-09-04 09:15:24 -04:00
Andrey e56924310b tear down Engine god object #4511 
just trying different things
 2022-09-03 07:44:24 -04:00
rusefillc 54e05ba0fc moving state into specific class (#4520) 
* moving state into specific class

* moving state into specific class
 2022-09-02 14:38:03 -04:00
Andrey 1ffa98ba89 a bit of dead code 2022-09-01 11:47:56 -04:00
Andrey 2b01d856d3 reducing confusion between library header and rusefi main repo header 2022-09-01 11:35:35 -04:00
Andrey 436c294770 refactoring: reducing outputChannels copy 2022-09-01 10:58:16 -04:00
Andrey ea22fcbe95 refactoring: enum name clean-up 2022-09-01 00:23:33 -04:00
Andrey 3eaaf5e293 english do you speak it 2022-08-31 22:56:38 -04:00
GitHub build-unit-tests Action 4fd74a2f2e Trigger wheel definitions 2022-09-01 02:22:06 +00:00
Andrey adde8077dd B6 progress 2022-08-30 05:20:56 -04:00
Andrey c18245d697 B6 progress 2022-08-30 04:38:20 -04:00
Andrey b0a09a2171 B6 progress 2022-08-30 04:07:48 -04:00
Matthew Kennedy dcab243381 knock retard limit table (#4498) 
* add max retard table

* ui

* s

* better naming

* s

* test can use base class
 2022-08-30 01:57:37 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499) 
* idle always uses instant rpm

* configs

* fully inject rpm
 2022-08-29 22:18:06 -04:00
Matthew Kennedy 2926570747 idle coasting table is RPM, not clt (#4487) 
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
 2022-08-29 08:15:04 -04:00
GitHub build-unit-tests Action 2c6db0638f Trigger wheel definitions 2022-08-29 02:52:44 +00:00
GitHub build-unit-tests Action 4d7e91b615 Trigger wheel definitions 2022-08-29 02:23:56 +00:00
Matthew Kennedy d660b240c4 B6 progress 2022-08-28 12:33:32 -04:00
Matthew Kennedy 234909a91f remove some uses of EFI_ERROR_CODE (#4496) 
* lua hooks

* findAngleMatch

* s

* s
 2022-08-28 09:43:21 -04:00
Matthew Kennedy 0d99d828e3 trim table for throttle #2 (#4472) 
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
 2022-08-28 08:28:20 -04:00
Andrey fdacca9152 B6 progress 2022-08-27 20:44:30 -04:00
Andrey 756eae8f54 B6 progress 2022-08-26 12:07:13 -04:00
Andrey 0f0c5598ab B6 progress 2022-08-26 00:30:46 -04:00
Andrey fefa1048fc B6 progress 2022-08-26 00:24:38 -04:00
Andrey caa9f1cf3c B6 progress 2022-08-26 00:21:17 -04:00
Andrey 077bdec25b refactoring 2022-08-26 00:16:36 -04:00
Andrey c17cc38470 refactoring 2022-08-26 00:14:52 -04:00
Andrey 45d8716fcc B6 progress 2022-08-26 00:04:47 -04:00
rusefillc 1ea6535b83 two bugs love to cancel each other 2022-08-25 23:55:42 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482) 
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
 2022-08-25 21:26:17 -04:00
Andreika fda9448798 [DRAFT] Air by rpm taper (#4486) 
* add rpm to getOpenLoop() and getRunningOpenLoop()

* implement airByRpmTaper

* unit-test for airByRpmTaper
 2022-08-25 21:23:23 -04:00
Andrey 3d50b20155 B6 progress 2022-08-25 19:26:18 -04:00
Andrey 2277d36cc6 B6 progress 2022-08-25 12:45:47 -04:00
Andrey 52210e2a74 B6 progress 2022-08-25 11:15:54 -04:00
Andrey 0b3478697a Lua code reuse 2022-08-25 10:45:26 -04:00
GitHub build-unit-tests Action fc1748de4c Trigger wheel definitions 2022-08-24 03:41:03 +00:00
rusefillc f5576b05d9 VQ trigger gaps improvement fix #4469 
nice, unit test is happier!
 2022-08-23 23:32:14 -04:00
GitHub build-unit-tests Action a80234ebdc Trigger wheel definitions 2022-08-22 23:49:31 +00:00
rusefi 3eeff9e388 Lua CAN bus index: let's fail if invalid value specified 2022-08-21 22:31:52 -04:00
Andrey 8f33e1b40f test coverage and some magic constant refactoring 2022-08-21 16:03:34 -04:00
Andrey 2d4b944547 test coverage and some magic constant refactoring 2022-08-21 15:22:22 -04:00
rusefi ea7597e0d6 trigger gap logging: it's a mess :( 2022-08-21 12:38:29 -04:00
rusefi 2f882b1452 refactoring: default argument value 2022-08-21 12:17:50 -04:00
Matthew Kennedy ea733ecbf0 fix inverted vvt (#4464) 
* fix inverted mode

* unit tests are great
 2022-08-20 20:12:32 -04:00
Matthew Kennedy f5c9c29a39 enable alwaysInstantRpm in some tests (#4461) 
* test some with alwaysInstantRpm set

* more
 2022-08-19 15:03:20 -04:00
Matthew Kennedy 6218edd040 allow logging multiple warnings at once (#4414) 
* allow logging multiple warnings at once

* comment

* .Code

* Revert ".Code"

This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.

* add a better comparison operator instead of conversion

* dot code

* Revert "dot code"

This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.

* force gcc-10 maybe?

* Revert "force gcc-10 maybe?"

This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.

* vq

* dot code

* dead

* dot code

* return may be null

* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?

* move static vector

* put cyclic buffer back how it was since we don't use it now
 2022-08-17 01:12:25 -04:00
rusefi b057c5bd71 random progress 2022-08-13 23:33:30 -04:00
rusefillc 69d582a674 ECU to Mainline DynoLog Data Protocol #4319 2022-08-12 23:53:48 -04:00
Matthew Kennedy fcb9897443 resolve VVT phase using every tooth, not just sync point (#4434) 
* resolve VVT phase using every tooth, not just sync point

* fix tests

* comment

* changelog
 2022-08-12 08:08:23 -04:00
rusefillc d97bcec161 refactoring: better field name 2022-08-09 20:32:39 -04:00
Matthew Kennedy 5fc7000834 Pt2001 module (#4396) 
* pt2001 uses module

* read flag0

* c

* libfirmware

* makefiles

* are unit tests happy?

* bootloader
 2022-08-08 08:53:08 -04:00
Matthew Kennedy 24142f8330 Simpler thread controller (#4327) 
* s

* Start -> start

* maybe tests are happy

* s

* s
 2022-08-02 01:16:13 +03:00
GitHub build-unit-tests Action 9106784bd2 Trigger wheel definitions 2022-07-31 14:26:12 +00:00
Matthew Kennedy d4721bee89 implement sensor checker (#4395) 
* implement sensor checker

* use default

* s

* fix

* properly report non-timeout errors

* it's not safe to read Value when invalid

* it's not safe to read Value when invalid
 2022-07-30 17:08:48 -04:00
rusefillc 35f9830cca it's impossible to receive AcceleratorPedal sensor via CAN/Lua #4369 2022-07-28 12:08:35 -04:00
Matthew Kennedy 14b39b7b0a unexpected contains information about why it failed (#4393) 
* unexpected can contain information

* info printing

* sensors return appropriate error codes

* remove reliance on undefined behavior

* s
 2022-07-28 10:04:28 +03:00
Matthew Kennedy 9f6ee5f359 detect bad Lua sensor name when registering (#4391) 
* format

* lua error on bad sensor

* comment

* name validation

* soft check before the hard check causes a fatal error

* s
 2022-07-27 12:41:21 +03:00
Matthew Kennedy a131c2c559 Reenable sanitize (#4384) 
* turn on sanitize, fix overrun

* allow sanitize override, disable it for shared lib

* probably fix android build
 2022-07-27 09:22:22 +03:00
GitHub build-unit-tests Action fc41ddc0d3 Trigger wheel definitions 2022-07-23 07:52:13 +00:00
Andrey e3278ad925 Extra gap ratios for custom trigger wheels fix #4375 2022-07-23 03:39:19 -04:00
Andrey 43bc08bc24 Extra gap ratios for custom trigger wheels fix #4375 2022-07-23 03:16:11 -04:00
rusefillc 7536414bfa Revert "Reenable sanitize (#4365)" 
This reverts commit da6bf0a775.
 2022-07-22 08:15:15 -04:00
Matthew Kennedy da6bf0a775 Reenable sanitize (#4365) 
* turn on sanitize, fix overrun

* allow sanitize override, disable it for shared lib
 2022-07-22 08:19:54 +03:00
Matthew Kennedy 1596228f10 libfirmware has interpolation tests (#4362) 
* move interpolation tests

* what actually happens if sanitize is off?

* oh look there are real bugs to be caught by sanitizer
 2022-07-21 15:41:42 -04:00
rusefillc 2bc4fd909d Launch control bug? "range" thing is confusing #4348 
a typo and configurable behaviour without UI
 2022-07-20 18:48:55 -04:00
Matthew Kennedy 2bf6c94663 fragments (#4357) 2022-07-19 11:02:41 +03:00
Matthew Kennedy 1fd637d27e remove idle offset (#4355) 
* remove offset

* remove more completely

* changelog
 2022-07-18 15:49:43 -04:00
Matthew Kennedy 1951bbda8b move math (#4353) 2022-07-17 00:16:22 -04:00
Matthew Kennedy cd98ad35c2 use libfirmware for a few things (#4351) 
* use libfirmware

* unit tests

* crc

* missed one

* bootloader
 2022-07-16 02:22:51 -04:00
rusefillc e91d72bba5 launch control for autocross on micro rusefi #4341 2022-07-14 16:41:50 -04:00
rusefillc 133ab5618b FSIO is dead 2022-07-14 07:52:58 -04:00
rusefillc 75ee3cfa03 RoverK - wow that's odd, but whatever 2022-07-12 03:09:42 -04:00
GitHub build-unit-tests Action 418b23660b Trigger wheel definitions 2022-07-12 04:33:14 +00:00
rusefillc eb4446f466 Make hard-coded gap ratios visible on trigger documentation images #4172 2022-07-12 00:11:25 -04:00
rusefillc cc3cbdabc0 Make hard-coded gap ratios visible on trigger documentation images #4172 2022-07-11 04:21:17 -04:00
Matthew Kennedy 3c88dda538 Add a timeout for Lua ETB adjustment (#4331) 
* lua etb timeout

* mocks

* test
 2022-07-10 05:46:28 +03:00
Matthew Kennedy 68fb838641 Lua hooks for gear detection (#4328) 
* implement

* sim has vss

* write a test

* guard
 2022-07-07 23:16:56 -04:00
Matthew Kennedy ab24c5eb35 Rewrite tooth logger buffer management (#4317) 
* s

* make it work

* put back enough maybe

* fix console composite log

* unit tests can just use a vector, why not

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-07-04 16:57:17 -04:00
Matthew Kennedy b5d85334c3 hellen board ID detect improvements (#4307) 
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-07-02 05:19:02 -04:00
Matthew Kennedy 67439afb96 rescale RPM values (#4300) 
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-06-29 18:48:30 -04:00
rusefillc 8708fd73cf logging of live data structs was: data points #3614 
huh?
 2022-06-29 02:42:03 -04:00
Matthew Kennedy 88ff234c91 Injector scheduled by angle, not tooth index (#4208) 
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine

* injection doesn't care about teeth

* fix up existing tests

* oh look, we can actually test this logic now without trying to depend on trigger shape!!!

* fix a real bug

* simplify
 2022-06-24 17:43:23 -04:00
Matthew Kennedy d5f1235a43 trigger tweaks cleanup (#4278) 
* simplify some math

* we say yes to the todo

* and put back that test

* test
 2022-06-23 23:11:29 -04:00
Matthew Kennedy f5843258b4 fix (#4279) 2022-06-23 21:35:05 -04:00
Matthew Kennedy 840bf6fb27 wideband live data (#4276) 
* wideband live data magic

* test build happy

* test even happier
 2022-06-23 20:04:26 -04:00
Andrey edd4dcb004 VAG Lua progress 2022-06-23 16:02:09 -04:00
Andrey 13107964f2 VAG Lua progress 2022-06-22 22:22:49 -04:00
Matthew Kennedy ccec58446b clt based rpm limit (#4267) 2022-06-22 16:49:24 -04:00
rusefillc 0dbecf312e bit math is hard :( 2022-06-20 21:51:21 -04:00
rusefillc 1b8e3bda34 bit math is hard :( 2022-06-20 21:36:10 -04:00
GitHub build-unit-tests Action d2c07806ae Trigger wheel definitions 2022-06-20 15:54:57 +00:00
GitHub build-unit-tests Action 784cbc0573 Trigger wheel definitions 2022-06-20 12:39:12 +00:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152) 
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2022-06-09 17:21:22 -04:00
GitHub build-unit-tests Action 32e15a6942 Trigger wheel definitions 2022-06-02 01:35:22 +00:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226) 
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
 2022-06-01 21:24:20 -04:00
Matthew Kennedy 56e7acd869 Trigger cleanup init (#4222) 
* extra parameter

* name decoders in constructor

* s
 2022-06-01 00:55:34 -04:00
rusefillc 767790621f helping build 2022-05-31 10:45:32 -04:00
rusefillc 2c5419df23 heling build 2022-05-31 08:48:24 -04:00
GitHub build-unit-tests Action c71a293f90 Trigger wheel definitions 2022-05-31 02:50:12 +00:00
Matthew Kennedy 54c339c0a4 remove trigger duty cycle calculation (#4213) 
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix

* remove duty cycle thing
 2022-05-30 22:39:57 -04:00
Matthew Kennedy 5f1801f9d6 trigger configuration refactoring for clarity (#4212) 
* This field was ignored.

* move pad out

* gone

* make trigger configuration a little clearer

* even simpler!

* format

* test fix
 2022-05-30 19:36:47 -04:00
Matthew Kennedy cf51533f45 More trigger encapsulation (#4207) 
* trigger decoder returns a result

* TriggerFormDetails

* s

* don't reach out and touch the engine
 2022-05-29 13:49:00 -04:00
GitHub build-unit-tests Action b4fbdd7aa7 Trigger wheel definitions 2022-05-24 19:05:09 +00:00
rusefillc 5d8f43789a spaces in JAVA_HOME usability 2022-05-24 14:42:42 -04:00