FOME-Tech
/
fome-fw
mirror of https://github.com/FOME-Tech/fome-fw.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
17,768 Commits 30 Branches 13 Tags 619 MiB
Commit Graph

1876 Commits

Author SHA1 Message Date
GitHub build-unit-tests Action 7d5d1251aa Trigger wheel definitions 2022-01-31 23:31:07 +00:00
Matthew Kennedy 60b9ddeb1e vss based dfco (#3845) 
* vss based dfco

* fix digits while we're here

* fix some other digits for fun

* don't use custom assert

* simplify test

* less than or equal, test vss behavior

* even better than comments are tooltips
 2022-01-27 14:05:18 -05:00
Matthew Kennedy 50c31b78ae extract logic from wall wetting AE (#3848) 
* extract logic

* extract interface

* explicitly test wall fuel
 2022-01-27 07:45:50 -05:00
Matthew Kennedy 4804a736f0 vss and flex are filtered (#3839) 
* vss and flex are filtered

* turbo

* freq sensor test
 2022-01-26 17:33:04 -05:00
Matthew Kennedy 1a0682aa0e dfco checks driver throttle intent (#3832) 2022-01-24 14:26:39 -05:00
Matthew Kennedy b07127614b decouple TPS accel enrichment from trigger (#3825) 
* move call site

* move thresholding out of fast path

* adjust config

* test
 2022-01-23 15:31:39 -05:00
Matthew Kennedy a1647fd66e baro fully in sensor model (#3829) 
* consumers and api

* dead test

* baro uses sensor model

* remove old (copy of?) map lookup logic

* I guess we don't need FastInterpolation any more?

* don't double init analog input
 2022-01-23 09:42:11 -05:00
Andrey 4e676e1a86 fixing NOISY_RPM handling via Sensor framework 2022-01-21 00:21:45 -05:00
Andrey 014ea2b78a migrating to SensorType::Rpm API 2022-01-20 23:54:52 -05:00
Andrey 970f81c5b3 migrating to SensorType::Rpm API 2022-01-20 23:43:18 -05:00
Andrey 5f3324cd6b migrating to SensorType::Rpm API 2022-01-20 23:32:59 -05:00
Andrey 5353d13d96 migrating to SensorType::Rpm API 2022-01-20 23:19:48 -05:00
Andrey 670bd91658 migrating to SensorType::Rpm API 2022-01-20 23:03:45 -05:00
Andrey f7f6a31530 migrating to SensorType::Rpm API 2022-01-20 22:58:12 -05:00
Andrey 37e700f8bd migrating to SensorType::Rpm API 2022-01-20 22:51:20 -05:00
Andrey 779e2fcbc5 migrating to SensorType::Rpm API 2022-01-20 22:44:59 -05:00
Andrey 92cbba3256 migrating to SensorType::Rpm API 2022-01-20 22:42:13 -05:00
Andrey adb00d4255 migrating to SensorType::Rpm API 2022-01-20 22:40:15 -05:00
Andrey e1f1f28045 migrating to SensorType::Rpm API 2022-01-20 22:31:07 -05:00
Andrey a168a94628 migrating to SensorType::Rpm API 2022-01-20 22:26:05 -05:00
Andrey 72ae8dd4a1 migrating to SensorType::Rpm API 2022-01-20 22:22:52 -05:00
Andrey 5d6985f085 migrating to SensorType::Rpm API 2022-01-20 22:12:04 -05:00
Andrey 3a6597464f migrating to SensorType::Rpm API 2022-01-20 22:04:45 -05:00
Andrey c27ed2525f what's the difference between setRpmValue and assignRpmValue #3815 
refactoring
 2022-01-20 21:57:27 -05:00
Matthew Kennedy 6fc4503ee2 XY Idle VE Table (#3781) 
* config & ui

* implement

* test idle VE switching behavior

* use the interface where we can

* s

* re-bump flash version
 2022-01-20 14:08:54 -05:00
GitHub build-unit-tests Action ad6251b5b3 Trigger wheel definitions 2022-01-20 02:18:29 +00:00
David Holdeman 38c1aaef93 use -C flag (#3811) 2022-01-18 19:25:59 -05:00
Andrey eb5206dada Remove legacy check fix #3808 2022-01-18 16:01:27 -05:00
Andrey b927134b0f https://rusefi.com/forum/viewtopic.php?p=44100#p44100 2022-01-18 10:24:08 -05:00
rusefillc 60e8eaf290 gcov coverage seems stale #3805 2022-01-18 08:35:37 -05:00
rusefillc f1862b9cad https://en.wikipedia.org/wiki/Pi 2022-01-14 21:51:03 -05:00
Matthew Kennedy 78119b7df4 improve maf output channels and logging (#3743) 
* maf channels

* s

* binary log

* if only I could type

* can

* instant RPM too

* s

* test

* graceful zero rpm

* test works

* float near
 2022-01-12 15:41:35 -05:00
rusefillc dd4950f850 Code style for methods with zero arguments #3535 2022-01-11 22:40:52 -05:00
Matthew Kennedy cb368580a6 don't start boost pwm unnecessarily (#3767) 
* don't start boost pwm unnecessarily

* test
 2022-01-11 20:47:50 -05:00
rusefillc 5c68f86a0d RE usability: live data for idle controller 2022-01-10 21:55:52 -05:00
rusefillc 5eaabf5eb6 RE usability: live data for idle controller 
static bad, class fields better
 2022-01-10 20:12:11 -05:00
rusefi 53b118d54e we can live without this test 2022-01-08 20:34:31 -05:00
rusefillc 0335802d7e mk files refactoring 
saving build
 2022-01-06 22:19:00 -05:00
rusefillc d447e34344 mk files refactoring 2022-01-06 21:48:48 -05:00
rusefillc 47f0423b73 mk files refactoring 2022-01-06 20:32:39 -05:00
rusefillc 1955c5a3c2 mk files refactoring 2022-01-06 20:06:31 -05:00
rusefillc 433ff5c62e Live Data progress 2022-01-06 19:02:35 -05:00
Andrey 5e9fcca6f9 Live Data progress 2022-01-05 20:41:51 -05:00
Andrey 6c1b363d37 Live Data progress 2022-01-05 20:15:23 -05:00
rusefillc 5737590d94 itoa unit test, not a very detailed one 2022-01-03 03:31:57 -05:00
Matthew Kennedy 4627bace31 Improve NA/NB miata sync parameters (#3730) 
* NA sync parameters

* NB vvt pattern too

* zach's car says tighten the gap

* look at that, we sync one cycle sooner!
 2022-01-01 21:39:04 -05:00
Matthew Kennedy c2cc5c8cc7 cylinder ignition trim (#3709) 
* cylinder ignition trim

* changelog

* changelog

* test

* move UI
 2022-01-01 15:47:47 -05:00
Matthew Kennedy 265f005239 hook up fuel trims (#3715) 
* hook up fuel trims

* pass all the params

* store per-cylinder fuel mass directly

* main trigger callback only touches per-cylinder, no banks!

* test test test test

* move UI to happy land

* changelog
 2022-01-01 02:19:59 -05:00
Matthew Kennedy c058698859 Nb2 crank sync special case (#3727) 
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* custom nb decoder

* test only resyncs once!

* good job valgrind, you found a bug!
 2021-12-31 15:47:25 -05:00
rusefillc 213c22fde3 GDI Epic #1448 
live view
 2021-12-31 15:28:24 -05:00
Matthew Kennedy d90d6705cf adjustment to #3722 (#3723) 
* s

* behold, another bug a test caught

* test

* test generates usable trigger pattern so it works correctly

* comment

* don't need that
 2021-12-31 01:21:21 -05:00
Matthew Kennedy 041a3e12a3 extract isSyncPoint function (#3726) 
* extract isSyncPoint

* test because why not

* check vvt resync nb2

* clean up noise from test case

* clarify and comment
 2021-12-30 11:39:04 -05:00
rusefillc e525bf06a7 E65 2021-12-29 00:50:17 -05:00
Andrey ea8e8fcc4b extract method 2021-12-27 21:09:41 -05:00
Andrey 89ceae63ba E65 2021-12-26 14:48:00 -05:00
rusefillc 917c13ef50 docs 2021-12-26 13:41:10 -05:00
rusefillc 98423f2046 live data 2021-12-26 13:00:17 -05:00
rusefillc 774e452738 E65 2021-12-24 17:35:27 -05:00
Andrey aedf984089 E65 2021-12-24 16:58:12 -05:00
Andrey f1705e83a9 E65 2021-12-24 16:56:17 -05:00
Andrey 1bcc0c9c92 E65 2021-12-24 16:53:24 -05:00
Andrey 436dec6df5 refactoring 2021-12-24 16:51:31 -05:00
Matthew Kennedy 5642ef07be Autoscale all the things! (#3713) 
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
 2021-12-22 08:09:41 -05:00
Matthew Kennedy 0f133f88a1 Map3D accepts any scaled_channel type (#3712) 
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio
 2021-12-21 18:52:46 -05:00
Andrey 1fc31cd565 Map3D needs some changes to allow autoscale RPM bin #3707 2021-12-21 16:04:16 -05:00
Matthew Kennedy f2312facd6 tables support non-integer-scaled scaled_channel (#3708) 
* support dividers

* float

* format
 2021-12-21 00:59:07 -05:00
Matthew Kennedy 2ba4c7844d simplify some table lookups (#3692) 
* simplify

* expand interpolation test
 2021-12-20 08:14:30 -05:00
Matthew Kennedy fae8b9ec06 clean up timing table defaults (#3705) 
* less crazy configs

* cleanup

* make that test happy
 2021-12-20 08:02:38 -05:00
rusefillc c8e1bde986 2 byte table axis #3045 2021-12-20 02:07:03 -05:00
Andrey faa29f0dc2 2 byte table axis #3045 
fixing build
 2021-12-20 01:50:23 -05:00
Andrey 842c787645 are we missing something? 2021-12-19 23:57:36 -05:00
rusefillc 7eca4d663b 2 byte table axis #3045 2021-12-19 22:43:10 -05:00
Matthew Kennedy e076ea4a04 make macos happy (#3699) 
* s

* explicitly include it because that's a good idea.
 2021-12-19 09:58:49 -05:00
Andrey be448c56f3 ISO-TP accounting for new buffer size 2021-12-19 01:10:13 -05:00
rusefillc 7a2d55fd53 is that all it needs? 2021-12-19 00:54:20 -05:00
Andrey 62d8ba2ae7 PCAN sandbox - error requestOutputChannels fix #3698 2021-12-19 00:29:30 -05:00
Andrey b9022a926d TS via TCP connector and ISO-TP via PCAN #3667 2021-12-18 21:46:49 -05:00
GitHub build-unit-tests Action ae52b4c5f5 Trigger wheel definitions 2021-12-17 03:17:55 +00:00
rusefillc b0c1a8fb2e MAP phase sensing fix #3544 
removing dead implementation
 2021-12-16 21:28:27 -05:00
rusefillc 02e31e1555 MAP phase sensing #3544 
removing dead implementation
 2021-12-16 21:13:55 -05:00
Andrey 3034dcc752 Lua to read tsOutputs #3376 
unit test fix
 2021-12-15 09:23:06 -05:00
rusefillc c82df1adef Lua to read tsOutputs #3376 
let's break master!
 2021-12-15 08:56:59 -05:00
rusefillc dafeaeaa31 Lua to read tsOutputs #3376 2021-12-14 23:16:05 -05:00
GitHub build-unit-tests Action 991511552d Trigger wheel definitions 2021-12-15 02:30:21 +00:00
Matthew Kennedy 8afee6c233 Honda K 12+1 decoder adjustment (#3694) 
* adjust trigger

* real cranking

* mk
 2021-12-14 21:10:01 -05:00
GitHub build-unit-tests Action d696a1620c Trigger wheel definitions 2021-12-14 00:05:57 +00:00
Matthew Kennedy d6a0154f79 maybe more working MAP sampling (#3689) 
* what if we do this

* cleanup

* s

* test
 2021-12-11 03:01:28 -04:00
Andrey 04cbd91b8c MAP phase sensing #3544 2021-12-10 17:28:03 -05:00
Andreika adfe24c801 can_isotp fix? (#3678) 
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
 2021-12-08 18:12:51 -05:00
Matthew Kennedy bdf6583306 smarter priming logic (#3674) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
 2021-12-08 16:20:19 -05:00
rusefillc e2e482d2b1 docs 2021-12-08 16:05:57 -05:00
Andreika 95adac3f03 CAN ISO-TP progress (+unit-tests fix) (#3677) 
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
 2021-12-08 15:11:19 -05:00
rusefillc 98dbf0a352 rusEFI console ISO-TP via PCAN #3667 2021-12-08 12:01:28 -05:00
rusefillc d735f8d198 rusEFI console ISO-TP via PCAN #3667 2021-12-08 11:55:34 -05:00
Matthew Kennedy e80654511d prime upon ignition voltage, not on power on (#3662) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* test

* dead adjacent line of code
 2021-12-08 07:26:49 -05:00
Matthew Kennedy 3d3bf5ea4b ignition controller detects rising edge on voltage (#3636) 
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test
 2021-12-07 21:28:04 -05:00
Andrey d3afd617d2 MAP phase sensing #3544 
new implementation seems complete?
 2021-12-07 21:08:25 -05:00
Andrey 0f6c9e15c3 MAP phase sensing #3544 
new implementation
 2021-12-07 20:00:04 -05:00
Andrey 7046d737ba docs 2021-12-07 19:59:43 -05:00
Andrey 1d52e84e35 refactoring 2021-12-07 17:00:42 -05:00
Andrey c793b19538 MAP phase sensing #3544 
look new unit test!
 2021-12-07 16:58:10 -05:00
Matthew Kennedy aa8584d89a calculate per-cylinder ignition timing (#3652) 
* simplify cylinder phasing

* per cylinder timing

* s

* s

* s

* why was there a divide by 2?
 2021-12-06 21:19:37 -05:00
rusefillc 2b465be253 MAP phase sensing #3544 
option to look for high and low peaks
 2021-12-05 14:25:26 -05:00
rusefillc e0559a8548 MAP phase sensing #3544 
taking a step back to happy place
 2021-12-04 18:21:10 -05:00
rusefillc 216b5d9e7a tune via CAN #3361 
CAN testability
 2021-12-04 01:01:48 -05:00
rusefillc 82044e579a header style 2021-12-04 01:01:48 -05:00
Andrei d1f30f10b1 CAN update 2021-12-03 21:44:15 -05:00
rusefillc 9dcaa2ecbc trigger_adc helping simulator 2021-12-01 14:17:16 -05:00
rusefillc a13bc09fe4 trigger_adc unit tests 2021-12-01 13:35:44 -05:00
Andrei 6c01dd5791 trigger_adc unit-test data files 2021-12-01 12:28:48 -05:00
rusefillc 52eace58e4 proteus to have enlarged Lua 2021-11-30 21:37:17 -05:00
Matthew Kennedy 565a94ea34 Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630) 
* no working copy

* oops
 2021-11-29 16:44:45 -05:00
rusefillc 7e99e9123d Epic: Remove FSIO #2928 2021-11-28 17:54:26 -05:00
Matthew Kennedy aed334f9ac better VSS configuration (#3542) 
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2021-11-27 08:49:07 -05:00
GitHub build-unit-tests Action 63e0b8b599 Trigger wheel definitions 2021-11-26 02:09:34 +00:00
GitHub build-unit-tests Action 0519ad2acb Trigger wheel definitions 2021-11-25 23:54:51 +00:00
Andrey 695557f709 MAP phase sensing #3544 2021-11-24 22:36:36 -05:00
Andrey d8799e7e8e MAP phase sensing #3544 2021-11-24 21:53:32 -05:00
Andrey c1196988a0 MAP phase sensing #3544 2021-11-24 21:53:16 -05:00
Matthew Kennedy 5274cffff3 main relay doesn't use fsio (#3580) 
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag

* main relay

* plumbing

* dead fsio stuff

* test it

* by 100%, we mean 99.98%
 2021-11-24 07:47:51 -05:00
rusefillc 7760ddd8b6 live data for wastegate #3588 
i want to persist state so no 'const' sorry
 2021-11-23 15:52:43 -05:00
rusefillc d9e8509440 harley 2021-11-22 19:16:57 -05:00
Matthew Kennedy 9bd8a19564 oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc 5271d9791a j1850 SAE crc8 Lua 2021-11-22 14:19:19 -05:00
rusefillc 3d8ddbceea j1850 SAE crc8 2021-11-22 14:03:52 -05:00
Scott Smith 9d61fb4cfd Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData (#3519) 
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData

Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp.  It could be better but this is simple
   and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays.  Makes the interface simpler
   and more rigid.  Also saves 4 bytes per Multi*.  Downside is access is now via -> and *,
   not . and (nothing).

Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA

* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?

* No magical templated StaticAlloc thingy.  Just virtual functions.
 2021-11-21 04:56:07 -05:00
Matthew Kennedy b9f8409f59 correctly compute engine revolution number (#3586) 
* add param

* first revolution is revolution 0, not revolution 1

* would you look at that, we sync one rev quicker!

* changelog

* rpm value
 2021-11-21 09:01:27 +03:00
Matthew Kennedy e2a4504728 rpm calculator refactoring, gm 24x test (#3585) 
* data

* stub test

* use getTimeSinceSyncPoint

* s

* s

* no

* test

* stray ;

* those were 1/10 what they were supposed to be

* actually check something

* dead log line?
 2021-11-20 14:59:02 +03:00
rusefillc 8029f8446a only c++ because lua does some things asan doesn't like, but don't actually cause overruns. 2021-11-20 03:04:52 -05:00
Matthew Kennedy 568dc8a277 don't do things that don't work in clang (#3584) 
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
 2021-11-20 02:40:41 -05:00
Matthew Kennedy 569415930c detect more overflows with asan (#3582) 
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
 2021-11-20 01:38:39 -05:00
rusefillc 03b13af2db On -fpermissive in Windows in unit tests fix #3581 2021-11-20 00:26:52 -05:00
rusefillc 6766ff8cab On -fpermissive in Windows in unit tests #3581 2021-11-20 00:23:27 -05:00
rusefillc 18aacc0ef6 On -fpermissive in Windows in unit tests #3581 2021-11-20 00:16:03 -05:00
Scott Smith 07d30285fc Basic framework for high pressure fuel pump control (#3476) 
* Basic framework for high pressure fuel pump control

* Many changes

Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot

* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.

* Make scheduling test actually useful - need non-0 activation angle.

Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
 2021-11-19 23:06:51 -05:00
Matthew Kennedy e7956a53f6 fuel pump doesn't use fsio (#3576) 
* fuel pump

* s

* call correct callback

* more dead

* test adjustment

* don't overflow

* don't need separate function

* java

* give it a name

* generated

* generated

* add to generate script

* import *

* this is so cheap we don't need a flag
 2021-11-19 22:23:12 -05:00
Matthew Kennedy a79b0c424c turn on c++ 20 (#3579) 
* set flags

* emit initializers

* jar
 2021-11-19 22:19:34 -05:00
Scott Smith aba4e5167e Separate out scheduleOrQueue into it's own standalone scheduler. (#3573) 
It's a large enough entity that it shouldn't be buried in ignition logic.
 2021-11-18 14:27:21 -05:00
Scott Smith b3e0b28c75 Make the module API more concise. (#3571) 
engineModules.get<FOO>(). becomes modules<FOO>()->

I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
 2021-11-17 21:50:00 -05:00
Scott Smith 659cc68be1 Final cleanup of ENGINE macros (#3567) 
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
 2021-11-17 13:45:10 -05:00
Scott Smith f9f13f0bad Create a base class EngineModule for that contains various useful callbacks. (#3548) 
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
 2021-11-17 20:13:19 +03:00
Scott Smith 80091498a6 Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565) 
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
 2021-11-17 03:54:21 -05:00
Scott Smith 14578ddae7 Remove a bunch of macros from engine_ptr.h (#3562) 2021-11-17 10:01:39 +03:00
Scott Smith dac2ae9b1d Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* (#3560) 
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*

for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
    git grep -l "$i" | xargs sed -i "s/$i//g"
done

git grep -l "inject" | xargs sed -i "/inject[(][)]/d"

for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
    git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done

git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h

* Review fixups.
 2021-11-16 16:52:11 -05:00
rusefillc 774d96493e spelling 2021-11-16 16:46:54 -05:00
Matthew Kennedy 7296593448 remove engine pointer passing (#3556) 
* some

* more

* more

* the last?!
 2021-11-16 04:15:29 -05:00
Scott Smith 2cfc4af998 Start the process of using a global engine ptr for unit tests. (#3551) 
* Start the process of using a global engine ptr for unit tests.

Passing around the engine, config, and persistent state wasn't buying anything.  Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables.  Add a dummy check in
case some test tries to set them manually.

* Fix OSX build

* Adapt PR to recently added code.
 2021-11-16 00:23:14 -05:00
Scott Smith c354d30a71 Use Valgrind to detect unitialized variable references. (#3555) 
* Use Valgrind to detect unitialized variable references.

Fix the edge cases that pop up

* Comment and disable Mac run
 2021-11-15 23:42:23 -05:00
Andrey b545743f7d Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
Andrey 7b790d36f6 random refactoring: trigger central encapsulation 2021-11-15 20:22:05 -05:00