Commit Graph

1390 Commits

Author SHA1 Message Date
Matthew Kennedy 58a5569006 require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
rusefillc bdb23d215d totally hiding irrelevant control to reduce confusion 2022-10-03 12:05:49 -04:00
rusefillc 75f9e94cd5 there is no third trigger simulator channel right? 2022-10-03 10:59:03 -04:00
rusefillc b756eba99b VVT minimum RPM #4545 2022-09-27 22:17:43 -04:00
rusefillc 0b707fbf90 engineSyncCam to be a drop-down not a number value #4611 2022-09-27 13:53:51 -04:00
rusefillc 8204b34ac4 engineSyncCam to be a drop-down not a number value #4611 2022-09-27 12:37:13 -04:00
rusefillc cd4e669077 ;+ is no longer needed 2022-09-26 05:44:52 -04:00
rusefillc 719bcaa288 engineSyncCam to be a drop-down not a number value #4611
the easy part
2022-09-26 05:26:52 -04:00
Andrey 178fe15760 more inclusive configuration name 2022-09-24 23:49:41 -04:00
rusefillc a06e3d5607 minor menu improvements 2022-09-22 22:36:24 -04:00
rusefillc 3a55a2d89a auxSpeed1 2022-09-20 23:00:42 -04:00
Matthew Kennedy e737141a6f add fuel/spark cut codes to TS indicators (#4592)
* add fuel/spark cut codes to TS indicators

* fix list

* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
rusefillc a4a1995508 useBiQuadOnAuxSpeedSensors 2022-09-19 12:13:20 -04:00
rusefillc a1143779f2 documenting biquad or else concerns 2022-09-19 12:06:00 -04:00
Matthew Kennedy 3987c12796 wbo fault code indicator (#4591)
* indicator for wideband errors

* only show if CAN wideband enabled

* tweaks
2022-09-18 21:37:46 -04:00
Matthew Kennedy 4106704385 add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
Matthew Kennedy 14068656ad more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefillc 7654c84c41 better location for mapCamDetectionAnglePosition 2022-09-15 15:07:11 -04:00
rusefillc 420822cb23 kick Start Cranking mode #4569 2022-09-13 02:18:49 -04:00
rusefillc 05fa36e744 Mark is asking for VIN number field #3967
GM says Hi
2022-09-10 01:05:31 -04:00
rusefillc b2ad515b0f vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey a35f20af78 remove alternator on/off mode fix #4548 2022-09-07 22:46:42 -04:00
rusefi 06552b6bee servo is truly not alive 2022-09-06 16:29:12 -04:00
Andrey d1088ceae7 refactoring: reducing outputChannels copy 2022-09-05 20:53:38 -04:00
Andrey 8f59b2e2a6 this one not my fault 2022-09-05 20:48:36 -04:00
Matthew Kennedy 99161cc523 use defs instead of magic numbers (#4523)
* use defs instead of magic numbers

* consecutive
2022-09-04 09:52:14 -04:00
Matthew Kennedy e81d7276f7 fix critical error readout (#4521)
* this indicator must be EXACTLY like this

* formatting tweaks while we're here
2022-09-03 11:57:55 -04:00
Matthew Kennedy ec8be9400c AC delay (#4502)
* AC delay

* changelog
2022-08-31 19:01:42 -04:00
Matthew Kennedy dcab243381 knock retard limit table (#4498)
* add max retard table

* ui

* s

* better naming

* s

* test can use base class
2022-08-30 01:57:37 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy ffa486d3f1 fixes (#4497) 2022-08-29 20:32:07 -04:00
Matthew Kennedy 0d99d828e3 trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
rusefillc b33e2d2a5b TinerStudio: no need to have 3s timeout, 300mS is ok for single-back devices. fix #4360 2022-08-27 18:19:47 -04:00
Andrey G 8aa3bf0544 tunerstudio: indicators: no blank indicators (#4492)
I'd like to see something on indicator even it is off.
2022-08-27 15:29:36 -04:00
Andrey G 20521dded2 tunerstudio: GPPWM gauges: unique names, use Note as label (#4491) 2022-08-27 15:01:47 -04:00
Andrey G aefea6d3ff output channels: isFuelPumpOn vs isPumpOn, remove second one (#4490) 2022-08-27 14:28:33 -04:00
Andrey G f8054437d3 Tunerstudio cleanup (#4489)
* tunerstudio: move LUA counters to gaugeCategory = LUA

* tunerstudio: move test bench gauges under gaugeCategory = Test Bench

* rusefi.input: gaugeCategory: formating

* tunerstudio: gaugeCategory = CAN for CAN counters

* tunerstudio: divide PIDs gaugeCategory into three: IDLE, ETB and Alternator
2022-08-27 09:55:19 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Matthew Kennedy e40c3a2180 etb rev limit indicator (#4483) 2022-08-25 20:49:21 -04:00
rusefi 7340700b74 refactoring 2022-08-24 12:11:11 -04:00
rusefillc 0886338770 Pavel Xenon is asking for EGT limping mode #3172
let's lower expectations for now
2022-08-22 18:08:38 -04:00
rusefillc cd30075ea4 upload ini from firmware build #4456 2022-08-18 10:19:09 -04:00
rusefillc 7a00ada5fd upload ini from firmware build #4456 2022-08-18 09:45:46 -04:00
Matthew Kennedy 2bfa3be1dc upload ini from firmware build (#4456) 2022-08-17 18:29:07 -04:00
rusefillc 8e07f864ca unconditional VVT PID logging 2022-08-17 01:03:21 -04:00
rusefillc 357c4c672a poke just in case 2022-08-16 21:00:59 -04:00
rusefillc f722b36716 # users are confused by TCU dialogs. open question how to repackage as pre-alpha 2022-08-15 17:28:24 -04:00
rusefillc 5f896cf00f https://github.com/rusefi/alphax-4chan/issues/57 2022-08-11 10:08:51 -04:00
rusefillc 443ac0bfdf Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-10 01:39:24 -04:00
Matthew Kennedy 66b4523575 add option to invert vvt control (#4425)
* add option to invert vvt control

* s

* s

* s

* one bit per cam type

* move the space

* I don't spelling good

* changelog
2022-08-09 16:22:55 -04:00
rusefillc 87389f152e https://github.com/rusefi/hellen154hyundai/issues/57 2022-08-09 13:26:11 -04:00
rusefillc 0ed57a1d93 ISO-TP does not work on real car #4427 2022-08-09 12:29:26 -04:00
Andrey G 8b78097ed1 config: options to enable OpenBLT on CAN interfaces (#4423) 2022-08-07 17:56:11 -04:00
rusefillc 7abb1124cc reducing confusion 2022-08-06 09:14:48 -04:00
rusefillc f43a01776c [SECURITY] Cheap password protection against tune modification fix #4243 2022-07-30 12:38:05 -04:00
rusefillc bba019af44 [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 12:07:04 -04:00
rusefillc c52171c3c1 [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 09:54:36 -04:00
rusefillc c63e5632f0 confusion between aux linear and aux for scripts fix #4345 2022-07-28 08:56:47 -04:00
Matthew Kennedy c46c34ead6 boost control thresholds (#4392) 2022-07-28 09:45:16 +03:00
Matthew Kennedy 4865213537 Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 17bf4d0c46 custom skipped wheel could be located on camshaft fix #4377 2022-07-25 08:05:52 -04:00
Andrey G 4a4443a27d Add "Reset to OpenBLT" button (#4364)
Similar to "Reset to DFU", but uses different seed
2022-07-22 08:21:11 +03:00
rusefillc 1d359c7361 Launch control bug? "range" thing is confusing #4348
minor fix
2022-07-21 04:16:30 -04:00
rusefillc 1245c83406 Launch control bug? "range" thing is confusing fix #4348 2022-07-20 18:52:02 -04:00
rusefillc 2bc4fd909d Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
Matthew Kennedy 1fd637d27e remove idle offset (#4355)
* remove offset

* remove more completely

* changelog
2022-07-18 15:49:43 -04:00
Matthew Kennedy ba8a84e5ce GDI: add min/max boost time config (#4343)
* add min/max boost time config

* add cast

* generated

* UI
2022-07-16 02:23:05 -04:00
rusefillc 807bb26555 raw aux inputs gauges #4346 2022-07-15 06:23:24 -04:00
rusefillc 72e372ea2b reducing confusion: pulling start button out of battery menu 2022-07-12 01:14:05 -04:00
rusefillc 13464f1c8f yes, yes, we get it: TPS 2022-07-11 12:36:00 -04:00
rusefillc 517418ba8d todo: shall we move into high_pressure_fuel_pump.txt and reduce OOP elegance or create a separate live data just for these ones? 2022-07-04 17:08:41 -04:00
Matthew Kennedy ab24c5eb35 Rewrite tooth logger buffer management (#4317)
* s

* make it work

* put back enough maybe

* fix console composite log

* unit tests can just use a vector, why not

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
rusefillc 0f66f562aa usability confustion: ediatble fields with board overrides fix #4295 2022-06-27 13:35:22 -04:00
rusefillc ebc7deaa84 greyed out pin is still used #4086 2022-06-27 11:56:08 -04:00
rusefillc 74383e6b3b verboseQuad 2022-06-26 19:47:58 -04:00
Matthew Kennedy 478549ccdf get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 98e0297987 force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
Matthew Kennedy ccec58446b clt based rpm limit (#4267) 2022-06-22 16:49:24 -04:00
rusefi 2dcdc7ed60 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
unused field & updated tooltip
2022-06-18 14:46:31 -04:00
rusefillc a5d086d424 knock dialog progress 2022-06-18 12:06:31 -04:00
Matthew Kennedy 27c98f70fe cam/crank sync improvements (#4152)
* clarify getOperationMode

* wait for phase synchronize to transition to sequential mode

* one test

* encapsulate vvtSyncCounter

* test

* Add option to stop VVT sync above some RPM

* getOrZero

* Revert "synchronized Phase handling improvements fix #4099"

This reverts commit e64c8cfccb.

* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"

This reverts commit 5454b8f509.

* remove synchronizedPhase

* only crank needs this

* changelog

* needsDisambiguation()

* test

* s

* bad merge

* put the timer back

* s

* s

* changelog

* test for new behavior

* correct parameter order

* spelling

* s

* s

* s

* tests merge happy

* bad merge

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
rusefi e19361387d i see dead line 2022-06-08 14:54:38 -04:00
rusefi 1b2c6cc755 https://github.com/rusefi/hellen-gm-e67 2022-06-05 22:49:10 -04:00
rusefi 5190cf44e0 B6 progress 2022-06-02 00:34:02 -04:00
rusefi ade667b63a Settings conflict another case of #4086 fix #4221 2022-05-31 17:05:33 -04:00
rusefillc 6319f2686d greyed out pin is still used #4086
at least some progress
2022-05-25 21:49:34 -04:00
rusefillc 3cc4e3143c TS injector bench test pulse is too short fix #4192 2022-05-22 09:43:09 -04:00
rusefillc a6ec774177 B6 test mule 2022-05-21 01:51:49 -04:00
rusefillc 649c56fe22 hiding second VR threshold 2022-05-19 12:35:04 -04:00
rusefillc 968153670f typos 2022-05-17 17:57:37 -04:00
rusefillc 10d27b70c0 https://github.com/rusefi/ts-issues/issues/36 2022-05-17 17:18:00 -04:00
rusefi 2338f83bc4 helping indicators & new gauges 2022-05-14 11:13:18 -04:00
rusefillc 9aebed59fe Maintenability: frequency sensors need a simple event counter in the logs #4173 2022-05-14 08:13:47 -04:00
Matthew Kennedy dede3f8215 phase resolution rpm limit (#4156) 2022-05-10 07:22:50 +03:00
rusefillc bdfb21793e Hide pin mode from well-known boards #3397 2022-05-08 16:01:42 -04:00
rusefillc 11d111a980 Hide pin mode from well-known boards #3397 2022-05-08 15:11:28 -04:00
rusefillc 4b95671ac0 An option to disable semi-random ignition #4151 2022-05-08 07:58:19 -04:00
rusefillc e1cfaa6e98 it's not alive 2022-05-02 05:37:51 -04:00
rusefillc 3329bc77c4 Make ETB low limit configurable #4119 2022-05-02 01:25:32 -04:00
rusefillc 88a225fc0b knock reaction #202 2022-04-29 10:47:28 -04:00
rusefillc 3003457352 helping TS 2022-04-26 11:04:46 -04:00
rusefi c9ceca7ed0 Lua is new FSIO 2022-04-23 17:21:08 -04:00
rusefi 0b74e9db49 Lua is new FSIO 2022-04-23 17:02:50 -04:00
David Holdeman b4e8dfb05a More untested transmission features (#4093)
* use ISS for gearbox ratio, add gauge for TC ratio

* measure shift time

* add shift time gauge, todo notes for pc

* do conversion in the right direction

* switch to Timer and seconds

* try fixing build

* try fixing build again

* try defines, remove include

* use shift pcs

* add 3-2 pct curve

* control 3-2 solenoid

* move 3-2 to persistent config

* fix param
2022-04-23 07:34:39 -04:00
David Holdeman 918224fbc1 Add ISS sensor, rearrange some transmission config (#4089)
* move other solenoids to new dialog

* change name of menu item

* move buttonshift to new dialog

* add ISS config

* add some iss code

* add iss output

* de-init ISS
2022-04-21 09:07:52 -04:00
rusefillc 3e7d4f99c7 also placing view panels next to controls 2022-04-21 00:20:36 -04:00
rusefillc e180715854 proper place for generated dialogs in the overall file, also placing view panels next to controls 2022-04-20 23:16:50 -04:00
rusefillc db68cf730a https://github.com/rusefi/alphax-2chan/issues/50 2022-04-19 19:52:44 -04:00
rusefillc 0c7f359912 Three names of the same thing fix #4085 2022-04-19 19:47:43 -04:00
rusefillc 7939a4c5da https://github.com/rusefi/alphax-2chan/issues/50
more progress
2022-04-19 14:33:46 -04:00
rusefillc 62823c947a https://github.com/rusefi/alphax-2chan/issues/50 2022-04-19 07:59:19 -04:00
David Holdeman d7ac0c1db8 TCU features and fixes (#4082)
* add tcc pwm freq field

* add pc fields, make trans fields conditional

* make button shift fields conditional, remove duplicates

* add 3-2 solenoid fields

* add PC curves

* try combining tcc curves

* try combining pc curves

* use airmass instead of tps for pc

* reduce airmass axis

* increase axis digits

* duplicate for per shift, change names

* add pc per shift arrays

* try moving tables

* move more tables

* init solenoid pins

* start adding pwm stuff, change some array names

* fix gear issue

* fix multiple shift issue

* fix transmission controllers not working

* fix transmission controllers not working 2

* rearrange and virtual some things

* make getMode const

* fix pwm
2022-04-18 20:09:27 -04:00
rusefillc 830179e226 documentation/readbility 2022-04-18 11:05:04 -04:00
Matthew Kennedy 8650686ab7 knock threshold table fix (#4077)
* fix knock threshold table

* defaults

* knock controller is engine module

* testable

* test builds

* knock tests work

* s

* format

* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc 6ff79cd0ef hash poke 2022-04-18 02:02:04 -04:00
rusefillc e3c262e09a poke. looks like hash does not update even while fancy input files are handled as input files and participate in CRC and hash calculation 2022-04-18 01:32:38 -04:00
rusefillc 31c3c33972 logging of live data structs was: data points #3614
alpha version of TS UI
2022-04-17 22:28:36 -04:00
rusefillc f5a0abb525 poke 2022-04-17 20:36:23 -04:00
rusefillc d886083978 logging of live data structs was: data points #3614 2022-04-17 13:02:01 -04:00
rusefillc bbfe2fa975 this would either fix master or not
really time to sleep now
2022-04-17 03:31:43 -04:00
rusefillc 5102d0d349 logging of live data structs was: data points #3614
on-topic and off-topic progress
2022-04-17 02:42:04 -04:00
Matthew Kennedy 735b4899e2 allow setting injection phase by start or center of injection (#4068)
* allow SOI/COI

* other change

* renames and simplify

* clean up ownIndex

* double check in spark logic
2022-04-15 10:22:36 -04:00
David Holdeman ae24cbf70e Some untested TCC control (#4066)
* rebase

* save changes

* save changes

* fix whitespace

* try enum class

* change field name

* Add TCC pin fields

* add TCC tables

* add a bit of TCC control logic
2022-04-12 19:15:09 -04:00
David Holdeman 2d4468df01 overhaul some docs surrounding rusefi_config.txt (#4064)
* overhaul some docs surrounding rusefi_config.txt

* move a little bit more from Dev Tips

* reflect change to output_channels.txt
2022-04-11 18:00:08 -04:00
rusefillc fc89db577f do not control VVT during cranking fix #3443 2022-04-10 19:31:41 -04:00
Matthew Kennedy e57a1b4f08 make the vss fliter parameter work again (#4056)
* vss has adjustable filter

* tooltip and validate

* s
2022-04-09 09:00:19 -04:00
Matthew Kennedy 88ff526764 Gear detection implementation (#4052)
* gear detect improvements

* ui

* ui for gear ratios

* ui

* output channel

* output channels etc

* implement gear detection

* name

* s

* status loop

* missing function

* ui tweaking

* s
2022-04-07 09:21:11 -04:00
David Holdeman 410a9ffbef Add interface for selecting GearController and TransmissionController classes (#4048)
* save changes

* save changes

* save changes

* fix mistakes

* try adding empty method

* copy simpleTransmissionController to GM 4L6X controller

* Import 4l6x header

* add to makefile

* fix whitespace

* try enum class

* change field name

* change field name in rusefi.input

* check for gear controller mode

* add mode fields to catch if mode was changed
2022-04-06 17:37:30 -04:00
Matthew Kennedy 405f7f3b43 Gear detection improvements (#4047)
* gear detect improvements

* ui

* ui for gear ratios

* ui
2022-04-06 16:15:58 -04:00
rusefillc b2403968d3 Gear detection based on RPM to VSS ratio #3779 2022-04-04 20:18:09 -04:00
Matthew Kennedy 72dabf4057 Flex fuel cranking improvements (#4043)
* improve flex cranking

* call it e85

* don't re-warn

* warning name

* ui
2022-04-04 17:41:36 -04:00
Andrey 67c3560b4c trigger help as URL 2022-04-03 18:48:34 -04:00
Andrey 5e0263d2f0 Proper cam speed labels in triggers #4021 2022-04-03 17:56:47 -04:00
rusefillc 710886e61d Proper cam speed labels in triggers #4021 2022-04-03 14:39:57 -04:00
rusefillc 68a0ac9991 Proper cam speed labels in triggers #4021 2022-04-03 14:06:22 -04:00
Andrey 3246e29245 Trigger setup in TS is highly confusing: hide operation mode from users? fix #4031 2022-04-03 02:46:00 -04:00
rusefillc 3ef96e1f74 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-02 22:08:33 -04:00
rusefillc e8bfec7942 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-02 21:01:29 -04:00
rusefillc f335b9847b [EPIC] [Feature Request] Transmission Control #1454 2022-03-28 23:00:33 -04:00
Matthew Kennedy 4c2518c4c0 output channel tweaks (#4023)
* shuffle around output channels

* postState should take a ref

* s

* s

* patch input file

* limits

* accel bad bounds check

* units

* units

* Revert "accel bad bounds check"

This reverts commit b2bb493be331d5d2cf40b9ed01363a53182c883e.

* missed an autoscale
2022-03-24 08:58:55 -04:00
Matthew Kennedy 1601156145 aux linear sensors (#4005)
* aux linear sensors

* comment

* kick build

* fix alignment

* fix alignment
2022-03-20 20:13:04 -04:00
rusefillc 0e42cec874 AlphaX 2chan new EN lines #3990 2022-03-13 11:54:17 -04:00
rusefillc cf1e639247 AlphaX 2chan new EN lines #3990 2022-03-12 10:01:57 -05:00
Andrey G f2b0d0692f Test bench: implement injector test for dead time calculation (#3960)
* Add output channel for TestBench iter counter

* Update testBenchIter from runBench

* rusefi.input: testBenchIter gauge

* rusefi.input: initial Injector test dialog
2022-03-08 19:25:58 -06:00
Matthew Kennedy cc7aacaa25 fix mangled ts (#3974) 2022-03-02 15:03:15 -06:00
Andrey G 106ea36507 TS: disable ignition and injector test according to cylindersCount (#3966) 2022-02-26 17:35:34 -05:00
rusefillc da36d0ca5a BMW 6HP gatewy #3954 2022-02-25 20:28:09 -05:00
rusefillc 9ce3f14137 Lua CAN relay performance #3911 2022-02-10 21:01:15 -05:00
rusefillc 9a73601020 per-bus verbose flag 2022-02-10 10:12:48 -05:00