Matthew Kennedy
c86f75ec78
Jammed ETB detection ( #4873 )
...
* jammed ETB detection
* autoscale
* comment
* cleanup
* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey
4c1f456c6b
symmetrical shapes are not rendered right #4956
2023-01-08 22:37:35 -05:00
rusefillc
d3e41b311e
refactoring
2023-01-08 22:30:57 -05:00
rusefillc
cc9da420d3
sweet 4g93 data
2023-01-07 17:31:13 -05:00
Andrey
a699e29c02
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
Matthew Kennedy
56aa0fe367
improve iat ignition table ( #4948 )
...
* iat ignition table
* changelog
2023-01-06 21:59:34 -05:00
Andrey
ae13e1a000
Mitsubishi 4G93 Trigger issues #4918
...
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey
0337cb44ac
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey
7c10ac7507
a bit of dead code
2023-01-03 13:59:25 -05:00
Andrey
bdffec4ce5
let's try again
2023-01-03 08:38:42 -05:00
Andrey
eb9c096ab7
a bit of dead code
2023-01-03 07:49:17 -05:00
Andrey
00e8cc4262
test coverage for antilag #4920
...
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey
36573a3044
test coverage for antilag #4920
...
bugfix?
2022-12-30 12:21:04 -05:00
Andrey
6a3c7d20e7
test coverage for antilag #4920
2022-12-30 12:17:53 -05:00
Andrey
13c3699415
test coverage for antilag #4920
2022-12-30 12:11:57 -05:00
rusefillc
6ec6b0b82a
refactoring: method name
2022-12-27 00:13:13 -05:00
rusefillc
1e04153867
random Frankenso clean-up
2022-12-14 19:29:01 -05:00
Matthew Kennedy
2118aaff60
Allow scheduling_s to come from a pool ( #4841 )
...
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy
29db8e2474
Combine angle based event ( #4884 )
...
* Remove AngleBasedEventOld/New, only AngleBasedEvent now
* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy
016b71babe
switch hpfp and aux valves to AngleBasedEventNew ( #4882 )
...
* switch hpfp to AngleBasedEventNew
* aux valves too!
2022-12-10 16:15:11 -05:00
rusefillc
c0daffda1d
reduce flash footprint by smarter code generation #4163
2022-12-03 00:51:41 -05:00
Matthew Kennedy
ecee1dd02d
ETB error counter logic ( #4854 )
...
* simplify ETB error counter logic
* dropped this: {
* happy test
* reorder logic, test etbErrorCode
* test that fails
* independent TPS and PPS counters
* missed a file
* happy test
2022-11-30 22:20:09 -05:00
Andrey
db8f7c48f3
ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832
2022-11-30 21:23:13 -05:00
Andrey
9641d08d67
ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832
2022-11-30 20:08:19 -05:00
Andrey
a6432feae7
ETB duty cycle jitter: only monitoring within this ticket #4833
2022-11-30 19:48:08 -05:00
rusefi
475c177f78
x2 spelling
2022-11-30 17:14:16 -05:00
Andrey
47aac2b46e
ETB duty cycle jitter #4833
...
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Matthew Kennedy
5576065eb9
default fuel cleanup and injection phase change ( #4836 )
...
* default fuel cleanup and injection phase change
* happy tests
* changelog
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Andrey
4a7a48779d
ETB duty cycle jitter #4833
2022-11-29 20:51:28 -05:00
Andrey
7547edb566
mock invalid & current state of ETB error counter
2022-11-29 20:36:03 -05:00
Andrey
b97745496e
refactoring: extracting method
2022-11-29 20:11:34 -05:00
Andrey
ca63f37d9e
ETB duty cycle jitter #4833
...
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey
8a3727de3e
ETB duty cycle jitter #4833
2022-11-29 14:59:08 -05:00
Andrey
73e309da03
ETB duty cycle jitter #4833
2022-11-29 14:02:44 -05:00
Andrey
82a3074cbd
ETB overheats due to constant isTpsError true/false/true/false jitter #4832
2022-11-29 11:42:09 -05:00
Andrey
d7cdf75e22
unit test compile more of ETB code
2022-11-28 23:41:51 -05:00
Andrey
a14fb947c2
exp average is pretty cool
2022-11-28 19:22:45 -05:00
Andrey
ac12287ab0
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey
c5a5d7f6eb
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey
e1d3647401
ETB duty cycle jitter #4833
...
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc
c729b10bbe
refactoring: constexpr fuel computer ( #4830 )
...
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc
d63f1af40d
without ValueProvider3D interface how do we mock? ( #4829 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey
f32ae379f5
nissan
2022-11-23 23:45:25 -05:00
rusefillc
261222bb04
avoid ctime in GPS UART ( #4824 )
...
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte
d4cc3caeab
code style, GPS fixes (test, firmware) ( #4822 )
...
* tidy NMEA
* const in nmea
* correct gps test output
* fix GPS UART print statements
* cleanup feature toggles in settings
* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
Andrey
7afc95a241
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
Andrey G
85f46318a4
SENT updates ( #4774 )
...
* SENT: simplify
* SENT: add crc6 routine, check crc for slow channels enhanced messages
* SENT: helper to get Slow Channel values
* SENT: getTickTime() report tick unit time
* unit_tests: SENT: update tests
2022-11-12 16:57:20 -05:00
Andrey
05b46b1b12
Nissan
2022-11-12 13:06:55 -05:00
Andrey G
9b0fa7ec43
SENT unit tests ( #4769 )
...
* unit_tests: sent: zero-init
* sent: SENT_SLOW_CHANNELS_MAX to header
* unit_tests: sent: clock, falling edges
* SENT: support and autodetect if device sends pause pulse
Also rework tick time calculation
* unit_tests: SENT: verbose debug on request
* unit_tests: SENT: actual checks
* unit_tests: SENT: extract common code for reuse
* unit_test: SENT: add test with fuel pressue captured data
* unit_test: SENT: add test with Ford ETB CLOSED captured data
2022-11-11 17:25:02 -05:00
Matthew Kennedy
7b47e77e58
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy
e801ffc979
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
Andrey
cebb3e1847
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-07 00:06:42 -05:00
rusefillc
1e10055279
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-06 23:21:54 -05:00
rusefi
5c32f75c2c
reducing ugly
2022-11-06 21:28:38 -05:00
rusefi
80e02de00b
https://rusefi.com/forum/viewtopic.php?p=46603#p46603
...
calling 'setTimeout' on bad self (cpp class not export)
2022-11-06 20:09:01 -05:00
Andrey
25d292c462
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
rusefillc
cc7af64ed3
minor trigger refactoring
2022-11-06 00:59:29 -04:00
Matthew Kennedy
32b170810e
duplicate log field names ( #4730 )
...
* remove duplicate target lambda/afr
* names on fuel computer
* remove more copies
* sensor.java
* everybody loves hard dependencies on generated fields
* target afr gauge fix
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy
acfde29c60
remove idle timing deadzone ( #4731 )
...
* remove idle timing deadzone
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey
ea0a054dfc
Nissan defaults
2022-11-02 12:05:51 -04:00
rusefi
8d0ac7a5be
huh, we can pole larger method here
2022-10-26 12:08:27 -04:00
Matthew Kennedy
890a8e0fed
implement "ford mode" injector correction ( #4686 )
...
* implement "ford mode"
* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy
1cc46a1b83
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
rusefillc
9c75704412
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
rusefillc
5590b55273
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
rusefillc
fc66b45ce4
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
Matthew Kennedy
14b92612e2
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy
f07c00548b
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
Andrey
3d329639ea
Mark is asking for VIN number field #3967
2022-10-04 21:12:51 -04:00
Matthew Kennedy
58a5569006
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
60fc30d34d
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy
f2c8a0192c
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
9cd5553617
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
90489edb96
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy
6f5bed28d9
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
dbf8a1ea2a
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Andrey
24cf41c5f7
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
Andrey
df0bb3ebc5
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
Andrey
178fe15760
more inclusive configuration name
2022-09-24 23:49:41 -04:00
Andrey
4653cde601
K progress
2022-09-24 23:18:57 -04:00
Andrey
63fe1120bd
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
Andrey
533d30efd1
fancy
2022-09-24 22:54:58 -04:00
Andrey
d497d99a8c
K
2022-09-24 15:37:51 -04:00
Andrey
e7e9742ba9
refactoring: extract constant
2022-09-24 15:33:01 -04:00
Matthew Kennedy
02aad24c59
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
c6a2f2657b
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
08499c7252
K20
2022-09-23 20:13:14 -04:00
rusefillc
04ac7fcd3b
K20
2022-09-23 18:25:24 -04:00
Matthew Kennedy
0dfba2a655
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
4e78c4c922
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
rusefillc
70dc03a821
B6
2022-09-17 23:49:24 -04:00
Andrey
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
b439f27284
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
34f87a3683
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
b1451e229c
GM
2022-09-14 00:03:38 -04:00
Andrey
32c6aef746
code formatting
2022-09-13 23:44:38 -04:00
Andrey G
1ca5988877
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
921b97431f
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00
Andrey
50b1d03001
E38
2022-09-09 14:04:22 -04:00
Andrey
73150de8df
E38
2022-09-09 01:15:55 -04:00
Matthew Kennedy
715c3efb18
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey
3c1cc0b857
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
f243f1608c
B6
2022-09-06 15:12:43 -04:00
Matthew Kennedy
1efe511be8
add hysteresis to limp rpm, boost, injector duty ( #4541 )
...
* add hysteresis
* changelog
2022-09-05 20:56:32 -04:00
Andrey
c8cdc50877
wow Leiderman-Khlystov
2022-09-05 20:23:40 -04:00
Andrey
07c08947ba
wow Leiderman-Khlystov
2022-09-05 20:02:33 -04:00
Andrey
ab3d92b995
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
76b74a85ba
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
Andrey
82fa9b191a
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Andrey
75b1549853
refactoring: moving field
2022-09-05 01:15:45 -04:00
Andrey
7706e2d4ae
wow Leiderman-Khlystov
2022-09-04 18:29:13 -04:00
rusefi
0f828f19a7
wow Leiderman-Khlystov
2022-09-04 15:58:46 -04:00
rusefi
2cc625871a
B6
2022-09-04 11:47:57 -04:00
rusefi
ee90371837
B6
2022-09-04 11:29:18 -04:00
Matthew Kennedy
fba0906942
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey
e56924310b
tear down Engine god object #4511
...
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc
54e05ba0fc
moving state into specific class ( #4520 )
...
* moving state into specific class
* moving state into specific class
2022-09-02 14:38:03 -04:00
Andrey
436c294770
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
Andrey
ea22fcbe95
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
Andrey
3eaaf5e293
english do you speak it
2022-08-31 22:56:38 -04:00
Andrey
adde8077dd
B6 progress
2022-08-30 05:20:56 -04:00
Andrey
c18245d697
B6 progress
2022-08-30 04:38:20 -04:00
Andrey
b0a09a2171
B6 progress
2022-08-30 04:07:48 -04:00
Matthew Kennedy
dcab243381
knock retard limit table ( #4498 )
...
* add max retard table
* ui
* s
* better naming
* s
* test can use base class
2022-08-30 01:57:37 -04:00
Matthew Kennedy
4035d79a91
idle always uses instant rpm ( #4499 )
...
* idle always uses instant rpm
* configs
* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy
2926570747
idle coasting table is RPM, not clt ( #4487 )
...
* idle coasting table is RPM, not clt
* default
* autoscale
* changelog
2022-08-29 08:15:04 -04:00
Matthew Kennedy
d660b240c4
B6 progress
2022-08-28 12:33:32 -04:00
Matthew Kennedy
234909a91f
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
Matthew Kennedy
0d99d828e3
trim table for throttle #2 ( #4472 )
...
* add table and wire it up
* trim table ui
* initialization
* changelog
* add a test
2022-08-28 08:28:20 -04:00
Andrey
fdacca9152
B6 progress
2022-08-27 20:44:30 -04:00
Andrey
756eae8f54
B6 progress
2022-08-26 12:07:13 -04:00
Andrey
0f0c5598ab
B6 progress
2022-08-26 00:30:46 -04:00
Andrey
fefa1048fc
B6 progress
2022-08-26 00:24:38 -04:00
Andrey
caa9f1cf3c
B6 progress
2022-08-26 00:21:17 -04:00
Andrey
077bdec25b
refactoring
2022-08-26 00:16:36 -04:00
Andrey
c17cc38470
refactoring
2022-08-26 00:14:52 -04:00
Andrey
45d8716fcc
B6 progress
2022-08-26 00:04:47 -04:00
rusefillc
1ea6535b83
two bugs love to cancel each other
2022-08-25 23:55:42 -04:00
Matthew Kennedy
08d2aee17b
dfco delay ( #4482 )
...
* dfco delay
* config
* using a function that doesn't exist? who does that
* test new behavior
* clearer test
2022-08-25 21:26:17 -04:00
Andreika
fda9448798
[DRAFT] Air by rpm taper ( #4486 )
...
* add rpm to getOpenLoop() and getRunningOpenLoop()
* implement airByRpmTaper
* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
Andrey
3d50b20155
B6 progress
2022-08-25 19:26:18 -04:00
Andrey
2277d36cc6
B6 progress
2022-08-25 12:45:47 -04:00
Andrey
52210e2a74
B6 progress
2022-08-25 11:15:54 -04:00
Andrey
0b3478697a
Lua code reuse
2022-08-25 10:45:26 -04:00
rusefillc
f5576b05d9
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
Andrey
8f33e1b40f
test coverage and some magic constant refactoring
2022-08-21 16:03:34 -04:00
Andrey
2d4b944547
test coverage and some magic constant refactoring
2022-08-21 15:22:22 -04:00
rusefi
ea7597e0d6
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
rusefi
2f882b1452
refactoring: default argument value
2022-08-21 12:17:50 -04:00