Matthew Kennedy
21998dae2d
tests
2023-11-01 15:14:53 -07:00
Matthew Kennedy
44bd9af964
misc anti shadow
2023-11-01 14:59:36 -07:00
Matthew Kennedy
f835025a2f
remove wrapAngle2, wrapAngle does fine
2023-10-19 14:46:55 -07:00
Matthew Kennedy
6f4a4fc373
implement ignition timing clamping ( #212 )
...
* implement ignition timing clamping
* ui, improved comment
* wrap atdc timing correctly
* tests
2023-07-21 15:55:04 -07:00
Matthew Kennedy
1885f3eca3
make spark and fuel more similar
2023-06-25 01:46:33 -07:00
Matthew Kennedy
e5ee320b67
make spark and fuel more similar
2023-06-25 01:31:30 -07:00
Matthew Kennedy
04e6f45ce9
log per-cylinder timing #76
2023-05-31 11:38:06 -07:00
Matthew Kennedy
41339c5418
change to log base timing
2023-05-31 11:22:41 -07:00
Matthew Kennedy
ad3ea57276
tooth_logger.h -> pch
2023-05-30 22:41:20 -07:00
Matthew Kennedy
9621ff844e
add ignition/injection mode output channel #85
2023-04-28 00:27:43 -07:00
Matthew Kennedy
d5f9479f28
ObdCode is enum class ( #77 )
...
* change ObdCode to enum class builds firmware
* test builds
* don't need this line at all
* can we go down to uint16_t?
2023-04-12 23:44:33 -07:00
Matthew Kennedy
778289455b
this warning is not useful fix #79
2023-04-12 19:42:44 -07:00
Matthew Kennedy
489d016682
function >>> macro
2023-04-12 19:32:52 -07:00
Matthew Kennedy
f090a97b0b
remove specs_s struct, flatten config
2023-03-27 00:58:18 -07:00
Matthew Kennedy
e5d28022ad
spammy prints cleanup
2023-03-16 01:27:03 -07:00
Matthew Kennedy
cd6b770945
is this just dead?
2023-03-03 02:05:50 -08:00
Matthew Kennedy
3fa2f44014
remove twoWireBatchIgnition
2023-03-02 22:23:24 -08:00
Andrey
3d096b2ac1
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
Andrey
df2b073c49
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
Matthew Kennedy
5471321363
don't warn if we intentionally skipped this spark ( #4961 )
...
* don't warn if we intentionally skipped this spark
* header
* real nb2
2023-01-10 19:07:44 -05:00
rusefillc
875a3dbe57
CI is useful
2023-01-01 11:30:50 -05:00
rusefillc
886ec74442
antilag and anti-lag #2403
...
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
Matthew Kennedy
a58e687d2f
TriggerScheduler cleanup ( #4844 )
...
* TriggerScheduler cleanup
* remove TRIGGER_EVENT_UNDEFINED
* remove dead overload of scheduleOrQueue
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
Andrey G
cc9b1517ac
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
58a5569006
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
90489edb96
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy
0dfba2a655
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
36d9eb4164
plumbing for 4513 ( #4599 )
...
* plumbing for 4513
* not static
2022-09-20 06:19:51 -04:00
Matthew Kennedy
e737141a6f
add fuel/spark cut codes to TS indicators ( #4592 )
...
* add fuel/spark cut codes to TS indicators
* fix list
* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
rusefillc
4318b47e58
"angle range findAngle#a6" critical error #4593
2022-09-19 18:33:19 -04:00
Andrey
b439f27284
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
rusefillc
f97c5ed8fd
i suspect that no one cares about these
2022-09-14 00:34:04 -04:00
Andrey
7369126d91
tear down Engine god object #4511
...
just trying different things
2022-09-07 15:38:15 -04:00
Andrey
b64e553d5d
refactoring: reducing outputChannels copy
2022-09-01 01:06:49 -04:00
Andrey
fcc1c72506
let spark deal with spark limpManager
2022-08-31 23:59:40 -04:00
Andrey
5392f8d13e
https://github.com/rusefi/hellen154hyundai/issues/60
...
extra logging
2022-08-25 19:58:10 -04:00
Matthew Kennedy
8650686ab7
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
Matthew Kennedy
735b4899e2
allow setting injection phase by start or center of injection ( #4068 )
...
* allow SOI/COI
* other change
* renames and simplify
* clean up ownIndex
* double check in spark logic
2022-04-15 10:22:36 -04:00
Matthew Kennedy
258f00efa3
fix sequential mode cranking ( #2919 )
...
* fix
* use the right enum
* do it for fuel too
* earlier
* s
2022-02-01 19:04:20 -05:00
Andrey
5f3324cd6b
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
Andrey
d2c46b3310
Let's always have TS structure so that unit tests can check values in outputChannels, kind of making outputChannels a god dump for state but whatever since Live View is coming
2021-12-07 20:18:47 -05:00
Matthew Kennedy
aa8584d89a
calculate per-cylinder ignition timing ( #3652 )
...
* simplify cylinder phasing
* per cylinder timing
* s
* s
* s
* why was there a divide by 2?
2021-12-06 21:19:37 -05:00
Matthew Kennedy
b2af3637a2
simplify cylinder phasing ( #3650 )
2021-12-05 10:46:35 -05:00
Scott Smith
aba4e5167e
Separate out scheduleOrQueue into it's own standalone scheduler. ( #3573 )
...
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
Scott Smith
a5b0604880
Add a lock for scheduleOrQueue events. ( #3572 )
...
Ignition callers are all tooth based, but aux valves calls it from both the microsecond timer and
the main initialization thread. HPFP will also soon call it from both those places too.
2021-11-18 05:08:32 +03:00
Scott Smith
659cc68be1
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
rusefillc
46d2b21ecc
proportional spark cut #3427
2021-11-17 04:06:22 -05:00
Scott Smith
80091498a6
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
dac2ae9b1d
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
Andrey
c201b5b0ec
proportional spark cut #3427
2021-11-16 05:56:15 -05:00