Commit Graph

1866 Commits

Author SHA1 Message Date
Matthew Kennedy 969002f105 Trigger scope uses full buffer (#4893)
* trigger scope uses full buffer

* channels swapped on 4chan

* UI has custom names for boards
2022-12-13 19:55:36 -04:00
rusefillc b2937de88c RPM correction/multiplier for Accel Enrich #4760 2022-12-13 14:58:55 -05:00
Matthew Kennedy 7fe386a6a5 tooth logger uses big buffer (#4883)
* big buffer

* mostly hooked up big buffer

* bad merge

* s

* sneak preview of trigger scope

* s

* constness

* channel limits

* s

* unnecessary

* efilib

* TcpServerSandbox

* includes fix

* binary format

* tooth logger uses big buffer

* dead config
2022-12-10 17:17:15 -05:00
Matthew Kennedy c617b00180 Use a shared buffer for "high memory" operations (#4878)
* big buffer

* mostly hooked up big buffer

* bad merge

* s

* sneak preview of trigger scope

* s

* constness

* channel limits

* s

* unnecessary

* efilib

* TcpServerSandbox

* includes fix

* binary format
2022-12-10 07:35:39 -05:00
rusefillc 6b2fedf631 reducing aux/lua mess 2022-12-04 12:51:57 -05:00
rusefillc 93b8121dc0 getDigital only works for 4 specific pins. Can it be made to work with generic digital pins? #4861 2022-12-04 12:45:27 -05:00
Andrey 90be54ff13 ETB duty cycle jitter: only monitoring within this ticket fix #4833 2022-11-30 19:49:16 -05:00
rusefi c86761cad1 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832
better default for 16 bit fields
2022-11-30 13:23:19 -05:00
rusefi 84d49b3436 ETB duty cycle jitter #4833
brain fart :(
2022-11-29 22:11:41 -05:00
rusefi e565b706ce ETB duty cycle jitter #4833
still totally dead on real hardware and I've already fixed two defects! time for an indicator
2022-11-29 22:01:15 -05:00
rusefillc 2191960a34 ETB duty cycle jitter #4833 2022-11-28 20:01:26 -05:00
Matthew Kennedy 3f9bb81834 fuel computer in SD logs (#4828)
* remove duplicate target lambda/afr

* names on fuel computer

* remove more copies

* sensor.java

* everybody loves hard dependencies on generated fields

* target afr gauge fix

* constexpr fuel computer

* status loop

* happier test

* gone test is happy test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 19:25:49 -05:00
Matthew Kennedy 431eb0e832 period -> frequency (#4837)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 08:10:05 -05:00
rusefillc 6a77c6136c ETB duty cycle jitter #4833 2022-11-27 00:45:02 -05:00
rusefi 947d4e952e usability progress: conditional ETB button enable. TODO: make logic consistent with other instances of same buttons 2022-11-26 14:26:29 -05:00
rusefillc fc5b4b42a2 Full Optimized – High Speed #4818 2022-11-23 21:30:50 -05:00
rusefillc 060810231a Full Optimized – High Speed #4818 2022-11-21 22:08:16 -05:00
rusefillc a76f5e9ea2 Full Optimized – High Speed #4818
one step back
2022-11-21 20:45:37 -05:00
rusefillc 881e2a6eb6 Full Optimized – High Speed #4818 2022-11-21 20:20:14 -05:00
Nathan Schulte 22f2d10bb7 Full Optimized – High Speed #4818 2022-11-21 20:12:13 -05:00
rusefillc ba8a510f77 Boost is it actually "open+closed"? fix #4803 2022-11-20 00:03:40 -05:00
rusefillc e3bad2649e simpler SENT for now 2022-11-19 09:38:39 -05:00
Andrey 9a3dfd7465 new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 15:45:32 -05:00
rusefillc 5e9ff35ef9 new trigger wheel shape for Benelli 3-cylinder engines #4744 2022-11-16 11:35:00 -05:00
rusefi 7ea4c6788c sentErrorRate digits 2022-11-15 19:53:25 -05:00
rusefillc 6e2708b621 Show cams in TS trigger logger #2496
oops
2022-11-14 23:42:10 -05:00
rusefillc 8d61ee2f12 high-speed composite logger #416 2022-11-14 18:32:26 -05:00
rusefi 58482b1546 Add fuel adder to launch #4777
only UI for now
2022-11-13 19:55:46 -05:00
rusefi 9ad7e346a2 Ford SENT ETB bench test in NJ #4745 2022-11-11 18:07:13 -05:00
rusefi 9f5a28091a minor naming consistency, should this be taken further? 2022-11-10 15:09:52 -05:00
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy acfde29c60 remove idle timing deadzone (#4731)
* remove idle timing deadzone

* test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
rusefillc 8bed91cc27 todo: better names 2022-11-02 11:16:42 -04:00
rusefillc 651101e6bc Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
rusefillc e5780234e3 SD card log fields list should be auto-generated #3985 2022-10-28 10:28:38 -04:00
rusefillc 6c84b2b58c SD card log fields list should be auto-generated #3985 2022-10-26 22:07:24 -04:00
Matthew Kennedy 7c9e3680b3 bigger blocking factor (#4703) 2022-10-26 16:49:55 -04:00
Matthew Kennedy ede3df75f5 dual MAF sensors (#4697)
* add second MAF

* output channesl

* move them around

* ok let's try at the very end

* is the logic wrong, or something else?

* ooh it's the sensor order
2022-10-24 12:41:05 -04:00
Matthew Kennedy 3e66e0030b allow all pins for inputs on default builds (#4693) 2022-10-23 15:29:12 -04:00
Matthew Kennedy 890a8e0fed implement "ford mode" injector correction (#4686)
* implement "ford mode"

* missed the enum value
2022-10-20 22:25:39 -04:00
rusefillc 00cccb2fa3 SENT protocol capture implementation #4631 2022-10-19 15:21:13 -04:00
Matthew Kennedy acec8f2da3 VE blend tables (#4640)
* blendy ve too

* ui

* small optimizations

* save kinetis memory

* changelog
2022-10-19 06:42:22 -04:00
rusefillc 69a503a0ee Lua aux gauge #4672 2022-10-17 21:21:23 -04:00
rusefi 3d748ba34a Lua aux gauge #4672 2022-10-16 23:38:24 -04:00
rusefillc 37a935ca58 triggerImage: todo: support symmetrical crank 2022-10-16 02:29:30 -04:00
Matthew Kennedy d74ae44b30 allow SD logging non-scaled_channel (#4657)
* allow SD logging non-scaled_channel

* comments and kick ci
2022-10-11 20:58:43 -04:00
rusefillc e00d4a819a SD card log fields list should be auto-generated #3985 2022-10-10 21:25:35 -04:00
rusefillc 71b2e8afe8 VVT minimum RPM #4545
typo :(
2022-10-07 11:58:13 -04:00
Matthew Kennedy a65190b008 remove 2jz trigger that's really 12 tooth crank (#4637)
* remove 2jz trigger that's really 12 tooth crank

* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
rusefillc 75f9e94cd5 there is no third trigger simulator channel right? 2022-10-03 10:59:03 -04:00
rusefillc 1e5e681c37 CAN side of automated testing #4630 2022-09-29 20:55:38 -04:00
rusefillc b756eba99b VVT minimum RPM #4545 2022-09-27 22:17:43 -04:00
rusefillc 8204b34ac4 engineSyncCam to be a drop-down not a number value #4611 2022-09-27 12:37:13 -04:00
rusefillc ed7da23b0d ;+ is no longer needed 2022-09-26 06:06:55 -04:00
rusefillc cd4e669077 ;+ is no longer needed 2022-09-26 05:44:52 -04:00
rusefillc 719bcaa288 engineSyncCam to be a drop-down not a number value #4611
the easy part
2022-09-26 05:26:52 -04:00
Andrey 3350ad6fbe Honda K cam wheels #3405 2022-09-24 23:49:41 -04:00
Matthew Kennedy 3a8a138bb8 up the table axis limits (#4609) 2022-09-23 19:11:24 -04:00
rusefillc a4a1995508 useBiQuadOnAuxSpeedSensors 2022-09-19 12:13:20 -04:00
rusefillc a1143779f2 documenting biquad or else concerns 2022-09-19 12:06:00 -04:00
Matthew Kennedy d84a290eca gppwm load axis can be another GPPWM channel (!!!!!) (#4587)
* gppwm load axis can be another GPPWM channel (!!!!!)

* explicit cast

* efiAssert not void

* kick
2022-09-17 21:38:06 -04:00
Matthew Kennedy 4106704385 add ignition adder tables (#4586)
* ign blend tables

* tweaks

* iterate

* tweaks

* axis values

* changelog
2022-09-16 20:07:04 -04:00
Matthew Kennedy 14068656ad more gppwm options (#4585)
* more gppwm options

* fix ui

* gppwm list size
2022-09-16 16:04:03 -04:00
rusefillc 420822cb23 kick Start Cranking mode #4569 2022-09-13 02:18:49 -04:00
rusefillc 6ff3a9f440 a bit of dead code 2022-09-11 01:02:56 -04:00
rusefillc 05fa36e744 Mark is asking for VIN number field #3967
GM says Hi
2022-09-10 01:05:31 -04:00
rusefillc b2ad515b0f vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic 2022-09-09 17:52:54 -04:00
Matthew Kennedy 715c3efb18 only report vvt position if we have full sync (#4547)
* only report vvt position if we have full sync

* comments

* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey a35f20af78 remove alternator on/off mode fix #4548 2022-09-07 22:46:42 -04:00
rusefi 06552b6bee servo is truly not alive 2022-09-06 16:29:12 -04:00
rusefillc a1ba01e0e4 customTotalToothCount has to be positive and realistic 2022-09-05 19:25:06 -04:00
rusefillc 6017e2a8af step forward (#4519) 2022-09-01 23:38:33 -04:00
Andrey c9008214f5 tear down Engine god object #4511
just trying different things
2022-09-01 19:05:40 -04:00
Matthew Kennedy 0863ac1a11 rename and fix skyactiv cam mode (#4505) 2022-08-31 22:12:45 -04:00
Matthew Kennedy d9ca1fb578 set a default, detect error (#4504) 2022-08-31 20:32:37 -04:00
Matthew Kennedy ec8be9400c AC delay (#4502)
* AC delay

* changelog
2022-08-31 19:01:42 -04:00
Matthew Kennedy dcab243381 knock retard limit table (#4498)
* add max retard table

* ui

* s

* better naming

* s

* test can use base class
2022-08-30 01:57:37 -04:00
Matthew Kennedy 4035d79a91 idle always uses instant rpm (#4499)
* idle always uses instant rpm

* configs

* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy ffa486d3f1 fixes (#4497) 2022-08-29 20:32:07 -04:00
Matthew Kennedy 2926570747 idle coasting table is RPM, not clt (#4487)
* idle coasting table is RPM, not clt

* default

* autoscale

* changelog
2022-08-29 08:15:04 -04:00
rusefillc 35f17f38b3 TT_VVT_MAZDA_MYSTERY 2022-08-28 21:54:24 -04:00
Matthew Kennedy 0d99d828e3 trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
rusefillc b33e2d2a5b TinerStudio: no need to have 3s timeout, 300mS is ok for single-back devices. fix #4360 2022-08-27 18:19:47 -04:00
Matthew Kennedy 08d2aee17b dfco delay (#4482)
* dfco delay

* config

* using a function that doesn't exist? who does that

* test new behavior

* clearer test
2022-08-25 21:26:17 -04:00
Matthew Kennedy dfd340e8c3 log the state of hasSynchronizedPhase() (#4478)
* s

* log whether we've synced phase

* trigger_state_primary

* need that file

* engine state is not the right spot
2022-08-24 18:11:05 -04:00
rusefi 7340700b74 refactoring 2022-08-24 12:11:11 -04:00
Andrey cb9d0fb41a Revert "Revert "Revert "Pavel Xenon is asking for EGT limping mode #3172"""
This reverts commit 934d2f5642.
2022-08-22 23:44:51 -04:00
Andrey 934d2f5642 Revert "Revert "Pavel Xenon is asking for EGT limping mode #3172""
This reverts commit e6292feb8e.
2022-08-22 23:06:45 -04:00
Andrey e6292feb8e Revert "Pavel Xenon is asking for EGT limping mode #3172"
This reverts commit f8185d9dfa.
2022-08-22 20:08:24 -04:00
rusefillc f8185d9dfa Pavel Xenon is asking for EGT limping mode #3172
let's lower expectations for now
2022-08-22 18:10:32 -04:00
Andrey 90130b3311 Revert "Revert "Revert "small step forward? (#4450)"""
This reverts commit 30297da80c.
2022-08-21 15:23:20 -04:00
Andrey 30297da80c Revert "Revert "small step forward? (#4450)""
This reverts commit d2365c5c7f.
2022-08-21 14:43:50 -04:00
rusefillc a849715fad Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 21:19:55 -04:00
rusefillc 00e3cabf23 Extra Idle Air if Throttle is Pressed behavior #3940 2022-08-18 21:10:19 -04:00
rusefillc dfd4953f0d unconditional VVT PID logging 2022-08-17 00:47:31 -04:00
Matthew Kennedy 012e6df17b quad cam on kinetis, for science (#4452)
* for science

* more
2022-08-16 22:33:29 -04:00
rusefillc 7d3e508c6d romraider is gone part 3 2022-08-16 22:32:21 -04:00
rusefillc 357c4c672a poke just in case 2022-08-16 21:00:59 -04:00
Andrey d2365c5c7f Revert "small step forward? (#4450)"
This reverts commit badbc1a46e.
2022-08-16 19:43:46 -04:00
rusefillc badbc1a46e small step forward? (#4450)
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-16 18:57:40 -04:00
rusefillc c68d4f1a94 Revert "VVT target to allow negative values #4424"
This reverts commit 723845f145.
2022-08-14 17:03:21 -04:00
rusefillc 723845f145 VVT target to allow negative values #4424
baby step towards VVT pid logging
2022-08-14 15:59:44 -04:00
Matthew Kennedy 66b4523575 add option to invert vvt control (#4425)
* add option to invert vvt control

* s

* s

* s

* one bit per cam type

* move the space

* I don't spelling good

* changelog
2022-08-09 16:22:55 -04:00
rusefillc 949bf5f474 VVT target to allow negative values #4424
ooooops
2022-08-09 15:41:02 -04:00
rusefillc 87389f152e https://github.com/rusefi/hellen154hyundai/issues/57 2022-08-09 13:26:11 -04:00
rusefillc 0ed57a1d93 ISO-TP does not work on real car #4427 2022-08-09 12:29:26 -04:00
rusefillc 68ce7c1254 VVT target to allow negative values #4424 2022-08-08 22:48:13 -04:00
Andrey G 8b78097ed1 config: options to enable OpenBLT on CAN interfaces (#4423) 2022-08-07 17:56:11 -04:00
rusefillc bba019af44 [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 12:07:04 -04:00
rusefillc 70698e6952 [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 11:29:13 -04:00
rusefillc f035d834c8 [SECURITY] Cheap password protection against tune modification #4243
actually the area at the end is way safer for a new lock field
2022-07-30 11:18:10 -04:00
rusefillc 930af1de7a [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 09:56:04 -04:00
rusefillc 6e951a21c3 [SECURITY] Cheap password protection against tune modification #4243 2022-07-30 09:31:53 -04:00
Matthew Kennedy c46c34ead6 boost control thresholds (#4392) 2022-07-28 09:45:16 +03:00
Matthew Kennedy 4865213537 Log gppwm output values (#4385)
* remove debug option

* purpose built output channels

* name

* embiggen sd log buffer

* Revert "embiggen sd log buffer"

This reverts commit 37432a56535b24c221ae92e9aaded23de4d4a579.

* embiggen SD log buffer
2022-07-27 12:10:00 +03:00
rusefillc 2bc4fd909d Launch control bug? "range" thing is confusing #4348
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
rusefillc 2ba07e975e Launch control bug? "range" thing is confusing #4348
bug or dead code? at least making it a bit more obvious
2022-07-20 18:30:20 -04:00
rusefillc 99d8bf0ac1 Launch control bug? "range" thing is confusing #4348
minor tooltip progress
2022-07-20 18:27:44 -04:00
Matthew Kennedy ba8a84e5ce GDI: add min/max boost time config (#4343)
* add min/max boost time config

* add cast

* generated

* UI
2022-07-16 02:23:05 -04:00
rusefillc 04e47532ef FSIO is dead 2022-07-14 07:46:10 -04:00
rusefillc dd094ad543 Make hard-coded gap ratios visible on trigger documentation images #4172 2022-07-11 12:36:41 -04:00
rusefillc cc3cbdabc0 Make hard-coded gap ratios visible on trigger documentation images #4172 2022-07-11 04:21:17 -04:00
rusefillc c51881a80d debug is set to idle mode, but none of the debug fields show anything #4335
reducing confusion
2022-07-07 23:04:19 -04:00
Matthew Kennedy ab24c5eb35 Rewrite tooth logger buffer management (#4317)
* s

* make it work

* put back enough maybe

* fix console composite log

* unit tests can just use a vector, why not

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-04 16:57:17 -04:00
Matthew Kennedy 26e08632a1 more generous script table axis limits (#4309)
* script table axis limits

* curves too, why not

* s

* s

* table type
2022-07-01 06:51:47 -04:00
Matthew Kennedy 67439afb96 rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
rusefillc 98949ba517 startUpFuelPumpDuration tooltip fix 2022-06-29 13:15:34 -04:00
rusefillc cb72ae6b12 startUpFuelPumpDuration tooltip fix 2022-06-29 10:48:36 -04:00
Andrey 71716793e0 logging of live data structs was: data points #3614 2022-06-29 03:21:25 -04:00
rusefillc 2e28537776 logging of live data structs was: data points #3614 2022-06-29 01:49:59 -04:00
rusefillc 0f66f562aa usability confustion: ediatble fields with board overrides fix #4295 2022-06-27 13:35:22 -04:00
rusefillc 74383e6b3b verboseQuad 2022-06-26 19:47:58 -04:00
rusefillc e8777995be visiting "live data" tab causes fatal error on ECU fix #4271 2022-06-25 19:48:48 -04:00
Matthew Kennedy 840bf6fb27 wideband live data (#4276)
* wideband live data magic

* test build happy

* test even happier
2022-06-23 20:04:26 -04:00
Matthew Kennedy 478549ccdf get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
Matthew Kennedy 98e0297987 force o2 heating (#4275) 2022-06-23 14:32:34 -04:00
Matthew Kennedy ccec58446b clt based rpm limit (#4267) 2022-06-22 16:49:24 -04:00
rusefillc 22e3ab8220 https://rusefi.com/forum/viewtopic.php?f=5&t=2353 2022-06-20 07:43:23 -04:00
Matthew Kennedy 40106224f0 Write output channels with new parser (#4219)
* let the new parser run

* s

* support for output channels

* usages reader uses new parser for output channels

* better debugging configuration

* bad merge

* test it a bit too

* more tests

* copy/paste the same content from other file

* s

* fix bugs where even the existing logic tries to write as an enum (?)

* jar

* print stream always unix

* print stream always unix

* use typedefs correctly

* jar

* stub support for multiple of each type

* s

* s

* name some more datas
2022-06-19 09:52:23 -04:00
Matthew Kennedy aa7a404a44 new parser TS output fixes, config file fixes (#4261)
* new parser TS output fixes, config file fixes

* jar
2022-06-18 17:24:50 -04:00
rusefi 2dcdc7ed60 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
unused field & updated tooltip
2022-06-18 14:46:31 -04:00
Matthew Kennedy 945fd58657 no trailing invalid (#4257)
* don't pad

* test & jar

* do it in the new parser too

* remove from config txt

* minor file format cleanups while we're at it
2022-06-17 21:23:42 -04:00
rusefillc bc72a70992 refactoring 2022-06-06 17:04:44 -04:00
rusefi 23172930ba new autoscale constraint #4111 2022-06-03 01:05:48 -04:00
Matthew Kennedy e274fba799 use yaml like you're supposed to (#4233)
* use yaml like you're supposed to

* parse output names (but don't use it yet)
2022-06-03 01:02:16 -04:00
rusefi 0549e7af33 breaking things for sake of autoscale, would this pass CI? 2022-06-03 00:15:17 -04:00
rusefi 811cc4eee7 refactoring: extract constant 2022-06-03 00:14:46 -04:00
rusefi db74c8723a triggerComp scale issues #4235 2022-06-03 00:09:13 -04:00
Matthew Kennedy c2f61dc95f Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy c185771362 500 byte blocking factor (#4227) 2022-06-01 20:27:20 -04:00