Andrey
0337cb44ac
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey
eb9c096ab7
a bit of dead code
2023-01-03 07:49:17 -05:00
Andrey
77caa77b4b
trigger refactoring: instance RPM fix #4740
2022-11-06 12:03:55 -05:00
Andrey
153a454472
trigger refactoring: instance RPM #4740
2022-11-06 11:47:23 -05:00
Andrey
9edfda7f72
trigger refactoring: instance RPM #4740
2022-11-06 11:45:51 -05:00
Andrey
f7daa5df72
trigger refactoring: instance RPM #4740
2022-11-06 11:41:27 -05:00
Andrey
ba17b83bea
trigger refactoring: instance RPM #4740
2022-11-06 11:12:20 -05:00
Andrey
f8cce72779
trigger refactoring: instance RPM #4740
2022-11-06 10:58:04 -05:00
rusefillc
2d96fb3ef6
minor trigger refactoring
2022-11-06 00:32:38 -04:00
rusefillc
8bcbb2b9b1
learning C++
2022-11-06 00:17:24 -04:00
rusefillc
6c8325c0c2
more fancy
2022-11-06 00:10:50 -04:00
Andrey
72ed388948
minor trigger refactoring
2022-11-05 21:43:12 -04:00
rusefillc
cb9e33d501
dead lines
2022-11-05 17:21:30 -04:00
rusefillc
bcafeb471b
dead lines
2022-11-05 15:20:02 -04:00
Andrey G
cc9b1517ac
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
f2c8a0192c
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
9cd5553617
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
dbf8a1ea2a
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Matthew Kennedy
02aad24c59
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
b4bc5551db
tear down Engine god object #4511
2022-09-15 22:06:16 -04:00
rusefillc
918112d588
tear down Engine god object #4511
2022-09-15 22:00:07 -04:00
rusefillc
03d176ca61
tear down Engine god object #4511
2022-09-15 21:55:15 -04:00
rusefillc
1c28ca0582
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
Andrey
f5a5764429
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey
1d0f13fc41
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey
579f3df7ad
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey G
1ca5988877
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
921b97431f
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
cb3c070928
refactoring: type safety
2022-09-11 02:57:35 -04:00
rusefillc
f9b849dd8f
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
rusefillc
3c647c6442
huh? dead code? how can we get NAN from eventAngles table? ( #4549 )
2022-09-07 23:45:33 -04:00
Andrey
3c1cc0b857
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
8253156233
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
Andrey
25b6d39802
os_access.h dead?
2022-09-07 15:56:45 -04:00
Matthew Kennedy
670c2e4afe
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
Matthew Kennedy
fba0906942
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
rusefillc
715b799b6c
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 ( #4495 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
rusefillc
4e6d129f27
poke 3
2022-08-23 09:02:38 -04:00
rusefillc
016cd3bc7c
poke 2
2022-08-22 23:43:06 -04:00
rusefillc
341b43e7e3
poke 1
2022-08-22 23:42:48 -04:00
rusefillc
637dc37e95
RE: reasons for verbose messages
2022-08-22 22:52:48 -04:00
rusefi
ea7597e0d6
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
rusefillc
f11480597d
todo: huh? dead code? how can we get NAN from eventAngles table?
2022-08-11 20:05:29 -04:00
rusefillc
d97bcec161
refactoring: better field name
2022-08-09 20:32:39 -04:00
Matthew Kennedy
d5f1235a43
trigger tweaks cleanup ( #4278 )
...
* simplify some math
* we say yes to the todo
* and put back that test
* test
2022-06-23 23:11:29 -04:00
rusefi
214d38f286
verbose trigger sync should reuse engineSnifferRpmThreshold fix #4259
2022-06-18 15:18:45 -04:00
rusefillc
9d942a1c4a
more info verbose trigger/vvt
2022-06-17 22:11:09 -04:00
Matthew Kennedy
27c98f70fe
cam/crank sync improvements ( #4152 )
...
* clarify getOperationMode
* wait for phase synchronize to transition to sequential mode
* one test
* encapsulate vvtSyncCounter
* test
* Add option to stop VVT sync above some RPM
* getOrZero
* Revert "synchronized Phase handling improvements fix #4099"
This reverts commit e64c8cfccb
.
* Revert "m_hasSynchronizedSymmetrical handling improvements #4099"
This reverts commit 5454b8f509
.
* remove synchronizedPhase
* only crank needs this
* changelog
* needsDisambiguation()
* test
* s
* bad merge
* put the timer back
* s
* s
* changelog
* test for new behavior
* correct parameter order
* spelling
* s
* s
* s
* tests merge happy
* bad merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-09 17:21:22 -04:00
Matthew Kennedy
c2f61dc95f
Remove third trigger channel ( #4226 )
...
* remove third trigger
* clean up the honda mess
* there was nothing novel about this engine config
* include
* missed a few
* s
* x
* changelog
* don't set the third trigger input
* don't redefine the same thing 3 times
* only two inputs!
* test
2022-06-01 21:24:20 -04:00
Matthew Kennedy
56e7acd869
Trigger cleanup init ( #4222 )
...
* extra parameter
* name decoders in constructor
* s
2022-06-01 00:55:34 -04:00