Commit Graph

44 Commits

Author SHA1 Message Date
Matthew Kennedy 959f14fae6 more dead 2023-02-21 11:54:24 -08:00
Matthew Kennedy bc4d1127bc etb style idle valve 2023-02-20 22:56:26 -08:00
Andrey 0f16637767 minor bugfix 2023-02-18 23:58:06 -05:00
Andrey 11e3cb3d8d TDD for minor bug 2023-02-18 23:14:02 -05:00
rusefi bfcd5953e1 DC is not ETB 2023-02-18 22:39:45 -05:00
Andrey 85e0e3cbce Nick wonders if DC wastegate is still FUBAR #5075 2023-02-17 22:17:09 -05:00
Matthew Kennedy aaa3ea2d3e remove useETBforIdleControl (#5054)
* remove useETBforIdleControl

* etb integrated

* jni weirdness
2023-02-12 16:49:12 -05:00
Matthew Kennedy 03daac572e more flexible GPPWM (#5032)
* gppwm improvements!

* test

* ui

* autoscale
2023-02-06 08:53:31 -04:00
rusefillc 65b06d1f2f h-bridge wastegate not alive on bench #4965
fixing master
2023-01-18 02:12:34 -05:00
Matthew Kennedy c86f75ec78 Jammed ETB detection (#4873)
* jammed ETB detection

* autoscale

* comment

* cleanup

* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey 00e8cc4262 test coverage for antilag #4920
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey 36573a3044 test coverage for antilag #4920
bugfix?
2022-12-30 12:21:04 -05:00
Andrey 6a3c7d20e7 test coverage for antilag #4920 2022-12-30 12:17:53 -05:00
Andrey 13c3699415 test coverage for antilag #4920 2022-12-30 12:11:57 -05:00
Matthew Kennedy 29db8e2474 Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 016b71babe switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
Matthew Kennedy ecee1dd02d ETB error counter logic (#4854)
* simplify ETB error counter logic

* dropped this: {

* happy test

* reorder logic, test etbErrorCode

* test that fails

* independent TPS and PPS counters

* missed a file

* happy test
2022-11-30 22:20:09 -05:00
Andrey db8f7c48f3 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 21:23:13 -05:00
Andrey 9641d08d67 ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832 2022-11-30 20:08:19 -05:00
Andrey a6432feae7 ETB duty cycle jitter: only monitoring within this ticket #4833 2022-11-30 19:48:08 -05:00
rusefi 475c177f78 x2 spelling 2022-11-30 17:14:16 -05:00
Andrey 47aac2b46e ETB duty cycle jitter #4833
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Andrey 4a7a48779d ETB duty cycle jitter #4833 2022-11-29 20:51:28 -05:00
Andrey 7547edb566 mock invalid & current state of ETB error counter 2022-11-29 20:36:03 -05:00
Andrey b97745496e refactoring: extracting method 2022-11-29 20:11:34 -05:00
Andrey ca63f37d9e ETB duty cycle jitter #4833
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey 8a3727de3e ETB duty cycle jitter #4833 2022-11-29 14:59:08 -05:00
Andrey 73e309da03 ETB duty cycle jitter #4833 2022-11-29 14:02:44 -05:00
Andrey 82a3074cbd ETB overheats due to constant isTpsError true/false/true/false jitter #4832 2022-11-29 11:42:09 -05:00
Andrey d7cdf75e22 unit test compile more of ETB code 2022-11-28 23:41:51 -05:00
Andrey ac12287ab0 ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey c5a5d7f6eb ETB duty cycle jitter #4833
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey e1d3647401 ETB duty cycle jitter #4833
a step back to safety
2022-11-27 19:26:28 -05:00
Matthew Kennedy 7b47e77e58 infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
rusefi 8d0ac7a5be huh, we can pole larger method here 2022-10-26 12:08:27 -04:00
Matthew Kennedy 58a5569006 require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy 0d99d828e3 trim table for throttle #2 (#4472)
* add table and wire it up

* trim table ui

* initialization

* changelog

* add a test
2022-08-28 08:28:20 -04:00
Matthew Kennedy ea733ecbf0 fix inverted vvt (#4464)
* fix inverted mode

* unit tests are great
2022-08-20 20:12:32 -04:00
Matthew Kennedy 3c88dda538 Add a timeout for Lua ETB adjustment (#4331)
* lua etb timeout

* mocks

* test
2022-07-10 05:46:28 +03:00
Andrey 7bd22b589d helping build 2022-05-02 06:30:06 -04:00
Matthew Kennedy 83caf1ea1b Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Andrey 298ea5f8c0 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 02:21:37 -04:00
Andrey 4adaf71e18 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 01:02:13 -04:00
Matthew Kennedy d1ea6d6386 test organization (#3882)
* organize actuators

* this test can be useful

* don't name things misc

* fewer tests called misc

* fewer tests called "big" (?)

* unnecessary
2022-02-02 16:36:35 -05:00