Commit Graph

10267 Commits

Author SHA1 Message Date
Robert Falkenberg 21a4a675dd cmake/gcc: disable [-Werror=maybe-uninitialized] for GCC >= 12.1.0
With GCC 12.1.0 there are numerous false-positive warnings on
"maybe uninitialized" variables.
2022-05-18 15:01:37 +02:00
Robert Falkenberg 0c9ba5b87e lib,asn1_utils: fix out of bounds access on zero-sized array
* fix error: ... offset 0 is out of the bounds [0, 0] [-Werror=array-bounds]
* fix note: destination object of size 0 allocated by ‘operator new []’
--> data_ = new T[cap_];
2022-05-18 15:01:37 +02:00
Pedro Alvarez 58f71b10b6 gnb,config: make SRB configuration mandatory 2022-05-18 14:27:03 +02:00
Pedro Alvarez 02b3558390 lib,pdcp_nr: fix typos 2022-05-17 10:29:37 +01:00
Pedro Alvarez a08579dae9 ue,rrc_nr: mark is_security_active as true, after updating SK counter. 2022-05-17 10:29:37 +01:00
Pedro Alvarez 7f98101f30 lib,pdcp_nr: fix rx unit tests 2022-05-17 10:29:37 +01:00
Pedro Alvarez 904dbff471 lib,pdcp_nr: fixed PDCP NR tx unit tests 2022-05-17 10:29:37 +01:00
Pedro Alvarez b361ab0650 lib,pdcp_nr: fix pdcp nr encryption 2022-05-17 10:29:37 +01:00
Pedro Alvarez 1b2c9502e2 lib,pdcp_nr: fix order in which header discard was done in PDCP NR. 2022-05-17 10:29:37 +01:00
Pedro Alvarez 39fbf21174 lib,pdcp_nr: fix order of integrity generation 2022-05-17 10:29:37 +01:00
Pedro Alvarez a148dff0cd gnb,ue,rrc: enable using integrity on DRBs 2022-05-17 10:29:37 +01:00
Robert Falkenberg aa9f844630 adt,fsm: ignore GCC warning for template specialization w/wo defaults for ReactFn or GuardFn 2022-05-17 09:53:32 +02:00
Robert Falkenberg 02cb2532f8 lib,pdcp_nr: make sure MAC-I is computed on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez c015540f54 lib,pdcp_nr: make sure MAC-I is added on SRBs, even when integrity is not active yet 2022-05-16 16:16:07 +01:00
Pedro Alvarez 25b8a35d7a lib,pdcp_nr: make sure we don extract MAC-I if integrity is not enabled. Make sure gNB does not enable integrity on DRBs 2022-05-16 16:16:07 +01:00
Pedro Alvarez ae8191c46d lib,rlc_am_nr: make sure we check that ACK_SN is not larger than TX_NEXT (after we checked we didn't get an ACK out of order) 2022-05-13 10:27:52 +01:00
Pedro Alvarez 97b66dbc4c lib,rlc_am_nr: fixed mal-formed status report in test. 2022-05-13 10:27:52 +01:00
Pedro Alvarez abc7294316 lib,rlc_am_nr: addded unit test for out of order status report 2022-05-13 10:27:52 +01:00
Pedro Alvarez 6d55560256 lib,rlc_am_nr: check if ACK SN is within rx_window. Stop
t-PollRetransmit only if status report is not ignored
2022-05-13 10:27:52 +01:00
Pedro Alvarez c457132570 lib,rlc_am_nr: avoid if that would always be true when checking the
out-of-order ACK. Check ACK_SN instead of stop SN with Tx_Next_Ack
2022-05-13 10:27:52 +01:00
Pedro Alvarez 7c42b09e89 lib,rlc_am_nr: check if rx ACK is smaller than current Tx_Next_Ack 2022-05-13 10:27:52 +01:00
Robert Falkenberg 0c24e9c55f lib,rlc_am_nr: clean retx_queue of ACK'ed SDUs 2022-05-13 06:49:13 +02:00
Robert Falkenberg 95480297f4 lib,rlc_am_nr: unit test removal of ACK'ed SDUs from retx queue 2022-05-13 06:49:13 +02:00
Robert Falkenberg e20cb2e0c8 lib,rlc_am_nr: empty PDUs shall not increment metrics.num_tx_pdus 2022-05-13 06:49:13 +02:00
Pedro Alvarez 2c5a74340b lib,rlc_um_nr: reduce log level of message 2022-05-12 22:25:11 +01:00
Robert Falkenberg 7b77558fd4 lib,rlc_um_nr: add log message if tx_sdu_queue has no non-null SDU 2022-05-12 22:25:11 +01:00
Pedro Alvarez 6a40fd8411 lib,pdcp_nr: disabe discard timer with RLC UM 2022-05-12 22:25:11 +01:00
Pedro Alvarez 92a6d8ec66 lib,rlc_um_nr: fix issue with discard in RLC UM NR 2022-05-12 22:25:11 +01:00
Pedro Alvarez 68b6facac8 lib,pdcp_nr: log RLC mode in PDCP configuration 2022-05-12 22:25:11 +01:00
Robert Falkenberg 9687af7660 add missing include for build with GCC 12
Related info: https://gcc.gnu.org/gcc-12/porting_to.html
2022-05-12 15:00:58 +02:00
Pedro Alvarez a72279dcbd Addressed review comments:
1 - enb,cfg: fix typo
2 - enb,config: added back deleted config option
3 - ue,rrc_nr: fix wrong log level in log message
4 - enb,config: remove unused parameter
2022-05-11 18:19:29 +01:00
Pedro Alvarez 97b32f2fb6 rrc_nr,utils: fix generation of RLC configs from ASN.1 structs created from cfg parser. 2022-05-11 18:19:29 +01:00
Pedro Alvarez 42011401ff gnb,config: remove SN length for 4G SRB configs 2022-05-11 18:19:29 +01:00
Pedro Alvarez b446fa87b0 gnb,config: enable changing the SN length of SRBs 2022-05-11 18:19:29 +01:00
Pedro Alvarez f79b3e9435 gnb,rrc: fix SRB config generation when configuration is present in rb.conf 2022-05-11 18:19:29 +01:00
Pedro Alvarez c737f75abb gnb,config: enable SRB config parser for SA 2022-05-11 18:19:29 +01:00
Pedro Alvarez ece3c69d45 gnb,rrc: make it possible to use default configs when SRB configs are not present. 2022-05-11 18:19:29 +01:00
Pedro Alvarez 3ae6aae230 gnb,rrc: starting to read srb configuration from config 2022-05-11 18:19:29 +01:00
Pedro Alvarez 36354ef6ff srsgnb,cfg_parser: adding parsing for SA SRB configs 2022-05-11 18:19:29 +01:00
Pedro Alvarez d2b27a6f7d srsgnb: added example SA srb config 2022-05-11 18:19:29 +01:00
Robert Falkenberg c5d5d45574 cmake: fix build for cmake option BUILD_SHARED_LIBS=ON
The cmake option BUILD_SHARED_LIBS (off by default) causes all
libraries to be built as shared libraries if not unless explicitly
stated otherwise.
Since test-helper libraries do not export their symbols, linking
fails if built as shared library.
Therefore, this change explicitly configures these helpers as STATIC.
2022-05-11 13:45:07 +02:00
Pedro Alvarez 3620308940 lib,pdcp_nr: added options to select re-ordering timer 2022-05-11 12:10:54 +01:00
Pedro Alvarez 1fecae9b5a lib,pdcp_nr: added ifdef to select pdcp_entity_nr 2022-05-11 10:15:58 +01:00
Robert Falkenberg ebbecbe27c lib,rlc_am_nr: cosmetic change -- clang format 2022-05-10 14:02:39 +02:00
Robert Falkenberg 9a34d4d81b lib,rlc_am_nr: unit tests for NACK merging 2022-05-10 14:02:39 +02:00
Robert Falkenberg ecc995bd4b lib,rlc_am_nr: merge NACKs across SN overflows 2022-05-10 14:02:39 +02:00
Robert Falkenberg e9156d4ba2 lib,rlc_am_nr: status PDU creation supports NACK range 2022-05-10 14:02:39 +02:00
Pedro Alvarez 283199d54f lib,rlc_am_nr: added unit test for nack ranges without SO 2022-05-09 14:03:25 +01:00
Pedro Alvarez e01bbb8f79 lib,rlc_am_nr: support also NACK ranges without SO_start/end. Fix for NACK ranges of sizee == 1 2022-05-09 14:03:25 +01:00
Pedro Alvarez 6d8357bee9 lib,rlc_am_nr: deleted error log for unhandled NACK ranges 2022-05-09 14:03:25 +01:00