Commit Graph

7948 Commits

Author SHA1 Message Date
Andre Puschmann 598594c51a all: bunch of pass by const& changes suggested by LGTM 2021-04-29 10:00:09 +02:00
Francisco 7ced0e73eb rlc,bugfix - avoid accessing the PDCP info of RLC segments when the PDCP has already discarded the respective PDCP SN. 2021-04-28 21:15:00 +02:00
Andre Puschmann 597729ac53 rlc: always remove PDCP SNs from undelivered queue
if RLC PDUs with certain PDCP SNs were already in flight
when their discard timer at PDCP expires, they weren't
remove from the undelivered_sdu_info_queue causing
indesired log entries like:

08:08:52.455280 [RLC    ] [W] PDCP_SN=2103 already marked as undelivered

when the SN was sent again (after wrap around).

The patch makes sure to always try to delete the PDCP SN
from the queue. It should fix (at least partly) #2560
2021-04-28 21:15:00 +02:00
Andre Puschmann 20075f6f33 rf_uhd_generic: fix segfault when accessing device tree
for some reasons the dev tree isn't available on the X310
with UHD4 and the code never checked the return value, causing
a segfault with that combo.
2021-04-28 20:24:17 +02:00
Xavier Arteaga 949ce965c7 Fix SCH NR CRC check 2021-04-28 20:23:52 +02:00
Xavier Arteaga e1ff824cc2 SRSUE avoid NR SR in UCI for PUSCH 2021-04-28 20:23:52 +02:00
Xavier Arteaga fb5dfb3a86 Improved NR unit test 2021-04-28 20:23:52 +02:00
Xavier Arteaga 28170c92a9 Multiple NR SCH fixes 2021-04-28 20:23:52 +02:00
Xavier Arteaga efb8da69d8 Cleaned DCI NR info string 2021-04-28 20:23:52 +02:00
Xavier Arteaga 8cb3e92ab3 Added LDPC flooded early stop 2021-04-28 20:23:52 +02:00
Xavier Arteaga 033661182a Aded SF len macro for NR 2021-04-28 20:23:52 +02:00
Xavier Arteaga 6c39a5e4ff Added PDSCH DMRS aditional unpacking 2021-04-28 20:23:52 +02:00
Xavier Arteaga 334b308c35 Fix DCI NR configuration from main configuration 2021-04-28 20:23:52 +02:00
Xavier Arteaga 86ad0446e1 Added NR PDSCH and PUSCH resource allocating flattening 2021-04-28 20:23:52 +02:00
Xavier Arteaga 892aea8219 Fix coverity warnings under lib/src/phy/utils 2021-04-28 16:53:44 +02:00
Xavier Arteaga 87cf3cf2e5 Fix coverity warnings under lib/src/phy/phch 2021-04-28 16:53:44 +02:00
Francisco 3f64b94a0f increase asn1 variable length field intermediate buffer, to support longer UE Radio Capabilities messages 2021-04-28 16:01:22 +02:00
Andre Puschmann 2a30cc72ab
Merge pull request #2758 from softwareradiosystems/pr_merge_with_master
Merge public master into `dev`
2021-04-28 16:00:31 +02:00
Andre Puschmann c86d38b8fa Merge remote-tracking branch 'github_public/master' into pr_merge_with_master 2021-04-28 13:14:13 +02:00
David Rupprecht bde30bb9be Added tests for band helper 2021-04-28 12:43:58 +02:00
Andre Puschmann 937c4ff3c3 demod_soft: removed unused NEON code
clang complained about unused code, so remove it of course.
2021-04-28 12:42:44 +02:00
Xavier Arteaga 71226e89df Minor dereference check 2021-04-28 10:28:09 +02:00
Xavier Arteaga b6fa82bf9a Fix more static analysis warnings 2021-04-28 10:28:09 +02:00
Francisco 70d6e4d9b3 mac, fix - Verify that mac::ue also exists in the scheduler before attempting to retrieve its metrics 2021-04-28 00:02:06 +01:00
Xavier Arteaga 290541993e Fix debug compilation 2021-04-27 20:31:29 +02:00
Xavier Arteaga efd6c569b8 Fix some static analisys warnings under lib/src/phy/fec 2021-04-27 20:31:29 +02:00
David Rupprecht fafa03f7c8 Extended the band helper table 2021-04-27 20:28:36 +02:00
Francisco 6e7d992552 remove UE on S1AP Release Request if MME S1AP UE ID hasn't been assigned yet 2021-04-27 19:14:25 +01:00
Francisco 3c4512cdd2 demote assert to expect check in circular stack pool destruction, when a leak is detected 2021-04-27 19:14:25 +01:00
Xavier Arteaga 6045998909 enb_phy_test uses default rr configuration 2021-04-27 16:55:51 +02:00
Xavier Arteaga 217f3cb416 SRSENB: select highest with/without SR correlation PUCCH result 2021-04-27 16:55:51 +02:00
Andre Puschmann ada6c71b5a rf_soapy: fix logic to print warning when Lime is used with short sample rates
previously the warning was printed when a Lime was connected to the PC.
Now all connected devices are printed but the warning is only
shown if the selected device is the Lime.
2021-04-27 15:32:26 +02:00
faluco aa3309157b Fixed polar encoder and decoder initialization failure for ARM. Initialization unconditionally used x86 SIMD routines instead of getting disabled for ARM compilations. 2021-04-27 14:42:30 +02:00
faluco d9e5f4ccc7 Replace a couple of inline functions in demod_soft with macros to allow constant propagation. The vgetq_lane_sX builtin expects a constant instead of a variable. 2021-04-27 14:42:30 +02:00
Francisco Paisana d39183419c
Separate TPC PUSCH and PUCCH target SINR (#2740)
* separate target pusch and pucch sinr configurations in tpc class and rr.conf
2021-04-27 10:12:40 +01:00
Francisco 38bf895efa fix asn1 compilation issue 2021-04-27 10:11:03 +01:00
Francisco 86dac9c823 several coverity high and medium impact fixes 2021-04-27 10:11:03 +01:00
Xavier Arteaga 9a4fcb605b Reviewed UHD Tx FSM 2021-04-27 09:52:41 +02:00
Xavier Arteaga 3413f29cc8 Fix channel interpolator for 4 ports 2021-04-27 09:50:33 +02:00
Andre Puschmann 03e1277b0b rf_soapy_imp: fix lowercase to detect Lime 2021-04-26 21:39:04 +02:00
Andre Puschmann a083b0da2a proc_ra: only log warning if RAR wasn't received in window
lead to some failing tests with RF where PRACH wasn't received
correctly. recovery machanism will retransmit PRACH.
2021-04-26 10:08:48 +02:00
Andre Puschmann 20575d3eec phy,enb: only initialize NR workers if needed
the NR support in the eNB isn't finished yet but loading
all DL objects even for 4G only isn't required. So only
even attempt to load them if a NR cell is configured.
2021-04-26 09:43:58 +02:00
Andre Puschmann b569e81299 rf_soapy_imp: fix LTE sample rate info check
only print if Lime is substring in dev args, so don't print with blade
2021-04-26 09:43:58 +02:00
Andre Puschmann f76cd5ef83 backward: fix compile error on aarch64 2021-04-26 09:43:58 +02:00
Andre Puschmann 0826b86cec srsue: remove NR DL freq and ARFCN option
not required anymore as all NR carrier tuning is done
through RRC signaling
2021-04-25 21:05:23 +02:00
Andre Puschmann 4dd17aee45 rrc/phy/nr: calculate tuning freq of NR carrier from RRC signaling params
skip initial tuning to hard-coded NR frequency and use RRC-provided
values to calculate center frequency
2021-04-25 21:05:23 +02:00
Andre Puschmann 6e79ae67aa ldpc/polar: add casts to avoid possible variable overflow before assignment 2021-04-25 21:03:53 +02:00
Andre Puschmann 92d4e6e746 adt/common: remove const from return type
reported by LGTM https://lgtm.com/projects/g/srsLTE/srsLTE/rev/pr-9ae46cae260b6b8137b34b9423bf1477bd6b5c42
2021-04-25 21:03:53 +02:00
Andre Puschmann ff53d2b8b8 all: set of trivial changes reported by LGTM
mainly fixmes, unused/empty code, etc.
2021-04-25 21:03:53 +02:00
AlaiaL 5fd4f421e9 Fixes coverity 366610 2021-04-23 21:22:06 +02:00