andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

depressing code comment

This commit is contained in:
Andrey 2021-06-26 23:01:47 -04:00
parent 5adb42f939
commit 4463ca1fdb
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
firmware/controllers/algo/engine_configuration.cpp
View File

@ -1153,12 +1153,16 @@ void prepareShapes(DECLARE_ENGINE_PARAMETER_SIGNATURE) {
#endif #endif
/**
* todo: why is this method NOT reciprocal to getCrankDivider?!
*/
float getRpmMultiplier(operation_mode_e mode) { float getRpmMultiplier(operation_mode_e mode) {
if (mode == FOUR_STROKE_SYMMETRICAL_CRANK_SENSOR) { if (mode == FOUR_STROKE_SYMMETRICAL_CRANK_SENSOR) {
return 2; return 2;
} else if (mode == FOUR_STROKE_CAM_SENSOR) { } else if (mode == FOUR_STROKE_CAM_SENSOR) {
return 0.5; return 0.5;
} else if (mode == FOUR_STROKE_CRANK_SENSOR) { } else if (mode == FOUR_STROKE_CRANK_SENSOR) {
// unit test coverage still runs if the value below is changed to '2' not a great sign!
return 1; return 1;
} }
return 1; return 1;

3
firmware/controllers/trigger/trigger_central.cpp
View File

@ -474,6 +474,9 @@ bool TriggerNoiseFilter::noiseFilter(efitick_t nowNt,
return false; return false;
} }
/**
* todo: why is this method NOT reciprocal to getRpmMultiplier?!
*/
int getCrankDivider(operation_mode_e operationMode) { int getCrankDivider(operation_mode_e operationMode) {
if (operationMode == FOUR_STROKE_CAM_SENSOR || operationMode == TWO_STROKE) { if (operationMode == FOUR_STROKE_CAM_SENSOR || operationMode == TWO_STROKE) {
// That's easy - trigger cycle matches engine cycle // That's easy - trigger cycle matches engine cycle