andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

let's remove "overrideCrankingIacSetting" "Override cranking IAC CLT multiplier" flexibility and always use additional table #7482

This commit is contained in:
rusefillc 2025-02-21 20:12:37 -05:00
parent d0db738647
commit 5a27aa6c6b
5 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
firmware/config/engines/canam.cpp
View File

@ -51,7 +51,6 @@ void setMaverickX3() {
engineConfiguration->idlePidDeactivationTpsThreshold = 2;
engineConfiguration->useSeparateAdvanceForIdle = true;
engineConfiguration->vvtControlMinRpm = 2000;
engineConfiguration->overrideCrankingIacSetting = true;
engineConfiguration->requireFootOnBrakeToCrank = true;
engineConfiguration->startButtonSuppressOnStartUpMs = 1000;

2
firmware/config/engines/hyundai.cpp
View File

@ -299,8 +299,6 @@ static void commonGenesisCoupe() {
engineConfiguration->crankingIACposition = 70;
// default 200.0
engineConfiguration->afterCrankingIACtaperDuration = 100;
// default "false"
engineConfiguration->overrideCrankingIacSetting = true;
// default 0.0
engineConfiguration->tpsAccelLookback = 0.3;
// default 40.0

2
firmware/integration/rusefi_config.txt
View File

@ -1105,7 +1105,7 @@ custom idle_mode_e 1 bits, U08, @OFFSET@, [0:0], "Open Loop + Closed Loop", "Ope
bit complexWallModel,"Advanced (tables)","Basic (constants)";Should we use tables to vary tau/beta based on CLT/MAP, or just with fixed values?
bit alwaysInstantRpm;RPM is measured based on last 720 degrees while instant RPM is measured based on the last 90 degrees of crank revolution
bit isMapAveragingEnabled
bit overrideCrankingIacSetting;If enabled, use separate temperature multiplier table for cranking idle position.\nIf disabled, use normal running multiplier table applied to the cranking base position.
bit unusedOverrideCrankingIacSetting;If enabled, use separate temperature multiplier table for cranking idle position.\nIf disabled, use normal running multiplier table applied to the cranking base position.
bit useSeparateAdvanceForIdle;This activates a separate ignition timing table for idle conditions, this can help idle stability by using ignition retard and advance either side of the desired idle speed. Extra advance at low idle speeds will prevent stalling and extra retard at high idle speeds can help reduce engine power and slow the idle speed.
bit isWaveAnalyzerEnabled
bit useSeparateVeForIdle;This activates a separate fuel table for Idle, this allows fine tuning of the idle fuelling.

1
firmware/tunerstudio/tunerstudio.template.ini
View File

@ -4589,7 +4589,6 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
dialog = crankingIAC, "Idle air valve"
field = "Cranking base IAC position", crankingIACposition
field = "After cranking IAC taper duration",afterCrankingIACtaperDuration
field = "Override cranking IAC CLT multiplier", overrideCrankingIacSetting
dialog = crankingIgnition, "Ignition"
field = "Timing Advance mode", useSeparateAdvanceForCranking

3
unit_tests/tests/test_idle_controller.cpp
View File

@ -122,7 +122,6 @@ TEST(idle_v2, crankingOpenLoop) {
config->cltIdleCorr[i] = i * 0.2f;
}
engineConfiguration->overrideCrankingIacSetting = true;
EXPECT_FLOAT_EQ(5, dut.getCrankingOpenLoop(10));
EXPECT_FLOAT_EQ(25, dut.getCrankingOpenLoop(50));
}
@ -249,8 +248,6 @@ TEST(idle_v2, testOpenLoopCranking) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
StrictMock<MockOpenLoopIdler> dut;
engineConfiguration->overrideCrankingIacSetting = true;
EXPECT_CALL(dut, getCrankingOpenLoop(30)).WillOnce(Return(44));
// Should return the value from getCrankingOpenLoop, and ignore running numbers