Renamed "bump" to "target", changed CHANGELOG

This commit is contained in:
pchmura4 2023-10-22 19:50:43 +02:00 committed by rusefillc
parent 0b852e4a81
commit beebe4c233
5 changed files with 9 additions and 6 deletions

View File

@ -28,6 +28,9 @@ Release template (copy/paste this for new release):
## Unreleased
### Breaking Changes
- "acIdleRpmBump" renamed to "acIdleRpmTarget", and changed the way of RPM rise needed for proper A/C operation from added to absolute target #5628
### Added
- DAC with Lua #5601
- TunerStudio cacerts fix script #5536

View File

@ -30,9 +30,9 @@ int IdleController::getTargetRpm(float clt) {
// Why do we bump based on button not based on actual A/C relay state?
// Because AC output has a delay to allow idle bump to happen first, so that the airflow increase gets a head start on the load increase
// alternator duty cycle has a similar logic
targetRpmAcBump = engine->module<AcController>().unmock().acButtonState ? engineConfiguration->acIdleRpmBump : 0;
targetRpmAcTarget = engine->module<AcController>().unmock().acButtonState ? engineConfiguration->acIdleRpmTarget : 0;
auto target = (targetRpmByClt < targetRpmAcBump) ? targetRpmAcBump : targetRpmByClt;
auto target = (targetRpmByClt < targetRpmAcTarget) ? targetRpmAcTarget : targetRpmByClt;
idleTarget = target;
return target;
}

View File

@ -593,7 +593,7 @@ static void setDefaultEngineConfiguration() {
engineConfiguration->isMapAveragingEnabled = true;
engineConfiguration->isWaveAnalyzerEnabled = true;
engineConfiguration->acIdleRpmBump = 50;
engineConfiguration->acIdleRpmTarget = 900;
engineConfiguration->acDelay = 0.5;
engineConfiguration->acIdleExtraOffset = 15;

View File

@ -1060,7 +1060,7 @@ bit tempBooleanForVerySpecialLogic
float turboSpeedSensorMultiplier;;"mult", 1, 0, 0, 7000, 3
Gpio[CAM_INPUTS_COUNT iterate] camInputsDebug;
int16_t acIdleRpmBump;Idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 2000, 0
int16_t acIdleRpmTarget;Idle target speed when A/C is enabled. Some cars need the extra speed to keep the AC efficient while idling.;"RPM", 1, 0, 0, 2000, 0
int16_t warningPeriod;set warningPeriod X;"seconds", 1, 0, 0, 60, 0

View File

@ -3421,7 +3421,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
dialog = idleOpenLoop, "Open Loop Idle"
slider = "Open loop base position", manIdlePosition, horizontal
field = "A/C adder", acIdleExtraOffset
field = "A/C target adder", acIdleRpmBump
field = "A/C RPM target", acIdleRpmTarget
field = "Fan #1 adder", fan1ExtraIdle
field = "Fan #2 adder", fan2ExtraIdle
field = "Dashpot/Taper Initial IAC Adder", iacByTpsTaper
@ -3504,7 +3504,7 @@ cmd_set_engine_type_default = "@@TS_IO_TEST_COMMAND_char@@@@ts_command_e_TS_
field = "Max CLT", maxAcClt
field = "Max TPS", maxAcTps
field = "A/C Idle adder", acIdleExtraOffset
field = "A/C Idle RPM", acIdleRpmBump
field = "A/C Idle RPM", acIdleRpmTarget
dialog = acSettings, "", border
panel = acSettingsWest, West