andreika-git
/
rusefi
mirror of https://github.com/andreika-git/rusefi.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

reducing/moving technical debt

This commit is contained in:
Andrey 2023-08-29 16:46:04 -04:00
parent 55cb5cfcf1
commit d2f899e737
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
firmware/controllers/algo/defaults/default_base_engine.cpp
View File

@ -39,9 +39,9 @@ void setLeftRightBanksNeedBetterName() {
}
static void setDefaultHPFP() {
engineConfiguration->hpfpCamLobes = 3;
// todo: would be nice for unit tests to be happy about these defaults
#if EFI_PROD_CODE
engineConfiguration->hpfpCamLobes = 3;
engineConfiguration->hpfpPumpVolume = 0.290;
engineConfiguration->hpfpMinAngle = 10;
engineConfiguration->hpfpActivationAngle = 30;

2
unit_tests/tests/trigger/test_trigger_decoder.cpp
View File

@ -867,6 +867,7 @@ TEST(big, testBatch) {
TEST(big, testSinglePoint) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
engineConfiguration->hpfpCamLobes = 0;
setTable(config->injectionPhase, -180.0f);
EXPECT_CALL(*eth.mockAirmass, getAirmass(_, _))
.WillRepeatedly(Return(AirmassResult{0.1008f, 50.0f}));
@ -895,6 +896,7 @@ TEST(big, testSinglePoint) {
TEST(big, testFuelSchedulerBug299smallAndLarge) {
EngineTestHelper eth(engine_type_e::TEST_ENGINE);
engineConfiguration->hpfpCamLobes = 0;
setTable(config->injectionPhase, -180.0f);
engineConfiguration->isFasterEngineSpinUpEnabled = false;
engine->tdcMarkEnabled = false;