Matthew Kennedy
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Andrey
612d52645a
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
Andrey
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
Andrey
111220d38c
more inclusive configuration name
2022-09-24 23:49:41 -04:00
Andrey
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
Andrey
a38d87b0e0
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
Andrey
93e64a61a6
fancy
2022-09-24 22:54:58 -04:00
Andrey
33be12541b
K
2022-09-24 15:37:51 -04:00
Andrey
0eef498b3e
refactoring: extract constant
2022-09-24 15:33:01 -04:00
Matthew Kennedy
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
2f18168d47
K20
2022-09-23 20:13:14 -04:00
rusefillc
ed72758a5d
K20
2022-09-23 18:25:24 -04:00
Matthew Kennedy
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
af7e4f6fe5
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
rusefillc
60e703e079
B6
2022-09-17 23:49:24 -04:00
Andrey
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
954ddacd96
GM
2022-09-14 00:03:38 -04:00
Andrey
8ce57d5599
code formatting
2022-09-13 23:44:38 -04:00
Andrey G
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
Andrey
cbb42b68d1
E38
2022-09-09 14:04:22 -04:00
Andrey
2199bfd7f7
E38
2022-09-09 01:15:55 -04:00
Matthew Kennedy
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
Andrey
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
07d895dfeb
B6
2022-09-06 15:12:43 -04:00
Matthew Kennedy
b305308ef6
add hysteresis to limp rpm, boost, injector duty ( #4541 )
...
* add hysteresis
* changelog
2022-09-05 20:56:32 -04:00
Andrey
4d65067345
wow Leiderman-Khlystov
2022-09-05 20:23:40 -04:00
Andrey
4c9df01b64
wow Leiderman-Khlystov
2022-09-05 20:02:33 -04:00
Andrey
4934d76d88
tear down Engine god object #4511
...
just trying different things
2022-09-05 04:24:17 -04:00
Andrey
268a5c7964
tear down Engine god object #4511
...
just trying different things
2022-09-05 02:44:06 -04:00
Andrey
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
Andrey
feb386a54b
refactoring: moving field
2022-09-05 01:15:45 -04:00
Andrey
796e421857
wow Leiderman-Khlystov
2022-09-04 18:29:13 -04:00
rusefi
fc46ec182c
wow Leiderman-Khlystov
2022-09-04 15:58:46 -04:00
rusefi
51ee116fea
B6
2022-09-04 11:47:57 -04:00
rusefi
5c88f4c1f0
B6
2022-09-04 11:29:18 -04:00
Matthew Kennedy
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
Andrey
d329f8ae10
tear down Engine god object #4511
...
just trying different things
2022-09-03 07:44:24 -04:00
rusefillc
25f4ebbc01
moving state into specific class ( #4520 )
...
* moving state into specific class
* moving state into specific class
2022-09-02 14:38:03 -04:00
Andrey
7e340cceb3
refactoring: reducing outputChannels copy
2022-09-01 10:58:16 -04:00
Andrey
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
Andrey
fef406a5a6
english do you speak it
2022-08-31 22:56:38 -04:00
Andrey
8500f4c313
B6 progress
2022-08-30 05:20:56 -04:00
Andrey
4e45046673
B6 progress
2022-08-30 04:38:20 -04:00
Andrey
027ed7742e
B6 progress
2022-08-30 04:07:48 -04:00
Matthew Kennedy
ee97e2a7d0
knock retard limit table ( #4498 )
...
* add max retard table
* ui
* s
* better naming
* s
* test can use base class
2022-08-30 01:57:37 -04:00
Matthew Kennedy
cbe70f8dec
idle always uses instant rpm ( #4499 )
...
* idle always uses instant rpm
* configs
* fully inject rpm
2022-08-29 22:18:06 -04:00
Matthew Kennedy
553b549b95
idle coasting table is RPM, not clt ( #4487 )
...
* idle coasting table is RPM, not clt
* default
* autoscale
* changelog
2022-08-29 08:15:04 -04:00
Matthew Kennedy
5a4e8b314a
B6 progress
2022-08-28 12:33:32 -04:00
Matthew Kennedy
b662e59707
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
Matthew Kennedy
ca60dc17bb
trim table for throttle #2 ( #4472 )
...
* add table and wire it up
* trim table ui
* initialization
* changelog
* add a test
2022-08-28 08:28:20 -04:00
Andrey
c6607a5a5e
B6 progress
2022-08-27 20:44:30 -04:00
Andrey
764fc833d7
B6 progress
2022-08-26 12:07:13 -04:00
Andrey
2ee07e643c
B6 progress
2022-08-26 00:30:46 -04:00
Andrey
678c0f1432
B6 progress
2022-08-26 00:24:38 -04:00
Andrey
2f3b1def90
B6 progress
2022-08-26 00:21:17 -04:00
Andrey
3477d4bd07
refactoring
2022-08-26 00:16:36 -04:00
Andrey
1b4bbb8772
refactoring
2022-08-26 00:14:52 -04:00
Andrey
97e8c978ce
B6 progress
2022-08-26 00:04:47 -04:00
rusefillc
055184e1ec
two bugs love to cancel each other
2022-08-25 23:55:42 -04:00
Matthew Kennedy
4d66dff87c
dfco delay ( #4482 )
...
* dfco delay
* config
* using a function that doesn't exist? who does that
* test new behavior
* clearer test
2022-08-25 21:26:17 -04:00
Andreika
c24712bed7
[DRAFT] Air by rpm taper ( #4486 )
...
* add rpm to getOpenLoop() and getRunningOpenLoop()
* implement airByRpmTaper
* unit-test for airByRpmTaper
2022-08-25 21:23:23 -04:00
Andrey
e480e9d561
B6 progress
2022-08-25 19:26:18 -04:00
Andrey
c266a9c542
B6 progress
2022-08-25 12:45:47 -04:00
Andrey
cc95f08fbc
B6 progress
2022-08-25 11:15:54 -04:00
Andrey
4844edc682
Lua code reuse
2022-08-25 10:45:26 -04:00
rusefillc
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
Andrey
585f2ebeea
test coverage and some magic constant refactoring
2022-08-21 16:03:34 -04:00
Andrey
35a71f8960
test coverage and some magic constant refactoring
2022-08-21 15:22:22 -04:00
rusefi
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
rusefi
0f320448ff
refactoring: default argument value
2022-08-21 12:17:50 -04:00
Matthew Kennedy
3e4965ea27
fix inverted vvt ( #4464 )
...
* fix inverted mode
* unit tests are great
2022-08-20 20:12:32 -04:00
Matthew Kennedy
eebc810295
enable alwaysInstantRpm in some tests ( #4461 )
...
* test some with alwaysInstantRpm set
* more
2022-08-19 15:03:20 -04:00
Matthew Kennedy
423f69a842
allow logging multiple warnings at once ( #4414 )
...
* allow logging multiple warnings at once
* comment
* .Code
* Revert ".Code"
This reverts commit 2b986bd50035aeec051d11aafd83fdbc1694351c.
* add a better comparison operator instead of conversion
* dot code
* Revert "dot code"
This reverts commit 35f6ae1007c41e3b30ea129a324f33ab4205036d.
* force gcc-10 maybe?
* Revert "force gcc-10 maybe?"
This reverts commit 4ddf8bcefddd354ccdc1da682c5fff1e68d44273.
* vq
* dot code
* dead
* dot code
* return may be null
* static_vector; maybe cyclic_buffer is broken or wrong tool for the job?
* move static vector
* put cyclic buffer back how it was since we don't use it now
2022-08-17 01:12:25 -04:00
rusefillc
8f6fb427eb
ECU to Mainline DynoLog Data Protocol #4319
2022-08-12 23:53:48 -04:00
Matthew Kennedy
76f5832db9
resolve VVT phase using every tooth, not just sync point ( #4434 )
...
* resolve VVT phase using every tooth, not just sync point
* fix tests
* comment
* changelog
2022-08-12 08:08:23 -04:00
rusefillc
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00
Matthew Kennedy
b6f1779781
implement sensor checker ( #4395 )
...
* implement sensor checker
* use default
* s
* fix
* properly report non-timeout errors
* it's not safe to read Value when invalid
* it's not safe to read Value when invalid
2022-07-30 17:08:48 -04:00
rusefillc
d320dd589c
it's impossible to receive AcceleratorPedal sensor via CAN/Lua #4369
2022-07-28 12:08:35 -04:00
Matthew Kennedy
923d2c2e44
unexpected contains information about why it failed ( #4393 )
...
* unexpected can contain information
* info printing
* sensors return appropriate error codes
* remove reliance on undefined behavior
* s
2022-07-28 10:04:28 +03:00
Matthew Kennedy
41318e0f9d
detect bad Lua sensor name when registering ( #4391 )
...
* format
* lua error on bad sensor
* comment
* name validation
* soft check before the hard check causes a fatal error
* s
2022-07-27 12:41:21 +03:00
Andrey
7887b9d1e1
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:39:19 -04:00
Andrey
20a16bd53b
Extra gap ratios for custom trigger wheels fix #4375
2022-07-23 03:16:11 -04:00
rusefillc
4987a0b93c
Launch control bug? "range" thing is confusing #4348
...
a typo and configurable behaviour without UI
2022-07-20 18:48:55 -04:00
Matthew Kennedy
848fbcf6ca
fragments ( #4357 )
2022-07-19 11:02:41 +03:00
Matthew Kennedy
e1254f84b9
remove idle offset ( #4355 )
...
* remove offset
* remove more completely
* changelog
2022-07-18 15:49:43 -04:00
Matthew Kennedy
a0d8ae3f4f
use libfirmware for a few things ( #4351 )
...
* use libfirmware
* unit tests
* crc
* missed one
* bootloader
2022-07-16 02:22:51 -04:00
rusefillc
b7cfa4e702
launch control for autocross on micro rusefi #4341
2022-07-14 16:41:50 -04:00
rusefillc
55ffb45934
FSIO is dead
2022-07-14 07:52:58 -04:00
rusefillc
b628c81d26
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-12 00:11:25 -04:00
rusefillc
2f0db8b7c4
Make hard-coded gap ratios visible on trigger documentation images #4172
2022-07-11 04:21:17 -04:00
Matthew Kennedy
8bc01472b7
Add a timeout for Lua ETB adjustment ( #4331 )
...
* lua etb timeout
* mocks
* test
2022-07-10 05:46:28 +03:00