5e7ddc9f24
start refactor
2020-07-22 13:11:07 -07:00
c6d2a856dd
Merge pull request #1606 from mck1117/reset-overlap
...
reset overlap counter on fuel reschedule
2020-07-20 23:51:34 -04:00
27f346b0ff
make private
2020-07-20 18:50:48 -07:00
a6139c5c70
Merge remote-tracking branch 'upstream/master' into export-all-logicdata
2020-07-20 18:48:54 -07:00
b66b8f8542
test with fix
2020-07-20 18:47:08 -07:00
ea49647c1d
compensate for bug
2020-07-20 13:21:15 -07:00
66b9c3ebea
auto export all logicdata
2020-07-20 13:12:21 -07:00
1da7be3f67
impruv
2020-07-20 12:40:23 -07:00
a92a8ba262
Merge remote-tracking branch 'origin/master'
2020-07-20 14:25:47 -04:00
1e8a9862f1
unit test framework improvements for smoother event execution
2020-07-20 14:25:32 -04:00
d85e98d1f7
Merge pull request #1622 from mck1117/encapsulate-wwae
...
put wall wetting inside InjectionEvent
2020-07-20 14:19:57 -04:00
8dba21c702
Merge remote-tracking branch 'upstream/master' into test-1592
2020-07-20 10:54:18 -07:00
2a45c9cbe8
unit test framework improvements for smoother event execution
2020-07-20 12:45:26 -04:00
de66f4dc6e
unit test framework improvements for smoother event execution
2020-07-20 11:16:51 -04:00
9c736a2c3d
test
2020-07-20 03:29:43 -07:00
46b7567195
put wall wetting inside
2020-07-20 00:04:05 -07:00
b2edd3a4f4
logicdata into unit tests
2020-07-20 00:36:10 -04:00
d6464fffe7
fix ( #1620 )
2020-07-19 18:05:31 -04:00
46a1d361b5
unit tests: order of tests multispark/sensor tests should not matter #1616
...
TODO
2020-07-19 14:10:55 -04:00
f7a182c170
would this work?
2020-07-19 13:59:55 -04:00
dbd3eaf7a9
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:54:47 -04:00
c755dea256
would this work?
2020-07-19 13:50:43 -04:00
8bce289fac
would this work?
2020-07-19 13:45:42 -04:00
b67e9c9df6
would this work?
2020-07-19 13:33:02 -04:00
ded219ba78
Injectors #1 and #5 stick open #1592
...
two bytes of progress
2020-07-19 13:32:17 -04:00
33b21c8bcf
one step backwards to help build?
2020-07-19 13:26:46 -04:00
fdb455a004
Injectors #1 and #5 stick open #1592
...
starting somewhere
2020-07-19 13:13:25 -04:00
f2fd9decdd
better folder structure
2020-07-19 12:57:05 -04:00
ee6cb2c97a
correct batch fuel cylinder pairing ( #1595 )
...
* correct batch fuel cylinder pairing
* param
* only change behavior on two wire batch
* Add tests for two wire batch & sequential
* improve testing a little bit
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-07-13 14:46:55 -04:00
13aef2dd77
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
7735758ec5
PidIndustrial does not limit iTerm fix #1599
2020-07-11 15:30:40 -04:00
84ebfe301a
PidIndustrial does not limit iTerm #1599
...
confirming issue with a unit test
2020-07-11 15:19:27 -04:00
720ade2319
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
23e6ea5475
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
1e8bebd5b3
Gen config refactor 2 ( #1560 )
...
* gen_config refactor, part II
* short board defines
* oops
* comment & undef
* define QUOTE
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2020-07-02 12:33:31 -04:00
a83cef6934
idle_min through FSIO not working as intended #1553
2020-07-01 20:45:37 -04:00
31f01bf26b
1 byte issue in TuneReadWriteTest #1512
2020-06-18 22:51:07 -04:00
c8fb6993ac
simplify cranking corrections ( #1510 )
2020-06-18 08:54:02 -04:00
a34201d1d1
fuel math simplifications ( #1485 )
...
* simplify
* fix
* tweak
* cleaning
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-17 17:15:04 -04:00
fb5756fe3e
nope, unit tests did not just fix themselves
2020-06-17 08:42:37 -04:00
65625deb32
only setup etb if primary sensor configured instead of proxy ( #1489 )
...
* only setup etb if primary sensor configured instead of proxy
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
9016df654c
Trigger decoding issues (60-2) #1488
...
unit test refactoring
2020-06-15 00:11:02 -04:00
b906d12268
Fix gppwm properly ( #1487 )
...
* directly control output in onoff mode
* test fixing
2020-06-11 20:43:26 -04:00
76745412c6
Factor out airmass logic ( #1483 )
...
* refactor
* extract more airmass
* rename, fix tests
2020-06-06 07:25:19 -04:00
2bdd8128db
refactor ( #1481 )
2020-06-03 21:12:12 -04:00
105460dada
Remove old thermistor implementation ( #1458 )
...
* remove test clt/iat
* remove warning since this code is nearly dead
* remove old therm impl
* tests & live doc
* not quite right
2020-05-28 17:51:33 -04:00
bef53d8ba5
remove maf2map mode ( #1474 )
...
* remove
* remove fully
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 14:06:18 -04:00
0290a268ab
Redundant accelerator pedal ( #1470 )
...
* add second boudns
* init logic
* test changes
* reconfigure correctly
* rams
2020-05-23 19:48:32 -04:00
b11c5cd8c8
switch some firmware warnings to errors ( #1465 )
...
* warnings as errors
* throw instead of exit
* test massaging
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
f2cf1358c1
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:49:56 -04:00
f32e7c19f4
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:42:09 -04:00
695c8ddb03
Clean-up analog channels in "unit" tests #1456
2020-05-20 03:38:55 -04:00
9dda1a21bc
Redundant tps ( #1427 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* partial hookup
* fix
* fix
* bad makefile merge
* use second TPS config
* update test
* update test
* sensor names
* set second pin by default
* fix auto cal
* auto cal both sensors
* add reconfigure of secondary sensors
* gobblin' up your ram
* slow down write a little bit
* put split in debug gauge
* s
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
94e63e7c43
binary logging ( #1443 )
...
* field support
* tests
* makefiles
* test data too
* missing include dir
* write correct thing
* fix one test
* fix test
* omnomnomnom ram
* format
* use defined names
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-17 15:56:37 -04:00
afc763f068
better VVT progress
2020-05-15 21:33:25 -04:00
da4c7e1a2a
VVT_INACTIVE
2020-05-14 23:31:01 -04:00
e46d9f0c99
Fix 100% duty injection ( #1431 )
...
* skip turn-off for high duty
* mock executor injection
* test
* switch to hard cut
* test no longer relevant
2020-05-14 07:44:32 -04:00
1f692c4a9b
34-2 3 cam Toyota wheel progress
2020-05-10 18:03:11 -04:00
3f7ca92241
removing some unneeded flexibility
2020-05-10 02:06:15 -04:00
32ba492b48
34-2 3 cam Toyota wheel progress
2020-05-10 01:21:54 -04:00
ac9faf6646
docs & clean-up
2020-05-10 00:59:32 -04:00
e2974cfeda
short term fuel trim: part 2 ( #1405 )
...
* add tooltip
* add other direction to deadband
* add impl
* test partitioning
* makefile
* wrong comment
* fix include
2020-05-07 08:52:32 -04:00
aa3bf51723
short term fuel trim: part 1 ( #1402 )
...
* add cell
* add stft cell tests
* add bit
* minimally generate
* config defaults
2020-05-06 21:00:40 -04:00
74d13c391f
Rewrite boost control in new closed loop framework ( #1342 )
...
* rewrite boost
* test
* fix build
* tests
* open loop test
* test closed loop
* fix names
* typo
* tests
* mock boost setOutput
* needs more virtual
* fix boost logic
* switch to TPS based open loop
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
745b0c04ac
pull out std air charge math ( #1397 )
2020-05-05 08:01:40 -04:00
c39662b5c6
better state messages
2020-05-01 18:52:06 -04:00
d728b1ca48
Minor ETB improvements ( #1381 )
...
* fix pid reset and pedal failure
* pause control later
* test pauseEtbControl
* update tooltip + field name
* update test
2020-04-28 16:52:40 -04:00
fe4b531aeb
Move ETB control to a thread ( #1374 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* fix dt
* re-resize ram
2020-04-28 07:22:31 -04:00
6bd5cd1112
fixing build
2020-04-26 20:40:06 -04:00
f128b33694
General purpose PWM: implementation & tests ( #1366 )
...
* config
* significant digits
* renumber enum, no need for a "none"
* ui
* impl base
* error handle MAP
* init & update
* don't need arg
* don't lie about sensor
* fix test build
* test stub
* initialize
* null check
* fix clamping
* test output
* types & enums
* don't need param
* test getOutput
* fix
* output pin instead of brain pin
* default config
2020-04-26 14:06:28 -04:00
a444e09ff8
etb CL test ( #1361 )
2020-04-24 17:54:03 -04:00
99489cff67
Improve ETB idle control ( #1319 )
...
* compress idle pos
* fix tests for new behavior
2020-04-20 17:29:03 -04:00
1a5e0a42f8
Inject idle to ETB ( #1335 )
...
* inject idle position
* pointer
* etb idle tests
* extract mocks
* ops
* test negative case too
* don't convert for etb
* guard
2020-04-20 16:26:35 -04:00
e04008610a
ETB: inject pedal map ( #1334 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
* inject pedal map
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
0619575716
ETB testing: output, position clamping ( #1333 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
8aac233a5f
rewrite etb tests with gmock ( #1330 )
2020-04-19 20:32:41 -04:00
75b009bbae
Closed loop controller base & ETB testing ( #1322 )
...
* closed loop controller base
* etb tps test
* closed loop controller tests
* test support
* update gtest
* fix for change
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 17:18:47 -04:00
0d699bcfe9
Improve unexpected ( #1323 )
...
* use type instead of value
* fix remaining initializer-list users
* impruv
* last consumer?
* consumer
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 08:37:43 -04:00
7f60384c75
add expected helper class ( #1321 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-19 01:53:04 -04:00
c5a0da2db7
consistency
2020-04-18 22:46:22 -04:00
4d24fdd57d
Fuel/ign correctino on new temp sensors ( #1318 )
...
* corrections
* test
* adv map
* tests
* cleanup
* lcd
* fsio
* unneeded
* more math
* last consumer
* cleanup
* fix kinetis
2020-04-18 18:45:30 -04:00
bc15e0826d
CLT consumer: fsio ( #1302 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
* fsio test help
2020-04-15 16:20:45 -04:00
044766ec70
New clt consumers part 1 ( #1301 )
...
* idle
* CLT test prep
* idle target
* header
* air interpolate
* ancient comment
* fuel cut
* fuel cut, idle tests
* cleanup
2020-04-15 09:48:17 -04:00
697055bd9f
fixing master
2020-04-14 12:55:39 -04:00
e1301f3c47
fix maf ( #1287 )
2020-04-12 15:52:29 -04:00
8006c0a548
CLT/IAT/Aux in the new sensor world ( #1269 )
...
* hook up clt
* init test
* probably fix test
* aux temp
* relax checking
* more significant figures
* remove old aux temp
* hand generate
* claim RAM
* move to ccm
* subscribe
* info printing
* warnings
* raise high voltage failure threshold
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-07 16:07:09 -04:00
200bfe3f80
Deadband helper & tests ( #1267 )
...
* deadband
* header
* comment
2020-04-06 09:16:26 -04:00
595df15dfd
fix ( #1268 )
2020-04-06 09:00:26 -04:00
345bf61bd5
Goodbye, old TPS ( #1266 )
...
* clear out tps
* boost control
* aux valves
* launch, aux valves
* unused field
2020-04-05 19:33:33 -04:00
7d5df29fbd
yet more tps consumers ( #1258 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
* old tests
* kill dead stuff
* cleanup
* more
* fix
* test
* s
* fix signature
* fix test
* comment
* priming pulse
* remove mock tps
* remove more dead
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-05 09:11:25 -04:00
3186741ddc
TPS Initialization Testing ( #1264 )
...
* test support
* stub for tests
* plumbing so we can test this
* add test
* comments
2020-04-05 09:10:08 -04:00
bc3f0c6b27
More TPS consumers: VE lookup ( #1256 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
* engine load
* ve lookup
* unused
* oops we needed that
* oops needed that too
* mocking
* test mocks
* oops
* helps to use the right sensor
* and cylinder cleanup
* fuel math
* typo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-04 08:41:09 -04:00
9f75c0cea6
TPS consumers: idle and ignition and obd2 and lcd ( #1254 )
...
* advance_map
* tests
* unneeded
* idle
* use driver intent instead
* and obd and lcd
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-03 19:59:08 -04:00
b197c6ff07
run ETB on new TPS ( #1248 )
...
* run ETB on new TPS
* why did we include all those...?
* init tps for etb test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 21:33:49 -04:00
ea4cfa9046
E30 M3 Tach output solution #907 ( #1203 )
...
* Update tachometer.cpp
Initial implementation of E30 M3 Tach output solution #907 , unit_test plus debugging next
* tacho unit tests
First successfull unit test for tachometer
* RAM adjustment so it would link
* refactoring tacho, broken!
* starting to make some progress...still fails after a few seconds
* Rework with SW PWM
* Update after code review
* unit_test update
* First working unit_test
* Update .gitignore
* Update engine_controller.cpp
* Update engine_controller.cpp
* Update tachometer.h
* Update test_tacho.cpp
Co-authored-by: rusefi <rusefi@users.noreply.github.com>
2020-04-02 15:20:04 -04:00
b015ec5944
Add redundant sensor ( #1249 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* casing
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:55:21 -04:00
22267e5479
Replace hasPedalPositionSensor ( #1245 )
...
* remove
* add Sensor::hasSensor
* consume in etb
* remove unused state
* don't use it there either
* format
* fix up tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-02 08:04:12 -04:00
a47dce4025
code style
2020-04-01 21:32:21 -04:00
50cd6549a2
Fully switch acc pedal to new sensors ( #1212 )
...
* proxy sensor
* header
* idle
* can
* settings
* remove old mocking
* remove old impl
* etb
* oops, gotta actually register it
* fix test
* structured bindings ftw!
* driver intent for stepper
* tear out old
* oops too much
2020-04-01 20:21:03 -04:00
483d4a2204
Debuggability in the new sensor world ( #1238 )
...
* rename to avoid conflict
* fix efilib
* add sensor printing
* makefile
* that check was already there
* const
* const
* fix tests
* formatting
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-30 18:29:42 -04:00
53679fab54
Finally rename injector_central to bench_test ( #1229 )
...
* bench test rename
* rename consumers
* good lord what are all of these externs doing
* fix tests
2020-03-26 08:03:55 -04:00
a5d4d06868
Multispark implementation ( #1192 )
...
* multispark prototype
* only multispark if not cut
* typo
* do some reasonableish math
* consume cfg
* todo
* bad merge
* move math out of engine2.cpp
* engine state config
* consume generated
* use new
* hand generate
* doc, debugging
* debug channel names
* don't depend on rpmcalc
* safer, fix math
* tests
* default multispark config
* remove todo
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-03-26 01:49:36 -04:00
1955af0b6c
random code inspired by Ola
2020-03-24 19:50:04 -04:00
d5600995e2
fix ( #1202 )
...
* fix test
* shrink memory
2020-03-19 20:02:49 -04:00
a33d479683
CLT stops working when using 2-0 custom trigger wheel #1171
2020-03-06 01:31:04 -05:00
40b0783205
Split out EtbHardware ( #1168 )
...
* start tear out motor
* fix
* nuke reconfig
* guard for test
* test fixing
* format, condense headers
* fix todos
* undo todo
* format
2020-03-03 17:56:50 -05:00
04a4e2bca3
ETB: expand automated testing #115
2020-02-22 23:18:02 -05:00
e9a3b218c4
miata vvt trigger decoding is broken #1145
2020-02-14 13:02:27 -05:00
a2c4b36edc
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:51:26 -05:00
ed2b7578a5
Merge remote-tracking branch 'remotes/origin/2019.12.25_release_1.19.12_xmas'
2020-02-14 10:50:50 -05:00
243a532f84
miata vvt trigger decoding is broken #1145
2020-02-14 10:49:22 -05:00
9790052596
miata vvt trigger decoding is broken #1145
2020-02-14 09:33:29 -05:00
75d9417131
miata vvt trigger decoding is broken #1145
2020-02-14 00:37:36 -05:00
4e8f9f0d30
cam/vvt decoder test progress
2020-02-05 01:08:39 -05:00
c7dce2e38b
Rescale TPS ( #1112 )
...
* fake adc ticks
* consumers
* fix test 1
* fix tests
2020-02-01 16:41:07 -05:00
d63dae9301
this test is even better now!
2020-01-31 13:45:15 -05:00
f6e7e8871a
VVT refactoring & assertions for VVT test
2020-01-31 01:49:10 -05:00
b6e0bc7ed1
date & VVT test progress
2020-01-31 01:23:01 -05:00
b6fe6555e0
lovely tiny bug which mostly affects NB2 with an impossible one tooth crank trigger wheel
2020-01-30 01:47:34 -05:00
d9b96fe509
extracting class & codes clean-up
2020-01-28 00:16:33 -05:00
282cd8e1ac
trigger refactoring
2020-01-26 14:20:55 -05:00
51ab9f5b57
reducing code duplication
2020-01-26 06:28:33 -05:00
db2ab72d12
refactoring trigger
2020-01-26 03:33:45 -05:00
9d0c5540d8
refactoring
2020-01-22 00:40:26 -05:00
bb217b01dd
happy new year unification
2020-01-13 21:57:43 -05:00
0bab01369a
refactoring: no need to specify parameter manually
2020-01-12 10:43:02 -05:00
d3d088676b
Add timeout + raw value access for sensors ( #1098 )
...
* timeout
* inject stamp
* allow getting raw value
* plumb timeout
* fix tests
2020-01-12 03:25:23 -05:00
645f51a038
better method names
2020-01-10 23:17:58 -05:00
851c6041b1
Inject timestamps in to hwHandleShaftSignal ( #1090 )
...
* injection
* injectors
2020-01-09 21:19:11 +03:00
b83a5310be
happy new year
2020-01-08 00:02:40 -05:00
95a7a9a8e1
Strongly typed action constructor ( #1087 )
...
* strong typing
* maybe we needed that one
2020-01-07 18:10:31 -05:00
5c85d53e16
Pass action_s instead of callback/param ( #1084 )
...
* change action
* consumers
* fix test
* didn't mean to add those
* simplify
* fix simulator
* fix sim for real
* oy
* maybe this time the simulator will actually be fixed, for real
* don't rely on undefined behavior
2020-01-07 00:41:18 -05:00
cb9fc19f92
that's not a worth a file
2019-12-24 00:03:53 -05:00
b9454790c7
Add new sensor function types ( #1065 )
...
* add functions
* add tests
* add chain tests
* float suffix
2019-12-17 09:06:29 -05:00
bd1bcccc19
this stuff is pretty dead
2019-12-15 21:59:25 -05:00
aa1b7e2c6b
and finally a unit test, like it shoud be!
2019-12-13 14:55:20 -05:00
236d952335
progress towards ETB controller mocking
2019-12-13 13:52:34 -05:00
af4f20551b
getting rid of boardConfiguration / binary compatible change
2019-12-11 17:48:55 -05:00
05ab778396
clean-up
2019-12-10 01:03:02 -05:00
1cc71ef8ec
dual-ETB progress
2019-12-10 00:07:46 -05:00
c5cfd21a70
just a trivial massive rename: TriggerState > TriggerWaveform
2019-12-08 01:09:39 -05:00
d6471a84bc
Refactor Trigger System #635
...
injecting callback via parameters instead of nasty "bool isInitializingTrigger" field
2019-12-06 01:57:11 -05:00
717abd6b67
Refactor Trigger System #635
...
injecting callback via parameters via magic and potentially broken field manipulation
2019-12-06 01:05:19 -05:00
813b6aa6ce
The Big Refactoring of 2019: folder structure #723
2019-12-04 01:11:10 -05:00
eb305f0265
#490
2019-12-03 00:29:12 -05:00
955b2b5c3f
misc clean-up
2019-12-02 13:53:31 -05:00
4dafc65d69
misc clean-up
2019-12-02 10:18:13 -05:00
0b4f624b2a
cj125 unit test progress!
2019-12-02 01:52:54 -05:00
1808642af1
Starter relay + Hardcoded 'FSIO' + simulator fix ( #1032 )
...
* Starter Relay: gui + built-in FSIO impl.
* Hardcoded 'FSIO' replacement for RAM-limited boards
* fix simulator
2019-11-25 20:08:01 -05:00
1cb2f92142
more correct variable names
2019-11-23 23:49:39 -05:00
7ee657d238
aux valves unit test
2019-11-23 22:55:21 -05:00
ab744af14b
header cleanup
2019-11-23 21:41:17 -05:00
af60a46229
making progres on angle-based scheduling
2019-11-23 20:36:40 -05:00
7b7b46a2a2
refactoring
2019-11-23 18:38:16 -05:00
f0c4817e1b
'triggerEventAngle' not really needed
2019-11-23 17:44:44 -05:00
aa4967383a
explicit list field to simplify code navigation
2019-11-23 17:04:51 -05:00
9ee8616cb0
Use templated array references ( #1027 )
...
* update defs
* consumers, use default params
* setArrayValues in tests
* floats
* test fixing
2019-11-22 23:27:24 -05:00
6c012ba0e4
v12
2019-11-18 23:54:08 -05:00
ebe6a4b981
v12 done right
2019-11-17 09:32:12 -05:00
fb7cba96b6
code formatting
2019-11-17 09:03:20 -05:00
25298e2392
32 bit vs 64 bit compiler challenge for floats in unit tests
2019-11-10 13:57:27 -05:00
b996190707
Industrial PID Controller ( #1002 )
...
* Implement Industrial PID controller
* Test-Use PidIndustrial in alternator
* Meaningful unit-tests for PidIndustrial
2019-11-10 13:04:27 -05:00
df291f4421
Missing dwell altogether in some corner cases fix #796
2019-11-06 00:31:24 -05:00
c9552f29bb
Missing dwell altogether in some corner cases #796
...
getting closer!
2019-11-06 00:01:08 -05:00
10a6d6eb8b
fix wwae ( #980 )
2019-10-17 00:06:54 -04:00
88c8363f82
I guess we can simply change the magic number
2019-10-16 23:02:37 -04:00
344136eea9
preparing for #973
2019-10-16 22:10:38 -04:00
f9fb4143a5
preparing for #973
...
wall wetting was not covered by any unit test?!
2019-10-16 16:46:34 -04:00
96f432fb4c
Coil duty cycle ignores dwell #977
2019-10-15 05:30:38 -04:00
938d7739a6
Coil duty cycle ignores dwell #977
...
test-driven is the way to go
2019-10-15 05:16:30 -04:00
12137fc7cd
preparing for #974
...
code comments & refactoring
2019-10-14 06:18:08 -04:00
5cb90d0e1b
preparation for #961
...
more unified access to pre-calculated value
2019-10-13 09:59:06 -04:00
ca6e49dcbc
preparation for #961
...
macro as a syntax sugar for method invocation
2019-10-10 07:28:52 -04:00
4574aaccce
I got carried away, but DEAD CODE?!
2019-10-08 03:14:21 -04:00
fbbf8995e4
wow, dead field
2019-10-08 02:17:32 -04:00
2b59940161
really not clear what is the best place for these classes
2019-10-08 02:13:52 -04:00
1ab488e4b4
refactoring: better field name(s)
2019-10-08 01:03:57 -04:00
ca67249522
refactoring: better field name
2019-10-08 00:54:19 -04:00
fdfd2244ce
One cylinder, 4 stroke, only crank sensor needs special wasted_mode spark control #968
...
just a unit test for now
2019-10-07 23:12:29 -04:00
e6f5a6e3f4
refactoring: all events are now validated in relation to current timestamp
2019-10-07 23:02:47 -04:00
0380d4d709
refactoring
2019-10-07 21:54:03 -04:00
d1da567b85
fix gm 24x decoder ( #963 )
...
* fix gm
* fix
* fix default config, tests
2019-10-05 08:27:30 -04:00
faa2a481ea
Simplify thermistor config ( #962 )
...
* simplify thermistor config
* fix test
2019-10-02 21:00:10 -04:00
7f9e912ea4
pid limits / etb limits
2019-09-29 14:56:18 -04:00
3201df7fbe
extracting pid test to separate file
2019-09-29 14:36:41 -04:00
4db887361c
Fix sensor mock spill, again ( #957 )
...
* actually reset
* add test
* doh
2019-09-27 21:40:36 -04:00
dfd5b11c8f
Revert "Fix sensor mocking bug ( #956 )"
...
This reverts commit 217081c1
2019-09-27 20:33:45 -04:00
217081c174
Fix sensor mocking bug ( #956 )
...
* actually reset
* add test
2019-09-27 20:21:50 -04:00
92ee072687
reducing copy/paste in unit tests
2019-09-25 09:09:32 -04:00
45ca9d19bf
reducing copy/paste in unit tests
2019-09-25 08:55:18 -04:00
3da60a406a
Merge branch 'master' of https://github.com/rusefi/rusefi
2019-09-25 08:40:56 -04:00
bc572bef51
reducing hell in unit tests
2019-09-25 08:40:33 -04:00
ee5643f1bf
Hmm, that didn't quite work right ( #955 )
...
* maybe that wasn't a good idea
* we don't need a copy because you can't clear the func after setting it
* no longer a template - move logic to cpp
* fix tests
* rename to avoid object collision
2019-09-25 07:26:56 -04:00
3bd1ddcc1f
Sensors: composition >> inheritance ( #953 )
...
* functional sensors
* format
* tests
* sim makefile
* eol
* format tests
2019-09-24 21:11:41 -04:00
567bd7dd58
absolute fuel pressure flow calculation #954
2019-09-24 18:39:26 -04:00
4f33dff0a1
ETB target is using integer values fix #945
2019-09-22 18:15:00 -04:00
e7b658547b
ETB target is using integer values #945
...
now we have a unit test! now we can fix the issue :)
2019-09-22 17:58:27 -04:00
533087f475
ETB target is using integer values #945
...
refactoring - ADC mocking is a mess
2019-09-22 09:56:06 -04:00
9b98446846
ETB target is using integer values #945
...
first we will write a unit test
2019-09-22 07:58:03 -04:00
f629ec038b
add sensor framework, tests ( #929 )
...
* add framework, tests
* move oil pressure to new way
* add init logic
* brackets on the same line
* spaces -> tabs
* spaces -> tabs for tests
* bracket on same line
* hook up sensor mocking
* add nan check
* fix nan check
* I wrote an essay
* casing
* only init if we have a sensor to init
* style, actually call init
* format
* fix casing
* typo
* implement linear sensor
* wire up producer
* smarter limiting
* setup comments
* add reporting
* doxyfile
* oops
* add adc subscription
* clarity
* fix logic
* multiply voltage
* test styling
* test guards
* remove dependencies
* linear sensor test
* remove unused
* fix merge
* format, implicit convert op
* explicit
* format tests
* fix merge
2019-09-21 14:33:38 -04:00
a72d2834fb
unit tests progress
2019-09-20 00:46:35 -04:00
87875d8825
unit tests progress
2019-09-20 00:34:42 -04:00
154092bbf5
unit tests progress
2019-09-19 22:56:54 -04:00
c59d8164c6
unit tests progress
2019-09-19 21:41:52 -04:00
bda089011c
unit tests progress
2019-09-19 08:05:23 -04:00
f48f60bb36
unit tests progress
2019-09-18 21:48:46 -04:00
dfc0743e9a
Delayed A/C compressor switch #922
...
unit tests skeleton
2019-09-12 07:31:13 -04:00
2349ea237a
Delayed A/C compressor switch #922
2019-09-11 19:30:36 -04:00
2804b31e7e
cranking fuel live data #911
2019-08-26 23:41:04 -04:00
c3d9330696
unit_tests are failing under 32 bit mingw-w64 fix #905
2019-08-25 17:38:08 -04:00
9161703598
reducing unit test noise
2019-08-25 02:01:09 -04:00
eedf2dffcb
reducing unit test noise
2019-08-25 01:19:23 -04:00
ee41d37c08
code style/type safety/docs/typos
2019-08-10 11:13:41 -04:00
f0c318aafd
WTF is wrong with MRE_miata_na6 config? operationMode complexity fix #898
2019-08-08 23:11:56 -04:00
e0acec2a63
WTF is wrong with MRE_miata_na6 config? operationMode complexity #898
...
fatal error is the best I can come up with quickly
2019-08-08 22:57:22 -04:00
539cd8b1c7
current toolchain does not work great with current rusEfi code, two methods with same name are hard for full text search :(
2019-08-08 22:33:52 -04:00
121ad9b786
fixing build & taking a safer route
2019-08-08 22:12:51 -04:00
7d73c6a8a9
WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
...
fancy smansy unit test with some C++11
2019-08-08 21:27:57 -04:00
643cc24931
WFT is wrong with MRE_miata_na6 config? operationMode complexity #898
...
more refactoring
2019-08-08 00:32:31 -04:00
f8a3d900dc
migrating to google test
2019-07-25 00:28:04 -04:00
4210754280
removing least useful engine configurations
2019-07-25 00:18:39 -04:00
358a50a961
setDefaultBoardConfiguration shouldn't have Frankenso pinout #852
2019-07-24 22:33:30 -04:00
aca4081507
FIRMWARE_ID
2019-07-13 14:08:08 -04:00
7cc040afe0
better variable names & fixing build
2019-07-13 08:19:00 -04:00
04bc1128df
support multiple VVT sensors #885
...
new fields & packing configuration. bumping configuration version
2019-07-12 14:24:45 -04:00
77075fce3d
Fix some maf logic ( #880 )
...
* fix maf
* thank you vscode for mangling ANSI -> utf8
2019-07-10 09:14:47 +03:00
452455fc99
Missing dwell altogether in some corner cases #796
...
skeleton
2019-07-01 15:04:39 -04:00
37a9e66bc1
Annotations in C++ code to produce formulas in rusEfi console #807
2019-06-19 22:34:11 -04:00
9b1d57adf6
I like static_cast
2019-06-17 10:22:43 -04:00
e76706332a
Annotations in C++ code to produce formulas in rusEfi console #807
2019-06-15 17:32:11 -04:00
47a3577e27
MK clean-up
2019-06-15 16:43:30 -04:00
e47bc4b952
Fix tunerstudio ratio vs. percent ( #838 )
...
* fix ratio vs pct
* fix idle cranking clt position
* fix defaults
* fix typo
* fix baro corr gauge
* baro default
* fix degree symbols
* fix testFuelMap
* fix testPlainCrankingWithoutAdvancedFeatures
* test testFasterEngineSpinningUp
2019-06-13 09:05:22 -04:00
3327cf8b4e
progress & fixinig unit tests
2019-06-01 09:11:01 -04:00
886a88bad3
fix #799
2019-05-27 16:12:59 -04:00
5f642ac254
unit tests should not have global context, including mock values
2019-05-27 15:56:12 -04:00
31faecf491
#799 unit test first
2019-05-27 14:55:35 -04:00
7b36fc951f
messing with TPS mocking
2019-05-27 14:21:12 -04:00
266f8b5176
Multiple sync pattern for faster cranking #679
2019-05-14 19:24:18 -04:00
742e532f51
progress
2019-05-12 20:45:02 -04:00
b11924952a
more PROD code into unit test
2019-05-12 20:31:28 -04:00
f3349f3163
Multiple sync pattern for faster cranking #679
...
unit test for current status
2019-05-12 19:58:15 -04:00
812c61903a
BUG: phase sensor validation attending - detect missing CAM signal fix #659
2019-05-11 00:21:37 -04:00
ff1d10dd2e
BUG: phase sensor validation attending - detect missing CAM signal #659
...
preparation
2019-05-10 23:52:55 -04:00
1c9a9d35a6
BUG: phase sensor validation attending - detect missing CAM signal #659
2019-05-10 23:20:42 -04:00
9d0462897f
Trigger: warning code on normal engine start up #669
2019-05-10 23:12:36 -04:00
04afb87610
Trigger: warning code on normal engine start up #669
...
avoiding CUSTOM_OBD_SKIPPED_FUEL fot triggers without synchronizaiton
2019-05-10 22:55:08 -04:00
c6198e34ec
BUG: phase sensor validation attending - detect missing CAM signal #659
...
refactoring and unit test first phase
2019-05-10 21:56:33 -04:00
4e61505620
refactoring unit test
2019-05-10 21:29:17 -04:00
5f70acab9f
Injection/Ignition angle inaccuracy on 60-2? EngineSniffer vs Real Hardware #778
...
only renaming methods
2019-05-07 17:10:47 -04:00
1350a94715
Saab CDM knock signal integration #647
2019-05-05 18:53:34 -04:00
70d01ccfe2
adjusting test due to e27f5d36f6
2019-05-04 23:24:19 -04:00
ac2a81d381
The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
...
maybe probably pointless refactoring? reducing parameters visibility
2019-05-03 18:41:43 -04:00
bc86783b45
TPS/TPS logging delta TPS not consistent with actual logic fix #768
2019-04-20 17:34:23 -04:00
d61c61d95c
random cleanup
2019-04-14 15:16:44 -04:00
ae711e3a52
smarter PWM API - need to pass arbitrary pointer
2019-04-12 20:35:02 -04:00
a122451301
unit test compilation fix under linux ( #747 )
2019-04-12 22:08:52 +02:00
be926cb792
reviving unit tests. too bad unit tests are coupled with cranking base fuel values :(
2019-04-04 09:17:12 -04:00
be9651cb95
The Big Refactoring of 2019: folder structure #723
2019-03-31 17:44:34 -04:00
372eb51f37
The Big Refactoring of 2019: folder structure #723
2019-03-31 17:14:53 -04:00
bd2b992918
unifying_file_naming
2019-03-29 09:11:13 -04:00
4b5ed3e0e1
Tps-accel. fractional mode ( #715 )
...
* Add new config settings for tps_accel_fractional_mode
* Add new variables for the fractional algo
* Add resetFractionValues() method
* Call onEngineCycleTps() and fix onEngineCycle()
* Implement the fractional algo
* More debug outputs for tps-enrich
* Nice & juicy unit-test!
2019-03-28 22:47:20 -04:00
984fc12f73
Idle timing PID control & TPS-based VE table ( #713 )
...
* Add new config settings for idleTimingPidControl & TPSBasedVeTable
* Add dialogs for idleTimingPidControl settings
* Add dialogs for TPSBasedVeTable settings
* Share the code for getTargetRpmForIdleCorrection() and move it from idle_thread.cpp
* Implement TPSBasedVeTable
* Add PID to advance_map.cpp
* Implement idleTimingPidControl
* Make getAdvanceCorrections() visible to unit-tests
* Unit-tests! Yeah!
2019-03-22 22:55:51 -04:00
653a735eab
refactoring: no logic changes, just nicer variable and method names
2019-03-12 18:54:46 -04:00
70ebc06517
gpiochips API, core and unit test ( #703 )
...
* Add external gpiochips driver API and core
* gpiochips: add unit test
2019-03-12 10:12:37 -04:00
e7e729c7cf
#699
2019-02-28 21:17:35 -05:00
cf8ddde1ce
#699
2019-02-28 21:09:31 -05:00
ec6bde7c26
#699
...
more googletest to unit tests
2019-02-28 20:31:48 -05:00
d1753b4860
#699
2019-02-28 19:48:38 -05:00
5813168e30
#699
2019-02-28 19:42:15 -05:00
9325cd6d23
better (?) variable names
2019-02-10 22:47:49 -05:00
17691227d5
Fix dwell default, improve TS field names ( #689 )
...
* improve message
* clarify cranking dwell settings
* change default
* fix unit test that made assumption
2019-02-07 07:44:07 -05:00
d2677290af
Multiple sync pattern for faster cranking #679
2019-02-03 21:19:47 -05:00
2a0d5e4749
Multiple sync pattern for faster cranking #679
2019-02-03 00:50:10 -05:00
e9a1341782
CJ125 unit-tests coverage #617
2019-02-02 01:06:45 -05:00
2b852ea48e
CJ125 unit-tests coverage #617
2019-02-01 23:48:11 -05:00
3b5a07c9d6
CJ125 unit-tests coverage #617
2019-02-01 23:16:34 -05:00
9a3441f11b
#657 pulling global access down
2019-01-28 00:44:30 -05:00
af518d7978
#657
2019-01-27 23:41:46 -05:00
14199080b1
Trigger rabbit hole ( #682 )
...
fix #681
* this did not work right
* progress: spinning is detected sooner now
* and now things are much better?
* and now reducing RAM usage
2019-01-24 21:12:55 -05:00
f7a2cc9e63
state validation progress
2019-01-22 23:15:33 -05:00
34e97c5d8e
unit tests framework fix
2019-01-22 23:09:34 -05:00
6f0c0fcf68
something is not right here :(
2019-01-21 22:45:37 -05:00
358af4ff89
testing API improvement (?)
2019-01-21 22:34:17 -05:00
d15399bba4
refactoring around GET_RPM
2019-01-21 22:32:30 -05:00
53b5c08c0a
refactoring around GET_RPM
2019-01-21 21:48:58 -05:00
7a20bda66f
refactoring around GET_RPM
2019-01-21 20:33:21 -05:00
1b8217392c
micro test refactoring
2019-01-21 19:15:17 -05:00
7e909205b6
tiny spinning progress
2019-01-21 15:34:39 -05:00
3697fc6052
future fast spinning 60/2 test
2019-01-20 22:21:12 -05:00
28bde6f084
better method name and docs related to improved craking logic
2019-01-20 11:33:40 -05:00
5b18f9f360
FSIO testability and test-driven development
2019-01-19 22:09:37 -05:00
082e7d268d
tests: reducing code duplication
2019-01-19 20:42:29 -05:00
ba3ebfb477
tests: moving away from global timeNowUs
2019-01-19 20:34:28 -05:00
beb84cfff9
#538
2019-01-19 20:29:10 -05:00
78f4a68d3a
#674 fix?
2019-01-19 19:45:35 -05:00
d299d02240
#35 progress
2019-01-19 11:28:37 -05:00
8b66bdc86b
#35 unit tests
2019-01-19 09:40:39 -05:00
c6f19d77be
#35 unit tests
2019-01-19 09:14:48 -05:00
82131d590c
microprogress
2019-01-17 22:59:17 -05:00
e4234bc004
trying ideas about testability
2019-01-17 00:24:41 -05:00
c852686f00
fixing typo
2019-01-16 23:36:38 -05:00
a8b3c8f8d2
refactoring: better location for shared methods
2019-01-15 21:36:13 -05:00
f18349cd68
migrating to googletest
2019-01-14 19:02:36 -05:00
481fa81071
migrating to googletest
2019-01-14 18:56:32 -05:00
38ed23c43f
migrating to googletest
2019-01-14 18:38:20 -05:00
473f67e907
migrating to googletest
2019-01-14 18:22:31 -05:00
9d1fc30857
migrating to googletest
2019-01-14 18:20:20 -05:00
6c62f2e25f
migrating to googletest
2019-01-14 18:00:59 -05:00
05181cd837
migrating to googletest
2019-01-14 17:44:03 -05:00
4c9de98100
migrating to googletest
2019-01-14 15:48:47 -05:00
4b95e5f124
migrating to googletest
2019-01-14 15:45:35 -05:00
cc300145b3
migrating to googletest
2019-01-14 15:37:05 -05:00
73aa22573e
migrating to googletest
2019-01-14 15:31:56 -05:00
1d1f1225f9
Trigger: Question: something strange trigger errors #662
...
undoing unplanned change
2019-01-14 08:59:50 -05:00
4b72599e2f
Trigger: Question: something strange trigger errors #662
...
hopefully CUSTOM_ERR_START_STACK fix
2019-01-14 08:57:08 -05:00
2bbc5feef4
minor improvement
2019-01-14 00:21:08 -05:00
c459020fdd
minor clean-up
2019-01-13 23:05:03 -05:00
5a0079cc6b
BUG: phase sensor validation attending #659
...
future test would live here
2019-01-13 22:52:22 -05:00
7d14bb6d57
migrating to googletest
2019-01-13 22:34:36 -05:00
1f410ad7cc
migrating to googletest
2019-01-13 22:15:21 -05:00
2e1d552396
MAF2MAP convestion #538
2019-01-13 01:53:58 -05:00
f70f9a0559
docs & unit test refactoring
2019-01-12 22:24:29 -05:00
85a4307d04
Question: something strange trigger errors #662
...
unit test progress
2019-01-12 21:36:50 -05:00
d69e796c37
Question: something strange trigger errors #662
...
unit test progress
2019-01-12 15:51:40 -05:00
3ca1c5360f
Question: something strange trigger errors #662
...
reducing warnings in unit tests
2019-01-12 15:32:40 -05:00
9ab1fa069f
cyclic_buffer.contains method
2019-01-12 14:01:13 -05:00
b7917800c8
making warning codes more unit testable
2019-01-12 08:34:38 -05:00
5301037f61
new unit test
2019-01-11 19:08:15 -05:00
d47afe0524
better field name
2019-01-11 01:18:35 -05:00
255f85e707
tests refactoring
2019-01-11 01:09:16 -05:00
cee7726960
random test refactoring
2019-01-10 23:39:41 -05:00
817eb74732
random test refactoring
2019-01-10 23:39:14 -05:00
704e7112f4
random test refactoring
2019-01-10 23:33:50 -05:00
e7ee023d2d
reducing global variables in tests
2019-01-10 23:24:36 -05:00
1defa2551e
reducing global variables in tests
2019-01-10 23:15:24 -05:00
7453e5ce5f
reducing global variables in tests
2019-01-10 23:09:56 -05:00
b43237b44b
reducing global variables in tests
2019-01-10 22:43:31 -05:00
34cfdfd718
reducing global variables in tests
2019-01-10 21:50:13 -05:00
a32e8a3530
reducing global variables in tests
2019-01-10 21:26:02 -05:00
8a2494a646
reducing global variables in tests
2019-01-10 21:19:46 -05:00
3921d36540
The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
2019-01-10 21:10:46 -05:00
dd8e2d9326
The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
2019-01-10 19:25:07 -05:00
cbd2d69731
The Big Refactoring of 2019: DECLARE_ENGINE_PARAMETER_SUFFIX consistency and simplification #657
2019-01-09 22:57:33 -05:00
fd9506b4e1
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 20:06:41 -05:00
02ac3d14c7
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 20:00:21 -05:00
bb2132e2c9
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 19:57:12 -05:00
38b5ae5b66
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 19:52:01 -05:00
b3ee5ec945
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 16:42:34 -05:00
da3d230798
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 16:30:14 -05:00
5e896ce279
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 10:36:35 -05:00
def54ae1ea
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 10:17:35 -05:00
970d120a41
The Big Refactoring of 2019: scheduler should not be global #655
2019-01-09 08:50:51 -05:00
f68cb90e6c
gtest
2019-01-08 22:10:54 -05:00
60e747481f
#35 first unit test with a mock!
2019-01-08 01:20:18 -05:00
778c1968e7
#35 refactoring towards making class testable
2019-01-08 00:28:53 -05:00
21c2695c93
#35 refactoring towards making class testable
2019-01-07 23:55:56 -05:00
c51af79731
#35
2019-01-07 23:23:50 -05:00
970855df56
new test style
2019-01-06 07:37:12 -05:00
aced64810f
better folder structure
2019-01-05 21:49:47 -05:00
Matthew Kennedy
rusefillc
rusefi
andreika-git
shadowm60
rusEfi
dron0gus
rusefi
rusefi