Commit Graph

494 Commits

Author SHA1 Message Date
rusefillc f35cd62b7c better code guard? 2023-05-24 11:12:00 -04:00
Matthew Kennedy 40673ffda2 add ignition/injection mode output channel #85
(cherry picked from commit 9621ff844eea704421dc6172d66a2f4053467277)
2023-05-04 18:58:50 -04:00
Matthew Kennedy d897a96c05 is this just dead?
(cherry picked from commit cd6b770945aa56ae52e188476034a862cba47bb0)
2023-04-29 01:08:14 -04:00
Andrey 51d0f6e347 it's going to be painful 2023-04-29 00:44:00 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
Andrey f296e30fb5 it's going to be painful 2023-04-28 21:01:08 -04:00
Matthew Kennedy 2857e9527d remove specs_s struct, flatten config
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
Matthew Kennedy d488ed5858 function >>> macro
(cherry picked from commit 489d016682d1c3eb4eb707cd1686686e40175dcd)
2023-04-28 20:27:12 -04:00
Andrey b95353cc12 logging of live data structs was: data points, we are moving away from debug mode #3614 2023-04-12 17:31:00 -04:00
Andrey 0470953cb8 We need to reshuffle timing calculation a bit, add one more gauge #5235 2023-04-12 17:22:28 -04:00
Andrey 32b7b014c9 per-cylinder should not contain firingOrderOffset fix #5236 2023-04-12 15:18:29 -04:00
Andrey 588bf77492 wow we have two separate per-cylinder trims?! fix #5237
refactoring: bringing two offsets much closer together, no change in overall logic
2023-04-12 15:04:14 -04:00
rusefillc deaee9ceae Ignition Knock response logging progress 2023-04-11 10:54:10 -04:00
GitHub gen-configs Action 883084ab9f Auto-generated configs and docs 2023-04-11 14:45:16 +00:00
rusefillc b629d5b064 Ignition Knock response logging progress 2023-04-11 10:43:34 -04:00
Andreika 919ed2d934
RPM soft limit and hysteresis #5214, #5224 (#5228)
* [DRAFT] RPM soft limit and hysteresis #5214, #5224

* fix m_timingRetard

* fix rpmHardLimitHyst

* unit-tests for #5214, #5224
2023-04-10 17:18:51 -04:00
rusefillc 23657b405c GDI: target pressure axis not always MAP fix #5155
bare minumum progress
only:proteus_f7
2023-03-05 23:32:04 -05:00
GitHub gen-configs Action c91b2344ce Auto-generated configs and docs 2023-03-06 04:16:07 +00:00
rusefillc 3031c6abd8 Poor man categories for logs #5153
only:proteus_f7
2023-03-05 23:12:56 -05:00
Andrey 1c7a800d7b https://github.com/rusefi/rusefi/pull/5040
only:mre_f4
2023-02-24 22:48:33 -05:00
Andrey 6588e813ae totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
Andrey 9abdab795d totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
Matthew Kennedy d5b00e1187
don't warn if we intentionally skipped this spark (#4961)
* don't warn if we intentionally skipped this spark

* header

* real nb2
2023-01-10 19:07:44 -05:00
Andrey G a300043f5d
Feed mapAveragingAdcCallback() with volts not adc raw values (#4940) 2023-01-05 12:14:48 -05:00
rusefillc 0300376c84 CI is useful 2023-01-01 11:30:50 -05:00
rusefillc 6146b01a36 antilag and anti-lag #2403
TurboMarian is the ALS boss
2022-12-21 20:12:00 -05:00
rusefillc e75a1bc1a1 guards 2022-12-17 18:26:38 -05:00
rusefillc d63d8f869a guards 2022-12-17 15:50:54 -05:00
rusefillc 85976ed63d guards 2022-12-17 15:23:32 -05:00
rusefillc 57ad9b7311 random getOrZero clean-up 2022-12-14 19:48:07 -05:00
Matthew Kennedy 5250b177c2
Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew (#4882)
* switch hpfp to AngleBasedEventNew

* aux valves too!
2022-12-10 16:15:11 -05:00
Matthew Kennedy 769cdd32ca
TriggerScheduler cleanup (#4844)
* TriggerScheduler cleanup

* remove TRIGGER_EVENT_UNDEFINED

* remove dead overload of scheduleOrQueue

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-28 08:55:38 -05:00
Matthew Kennedy 8ea5969607
fix warnings (#4840)
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-27 10:11:14 -05:00
Andrey 77a3f5d795 trigger refactoring: instance RPM #4740 2022-11-06 11:56:18 -05:00
Andrey d75bf59cdc trigger refactoring: instance RPM #4740 2022-11-06 11:12:20 -05:00
Andrey b5796c121d trigger refactoring: instance RPM #4740 2022-11-06 10:58:04 -05:00
GitHub gen-configs Action 54cea0119a Auto-generated configs and docs 2022-11-01 21:35:56 +00:00
rusefillc dd081e5d58 Too long field comment becomes log field name #4716 2022-11-01 17:31:47 -04:00
GitHub gen-configs Action 523a6b9592 Auto-generated configs and docs 2022-11-01 21:00:55 +00:00
rusefillc 53649f73f1 Too long field comment becomes log field name #4716 2022-11-01 16:51:51 -04:00
Andrey G e7b06cbfca
compile warnings: signed vs unsigned and unused (#4713) 2022-10-30 09:47:53 -04:00
rusefillc 0283351d6c send more of Engine Sniffer data #4560 2022-10-29 21:55:35 -04:00
Matthew Kennedy de65a247d6
plumbing for dual MAP sensors (#4704)
* wiring for dual maps

* s
2022-10-27 21:15:04 -04:00
Matthew Kennedy dfe2ead2e7
prep for multiple MAP sensors (#4705)
* prep for multiple MAP sensors

* move guard

* sensor info printing

* maybe kinetis memory
2022-10-27 13:59:36 -04:00
Andrey b01082640b Revert "prep for multiple MAP sensors (#4677)"
This reverts commit b8c79b7881.
2022-10-26 21:25:02 -04:00
Matthew Kennedy b8c79b7881
prep for multiple MAP sensors (#4677)
* prep for multiple MAP sensors

* move guard

* sensor info printing
2022-10-26 18:06:20 -04:00
rusefillc 98076927b0
progress: rpm register based on trigger input being none or not (#4691)
* progress: rpm register based on trigger input being none or not

* use helper functions

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-22 09:27:41 -04:00
rusefillc 7a1e729cd8 ROLLBACK 2022-10-21 22:45:46 -04:00
rusefillc 3abed33988 progress: rpm register based on trigger input being none or not 2022-10-21 22:07:41 -04:00
Matthew Kennedy 940e0dc369
require ignition on for firing (#4628)
* require ignition on for firing

* too much havoc for a unit test

* patch up references

* last one

* fix changelog mangling

* fix the changelog template too

* bad merge

* fix the template again

* s

* fake battery voltage on hw ci

* ugh merge

* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy cb86c014cf
fix instant rpm clearing bug (#4629)
* improve instant rpm

* changelog
2022-09-29 07:15:59 -04:00
Andrey baaec6a603 refactoring: encapsulation 2022-09-28 22:42:08 -04:00
Matthew Kennedy 264d33d30e
refactor prime (#4627) 2022-09-28 07:53:12 -04:00
Matthew Kennedy b089825a4a
schedule ignition charge by angle instead of tooth (#4513)
* schedule ignition charge by angle

* same mistake as #4536

* s

* wrap sparkAngle too

* AngleBasedEventNew

* function moved

* implement scheduleOrQueue

* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy dfe1b47b4d
remove ignitionPin (#4608)
* remove ignitionPin

* now that's gone

* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy a9cc3223dc
plumbing for 4513 (#4599)
* plumbing for 4513

* not static
2022-09-20 06:19:51 -04:00
Matthew Kennedy af7e4f6fe5
two modes trigger scheduler (#4598)
* two modes trigger scheduler

* asOld

* hpfp
2022-09-20 05:28:23 -04:00
Matthew Kennedy 3a57c41c1b
add fuel/spark cut codes to TS indicators (#4592)
* add fuel/spark cut codes to TS indicators

* fix list

* only set clearReason if not cleared
2022-09-19 22:01:03 -04:00
rusefillc d9733199c1 "angle range findAngle#a6" critical error #4593 2022-09-19 18:33:19 -04:00
rusefillc efb232223f moving acceleration around 2022-09-16 00:06:57 -04:00
rusefillc 61134b452a tear down Engine god object #4511
oh I hope this ends well
2022-09-15 23:41:06 -04:00
rusefillc 45d88f1d26 tear down Engine god object #4511 2022-09-15 22:21:07 -04:00
rusefillc ec0e567989 tear down Engine god object #4511 2022-09-15 21:46:01 -04:00
rusefillc 2d21aacc08 CUSTOM_INSTANT_MAP_DECODING 2022-09-15 15:07:31 -04:00
rusefillc 888247eccd mapFast into logs 2022-09-15 14:55:49 -04:00
Andrey 0e91914266 deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey 2c0ce0ec7d deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey 6cdb0dc0af deep rabbit holes are the best ones!
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey 82cda62bac inline method to reduce confusion 2022-09-14 01:34:52 -04:00
Andrey fedfd42989 removing dead parameter 2022-09-14 01:13:57 -04:00
Andrey 28704a9970 moving IO-only away from scheduling logic 2022-09-14 00:55:55 -04:00
Andrey b69d613192 moving IO-only away from scheduling logic 2022-09-14 00:52:24 -04:00
rusefillc e733782920 i suspect that no one cares about these 2022-09-14 00:34:04 -04:00
Andrey G 55c1f53c75
dead code, reduce typedefs (#4566)
* Do lightweight checks first

* Dead getTimeIgnitionSeconds()

Dead since 81fffe87b7

* Get rid of efitime_t.

Purpose are not clear. Use efitick_t where ticks are used,
use efitimeus_t for uS, use efitimems_t or efitimems64_t for mS.

* Fix unit tests

* Fix misc: stm32f1_test_project
2022-09-11 16:08:11 -04:00
rusefillc 94762094a7 refactoring - reducing API between FW and Java 2022-09-11 01:59:44 -04:00
rusefillc cfb843b315 send more of Engine Sniffer data #4560
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
rusefillc 7bc7299db1 send more of Engine Sniffer data #4560 2022-09-10 20:25:29 -04:00
Andrey 0d72d41721 refactoring: brining stuff closer 2022-09-08 00:19:24 -04:00
Andrey a3d51d8b49 refactoring: better place for cam validation 2022-09-07 23:31:44 -04:00
Andrey c60e0382dc refactoring: parameter rename 2022-09-07 23:24:24 -04:00
Andrey d3eab7c3b7 brutal encapsulation 2022-09-07 21:29:11 -04:00
Andrey 5962cbd5c2 brutal encapsulation 2022-09-07 20:31:04 -04:00
Andrey 52869d63bb tear down Engine god object #4511
just trying different things
2022-09-07 20:25:49 -04:00
Andrey ae93591755 brutal encapsulation 2022-09-07 20:20:29 -04:00
Andrey 6e8d248408 brutal encapsulation 2022-09-07 19:37:11 -04:00
Andrey 173ceae146 extracting prime_injection 2022-09-07 16:27:56 -04:00
Andrey 2d9dbbd6b8 extracting prime_injection 2022-09-07 16:25:50 -04:00
Andrey ab4b451195 os_access.h dead? 2022-09-07 15:56:45 -04:00
Andrey 197454ac34 tear down Engine god object #4511
just trying different things
2022-09-07 15:38:15 -04:00
rusefillc a7af8ecec9
Engine Sniffer into TS data logs fix #4535 (#4537) 2022-09-05 19:49:27 -04:00
Andrey 13c42ead92 tear down Engine god object #4511
just trying different things
2022-09-05 04:28:47 -04:00
Andrey 4934d76d88 tear down Engine god object #4511
just trying different things
2022-09-05 04:24:17 -04:00
Andrey c9828a8b0f tear down Engine god object #4511
just trying different things
2022-09-05 04:10:14 -04:00
Andrey f1f447df45 tear down Engine god object #4511
just trying different things
2022-09-05 03:38:44 -04:00
Andrey 99d8801dc6 tear down Engine god object #4511
just trying different things
2022-09-05 02:59:38 -04:00
Andrey 268a5c7964 tear down Engine god object #4511
just trying different things
2022-09-05 02:44:06 -04:00
Andrey 6d72805a56 tear down Engine god object #4511
just trying different things
2022-09-05 02:28:46 -04:00
Andrey 7139c21e7a Injection Offset for skipped wheel triggers fix #4536 2022-09-05 01:31:03 -04:00