827dc22757
rewrite neon trigger ( #5003 )
...
* rewrite neon trigger
* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
9630edfbf8
mitsu 4g63 ( #5001 )
...
* mitsu 4g63
* file header
2023-01-24 06:53:40 +05:30
d98e197f49
toyota 4-1 noise rejection ( #4980 )
2023-01-20 15:47:44 +05:30
6bfda5cb23
Auto-generated configs and docs
2023-01-10 21:35:32 +00:00
eb56c2897a
detect and ignore doubled trigger edges ( #4656 )
...
* isToothExpectedNow
* s
* s
* kick ci
* only warn at high enough RPM to detect non-smooth trigger
* 4b11 test
2023-01-10 16:07:17 -05:00
00aef081ac
12 tooth crank issues fix #4943
2023-01-09 21:10:55 -05:00
1b080bcd09
12 tooth crank issues fix #4943
2023-01-09 15:48:49 -05:00
c72528e5c2
12 tooth crank issues #4943
...
refactoring
2023-01-08 22:30:57 -05:00
0f1d46238f
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
b49e1569ba
findTriggerZeroEventIndex() failed fix #4935
2023-01-04 13:15:45 -05:00
def809aa39
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
d0f6fa8ea3
let's try again
2023-01-03 08:38:42 -05:00
0620164d14
Auto-generated configs and docs
2023-01-03 12:55:38 +00:00
603f188b55
a bit of dead code
2023-01-03 07:49:17 -05:00
2b4d58005b
guards
2022-12-17 14:43:51 -05:00
cb97c89588
Toyota cam 4-1 can be a plain skipped tooth decoder ( #4863 )
...
* this should be RiseOnly
* use 4-1 skipped tooth for toyota
2022-12-02 07:37:18 -05:00
ce550aaa3d
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 15:45:32 -05:00
99edf9484a
docs
2022-11-16 15:23:42 -05:00
6ca9b6eda7
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
2fb23cf58b
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 12:18:46 -05:00
f7d97e202e
docs
2022-11-16 12:18:34 -05:00
32d3669a35
new trigger wheel shape for Benelli 3-cylinder engines #4744
2022-11-16 11:35:00 -05:00
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
7bd9dbf89e
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
ec77afeaa0
reducing ugly
2022-11-06 20:47:57 -05:00
1475ecf273
trigger refactoring: instance RPM fix #4740
2022-11-06 12:03:55 -05:00
77a3f5d795
trigger refactoring: instance RPM #4740
2022-11-06 11:56:18 -05:00
83e736b06a
trigger refactoring: instance RPM #4740
2022-11-06 11:47:23 -05:00
7b10b32958
trigger refactoring: instance RPM #4740
2022-11-06 11:45:51 -05:00
79afd2b6fa
trigger refactoring: instance RPM #4740
2022-11-06 11:41:27 -05:00
d75bf59cdc
trigger refactoring: instance RPM #4740
2022-11-06 11:12:20 -05:00
a5136a0eae
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
b5796c121d
trigger refactoring: instance RPM #4740
2022-11-06 10:58:04 -05:00
53d3c4a529
minor trigger refactoring
2022-11-06 01:32:59 -04:00
87d6aa2ed9
minor trigger refactoring
2022-11-06 01:11:33 -04:00
e3fd84ed08
minor trigger refactoring
2022-11-06 00:32:38 -04:00
a0c234c76d
learning C++
2022-11-06 00:17:24 -04:00
d4bb6a3a5e
more fancy
2022-11-06 00:10:50 -04:00
cd77afe464
minor fix: will be invoked downstream
2022-11-05 23:58:05 -04:00
2866ba54b8
minor fix: no need to assign same value twice
2022-11-05 23:50:03 -04:00
43e3fce9b1
minor trigger refactoring
2022-11-05 22:42:33 -04:00
fd86dc2b0f
minor trigger refactoring
2022-11-05 22:30:08 -04:00
c6e34be447
A gem of dead code
2022-11-05 21:53:38 -04:00
b57bf2903a
minor trigger refactoring
2022-11-05 21:43:12 -04:00
6c3899f401
dead lines
2022-11-05 17:21:30 -04:00
500b3e8678
dead lines
2022-11-05 15:20:02 -04:00
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
0283351d6c
send more of Engine Sniffer data #4560
2022-10-29 21:55:35 -04:00
cb77801ed3
Auto-generated configs and docs
2022-10-28 14:09:22 +00:00
a4aa280e90
SD card log fields list should be auto-generated #3985
2022-10-28 10:04:33 -04:00
6b28fee5ce
Auto-generated configs and docs
2022-10-28 13:11:34 +00:00
5df60fd084
SD card log fields list should be auto-generated #3985
2022-10-28 09:06:15 -04:00
cf75202ab6
Automation coverage for RPM not reading #4709
2022-10-28 02:44:38 -04:00
2677da2105
refactoring
2022-10-28 02:41:20 -04:00
983f88709a
progress: allow only exhaust cam input now that we have index parameter
2022-10-22 08:40:36 -04:00
da0fa03f0a
refactoring: wider usage of helper method
2022-10-22 08:39:55 -04:00
905f59d561
progress: rpm register based on trigger input being none or not
2022-10-21 23:29:39 -04:00
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
19b0f7e66e
triggerImage: todo: support symmetrical crank
2022-10-16 12:10:58 -04:00
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
6a99469c8a
// todo: what is broken _exactly_? ( #4531 )
...
* // todo: what is broken _exactly_?
* hold on, why "float autoscale" at all here?
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 23:13:14 -04:00
bd4ca6a805
Auto-generated configs and docs
2022-10-09 02:22:51 +00:00
86d3b16939
hold on, why "float autoscale" at all here? ( #4647 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-10-08 22:11:34 -04:00
a773b3249a
remove 2jz trigger that's really 12 tooth crank ( #4637 )
...
* remove 2jz trigger that's really 12 tooth crank
* triggerimage hardcoded name
2022-10-05 21:59:17 -04:00
6e021fb880
change triggers that need RiseOnly ( #4636 )
...
* triggers that need RiseOnly
* skipped tooth
* s
2022-10-05 20:10:27 -04:00
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
57c804c6f5
there is no third trigger simulator channel right?
2022-10-03 00:18:11 -04:00
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
36113d6f66
nicer fatal message if that ever happens
2022-09-28 19:47:14 -04:00
1b56415c56
Auto-generated configs and docs
2022-09-25 22:54:41 +00:00
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
26356adf92
also invert trigger stim if you have trigger input inverted ( #4612 )
2022-09-25 10:10:31 -04:00
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
61cfff1e9e
K progress - just a rename
2022-09-24 23:25:36 -04:00
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
3b5ee8da51
Auto-generated configs and docs
2022-09-24 04:29:39 +00:00
dd41cf0a05
log tooth angle difference ( #4613 )
2022-09-23 23:49:28 -04:00
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
6dd933ea86
terrible horrible typo ( #4597 )
2022-09-20 12:39:16 -04:00
efb232223f
moving acceleration around
2022-09-16 00:06:57 -04:00
3104538022
just a rename & hiding unit test method
2022-09-15 23:07:08 -04:00
50cef9a201
tear down Engine god object #4511
2022-09-15 22:12:49 -04:00
fc9fb5724c
tear down Engine god object #4511
2022-09-15 22:06:16 -04:00
13bd9ab641
tear down Engine god object #4511
2022-09-15 22:00:07 -04:00
52f52376de
tear down Engine god object #4511
2022-09-15 21:55:15 -04:00
ec0e567989
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
9e7f36a5ca
tear down Engine god object #4511
2022-09-15 21:28:27 -04:00
85b170f84e
dead idea
2022-09-15 14:55:32 -04:00
0c87bb7260
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:45:31 -04:00
0e91914266
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
663c39afdc
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:24:41 -04:00
2c0ce0ec7d
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
12d857b99c
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:06:52 -04:00
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
55c1f53c75
dead code, reduce typedefs ( #4566 )
...
* Do lightweight checks first
* Dead getTimeIgnitionSeconds()
Dead since 81fffe87b7
2022-09-11 16:08:11 -04:00
e2addd1951
Supress tons of warning from triggers ( #4565 )
2022-09-11 15:25:58 -04:00
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
7cc41dfa75
human brain does need sleep
2022-09-11 12:40:24 -04:00
07727f5d0a
Revert "refactoring: type safety"
...
This reverts commit ed7908a69d
2022-09-11 11:14:20 -04:00
ed7908a69d
refactoring: type safety
2022-09-11 11:00:12 -04:00
2eca6ec3c7
refactoring: type safety
2022-09-11 05:41:01 -04:00
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
6e71b72acc
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
94762094a7
refactoring - reducing API between FW and Java
2022-09-11 01:59:44 -04:00
cfb843b315
send more of Engine Sniffer data #4560
...
hello Kinetis it has been a while!
2022-09-11 00:18:08 -04:00
7b4a5c9be6
vvtBooleanForVerySpecialCases, tempBooleanForVerySpecialLogic
2022-09-09 17:52:54 -04:00
72299bd1ba
only report vvt position if we have full sync ( #4547 )
...
* only report vvt position if we have full sync
* comments
* make it selectable, since that makes the test useful
2022-09-08 16:15:36 -04:00
9e9c0217b8
huh? dead code? how can we get NAN from eventAngles table? ( #4549 )
2022-09-07 23:45:33 -04:00
27c40e162b
Auto-generated configs and docs
2022-09-08 02:41:09 +00:00
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
00fea2cbe5
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
aeeef3dbd0
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
c1b218b772
refactoring: let's use different names for different things
2022-09-05 01:16:24 -04:00
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
c28c876357
todo: what is broken _exactly_?
2022-09-03 06:55:47 -04:00
7dee4d33cb
Auto-generated configs and docs
2022-09-01 14:11:17 +00:00
5941ad8fb7
smaller step forward
2022-09-01 10:06:00 -04:00
1d1fd2da43
Revert "smaller step forward"
...
This reverts commit f0e6bcc279
2022-09-01 09:10:11 -04:00
e1b3c3380f
Revert "smaller step forward"
...
This reverts commit f388163d2a
2022-09-01 09:10:07 -04:00
f388163d2a
smaller step forward
2022-09-01 08:51:13 -04:00
f0e6bcc279
smaller step forward
2022-09-01 08:44:46 -04:00
b712732dff
Auto-generated configs and docs
2022-09-01 05:33:56 +00:00
2cfe2a41b3
smaller step forward
2022-09-01 01:11:03 -04:00
ce5e618e3f
smaller step forward
2022-09-01 01:08:51 -04:00
5237235e48
Auto-generated configs and docs
2022-09-01 04:53:05 +00:00
9e14073feb
c63fb29aaf partial rollback
2022-09-01 00:46:54 -04:00
da66fa055c
refactoring: enum name clean-up
2022-09-01 00:23:33 -04:00
4f6f985d4f
Auto-generated configs and docs
2022-09-01 04:18:59 +00:00
c63fb29aaf
refactoring: reducing outputChannels copy
2022-09-01 00:13:55 -04:00
28d797d5c2
moving confusion further away from fuel control
2022-08-31 23:59:40 -04:00
398003c65d
Auto-generated configs and docs
2022-09-01 03:56:47 +00:00
dddec7cf06
currentEngineDecodedPhase as trigger central field
2022-08-31 23:31:35 -04:00
6d3a6dc2f8
readability
2022-08-31 23:29:47 -04:00
ca4936d3fe
rename and fix skyactiv cam mode ( #4505 )
2022-08-31 22:12:45 -04:00
b444e400eb
docs
2022-08-29 10:51:32 -04:00
b7490590a2
TT_VVT_MAZDA_MYSTERY
2022-08-28 23:01:38 -04:00
219a190fbc
TT_VVT_MAZDA_MYSTERY
2022-08-28 22:43:03 -04:00
4b0c8c9ff2
TT_VVT_MAZDA_MYSTERY
2022-08-28 21:54:24 -04:00
b662e59707
remove some uses of EFI_ERROR_CODE ( #4496 )
...
* lua hooks
* findAngleMatch
* s
* s
2022-08-28 09:43:21 -04:00
85490a497d
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 ( #4495 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
cf8d43f412
Auto-generated configs and docs
2022-08-24 22:15:50 +00:00
73abcb044d
log the state of hasSynchronizedPhase() ( #4478 )
...
* s
* log whether we've synced phase
* trigger_state_primary
* need that file
* engine state is not the right spot
2022-08-24 18:11:05 -04:00
5007084981
VQ trigger gaps improvement fix #4469
...
nice, unit test is happier!
2022-08-23 23:32:14 -04:00
859a66bb3b
poke 3
2022-08-23 09:02:38 -04:00
Matthew Kennedy
GitHub gen-configs Action
rusefillc
Andrey
Andrey G
rusefillc