Matthew Kennedy
16de438ab8
knock threshold table fix ( #4077 )
...
* fix knock threshold table
* defaults
* knock controller is engine module
* testable
* test builds
* knock tests work
* s
* format
* everyone loves changelogs
2022-04-18 08:03:16 -04:00
Matthew Kennedy
6aef4f10d0
fragment refactoring ( #4072 )
...
* fragment refactoring
* jar
* jar?
2022-04-16 09:24:45 -04:00
rusefi
141804f490
steps towards better commands encapsulation
2022-04-14 01:44:35 -04:00
rusefillc
44ed81fce0
logging of live data structs was: data points #3614
...
handling request past end of fragments
2022-04-13 23:31:32 -04:00
rusefillc
53d31ee0ea
logging of live data structs was: data points #3614
...
support for null fragments
2022-04-13 20:46:55 -04:00
rusefillc
3c7eb93fe1
steps towards ignition live data
2022-04-13 16:48:25 -04:00
Matthew Kennedy
baef88d1c7
make the vss fliter parameter work again ( #4056 )
...
* vss has adjustable filter
* tooltip and validate
* s
2022-04-09 09:00:19 -04:00
Matthew Kennedy
bd2b5a3dba
gear detection validation ( #4053 )
...
* gear detection validation
* test validation because why not
2022-04-09 08:59:07 -04:00
Matthew Kennedy
f0b810a81c
Gear detection implementation ( #4052 )
...
* gear detect improvements
* ui
* ui for gear ratios
* ui
* output channel
* output channels etc
* implement gear detection
* name
* s
* status loop
* missing function
* ui tweaking
* s
2022-04-07 09:21:11 -04:00
Matthew Kennedy
ad368b2031
Gear detection improvements ( #4047 )
...
* gear detect improvements
* ui
* ui for gear ratios
* ui
2022-04-06 16:15:58 -04:00
rusefillc
b005a049e2
JNI for test coverage #3965
2022-04-04 22:33:30 -04:00
Andrey
8053aeb9cf
Extra Idle Air if Throttle is Pressed behavior #3940
...
only live data
2022-04-03 20:30:09 -04:00
GitHub build-unit-tests Action
ec3fc18a2d
Trigger wheel definitions
2022-04-03 22:10:40 +00:00
Andrey
093de78ff3
Proper cam speed labels in triggers #4021
2022-04-03 17:56:47 -04:00
GitHub build-unit-tests Action
dcd1419c59
Trigger wheel definitions
2022-04-03 16:42:45 +00:00
rusefillc
e631988b22
Proper cam speed labels in triggers #4021
2022-04-03 12:22:47 -04:00
Matthew Kennedy
289122c0b7
fix 4032 ( #4034 )
...
* fix 4032
* board defaults should not set these things
2022-04-03 06:58:25 -04:00
Andrey
204ac3961b
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey
cc9a1136c4
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 02:21:37 -04:00
Andrey
b0be8c4b66
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
...
progress: this way test is less fake!
2022-04-03 02:13:56 -04:00
Andrey
5840a61f55
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 01:02:13 -04:00
Andrey
95d36b37e3
Trigger setup in TS is highly confusing: hide operation mode from users? #4031
2022-04-03 00:34:18 -04:00
rusefillc
6b5747d4c8
refactoring: method rename
2022-04-02 21:01:29 -04:00
GitHub build-unit-tests Action
61897aa3ee
Trigger wheel definitions
2022-04-02 23:28:57 +00:00
rusefillc
086739d20a
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-02 19:08:22 -04:00
GitHub build-unit-tests Action
0c0b5f582a
Trigger wheel definitions
2022-04-02 19:26:13 +00:00
rusefillc
174a3f33bd
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-04-01 22:05:25 -04:00
GitHub build-unit-tests Action
d2c694c0b2
Trigger wheel definitions
2022-03-24 00:18:03 +00:00
GitHub build-unit-tests Action
be283b96d2
Trigger wheel definitions
2022-03-22 10:45:51 +00:00
rusefillc
b1de262520
toothed previous time #4019
2022-03-21 20:41:09 -04:00
GitHub build-unit-tests Action
cb952a702c
Trigger wheel definitions
2022-03-21 00:24:31 +00:00
GitHub build-unit-tests Action
3a40347835
Trigger wheel definitions
2022-03-20 02:22:26 +00:00
GitHub build-unit-tests Action
f3e377bb27
Trigger wheel definitions
2022-03-20 00:11:47 +00:00
Andrey
1b334656e1
Refactoring, technical debt: export more of trigger attributes into triggers.txt file #2077
2022-03-19 19:59:36 -04:00
GitHub build-unit-tests Action
f3b2cefe27
Trigger wheel definitions
2022-03-19 23:45:58 +00:00
GitHub build-unit-tests Action
b62eb9dbb8
Trigger wheel definitions
2022-03-19 21:05:36 +00:00
GitHub build-unit-tests Action
e3bb929c6d
Trigger wheel definitions
2022-03-19 20:14:32 +00:00
GitHub build-unit-tests Action
e35bf1edaf
Trigger wheel definitions
2022-03-19 16:35:49 +00:00
rusefillc
697f675daf
JNI for test coverage #3965
2022-03-19 11:55:44 -04:00
Matthew Kennedy
4e57daf6d7
test AEM X-Series wideband protocol ( #4002 )
...
* break out acceptFrame, test CanListener
* test AEM xseries protocol
* tweaks
* tweaks
* maybe everyone compiles happily now
2022-03-15 15:52:50 -04:00
rusefillc
cbd6879ddf
JNI for test coverage #3965
2022-03-15 13:57:40 -04:00
rusefillc
6c8f130ff9
JNI for test coverage #3965
2022-03-15 13:05:24 -04:00
rusefillc
2181430101
JNI for test coverage #3965
2022-03-15 11:09:54 -04:00
rusefillc
05e8f7f6d4
gtest in library is hard ( #3998 )
...
* Revert "Revert "JNI for test coverage #3965""
This reverts commit 7566328816
.
* JNI for test coverage #3965
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-03-14 22:15:21 -04:00
GitHub build-unit-tests Action
330e4065fe
Trigger wheel definitions
2022-03-15 00:55:36 +00:00
Matthew Kennedy
a0f114a9a2
break out acceptFrame, test CanListener ( #4001 )
2022-03-14 19:09:01 -04:00
Matthew Kennedy
5811f691d9
things are happy without gtest ( #3999 )
...
* things are happy without gtest
* this is not a static lib
2022-03-14 15:00:02 -04:00
rusefillc
3076027887
spelling
2022-03-14 13:11:10 -04:00
rusefillc
983688a9fa
JNI for test coverage #3965
2022-03-14 00:10:01 -04:00
rusefillc
8733841c79
JNI for test coverage #3965
2022-03-13 21:36:25 -04:00
rusefillc
6aa62190ee
JNI for test coverage #3965
2022-03-13 21:04:04 -04:00
rusefillc
9d0f1fe64a
Jni engine ( #3995 )
...
* JNI for test coverage #3965
* JNI for test coverage #3965
* JNI for test coverage #3965
2022-03-13 20:03:49 -04:00
rusefillc
20cf22665e
JNI for test coverage #3965
2022-03-13 00:25:10 -05:00
rusefillc
19c034db51
JNI for test coverage #3965
2022-03-13 00:06:26 -05:00
rusefillc
6dca5bfcc4
JNI for test coverage #3965
2022-03-13 00:01:16 -05:00
rusefillc
44b5383a71
JNI for test coverage #3965
2022-03-12 23:47:38 -05:00
Matthew Kennedy
0937de1b84
flash storage uses 32 bit CRC ( #3984 )
...
* better flash logic and warning message
* comment
* s
* ssssss
* simplify logic
* use 32 bit crc
* s
* don't test things that don't exist
2022-03-08 23:17:35 -05:00
rusefillc
9b99fc306c
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:37:08 -05:00
rusefillc
56bb2e2c70
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:34:39 -05:00
rusefillc
e688dd10d1
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:30:36 -05:00
rusefillc
be368ad2d2
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:29:28 -05:00
rusefillc
825a8d38ee
JNI for test coverage #3965
...
strange work-around
2022-03-01 00:27:04 -05:00
rusefillc
a036dcda87
JNI for test coverage #3965
2022-03-01 00:13:39 -05:00
rusefillc
82686cfb9f
JNI for test coverage #3965
2022-02-28 12:54:33 -05:00
rusefillc
2eda9310b2
JNI for test coverage #3965
2022-02-26 21:52:52 -05:00
rusefillc
af39ca9eba
JNI for test coverage #3965
...
hello darwin
2022-02-26 21:02:34 -05:00
rusefillc
6cbb602c08
JNI for test coverage #3965
2022-02-26 21:02:34 -05:00
rusefillc
2955f66f66
JNI for test coverage #3965
2022-02-26 21:02:34 -05:00
rusefillc
1a6c0c57c8
JNI for test coverage #3965
2022-02-26 18:12:34 -05:00
rusefillc
865cd1bc54
JNI for test coverage #3965
2022-02-26 18:12:34 -05:00
Andrey G
067055095f
cli registry: rework this hell, add FFF and FFFFF ( #3964 )
...
* cli registry: rework this hell, add FFF and FFFFF
* kinetis: no nodefaultlib
* revert back token helpers
* cli_registery: argument parser: do not eat qoutes
* Unit test for FFF
* cli_registry: remove debug
2022-02-26 16:58:10 -05:00
rusefillc
c94bbcc34f
one step back: helping master
2022-02-26 13:52:39 -05:00
rusefillc
540c68d7ce
dead code: THUMB really does not apply here
2022-02-26 13:48:51 -05:00
rusefillc
95b1d6cc5b
JNI for test coverage #3965
2022-02-26 13:10:57 -05:00
rusefillc
ef3b23312e
refactoring
2022-02-26 13:03:22 -05:00
rusefillc
abca5dca2f
JNI for test coverage #3965
2022-02-26 12:51:50 -05:00
rusefillc
0130933dd7
BMW 6HP gatewy #3954
2022-02-22 23:13:32 -05:00
rusefillc
970d63568f
Revert "lua: TDD of enabling base lib"
...
This reverts commit d8b3712817
.
2022-02-22 20:50:38 -05:00
rusefillc
d8b3712817
lua: TDD of enabling base lib
2022-02-22 16:25:41 -05:00
rusefillc
38d7f12b30
BMW 6HP gatewy #3954
2022-02-22 15:35:50 -05:00
rusefillc
dc824f0c42
N73
2022-02-21 11:29:46 -05:00
rusefillc
70ea61c091
N73
2022-02-19 20:46:04 -05:00
Matthew Kennedy
f1897ba7aa
less dependence on that logger ( #3884 )
...
* less dependence on that logger
* comma
* refactor a bit, make it clear what this thing actually *does*
* static
* shrink the buffer a bit and make names useful
* dead util that's just subtraction lol
2022-02-09 06:53:16 -05:00
Matthew Kennedy
d8073e8b27
remove mock adc ( #3888 )
...
* remove mock adc
* do these do /anything/?
2022-02-03 20:43:34 -05:00
Andreika
2beca221a3
hellen_board_id + hellen-common.mk ( #3885 )
...
* Hellen_board_id
* move EXTI init before config load
* add NT2USF()
* Hellen_board_id unit-tests
* hellen-common.mk
* fix for older macos compiler
2022-02-03 11:24:31 -05:00
Matthew Kennedy
06437f304f
dead StartupFuelPumping ( #3883 )
...
* dead
* test
* dead config too
2022-02-03 08:01:21 -05:00
Matthew Kennedy
28f39fe71c
test organization ( #3882 )
...
* organize actuators
* this test can be useful
* don't name things misc
* fewer tests called misc
* fewer tests called "big" (?)
* unnecessary
2022-02-02 16:36:35 -05:00
Matthew Kennedy
10be2d5f40
Remove FSIO, byeeeeeeeee ( #3865 )
...
* vestigial config
* replace last functionality
* engine/board configs include
* files that didn't need to include this
* remove FSIO implementation
* stragglers
* random little bits
* s
* s
* ConfigDefinition
* jar
* s
2022-02-02 02:03:31 -05:00
Matthew Kennedy
40d16291b0
Remove fsio part 2 ( #3876 )
...
* dead config stuff
* fsio state
* remove tests
* getEngineValue
* put part back
2022-02-02 00:49:44 -05:00
rusefillc
42deca0fd0
Main relay shutdown rebase ( #3880 )
...
* aggregate
* main relay controller handles delayed shutoff
* main relay controller handles delayed shutdown
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-02-02 00:45:11 -05:00
Matthew Kennedy
a718f3a30a
Remove fsio part 1 ( #3871 )
...
* dead includes
* move last logic out of fsio
* dead functions
2022-02-01 15:42:04 -05:00
rusefillc
ca98e270e1
safer file name ( #3861 )
...
* safer file name
* safer file name
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-01-31 21:51:32 -05:00
GitHub build-unit-tests Action
2986a6794b
Trigger wheel definitions
2022-01-31 23:31:07 +00:00
Matthew Kennedy
2444090933
vss based dfco ( #3845 )
...
* vss based dfco
* fix digits while we're here
* fix some other digits for fun
* don't use custom assert
* simplify test
* less than or equal, test vss behavior
* even better than comments are tooltips
2022-01-27 14:05:18 -05:00
Matthew Kennedy
eb14d74846
extract logic from wall wetting AE ( #3848 )
...
* extract logic
* extract interface
* explicitly test wall fuel
2022-01-27 07:45:50 -05:00
Matthew Kennedy
d65652d7bc
vss and flex are filtered ( #3839 )
...
* vss and flex are filtered
* turbo
* freq sensor test
2022-01-26 17:33:04 -05:00
Matthew Kennedy
df1635b5a0
dfco checks driver throttle intent ( #3832 )
2022-01-24 14:26:39 -05:00
Matthew Kennedy
b5232ab5e6
decouple TPS accel enrichment from trigger ( #3825 )
...
* move call site
* move thresholding out of fast path
* adjust config
* test
2022-01-23 15:31:39 -05:00
Matthew Kennedy
f5d4690fe1
baro fully in sensor model ( #3829 )
...
* consumers and api
* dead test
* baro uses sensor model
* remove old (copy of?) map lookup logic
* I guess we don't need FastInterpolation any more?
* don't double init analog input
2022-01-23 09:42:11 -05:00
Andrey
33df88d3f7
fixing NOISY_RPM handling via Sensor framework
2022-01-21 00:21:45 -05:00
Andrey
1bd71e4b2e
migrating to SensorType::Rpm API
2022-01-20 23:54:52 -05:00
Andrey
4ebb3c94d3
migrating to SensorType::Rpm API
2022-01-20 23:43:18 -05:00
Andrey
cda2b711cf
migrating to SensorType::Rpm API
2022-01-20 23:32:59 -05:00
Andrey
9313bcca92
migrating to SensorType::Rpm API
2022-01-20 23:19:48 -05:00
Andrey
0e1f7bea8c
migrating to SensorType::Rpm API
2022-01-20 23:03:45 -05:00
Andrey
e37ab73f1d
migrating to SensorType::Rpm API
2022-01-20 22:58:12 -05:00
Andrey
e945bc4bc9
migrating to SensorType::Rpm API
2022-01-20 22:51:20 -05:00
Andrey
5ea408c033
migrating to SensorType::Rpm API
2022-01-20 22:44:59 -05:00
Andrey
e55eb28086
migrating to SensorType::Rpm API
2022-01-20 22:42:13 -05:00
Andrey
df5cb34fb8
migrating to SensorType::Rpm API
2022-01-20 22:40:15 -05:00
Andrey
16b3e95865
migrating to SensorType::Rpm API
2022-01-20 22:31:07 -05:00
Andrey
3183a123cd
migrating to SensorType::Rpm API
2022-01-20 22:26:05 -05:00
Andrey
8361b6d1f6
migrating to SensorType::Rpm API
2022-01-20 22:22:52 -05:00
Andrey
9f08db256b
migrating to SensorType::Rpm API
2022-01-20 22:12:04 -05:00
Andrey
c7a62bcdb3
migrating to SensorType::Rpm API
2022-01-20 22:04:45 -05:00
Andrey
c17592bfe2
what's the difference between setRpmValue and assignRpmValue #3815
...
refactoring
2022-01-20 21:57:27 -05:00
Matthew Kennedy
76fdb4063e
XY Idle VE Table ( #3781 )
...
* config & ui
* implement
* test idle VE switching behavior
* use the interface where we can
* s
* re-bump flash version
2022-01-20 14:08:54 -05:00
GitHub build-unit-tests Action
f7231ac9bd
Trigger wheel definitions
2022-01-20 02:18:29 +00:00
David Holdeman
0dce4a41f5
use -C flag ( #3811 )
2022-01-18 19:25:59 -05:00
Andrey
08c1c5d969
Remove legacy check fix #3808
2022-01-18 16:01:27 -05:00
Andrey
7e007cc534
https://rusefi.com/forum/viewtopic.php?p=44100#p44100
2022-01-18 10:24:08 -05:00
rusefillc
5a84982c05
gcov coverage seems stale #3805
2022-01-18 08:35:37 -05:00
rusefillc
d305f2c5cf
https://en.wikipedia.org/wiki/Pi
2022-01-14 21:51:03 -05:00
Matthew Kennedy
7d341cfc9d
improve maf output channels and logging ( #3743 )
...
* maf channels
* s
* binary log
* if only I could type
* can
* instant RPM too
* s
* test
* graceful zero rpm
* test works
* float near
2022-01-12 15:41:35 -05:00
rusefillc
4db4ac060c
Code style for methods with zero arguments #3535
2022-01-11 22:40:52 -05:00
Matthew Kennedy
3e56bacef9
don't start boost pwm unnecessarily ( #3767 )
...
* don't start boost pwm unnecessarily
* test
2022-01-11 20:47:50 -05:00
rusefillc
699a5ef302
RE usability: live data for idle controller
2022-01-10 21:55:52 -05:00
rusefillc
339b906aa9
RE usability: live data for idle controller
...
static bad, class fields better
2022-01-10 20:12:11 -05:00
rusefi
1e22f3fc4d
we can live without this test
2022-01-08 20:34:31 -05:00
rusefillc
fcdb7b340d
mk files refactoring
...
saving build
2022-01-06 22:19:00 -05:00
rusefillc
04ab6a0488
mk files refactoring
2022-01-06 21:48:48 -05:00
rusefillc
a13a0a2cc9
mk files refactoring
2022-01-06 20:32:39 -05:00
rusefillc
7f0357ffcb
mk files refactoring
2022-01-06 20:06:31 -05:00
rusefillc
7c0fd37dfe
Live Data progress
2022-01-06 19:02:35 -05:00
Andrey
a07c88216d
Live Data progress
2022-01-05 20:41:51 -05:00
Andrey
ed6c89ec10
Live Data progress
2022-01-05 20:15:23 -05:00
rusefillc
51ade79641
itoa unit test, not a very detailed one
2022-01-03 03:31:57 -05:00
Matthew Kennedy
0932fcf94c
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
Matthew Kennedy
338c14c3a8
cylinder ignition trim ( #3709 )
...
* cylinder ignition trim
* changelog
* changelog
* test
* move UI
2022-01-01 15:47:47 -05:00
Matthew Kennedy
ab3e3ac83f
hook up fuel trims ( #3715 )
...
* hook up fuel trims
* pass all the params
* store per-cylinder fuel mass directly
* main trigger callback only touches per-cylinder, no banks!
* test test test test
* move UI to happy land
* changelog
2022-01-01 02:19:59 -05:00
Matthew Kennedy
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
rusefillc
f715210b39
GDI Epic #1448
...
live view
2021-12-31 15:28:24 -05:00
Matthew Kennedy
b3de217c1b
adjustment to #3722 ( #3723 )
...
* s
* behold, another bug a test caught
* test
* test generates usable trigger pattern so it works correctly
* comment
* don't need that
2021-12-31 01:21:21 -05:00
Matthew Kennedy
4981eb43d0
extract isSyncPoint function ( #3726 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* clean up noise from test case
* clarify and comment
2021-12-30 11:39:04 -05:00
rusefillc
4bc9c39044
E65
2021-12-29 00:50:17 -05:00
Andrey
ae5dbd63a4
extract method
2021-12-27 21:09:41 -05:00
Andrey
7322fc345e
E65
2021-12-26 14:48:00 -05:00
rusefillc
6665c4fb34
docs
2021-12-26 13:41:10 -05:00
rusefillc
b337fed520
live data
2021-12-26 13:00:17 -05:00
rusefillc
561a466cdb
E65
2021-12-24 17:35:27 -05:00
Andrey
af1259c176
E65
2021-12-24 16:58:12 -05:00
Andrey
97b3212e56
E65
2021-12-24 16:56:17 -05:00
Andrey
1f40be01b9
E65
2021-12-24 16:53:24 -05:00
Andrey
19a8685644
refactoring
2021-12-24 16:51:31 -05:00
Matthew Kennedy
a4871c703c
Autoscale all the things! ( #3713 )
...
* Map3D accepts any scaled_channel type
* consistency
* reinstate test
* fix ratio
* throttle, boost, gppwm
* scale ignition and VE
* tests
2021-12-22 08:09:41 -05:00
Matthew Kennedy
dff6d9b2f1
Map3D accepts any scaled_channel type ( #3712 )
...
* Map3D accepts any scaled_channel type
* consistency
* reinstate test
* fix ratio
2021-12-21 18:52:46 -05:00
Andrey
6b91bacd59
Map3D needs some changes to allow autoscale RPM bin #3707
2021-12-21 16:04:16 -05:00
Matthew Kennedy
b6a8bed429
tables support non-integer-scaled scaled_channel ( #3708 )
...
* support dividers
* float
* format
2021-12-21 00:59:07 -05:00
Matthew Kennedy
3a4a0ba18d
simplify some table lookups ( #3692 )
...
* simplify
* expand interpolation test
2021-12-20 08:14:30 -05:00
Matthew Kennedy
0810198185
clean up timing table defaults ( #3705 )
...
* less crazy configs
* cleanup
* make that test happy
2021-12-20 08:02:38 -05:00
rusefillc
47cde8801c
2 byte table axis #3045
2021-12-20 02:07:03 -05:00
Andrey
76768d6ac4
2 byte table axis #3045
...
fixing build
2021-12-20 01:50:23 -05:00
Andrey
76088f686f
are we missing something?
2021-12-19 23:57:36 -05:00
rusefillc
66f82a0cdb
2 byte table axis #3045
2021-12-19 22:43:10 -05:00
Matthew Kennedy
cddb9484a9
make macos happy ( #3699 )
...
* s
* explicitly include it because that's a good idea.
2021-12-19 09:58:49 -05:00
Andrey
951cea4471
ISO-TP accounting for new buffer size
2021-12-19 01:10:13 -05:00
rusefillc
907499416b
is that all it needs?
2021-12-19 00:54:20 -05:00
Andrey
d7e25028a0
PCAN sandbox - error requestOutputChannels fix #3698
2021-12-19 00:29:30 -05:00
Andrey
1dbcaaa6a4
TS via TCP connector and ISO-TP via PCAN #3667
2021-12-18 21:46:49 -05:00
GitHub build-unit-tests Action
01a89a5e2f
Trigger wheel definitions
2021-12-17 03:17:55 +00:00
rusefillc
4292c2fb1d
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
rusefillc
06ccf524dd
MAP phase sensing #3544
...
removing dead implementation
2021-12-16 21:13:55 -05:00
Andrey
8d7452e5d1
Lua to read tsOutputs #3376
...
unit test fix
2021-12-15 09:23:06 -05:00
rusefillc
ced403f7ee
Lua to read tsOutputs #3376
...
let's break master!
2021-12-15 08:56:59 -05:00
rusefillc
5bdf25c3f8
Lua to read tsOutputs #3376
2021-12-14 23:16:05 -05:00
GitHub build-unit-tests Action
8ee2f49966
Trigger wheel definitions
2021-12-15 02:30:21 +00:00
Matthew Kennedy
256df56fa7
Honda K 12+1 decoder adjustment ( #3694 )
...
* adjust trigger
* real cranking
* mk
2021-12-14 21:10:01 -05:00
GitHub build-unit-tests Action
47a55eaa91
Trigger wheel definitions
2021-12-14 00:05:57 +00:00
Matthew Kennedy
6de8364895
maybe more working MAP sampling ( #3689 )
...
* what if we do this
* cleanup
* s
* test
2021-12-11 03:01:28 -04:00
Andrey
9ae24735f8
MAP phase sensing #3544
2021-12-10 17:28:03 -05:00
Andreika
6be915f7af
can_isotp fix? ( #3678 )
...
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-12-08 18:12:51 -05:00
Matthew Kennedy
4148ee76bf
smarter priming logic ( #3674 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
* priming happens on ignition-on
* priming has its own scheduling
* config & UI
* dead config
* implementation
* look, the test caught a bug
* keep the watchdog happy
* bad merge
* changelog
* easier to read the test
* test naming
2021-12-08 16:20:19 -05:00
rusefillc
f1855a41ae
docs
2021-12-08 16:05:57 -05:00
Andreika
72cefd42de
CAN ISO-TP progress (+unit-tests fix) ( #3677 )
...
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-12-08 15:11:19 -05:00
rusefillc
3a33e59b86
rusEFI console ISO-TP via PCAN #3667
2021-12-08 12:01:28 -05:00
rusefillc
f104e4cc2f
rusEFI console ISO-TP via PCAN #3667
2021-12-08 11:55:34 -05:00
Matthew Kennedy
2050580a16
prime upon ignition voltage, not on power on ( #3662 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
* priming happens on ignition-on
* priming has its own scheduling
* test
* dead adjacent line of code
2021-12-08 07:26:49 -05:00
Matthew Kennedy
91ec135cf8
ignition controller detects rising edge on voltage ( #3636 )
...
* ignition controller detects rising edge on voltage
* update test
* comment
* ignore negative transients
* tweak
* test
2021-12-07 21:28:04 -05:00
Andrey
50038167d8
MAP phase sensing #3544
...
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Andrey
e72d57438a
MAP phase sensing #3544
...
new implementation
2021-12-07 20:00:04 -05:00
Andrey
73fb5a2ef8
docs
2021-12-07 19:59:43 -05:00
Andrey
8b246a8d92
refactoring
2021-12-07 17:00:42 -05:00
Andrey
6e49d66385
MAP phase sensing #3544
...
look new unit test!
2021-12-07 16:58:10 -05:00
Matthew Kennedy
3a95e86112
calculate per-cylinder ignition timing ( #3652 )
...
* simplify cylinder phasing
* per cylinder timing
* s
* s
* s
* why was there a divide by 2?
2021-12-06 21:19:37 -05:00
rusefillc
2f45ed205c
MAP phase sensing #3544
...
option to look for high and low peaks
2021-12-05 14:25:26 -05:00
rusefillc
0c91e77749
MAP phase sensing #3544
...
taking a step back to happy place
2021-12-04 18:21:10 -05:00
rusefillc
5f4b224b5f
tune via CAN #3361
...
CAN testability
2021-12-04 01:01:48 -05:00
rusefillc
37183a0640
header style
2021-12-04 01:01:48 -05:00
Andrei
c6fa50d196
CAN update
2021-12-03 21:44:15 -05:00
rusefillc
c80a37503e
trigger_adc helping simulator
2021-12-01 14:17:16 -05:00
rusefillc
aaf732f738
trigger_adc unit tests
2021-12-01 13:35:44 -05:00
Andrei
1047fed77c
trigger_adc unit-test data files
2021-12-01 12:28:48 -05:00
rusefillc
79e43384a5
proteus to have enlarged Lua
2021-11-30 21:37:17 -05:00
Matthew Kennedy
a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option ( #3630 )
...
* no working copy
* oops
2021-11-29 16:44:45 -05:00
rusefillc
0c4e64fb2d
Epic: Remove FSIO #2928
2021-11-28 17:54:26 -05:00
Matthew Kennedy
d5363b814a
better VSS configuration ( #3542 )
...
* vss uses real values
* some defaults
* test and correct math
* km, not miles!
* comment
* tooltip
* that macro went away
* 100hz and default settings gives 9kph
* changelog
* order of operations safety
* make the test like the pwm test
* housekeeping
* this is why we need sensor automation
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
GitHub build-unit-tests Action
7ea34947d5
Trigger wheel definitions
2021-11-26 02:09:34 +00:00
GitHub build-unit-tests Action
8d1231a588
Trigger wheel definitions
2021-11-25 23:54:51 +00:00
Andrey
e2fa1af527
MAP phase sensing #3544
2021-11-24 22:36:36 -05:00
Andrey
58c0fb4539
MAP phase sensing #3544
2021-11-24 21:53:32 -05:00
Andrey
259e8744cb
MAP phase sensing #3544
2021-11-24 21:53:16 -05:00
Matthew Kennedy
81fffe87b7
main relay doesn't use fsio ( #3580 )
...
* fuel pump
* s
* call correct callback
* more dead
* test adjustment
* don't overflow
* don't need separate function
* java
* give it a name
* generated
* generated
* add to generate script
* import *
* this is so cheap we don't need a flag
* main relay
* plumbing
* dead fsio stuff
* test it
* by 100%, we mean 99.98%
2021-11-24 07:47:51 -05:00
rusefillc
c75291f415
live data for wastegate #3588
...
i want to persist state so no 'const' sorry
2021-11-23 15:52:43 -05:00
rusefillc
50ccf1fbea
harley
2021-11-22 19:16:57 -05:00
Matthew Kennedy
3334a6963c
oh my god we've had no asserts ( #3595 )
2021-11-22 17:52:03 -05:00
rusefillc
42da5746f4
j1850 SAE crc8 Lua
2021-11-22 14:19:19 -05:00
rusefillc
da68ff5ad6
j1850 SAE crc8
2021-11-22 14:03:52 -05:00
Scott Smith
ba4a00d3bb
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData ( #3519 )
...
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData
Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp. It could be better but this is simple
and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays. Makes the interface simpler
and more rigid. Also saves 4 bytes per Multi*. Downside is access is now via -> and *,
not . and (nothing).
Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA
* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?
* No magical templated StaticAlloc thingy. Just virtual functions.
2021-11-21 04:56:07 -05:00
Matthew Kennedy
9a28e8d938
correctly compute engine revolution number ( #3586 )
...
* add param
* first revolution is revolution 0, not revolution 1
* would you look at that, we sync one rev quicker!
* changelog
* rpm value
2021-11-21 09:01:27 +03:00
Matthew Kennedy
a342bee57e
rpm calculator refactoring, gm 24x test ( #3585 )
...
* data
* stub test
* use getTimeSinceSyncPoint
* s
* s
* no
* test
* stray ;
* those were 1/10 what they were supposed to be
* actually check something
* dead log line?
2021-11-20 14:59:02 +03:00
rusefillc
bdc6340df7
only c++ because lua does some things asan doesn't like, but don't actually cause overruns.
2021-11-20 03:04:52 -05:00
Matthew Kennedy
754e832a7f
don't do things that don't work in clang ( #3584 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-20 02:40:41 -05:00
Matthew Kennedy
bb57a4b084
detect more overflows with asan ( #3582 )
...
* overflow detector
* type list dynamic allocate
* fix the buffer length
* comment
* pr fb
* sanitize sim
* fix sim sanitizer bug
* didn't mean to turn off optimization for sim
* asan can do that, if you turn it on!
* cleaning
2021-11-20 01:38:39 -05:00
rusefillc
fcc2b780e9
On -fpermissive in Windows in unit tests fix #3581
2021-11-20 00:26:52 -05:00
rusefillc
f1900b4887
On -fpermissive in Windows in unit tests #3581
2021-11-20 00:23:27 -05:00
rusefillc
e54d3b9e06
On -fpermissive in Windows in unit tests #3581
2021-11-20 00:16:03 -05:00
Scott Smith
5bc1949aef
Basic framework for high pressure fuel pump control ( #3476 )
...
* Basic framework for high pressure fuel pump control
* Many changes
Move calculations to fast callback
Move main object into Engine
Respond to pin changes without requiring a reboot
* Use EngineModule for HpfpController
Schedule pin off after executing pin on so we are sure it ends, even if the motor stops.
Test scheduling.
Less RAM use by only having one event and reordering fields.
* Make scheduling test actually useful - need non-0 activation angle.
Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-11-19 23:06:51 -05:00
Matthew Kennedy
d40ca0f581
fuel pump doesn't use fsio ( #3576 )
...
* fuel pump
* s
* call correct callback
* more dead
* test adjustment
* don't overflow
* don't need separate function
* java
* give it a name
* generated
* generated
* add to generate script
* import *
* this is so cheap we don't need a flag
2021-11-19 22:23:12 -05:00
Matthew Kennedy
cdd27abb09
turn on c++ 20 ( #3579 )
...
* set flags
* emit initializers
* jar
2021-11-19 22:19:34 -05:00
Scott Smith
18c27a6e9c
Separate out scheduleOrQueue into it's own standalone scheduler. ( #3573 )
...
It's a large enough entity that it shouldn't be buried in ignition logic.
2021-11-18 14:27:21 -05:00
Scott Smith
98040ad9af
Make the module API more concise. ( #3571 )
...
engineModules.get<FOO>(). becomes modules<FOO>()->
I believe the new API is more conducive to supporting arrays, by doing std::array<T, N> or
std::array<Mockable<T>, N>, with the support of a helper class.
2021-11-17 21:50:00 -05:00
Scott Smith
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith
988aacdd91
Create a base class EngineModule for that contains various useful callbacks. ( #3548 )
...
* Create a base class EngineModule for that contains various useful callbacks.
This cleans up the API by not requiring the notifiers to know about who wants callbacks. The only
place you need to update to add a module is in one place.
* Add mockability.
* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith
8dbdeb7773
Remove a bunch of macros from engine_ptr.h ( #3562 )
2021-11-17 10:01:39 +03:00
Scott Smith
cc95bd6c8e
Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER* ( #3560 )
...
* Programmatically remove EnginePtr/inject, EXPAND_Engine, and WITH_ENGINE_TEST_HELPER*
for i in ": public EnginePtr " ", public EnginePtr" "EXPAND_Engine;" "EXPAND_Engine"; do
git grep -l "$i" | xargs sed -i "s/$i//g"
done
git grep -l "inject" | xargs sed -i "/inject[(][)]/d"
for i in WITH_ENGINE_TEST_HELPER_SENS WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK WITH_ENGINE_TEST_HELPER; do
git grep -l "$i" | xargs sed -i "s/$i/EngineTestHelper eth/g"
done
git checkout firmware/controllers/core/engine_ptr.h
git checkout unit_tests/global.h
* Review fixups.
2021-11-16 16:52:11 -05:00
rusefillc
17d4646dce
spelling
2021-11-16 16:46:54 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
Scott Smith
344c9073e2
Start the process of using a global engine ptr for unit tests. ( #3551 )
...
* Start the process of using a global engine ptr for unit tests.
Passing around the engine, config, and persistent state wasn't buying anything. Instead, use
EngineTestHelper(Base) to correctly set and clear the global variables. Add a dummy check in
case some test tries to set them manually.
* Fix OSX build
* Adapt PR to recently added code.
2021-11-16 00:23:14 -05:00
Scott Smith
62daac73c7
Use Valgrind to detect unitialized variable references. ( #3555 )
...
* Use Valgrind to detect unitialized variable references.
Fix the edge cases that pop up
* Comment and disable Mac run
2021-11-15 23:42:23 -05:00
Andrey
0cc88ec6e2
Not all launch control options are used #3554
2021-11-15 21:13:01 -05:00
Andrey
655b77dc3f
random refactoring: trigger central encapsulation
2021-11-15 20:22:05 -05:00
Andrey
05fa6071dd
refactoring launch
2021-11-15 19:55:04 -05:00
Scott Smith
7011be6f86
Test for stack use after free in ASAN. ( #3552 )
...
Fix two cases that didn't affect the product, but did affect our ability to test.
2021-11-15 19:44:39 -05:00
Andrey
4002c92dcc
refactoring launch
2021-11-15 18:57:12 -05:00
Andrey
34015eceee
refactoring launch
2021-11-15 14:40:35 -05:00
Matthew Kennedy
cb032fb1ea
(void) -> () ( #3550 )
...
* static functions with (void)
* more
* Revert "more"
This reverts commit 246e53441f935451437df186ac92d7df26b62fb6.
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-15 13:02:34 +01:00
Matthew Kennedy
145316c497
less macro, more c++ ( #3549 )
...
* less macro
* s
2021-11-15 12:44:40 +01:00
GitHub build-unit-tests Action
97bf934e58
Trigger wheel definitions
2021-11-14 23:14:04 +00:00
rusefi
a5764d6e67
Lua: changing "table" API
2021-11-14 16:44:52 -05:00
rusefillc
c22215cea7
Epic: Remove FSIO #2928
2021-11-14 10:39:47 -05:00
rusefillc
a85d1bb064
Epic: Remove FSIO #2928
2021-11-14 07:30:26 -05:00
GitHub build-unit-tests Action
7a9d1ecdd1
Trigger wheel definitions
2021-11-14 03:05:33 +00:00
Matthew Kennedy
73b05d2e20
lua pid class ( #3411 )
...
* lua pid
* no luaaa stl
* update luaaa
* finality
* luaaa
* luaaa
* = default
* bad merge
* gitmodules
* lua
* proteus demo script
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 03:18:16 -05:00
Matthew Kennedy
57ad75aa98
load lua libs correctly ( #3529 )
...
* fix lua lib loading
* test
2021-11-11 13:44:13 -05:00
Scott Smith
713083baa5
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
Scott Smith
2f4d123052
Change users of MultiChannelStateSequence to use the API ( #3524 )
...
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
Scott Smith
d4c4db9a12
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
rusefi
72a2bdba66
MathMin
2021-11-10 19:23:05 -05:00
Matthew Kennedy
3f2a9c3fe8
test TS writes ( #3515 )
...
* test TS writes
* s
* this must be a gcc extension
2021-11-10 07:29:40 -05:00
Scott Smith
158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Scott Smith
37da55c920
Compile each project's PCH to a separate file to reduce developer friction. ( #3505 )
...
Having to remove the precompiled header when switching from firmware to simulator to unit_tests and
back again is annoying. Use a directory to store the precompiled header output. Turn off
precompiled header warnings as GCC still complains even if it finds a valid one eventually.
2021-11-08 15:52:58 -05:00
Scott Smith
13c496b79b
Make getTimeNowNt even faster ( #3504 )
...
The last version is already much better than the original, mostly because it doesn't call
CriticalSectionLocker, which has a ton of overhead due to debug tracking. But this version is
another 4 instructions / 12 bytes shorter. Does as much match in 32-bit land as possible, and
avoids math operations that span 64-bits (i.e. either operate on the lower half or upper half, but
not both). The result is only 3 instructions not including the necessary 4 loads (ptr to now, now,
ptr to upper, upper), 1 store (upper), and 1 return/branch.
2021-11-08 14:24:31 -05:00
Andrey
2c715be4b7
ETB: do not touch HW pins if function not selected, this way Lua can use DC motor hardware pins directly
2021-11-08 12:44:37 -05:00
Andrey
8a963633d3
refactoring: assigning etbFunctions earlier
2021-11-08 12:39:41 -05:00
Andrey
1b0d48d8c0
WITH_ENGINE_TEST_HELPER_BOARD_CALLBACK
2021-11-08 12:27:02 -05:00
Andrey
9b0f617664
lua pid class #3411
2021-11-07 09:53:40 -05:00
Matthew Kennedy
e7a1fb4aaa
unit test build times ( #3489 )
...
* don't emit assembly listings
* more
* extract coverage
* link coverage
2021-11-06 21:20:24 -04:00
Andrey
6111355e6c
Remove Miata MX5 NB1 trigger #3488
2021-11-06 20:24:41 -04:00
GitHub build-unit-tests Action
3222881248
Trigger wheel definitions
2021-11-05 22:25:35 +00:00
Matthew Kennedy
3348c0404b
configurable etb maximum ( #3469 )
...
* etb maximum
* update tests and test new behavior
2021-11-05 18:16:19 -04:00
Scott Smith
6d38fe1eb3
Allow scaled_channel to have both multiplier and divisor ( #3468 )
...
Disallow scaled_channel for float. I can't think of a reason to allow it, and it gets in the way
of rounding.
Add separate template param to setTable; let the compiler sort out whether assignment can happen
between TElement and VElement without forcing them to be the same at function call time.
2021-11-05 17:34:22 -04:00
Andrey
f6a20ca1ea
lua curve progress
2021-11-05 16:08:48 -04:00
rusefillc
610c2b0ad1
lua curve progress
2021-11-05 10:34:12 -04:00
GitHub build-unit-tests Action
44b2e07b84
Trigger wheel definitions
2021-11-05 11:24:12 +00:00
Matthew Kennedy
24224729a3
support autoscale on table axes ( #3452 )
...
* scale map Y axis
* allow different row/col types
* scaled channel detector
* interpolation
* looks like this actually works
* tests, no manual scaling
* comment
2021-11-03 19:53:26 -04:00
Andrey
44fa9b028b
lua interpolate
2021-11-02 23:35:48 -04:00
Matthew Kennedy
980a7cc833
autoscale fields in generated structs ( #3444 )
...
* add to grammar
* parser
* parser
* example consumer
* build config tool
* commit the right jar
2021-11-02 18:59:19 -04:00
Matthew Kennedy
75a2b5ef02
Knock retard ( #3396 )
...
* output gauge
* knock controller
* don't need that
* inject engine ref
* test knock
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-01 23:33:59 -04:00
GitHub build-unit-tests Action
f9860c74b3
Trigger wheel definitions
2021-10-31 01:43:02 +00:00
rusefillc
db6bdfae61
small step back
2021-10-30 20:52:10 -04:00
Matthew Kennedy
29ec0a5859
better pch usage and gmock constructors ( #3426 )
...
* break out mock constructors
* comment and spacing
* unnecessary compiler options
* happy stepper
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-30 20:31:09 -04:00
rusefillc
d5de11bcc1
Override trigger gaps feature #2734
2021-10-30 11:09:10 -04:00
rusefillc
64ecbb16ab
Revert "lua pid class #3411"
...
This reverts commit dde80bb900
.
2021-10-28 23:41:23 -04:00
rusefillc
dde80bb900
lua pid class #3411
2021-10-28 23:35:53 -04:00
Andrey
0e6a51e5c0
export board-specific macro for stm32 pins based on board yaml #3298
...
meta progress
2021-10-26 10:27:10 -04:00
Andrey
e5a5b0a0f7
export board-specific macro for stm32 pins based on board yaml #3298
...
mre meta progress
2021-10-25 21:05:45 -04:00
Andrey
9ab6c42418
export board-specific macro for stm32 pins based on board yaml #3298
...
proteus meta progress
2021-10-25 17:36:21 -04:00
David Holdeman
c1b173a1e1
Use SSH for remaining workflows ( #3407 )
...
* install sshpass instead of ncftp
* don't use file for command
* change env vars
* replace ncftp with sshpass in docs
* switch gcov upload
* use heredoc instead of file
* convert ibom
* whoops
* messed up var
* remove quotes
* undo ini variable changes
2021-10-25 08:22:31 -04:00
GitHub build-unit-tests Action
d91b9edcee
Trigger wheel definitions
2021-10-24 22:31:19 +00:00
rusefillc
bf7ae2c76e
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 13:10:38 -04:00
rusefillc
b7601e063f
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-24 11:40:47 -04:00
Matthew Kennedy
383d8caad9
Lua CAN RX ( #3403 )
...
* wiring
* static
* implementation
* comment
* unit tests happy
* guard
* guard smarter, not harder
* guard smarter not harder
* guard even smarter, not even harder
* don't need that
2021-10-24 08:37:04 -04:00
Matthew Kennedy
8a841bb52c
lua can set sensors ( #3389 )
...
* add sensor unsubscribe
* sensor hook
* test it!
* virtual destructor makes us sad
* ensure deinit
2021-10-22 16:36:29 -04:00
Andrey
b750755369
findSensorTypeByName
2021-10-21 14:33:59 -04:00
Andrey
37594d5646
findSensorTypeByName
2021-10-20 22:21:42 -04:00
GitHub build-unit-tests Action
0accd1cf02
Trigger wheel definitions
2021-10-20 17:14:06 +00:00
rusefillc
eb05f4594e
very old very dead code
2021-10-20 12:57:07 -04:00
rusefillc
1493973bea
very old very dead code
2021-10-20 10:38:36 -04:00
Matthew Kennedy
e4c34e016a
last packet optimization ( #3363 )
...
* last packet optimization
* comment
* test
* missed one
* set tcp mss
2021-10-18 19:59:08 -04:00
rusefillc
0254a141df
Whatever we call it, no matter how we do it - we need live data / remote view into rusEFI actual state #3353
...
progress
2021-10-14 15:17:30 -04:00
rusefillc
38eaa3bdff
Review unit_tests/compile.sh fix #3349
2021-10-13 21:09:11 -04:00
rusefillc
77ed015826
Review unit_tests/compile.sh fix #3349
2021-10-13 15:33:31 -04:00
Andreika
bc4a068c9c
[DRAFT] IAC H-Bridge Microstepping ( #3213 )
...
* fix for stepperHbridgeHardware
* new config fields for microstepping
* add stepper dir pin mode to the dialog
* refactor stepper hw dialog & add microstepping panel
* microstepper modes enum
* stepperDcInvertedPins needed by Hellen
* add sleep() for stepper and divisor for pause()
* microstepping impl.
* make unit-tests more happy
* small progress
* fix etb-stepper dlg conflict
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 13:57:04 -04:00
Andreika
d917cc8cc2
[DRAFT] Fix cranking->idling taper phase for useSeparate*ForIdle tables ( #3168 )
...
* Rename Phase::CrankToRunTaper -> CrankToIdleTaper
* Change isIdling() to isIdlingOrTaper()
* test_idle_controller.cpp
* useSeparateIdleTablesForCrankingTaper setting
Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2021-10-06 12:05:20 -04:00
Matthew Kennedy
9797d25b7c
getOrZero ( #3319 )
2021-10-05 19:59:07 -04:00
GitHub build-unit-tests Action
9fad6778f5
Trigger wheel definitions
2021-10-05 19:48:31 +00:00
GitHub build-unit-tests Action
2d42adcff7
Trigger wheel definitions
2021-10-04 23:05:37 +00:00
Matthew Kennedy
db12cdbe19
put MAP in the sensor model ( #3292 )
...
* map averaging in sensor model
* deadly, deadly code!
* mpxh
* Revert "deadly, deadly code!"
This reverts commit 346fe25267966a313145a809792dced84be348cf.
* comments
* sensor types
* last sensor
* channel init
* correct spot
* deinit properly
* simplify
* fix
* mocks
* map init test
* showInfo
* comment
* singleton identity function
* sensor info print
* multiple cylinder averaging buffer
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-10-04 17:18:08 -04:00
rusefillc
77ebc71f9a
overdwell protection #3071 ( #3294 )
2021-10-02 01:17:53 -04:00
Matthew Kennedy
0a550a70b1
overdwell protection ( #3220 )
...
* cancel event
* looks like it works...
* some tests are happy
* add enable bit
* undo test changes
* Revert "add enable bit"
This reverts commit 000afadd3fc560867302557afe26f76cd9fc4ed6.
* enable bit in engine
* only turn off for one test
* Revert "undo test changes"
This reverts commit 106db49e291b5a531a94de6ac177c6584d5337f6.
2021-10-02 01:10:24 -04:00
Andrey
13d21716db
reducing crazy in unit tests
2021-10-02 00:13:15 -04:00
Andrey
097e871b19
reducing crazy in unit tests
2021-10-02 00:00:08 -04:00
Andrey
3da054c6e7
reducing crazy in unit tests
2021-10-01 23:53:22 -04:00
Andrey
7398ba5059
reducing crazy in unit tests
2021-10-01 22:50:09 -04:00
Andrey
d478c9c411
reducing crazy in unit tests
2021-10-01 22:33:06 -04:00
Andrey
b71d3c6111
reducing crazy in unit tests
2021-10-01 22:29:44 -04:00
rusefillc
a6fbb98193
Complete fuel cut, maybe by wall wetting? Warning on decel (?) CUSTOM_OBD_SKIPPED_FUEL = 9010 fix #3225
2021-09-27 22:04:03 -04:00
Matthew Kennedy
f41a2715a3
system lua: load a script! ( #3231 )
...
* load script
* test
* needs more rams
* embiggen stack
* init system lua from lua thread
* de-embiggen stack
* system needs a little more
* memory
* om nom nom delicious memory
* how much more memory could it want
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-23 21:45:14 -04:00
GitHub build-unit-tests Action
be5bb57016
Trigger wheel definitions
2021-09-22 00:48:36 +00:00
Matthew Kennedy
b5bde5c307
Turbo sensor ( #3245 )
...
* outputs rpm
* no msg param necessary
* new sensor type
* happy test
2021-09-20 15:39:41 -04:00
alxrMironov
bb341c4c07
Turbo speed sensor implementation #2935 ( #3209 )
...
* Add turbocharger speed converter class
* Add turbocharger speed converter tests
* Add turbocharger speed sensor initialization functions
* Add turbocharger speed sensor to initialization
Co-authored-by: alxrMironov <330OMcorporative>
Co-authored-by: rusefillc <48498823+rusefillc@users.noreply.github.com>
2021-09-19 20:50:11 -04:00
rusefi
6307ffd3a6
merc128: engine config defaults #3236
2021-09-18 22:12:22 -04:00
rusefillc
3e50319eb7
merc128: engine config defaults #3236
2021-09-18 21:27:17 -04:00
rusefillc
847fb75a23
TS channel names for nicer console messages
2021-09-18 15:33:14 -04:00
GitHub build-unit-tests Action
55671165a4
Trigger wheel definitions
2021-09-13 15:23:48 +00:00
GitHub build-unit-tests Action
8b2e3e227d
Trigger wheel definitions
2021-09-12 16:05:23 +00:00
Matthew Kennedy
2e5a4b3691
no asan on windows ( #3230 )
2021-09-07 17:39:04 -04:00
GitHub build-unit-tests Action
78cb22d4fb
Trigger wheel definitions
2021-09-05 18:12:47 +00:00
Andrey
a5e17ba0d6
x86_64-w64-mingw32-g++: error: libsanitizer.spec: No such file or directory #3221
2021-09-05 07:15:33 -04:00
Matthew Kennedy
c72bd07179
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
rusefillc
427cce7596
Lua timer ( #3218 )
...
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* Lua: Timer class #3159
* lua timer is happy (#3216 )
* hooks are happy
* don't need that any more
* format
* update lib
* module
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2021-09-03 20:21:39 -04:00
GitHub build-unit-tests Action
2b302f1b0c
Trigger wheel definitions
2021-09-01 06:51:15 +00:00
rusefillc
fbf64e92c8
docs
2021-08-31 05:37:14 -04:00
rusefillc
0c2d5f829d
docs
2021-08-31 04:38:35 -04:00
rusefillc
6ea76921f4
docs
2021-08-31 04:27:31 -04:00
rusefillc
ee4f66b544
docs
2021-08-31 04:22:26 -04:00
rusefillc
c141088198
docs
2021-08-31 04:20:57 -04:00
Matthew Kennedy
730b26d034
remove old vss implementation ( #3208 )
...
* dead vss
* remove
2021-08-28 01:39:55 -04:00
Matthew Kennedy
6407e74ae2
disable closed loop boost below MAP threshold ( #3206 )
...
* boost minimum map
* changelog
2021-08-27 17:54:08 -04:00
Matthew Kennedy
0c6297e926
add cancel to scheduler ( #3201 )
...
* fw
* for tests
* simulator
* sim
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-27 11:30:06 +03:00
Matthew Kennedy
cf5d4cbe1c
add & test remove from linked list ( #3199 )
2021-08-26 23:03:09 +03:00
Matthew Kennedy
a18b86a09b
start allowing ADC change while running ( #3100 )
...
* allow re-register of the same sensor
* add api to unsubscribe
* do it for tps
* clear the pin
* happy test
* maybe make afr happy for now
* tests build
* happy simulator
* active configuration
* check valid
* we need vbatt now
* manage all pin init in init_sensors.cpp
* don't need that
* cleanup
* thermistors
* do two phase reinit in the right place
* config vs engine
* finally the tests are happy
2021-08-24 16:41:16 -04:00
alxrMironov
f926d2ccba
Vehicle speed switching to frequency sensor #3106 ( #3148 )
...
* Add vehicle_speed_converter.h with realization.
* Add test_vehicle_speed_converter.cpp with realization.
* Add test_vehicle_speed_converter.cpp to Makefile
* Edit "VehicleSpeedSensor" from function pointer sensor to frequency sensor
* Fix "VehicleSpeedSensor" init function args
* Remove "VehicleSpeedConverter" empty constructor
* Edit vehicle_speed_converter.h code style
* Fix args and engine injection in "VehicleSpeedSensor" initialization procedure
* Remove old "Vehicle Speed" module initialization
* Revert "Remove old "Vehicle Speed" module initialization"
This reverts commit 100b7caa8c615c20eed3d0c23a49824b4e556148.
* Remove old "Vehicle Speed" module initialization pieces
* Revert "Revert "Remove old "Vehicle Speed" module initialization""
This reverts commit f559a726f1f7f5a7acacd1b6517e571743e84327.
* Debug changes
* Revert "Debug changes"
This reverts commit f7e2be1a8a46c6f3f93f14f002b2f2db539da8e2.
* Another debug changes
* More debug changes
* And more debug changes.
* Revert "Another debug changes"
This reverts commit 914fbb1df42c37e4b5ecbb119bb45e7cffdf4064.
* Revert "More debug changes"
This reverts commit 0b2d96d461c3cd9b0f1ae97ed110b8effe6b0cc6.
* Revert "And more debug changes."
This reverts commit 06ae8daded0e6e1c025e4e5058b47283f4adfe92.
* Add "Vehicle Speed" sensor reconfiguration
* Revert "Add "Vehicle Speed" sensor reconfiguration"
This reverts commit a089a6d563dd710004ce1a7da1744b0b4b90c3b1.
* Revert "Revert "Add "Vehicle Speed" sensor reconfiguration""
This reverts commit 7b2bb8af4b3caa547236ca59e4c4bdb3ac1200cc.
* Debug changes
* Another debug changes
* Fix another debug changes
* Another debug changes 2
* Revert "Another debug changes 2"
This reverts commit cfad55141eec125b2f1d35fb95d9f46b54f666b6.
* Revert "Fix another debug changes"
This reverts commit 9bc2c74a3be6fd896827ff48cf4580e7657529c0.
* Revert "Another debug changes"
This reverts commit 4337ed8cad8dff508d093944eb3f75e9a69e4a77.
* Edit class FrequencySensor, make it more RAII
* Debug changes
* Debug changes 2
* Debug changes 3
* Revert "Debug changes 3"
This reverts commit 52a7054c122b5157540fe45a055a84b57478d722.
* Revert "Debug changes 2"
This reverts commit dec79fb913344ccb4b8614910ad62e6c129a243e.
* Revert "Debug changes"
This reverts commit eb08d7a529b55ba397a7dd2c154b76eab42f212b.
* Revert "Edit class FrequencySensor, make it more RAII"
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Citroen Berlingo" engine config.
This reverts commit 3a0bb1d3f1dd23c1b04e4cc1c526cfdc67ae86a3.
* Remove VSS pin definition in "Dodge Neon" engine config
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-24 00:55:41 -04:00
Andrey
7363ac5c09
zero dwell warning at zero RPM #3153
2021-08-16 09:11:30 -04:00
Matthew Kennedy
2ad4a9df1e
actually remove FSIO idle stuff ( #3150 )
...
* debug mode
* pid cleanup
* more dead
* more dead
* wow more dead
* much dead many death wow
2021-08-14 09:48:45 +03:00
rusefillc
86e4664b2d
dead idle FSIO
2021-08-12 18:28:55 -04:00
alxrMironov
7ebebd6922
Begin "vehicleSpeed" refactoring. Module switched to "FunctionalPointerSensor" class. #3106 #3107 #3108 . ( #3132 )
...
* Add new sensor type "VehicleSpeed"
* Add "Vehicle speed" sensor to name list
* Add Vehicle speed sensor initialization with function pointer sensor.
* Add init_vehicle_speed_sensor.cpp to Makefile
* Replace dependencies from "getVehicleSpeed" to OOP-like "Sensor::get()"
* Add warning and TODO to "mock vehicle speed" call
* Replace get & mock "VehicleSpeed" methods in tests
* Remove #warning directive (cause error by current settings)
* Remove stray tab
* Remove explicitly type casting.
* Add "InitVehicleSpeedSensor" function declaration to init.h
* Add "VehicleSpeedSensor" initialization call into "InitNewSensors"
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-12 22:16:51 +03:00
GitHub build-unit-tests Action
3dda11cb7f
Trigger wheel definitions
2021-08-11 22:53:10 +00:00
Matthew Kennedy
90a0e47b04
skip etb init if no primary sensor ( #3136 )
...
* skip init if no primary sensor
* specific test
2021-08-12 00:45:44 +03:00
Andrey
0df437e749
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 07:04:18 -04:00
GitHub build-unit-tests Action
551de3edf0
Trigger wheel definitions
2021-08-08 10:24:03 +00:00
Matthew Kennedy
d24f1462e2
even more pch ( #3112 )
...
* s
* more
* s
* f7
2021-08-04 19:30:52 -04:00
Matthew Kennedy
5ff7235040
don't "validate instant RPM" ( #3095 )
...
* don't "validate instant RPM"
* test actually tests the right thing
* test mode transition
2021-08-04 08:17:14 +03:00
Matthew Kennedy
25414ebdad
yet more pch ( #3068 )
...
* big pch energy
* put back ramdisk stub
* tests are happy
* h743 nucleo
* kinetis
* I love deleting code!
* make stepper happy
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-03 22:05:01 -04:00
Andrey
75f27c6cbc
unit test for vehicle_speed.cpp fix #3081
2021-08-03 19:54:11 -04:00
alxrMironov
6d12533120
Unit tests for vehicle speed.cpp #3081 ( #3103 )
...
* Add test_vehicle_speed.cpp
* Add test_vehicle_speed.cpp to makefile
* Add tests for vehicle_speed.cpp
* Enable vehicle_speed.cpp testing
* Edit make some constants explicit and format code style
* Revert "Enable vehicle_speed.cpp testing"
This reverts commit bcba5219a1d69fb3375e33c7fcb97abffc190a75.
* Remove verbose variables
* Remove dead code strings
* Fix tests coupling by setMockVehicleSpeed
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-03 19:49:16 -04:00
Andrey
8fe2d99254
unit test for vehicle_speed.cpp #3081
2021-08-03 19:48:24 -04:00
Matthew Kennedy
a8eddbccf6
perform extra-step-prevention in the stepper driver itself ( #3038 )
...
* perform extra-step-prevention in the stepper driver itself
* isBusy flag
* I am unable to type
* the court of public opinion has decided that greater-equal is correct
* that sets target in steps, not percent
* correct var name
* mock stepper motor
* testable stepper
* build is happy
* helping build
2021-08-02 07:03:57 -04:00
Matthew Kennedy
f16173b4dd
call handleShaftSignal ( #3097 )
2021-08-02 07:02:45 -04:00
Matthew Kennedy
fcd6c3d520
fix the mess ( #3094 )
...
* test
* s
2021-08-01 23:21:53 -04:00
alxrMironov
6f96887d74
Unit test for flex sensor.cpp #3091 ( #3093 )
...
* Add test_flex_sensor.cpp
* Add test_flex_sensor.cpp to makefile
* Edit test_flex_sensor.cpp code formatting
* Fix test case name in test_flex_sensor.cpp
* Remove explicitly defined constructor of "FlexSensorForTests" class
* Edit included headers replaced by single one in test_flex_sensor.cpp
* Edit format to make similar to other files.
Co-authored-by: alxrMironov <330OMcorporative>
2021-08-01 22:14:01 -04:00
Matthew Kennedy
250bd0670e
unit test vss segfault fix ( #3090 )
...
* enable feature
* dynoview
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-08-01 15:05:52 -04:00
rusefillc
85d515eafc
Revert "unit test for vehicle_speed.cpp #3081"
...
This reverts commit 65c08fc9
2021-08-01 12:54:44 -04:00
rusefillc
65c08fc95e
unit test for vehicle_speed.cpp #3081
2021-08-01 12:20:19 -04:00
Matthew Kennedy
4aaee01a26
remove some noise from nb2 trigger log ( #3078 )
2021-07-30 08:19:16 -04:00
Matthew Kennedy
0d983855b9
instant rpm uses full engine cycle ( #3077 )
...
* instant rpm uses full engine cycle
* turn off fast spinup for this test
2021-07-30 08:18:24 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
GitHub build-unit-tests Action
4042013edb
Trigger wheel definitions
2021-07-26 01:51:25 +00:00
Matthew Kennedy
3518da97a7
set up precompiled header ( #2971 )
...
* ignore
* set up precompiled header
* makefile
* fixes
* cleanup
* only depend cpp on pch
* efifeatures in pch
* f7 efifeatures
* consolidate
* simulator
* proteus build
* error handling is a good one
* bootloader pch
* don't auto include pch
* dirs
* delete on clean
* bootloader cleans
* clean.sh deletes pch
* disable in bl for now
* there was a typo so maybe it'll work now
* remove todo
* don't need that any more
* don't need these parts
* don't need this part
* undo changes
* use a different cpp as example
* s
* Revert "cleanup"
This reverts commit 8de8698490f5d09c2df753f00a89751aa898be9a.
* also unnecessary now
* buh
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-25 21:23:23 -04:00
Matthew Kennedy
bd599ab374
cleanup for pch ( #3062 )
...
* cleanup
* d
2021-07-25 20:43:02 -04:00
Matthew Kennedy
f6095b8339
fix nonlinear correction threshold ( #3060 )
...
* s
* macro
* test has to do the inverse
2021-07-25 20:42:26 -04:00
Andrey
2495713af6
Clutch switch inverted options do not invert detected pedal position
...
#3545
2021-07-24 19:49:23 -04:00
Matthew Kennedy
617c2886d9
adjust taper behavior ( #3051 )
...
* adjust taper behavior
* check that taper works in running state too
2021-07-24 16:12:07 -04:00
rusefillc
23842bf143
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
rusefillc
16d98f417f
Update readme.md
2021-07-23 15:05:04 -04:00
Andrey
6fc693aea2
VVT position of first cam is off on first cycle fix #2987
2021-07-22 01:02:37 -04:00
Andrey
7db8bc816e
Nissan VVT trigger decoder #2887
2021-07-21 23:26:40 -04:00
Andrey
783fd70cce
Nissan VVT trigger decoder #2887
2021-07-21 23:24:23 -04:00
Andrey
c75dd65b56
Nissan VVT trigger decoder #2887
2021-07-21 23:16:44 -04:00
Andrey
24cfbeba35
Nissan VVT trigger decoder #2887
2021-07-21 23:08:56 -04:00
rusefillc
07d32a9e80
Nissan VVT trigger decoder #2887
2021-07-21 22:41:37 -04:00
rusefi
dba7a333f8
nissan logic cranking
2021-07-21 21:58:00 -04:00
GitHub build-unit-tests Action
206ec719c0
Trigger wheel definitions
2021-07-22 00:45:29 +00:00
Matthew Kennedy
d520d12490
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
Matthew Kennedy
4b95262a5d
simplify quad vvt test ( #3018 )
...
* use single tooth in quad cam test
* mod == remainder
* now the test works without changes
2021-07-21 18:48:05 -04:00
Matthew Kennedy
b9f141256a
test existing implementation ( #3017 )
2021-07-21 17:48:37 -04:00
Matthew Kennedy
0f0b84a6db
remove TS file read ( #3004 )
...
* remove
* more defines
* test
* lots of java
* s
2021-07-21 14:24:53 -04:00
Matthew Kennedy
5f3464b204
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey
b161a26956
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 19:43:17 -04:00
Andrey
9345e5d2e0
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
GitHub build-unit-tests Action
e7e166aa04
Trigger wheel definitions
2021-07-17 06:30:25 +00:00
GitHub build-unit-tests Action
f76887c17b
Trigger wheel definitions
2021-07-17 05:29:22 +00:00
Andrey
0d8fd6f271
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
GitHub build-unit-tests Action
ff7cd22a44
Trigger wheel definitions
2021-07-17 04:46:01 +00:00
Matthew Kennedy
a62d6743bc
lua hooks for CAN tx ( #2967 )
...
* CanTxMessage usable from unit test
* testLuaReturnsNil
* CAN hook and tests
* it helps if parameter names exist
* nameless params
* s
* redefinition of default argument
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-16 14:06:26 -04:00
Andrey
03bb3e3ace
trigger signal debug pins - logic level output #2959
...
test driven development is still amazing
2021-07-15 09:29:14 -04:00
Andrey
74e5eb8bb7
trigger signal debug pins - logic level output #2959
2021-07-15 02:12:57 -04:00
Andrey
b1f721e20b
trigger signal debug pins - logic level output #2959
2021-07-15 00:50:29 -04:00
Andrey
7486f5f040
trigger signal debug pins - logic level output #2959
2021-07-15 00:34:22 -04:00
Andrey
e721c1768f
trigger signal debug pins - logic level output #2959
2021-07-14 22:51:08 -04:00
Andrey
27350dbad8
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:47:55 -04:00
Andrey
e1c41ff798
FATAL on NB2 tune jim stim input signal #2965
2021-07-14 16:03:00 -04:00
Andrey
4750aa2efa
cute example of a bug which only macoc unit test fails to compile
2021-07-13 18:15:22 -04:00
Andrey
b20e6ae8a5
NB2 hellen-72-rev-d something is off #2958
2021-07-13 18:02:29 -04:00
Andrey
841875fb94
NB2 hellen-72-rev-d something is off #2958
2021-07-13 15:49:36 -04:00
Andrey
e1b6b405eb
NB2 hellen-72-rev-d something is off #2958
2021-07-13 15:04:30 -04:00
Andrey
7fd2e8275f
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:39:21 -04:00
Andrey
174e12b281
NB2 hellen-72-rev-d something is off #2958
2021-07-13 14:24:47 -04:00
rusefillc
1a72390d37
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 14:07:55 -04:00
rusefillc
acc4882f06
NB2 hellen-72-rev-d something is off #2958
...
export as is
2021-07-13 13:27:47 -04:00
Andrey
774bcaa5ef
it's spelled 'resources' :(
2021-07-13 12:36:50 -04:00
Andrey
f33862f537
it's spelled 'resources' :(
2021-07-13 12:35:43 -04:00
rusefi
b3c076dae7
NB2 hellen-72-rev-d something is off #2958
2021-07-13 11:57:18 -04:00
Matthew Kennedy
aef0732509
fix vvt indication ( #2926 )
...
* wrap logic
* rename gauges
* names and ranges
* binary log
* we actually don't need that warning
* values auto wrap
* values auto wrap
* bye warnings
* comparison
2021-07-12 16:29:07 -04:00
Matthew Kennedy
7a21f7fbc0
inject ( #2938 )
2021-07-09 17:02:25 -04:00
rusefillc
70fd233740
random progress
2021-07-09 14:27:10 -04:00
Matthew Kennedy
86683afca2
trailing spark scheduling ( #2932 )
...
* enable bit
* implement trailing sparks
* test trailing spark
* it helps to call the correct function
* add pins
* gobblin ram
2021-07-09 08:37:46 -04:00
Andrey
9dfc066bce
restore testQuadCam #2911
2021-07-08 00:11:54 -04:00
Andrey
0aa8693f21
Matt has CUSTOM_ERR_VVT_OUT_OF_RANGE warning #2921
2021-07-07 23:55:49 -04:00
Matthew Kennedy
d10ba3ddfa
injector nonlinearity ( #2916 )
...
* nonlinear polynomial
* make existing tests work again
* test that nonlinearity is called
* s
* fix enum
* ui
* fix and test
* comment
* changeloggy
2021-07-07 23:46:44 -04:00
Matthew Kennedy
5e08907590
knock sensing peak detect ( #2910 )
...
* knock peak detect
* comments
* comment
* initialize
* test
* fix warnings while we're here
* those are functions, not values
* ram
2021-07-06 21:44:59 -04:00
Matthew Kennedy
5bd3ae3aaa
Disable closed loop idle during cranking->running taper ( #2900 )
...
* implement
* dead file?
* implement tests
* new phase
2021-07-06 08:47:06 -04:00
Andrey
70424ac7b5
Nissan VVT trigger decoder #2887
...
another bug - improper handling of three-times-symmetrical
2021-07-05 23:15:44 -04:00
Andrey
2e9e5c2745
Nissan VVT trigger decoder #2887
...
that looks like one bug
2021-07-05 22:50:44 -04:00
Andrey
1b174bd4b3
Nissan VVT trigger decoder #2887
...
that's all very strange
2021-07-05 22:17:26 -04:00
Andrey
064c1612e3
restore testQuadCam #2911
2021-07-05 21:04:09 -04:00
Andrey
7cd5ea855c
restore testQuadCam #2911
2021-07-05 20:56:24 -04:00
Matthew Kennedy
43e6cef77d
more graceful chibios assertion failure ( #2859 )
...
* no custom assert hook
* dead
* setjmp/longjmp
* always call tid hook
* tests get threadid
* simulator threadid
* kick
* stubs for kinetis
* make it happier
* noreturn
* oops
* comments
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-05 18:18:58 -04:00
Matthew Kennedy
3574de1da3
shard unit tests ( #2906 )
...
* scripts
* it found problems!
* off by one
* call bash maybe?
2021-07-04 22:28:31 -04:00
Matthew Kennedy
992570f322
explicitly set mock vss to test ( #2905 )
2021-07-04 17:52:45 -04:00
Andrey
f12b414057
unit tests pass on Linux fail on Windows #2902
2021-07-04 11:15:05 -04:00
Matthew Kennedy
007a390f2b
Gate closed loop idle on road speed ( #2901 )
...
* implement
* test
* b
* config
2021-07-04 09:35:12 -04:00
Andrey
b67b1f424f
Nissan VVT trigger decoder fix #2887
...
TDD is amazing we are done here!
2021-07-03 12:43:01 -04:00
Andrey
0cf095a943
Nissan VVT trigger decoder #2887
2021-07-03 12:02:00 -04:00
Andrey
23e7022e55
Nissan VVT trigger decoder #2887
2021-07-03 11:08:22 -04:00
Andrey
f5e937fe2b
refactoring: getShaftSynchronized
2021-07-03 10:37:03 -04:00
Andrey
152eea43b1
Nissan VVT trigger decoder #2887
2021-07-03 10:15:41 -04:00
Andrey
0d5098e0a9
Nissan VVT trigger decoder #2887
2021-07-03 09:43:54 -04:00
Andrey
ba8b8a2e8d
docs
2021-07-02 22:06:08 -04:00
Andrey
e5a1b68eb2
Nissan VVT trigger decoder #2887
2021-07-02 20:28:15 -04:00
Andrey
1660a5b3fd
Nissan progress
2021-07-02 19:57:26 -04:00
Andrey
e7d7d79f13
Nissan progress
2021-07-02 19:23:52 -04:00
Andrey
0d7c0a7f50
Nissan progress
2021-07-02 18:33:32 -04:00
Andrey
d18d4496d1
Nissan progress
2021-07-02 17:32:45 -04:00
Andrey
bd5ff4b5a5
Nissan progress
2021-07-02 16:31:10 -04:00
Andrey
a9e7166f74
Nissan progress
2021-07-02 14:56:12 -04:00
GitHub build-unit-tests Action
53e4908497
Trigger wheel definitions
2021-07-02 04:07:11 +00:00
GitHub build-unit-tests Action
c96e233341
Trigger wheel definitions
2021-07-02 02:41:10 +00:00
GitHub build-unit-tests Action
61834eafd6
Trigger wheel definitions
2021-07-02 02:00:29 +00:00
GitHub build-unit-tests Action
d5ae3e5492
Trigger wheel definitions
2021-07-02 01:46:14 +00:00
Matthew Kennedy
025c32de00
Stricter miata sync ( #2891 )
...
* strict mazda trigger shape
* this is an even better gap
* sync point moved so things are different now
* fix
* update instantrpm in test
* s
* s
* this is safer
* test
* tests
* instant rpm
* cleanup
2021-07-01 21:29:04 -04:00
GitHub build-unit-tests Action
9d49790067
Trigger wheel definitions
2021-07-01 23:10:14 +00:00
Matthew Kennedy
8569f028d6
Fix pre sync timestamp copy ( #2892 )
...
* fix tests
* fix pre sync copy
* this fixes the issue
2021-07-01 18:58:28 -04:00
Matthew Kennedy
2a85bfc73f
test multiple starts ( #2888 )
...
* test
* pi
* typo
* private
* test short gap too
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 17:29:31 -04:00
Matthew Kennedy
1bca4843fe
test dc_motor.cpp ( #2890 )
...
* use ipwm where possible
* mock ipwm
* initialize
* test
2021-07-01 09:21:18 -04:00
Matthew Kennedy
35ad1b7d89
fix instant rpm ( #2886 )
...
* fix instant rpm
* this is what it should look like!
* warning
* comment issue link
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 09:19:16 -04:00
Matthew Kennedy
c171d5f1d3
not const getAirmass ( #2883 )
...
* not const
* test
2021-07-01 00:05:42 -04:00
Matthew Kennedy
942f23a6b3
aggressively test rpm calculator ( #2884 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-07-01 00:05:24 -04:00
Matthew Kennedy
5c60973dd8
Consolidate hwHandleShaftSignal ( #2875 )
...
* consolidate trigger input
* merge functions
* comment
* dead
* hw vs. not hw
* stray comma
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 10:06:22 -04:00
Matthew Kennedy
32f5ce6fb4
no fan if stopped engine ( #2822 )
...
* no fan if stopped engine
* config
* use config
* more tests
* merge
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-28 08:52:54 -04:00
Matthew Kennedy
cd5eb6a77c
Move AC logic out of FSIO ( #2872 )
...
* new impl
* remove fsio
* inject "is ac active" to fan
* include the correct code
* include
* test
* more AC features
* AC switch vs. actual AC indicators
* include
* duh
2021-06-27 18:51:34 -04:00
Andrey
fcc97fb9a6
VW warnings on cranking #2861
2021-06-27 13:01:56 -04:00
Andrey
f6b003820c
more minimal version of fix trigger replay #2874
2021-06-27 11:38:42 -04:00
Andrey
8696ea4890
crankDivider is asking for a new unit test
2021-06-27 00:51:14 -04:00
Andrey
a5eeb19c4d
refactoring - explicit read method
2021-06-26 22:07:45 -04:00
Andrey
7c7766efcc
VW warnings on cranking #2861
2021-06-26 16:05:43 -04:00
Andrey
2633c33fab
please use const char* they say
2021-06-26 01:39:04 -04:00
Andrey
c6d0d88465
VW warnings on cranking #2861
2021-06-26 01:37:55 -04:00
rusefillc
8a2564aaef
VW warnings on cranking #2861
2021-06-26 01:31:50 -04:00
Andrey
6dbc40e990
VW warnings on cranking #2861
2021-06-26 00:51:09 -04:00
Andrey
78dd28467d
progress
2021-06-26 00:33:28 -04:00
Andrey
f2db775586
progress
2021-06-26 00:16:41 -04:00
rusefillc
6a00036983
VW warnings on cranking #2861
2021-06-25 22:24:41 -04:00
GitHub build-unit-tests Action
587338c581
Trigger wheel definitions
2021-06-25 18:45:59 +00:00
rusefillc
0af5de0934
Minor change of Miata NA trigger shape #2855 #669 ( #2856 )
...
* Minor change of Miata NA trigger shape #2855 #669
* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey
942eb46471
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:19:16 -04:00
Andrey
dbea1e23a0
Trigger: warning code on normal engine start up #669
...
better TDC unit test approach?
2021-06-25 13:02:37 -04:00
Andrey
12efc6259a
.logicdata files closer together - partial revert, that did not work as expected
2021-06-25 12:59:44 -04:00
Andrey
288c2620c6
.logicdata files closer together
2021-06-25 12:45:41 -04:00
Andrey
266e50f4ca
Trigger: warning code on normal engine start up #669
...
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey
f04cb1ceac
Trigger: warning code on normal engine start up #669
2021-06-25 01:43:15 -04:00
Andrey
71fdfe6756
giving unit tests a chance to use tdcMarkCallback
2021-06-25 01:31:53 -04:00
Andrey
76840d07db
better test coverage
2021-06-24 23:38:16 -04:00
Andrey
a39920b68e
refactoring - better entity names
2021-06-24 23:19:31 -04:00
Andrey
8d17e0576c
docs
2021-06-24 23:12:16 -04:00
Andrey
175eea0a96
raw files #669
2021-06-24 22:39:00 -04:00
Andrey
3092164e48
Minor change of Miata NA trigger shape #2855 #669
2021-06-24 22:21:30 -04:00
Andrey
461132d993
Trigger: warning code on normal engine start up #669
2021-06-24 21:58:40 -04:00
Matthew Kennedy
7eb3b9890d
misc threading/safety improvements ( #2854 )
...
* allow termination of thread controller
* no gpio if fatal
* stub for test
2021-06-24 20:18:23 -04:00
Andrey
6ca965d246
Trigger: warning code on normal engine start up #669
2021-06-23 11:32:06 -04:00
Andrey
1c48a61339
refactoring
2021-06-23 06:37:32 -04:00
Andrey
a57d7c48fb
global static not good, there shall be only one god object /s
2021-06-23 06:10:27 -04:00
Andrey
74c5a80cac
Trigger: warning code on normal engine start up #669
2021-06-23 05:22:08 -04:00
Andrey
cbfc4cdd8d
Trigger: warning code on normal engine start up #669
2021-06-23 05:00:26 -04:00
rusefillc
a222a3961a
one can dream about a well defined framework
2021-06-19 09:56:08 -04:00
Matthew Kennedy
a4e3e28d14
make the test legible ( #2834 )
2021-06-18 22:53:22 -04:00
Andrey
2c66d74c7e
Trigger: warning code on normal engine start up #669
2021-06-18 22:52:01 -04:00
Matthew Kennedy
3a30f038ce
kill engine if no oil pressure ( #2800 )
...
* min oil pressure for crank
* do it time-based
* rename field
* include
* fix existing test
* tests
* fix logic
* more test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-16 17:20:28 -04:00
Matthew Kennedy
93adb8ea76
Etb rev limit ( #2820 )
...
* cfg
* impl
* a test
* don't break the ts channel
* text
2021-06-16 08:44:48 -04:00
Matthew Kennedy
a4973a6f3d
fan/AC idle improvements ( #2818 )
...
* fan 2 open loop bump
* we had an AC target bump all this time?!
* format
* enable test
* I can't type
2021-06-15 17:30:35 -04:00
Matthew Kennedy
7d2057e74a
remove cranking dwell angle ( #2814 )
...
* config & impl
* settings
* engines & boards
* this test doesn't do anything interesting
2021-06-13 07:52:07 -04:00
Matthew Kennedy
15d172ab08
apply open loop idle when in automatic mode ( #2745 )
...
* always apply open loop in closed loop
* simplify flags
* comment
* move
* comment
* missed one
* config for fan bump
* adjust miata defaults
* test fan/ac open loop
* idle CL tests
* test coasting
* test integration case
* fix merge
* put back reset logic for now
* s
* don't need that part
* I guess use OL as baseIdlePosition
* reset condition
2021-06-12 14:21:11 -04:00
Matthew Kennedy
c27549b2e8
hard coded fan logic ( #2805 )
...
* remove fsio
* hard code impl
* test it
* enable fan with AC
* make commented stuff match
2021-06-11 06:25:12 -04:00
Matthew Kennedy
a54a5e7f90
convert gpiochips to c++ ( #2761 )
...
* core
* basic header
* tests are happy
* tle6240
* tle8888
* 33972
* 33810
* tle8888_req_init
* unused warning
* warning
* unsigned
* 8888 debug
* fix
* don't qualify
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-10 04:11:01 -04:00
Matthew Kennedy
3ef969d743
warnings & assorted cleanup ( #2793 )
...
* lua hook
* validateBuffer
* tables
* simplify fsio table
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 14:30:25 -04:00
GitHub build-unit-tests Action
fbbb99f50c
Trigger wheel definitions
2021-06-02 16:43:30 +00:00
Matthew Kennedy
ab214f974c
Bandaid for 2735 ( #2788 )
...
* bandaid
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-02 12:02:52 +03:00
Matthew Kennedy
790ac08a2e
Cranking defaults ( #2787 )
...
* defaults
* more
* cranking fuel
* cranking timing
* cranking time digits
* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
Matthew Kennedy
f3c5ff6d54
idle fan/AC open loop bump ( #2785 )
...
* idle open loop ui section
* idle bump logic
* test fan/ac bump
2021-06-01 00:45:04 +03:00
Matthew Kennedy
39e4f70405
iac coast table ( #2784 )
2021-06-01 00:43:58 +03:00
Matthew Kennedy
7d773bfb1d
make the implementation match what the UI claims ( #2779 )
2021-05-31 07:37:02 -04:00
Matthew Kennedy
a50f8e0077
Idle test that fails ( #2781 )
...
* make member func
* failing test
2021-05-31 06:18:15 -04:00
rusefillc
33d296d4c7
my status
2021-05-31 05:27:51 -04:00
GitHub build-unit-tests Action
2bbd6e7cdc
Trigger wheel definitions
2021-05-31 08:53:37 +00:00
Matthew Kennedy
ec8e1eee69
require redundant pedal ( #2758 )
...
* require redundant pedal
* return false
* I don't typing good
* tests
* tests
2021-05-30 19:19:57 -04:00
GitHub build-unit-tests Action
8bdb38ef86
Trigger wheel definitions
2021-05-29 08:25:43 +00:00
GitHub build-unit-tests Action
b0cf3e45dc
Trigger wheel definitions
2021-05-26 10:24:44 +00:00
GitHub build-unit-tests Action
c6e3bf7c52
Trigger wheel definitions
2021-05-26 09:43:53 +00:00
Andrey
c89a60845b
subaru 7/6 progress based on https://rusefi.com/forum/viewtopic.php?p=41021#p41021
2021-05-26 05:22:13 -04:00
Andrey
0ad11168e8
Override trigger gaps feature #2734
2021-05-25 17:19:20 -04:00
Andrey
a36b655e67
Trigger: warning code on normal engine start up #669
2021-05-24 06:03:58 -04:00
Andrey
192fc18817
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:59:08 -04:00
Andrey
45de0c2350
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-23 18:49:48 -04:00
Andrey
7dd0565faa
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-21 11:07:59 -04:00
Matthew Kennedy
de7879b6e4
convert a table to scaled_channel ( #2724 )
...
* scaled VE table
* use setTable
* efi::clear
* ratio -> struct
2021-05-20 20:00:32 -04:00
Matthew Kennedy
5cb659a7b0
lua pwm hooks ( #2687 )
...
* pwm hook
* dedicated pins
* write hook
* UI
* more info
* zero based, clamp
* memory
* don't compile lua in bootloader at all
2021-05-20 19:01:17 -04:00
Matthew Kennedy
b398d03f5f
rewrite table3d ( #2723 )
...
* post cranking factor limits
* sensible defaults
* but not for tests
* add pointer version of get bin
* test via map3d
* put that back for a minute
* new impl
* fix order
* rename and fix table orientation
* flip the table to the correct orientation
* dead cleanup, rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-20 22:31:16 +03:00
Matthew Kennedy
0ea1f15ca3
compile gpiochips as cpp ( #2702 )
...
* rename
* core
* structing
* more
* makefile
* structing
* 6240 compiles
* explicit cast instead of implicit narrowing
* 8888
* no extern C
* fix tests build
* extern "C"
* 33810
* 8860
* 33810
* linker
* unbreak master
* don't need that if compiling as C++
* bump config
* fix test
* tests
* unit tests bad merge
* build
* move subaru logic to cpp file
* cpp goodness
* hpp include
* this is probably the right thing to do
* simulator
2021-05-17 08:42:56 +03:00
rusefillc
e892defd78
helping jenkins
2021-05-16 11:35:05 -04:00
Andrey G
54eeac2c10
Hw layer rearrangement ( #2707 )
...
* Fix unit_tests
* simulator: fix redifinition of TS_PRIMARY_SERIAL warning
2021-05-16 15:19:34 +03:00
Andrey
f301749556
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-15 16:21:24 -04:00
Andrey
4f63d2b476
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-15 05:27:33 -04:00
rusefillc
dfd0d3229f
More low-level firmware coverage for the simulator/unit-tests #2656
2021-05-14 10:58:53 -04:00
Matthew Kennedy
1d10fbc7a8
const airmass ( #2694 )
2021-05-14 07:17:22 -04:00
Matthew Kennedy
9b0c7ff693
explicitly test PTC thermistors ( #2681 )
...
* test ptc
* allow hotter for air cooled people
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-10 18:15:09 -04:00
Matthew Kennedy
6a060e5cae
remove intermediate buffer ( #2668 )
...
* remove define
* goodbye intermediate logging buffer
* free ram! woo!
2021-05-10 08:01:24 -04:00
Matthew Kennedy
4474f9f1c2
Maf in sensor model ( #2672 )
...
* init
* consumers
* hasMafSensor
* consumers
* remove
* remove
* s
* guard
* tiny bit of ram
* ram
2021-05-09 20:59:06 -04:00
Andrey
0d63fd04c5
unit tests usability: overwriting an existing profile data with a different timestamp fix #2650
2021-05-07 22:33:26 -04:00
rusefillc
9032730700
Break out unit tests #2627
2021-05-07 22:14:22 -04:00
rusefillc
c4add59219
Break out unit tests #2627
2021-05-07 17:45:26 -04:00
rusefillc
66cd0da92f
Break out unit tests #2627
2021-05-07 17:43:24 -04:00
rusefillc
7eb28a1367
Break out unit tests #2627
2021-05-07 17:18:18 -04:00
rusefillc
5fdc1a17d3
Break out unit tests #2627
2021-05-07 12:36:30 -04:00
Matthew Kennedy
8b30776016
remove stateChangeCallback from simplepwm ( #2644 )
...
* remove callback parameter from cj125
* remove from ext
* remove stateChangeCallback
* alt doesn't need that
* demorgan
* remove call
* bad cut/paste
* check the actual pin in the test
2021-05-07 09:38:41 -04:00
rusefillc
e26f2215d5
Break out unit tests #2627
2021-05-06 16:33:10 -04:00
rusefillc
c28517f9e3
docs
2021-05-06 10:43:25 -04:00
rusefillc
45d877414d
explicit paths
2021-05-06 10:09:18 -04:00
rusefillc
2c49760626
explicit paths
2021-05-06 10:04:21 -04:00
Matthew Kennedy
a25773a11b
more Lua hooks ( #2605 )
...
* more hooks
* zero index
* test table hook
* test works
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-29 22:22:04 -04:00
Matthew Kennedy
830575a306
lua 5.4 ( #2590 )
...
* thread priority
* build
* makefile prep
* call startup
* lua 5.1
* mk
* 5.3
* mk
* I guess lua does something?
* extract hooks, builds for tests
* a bit of error handling
* guard
* bootloader makefile
* remove lua
* submodule
* submodule update
* builds with submodule
* disabled by default
* h7 chconf
* tweaks
* add a useful hook
* move luaconf
* perf trace lua
* test helpers
* lua unit tests
* include to satiate clang
2021-04-28 22:41:25 -04:00
Matthew Kennedy
c26987b96b
Destroy all shared logger ( #2574 )
...
* most of shared logger
* a few more
* one more
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy
bd1c84fa62
Logging remove 3 ( #2568 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
* vvt
* more
* idle
* missed one
* dynoview
* launch
* can
* console IO
* s
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-20 14:09:41 -04:00
Matthew Kennedy
5145ee4b62
logging cleanup 2: sensors, pid, etb, etc ( #2567 )
...
* ts logger
* sensors
* wideband too
* missed one
* init
* motors, pid, etc
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 20:02:32 -04:00
Matthew Kennedy
6b64db7f9c
rewrite text logging system ( #2439 )
...
* minor cleanup
* enable mailboxes
* priority
* implement new logger
* more cleaning
* signature
* remove debug
* put the assertion back in
* remove debugging
* spelling
* doy
* tweaks & comments
* cleaning
* size_t
* guard more
* test build now
* needs more ram until we can remove LogginWithSTorage
* hunt for memory
* bootloader
* unused
* stub simulator
* it would help to get the signature right
* geez kinetis only has 64k ram
* more guarding because kinetis
* that's now very legal and very cool
* templatify
* s
* force null terminate
* probably fix
* const
* write a test
* disable sensor chart for now
* hide SC ui
* oh nope that breaks many things
This reverts commit c3c1bb324fb484c3d9cc44b7715c234bc0392e1e.
* missed one
* reset after scheduleLogging
* we can't print out the full message because it contains commas which break parsing
* force terminate long buffers
* let's see how much memory we have to play with
* a lot, is the answer
* real thread name
* shrink this for now before its deleted
* turn that back on
* biiig comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-18 18:46:47 -04:00
GitHub build-unit-tests Action
864510a7f3
Trigger wheel definitions
2021-04-15 23:39:10 +00:00
rusefillc
2b6345070f
WOW major scheduling drama on NB2 running with Proteus #2533
2021-04-15 19:12:09 -04:00
GitHub build-unit-tests Action
86410fd1a9
Trigger wheel definitions
2021-04-09 17:12:18 +00:00
GitHub build-unit-tests Action
b782873558
Trigger wheel definitions
2021-04-09 02:45:15 +00:00
rusefillc
6eb68aa4a1
helping us trace CUSTOM_INTEPOLATE_ERROR
2021-04-08 16:14:06 -04:00
rusefillc
b49c5200b7
helping us trace CUSTOM_FSIO_STACK_SIZE
2021-04-08 15:15:12 -04:00
rusefillc
462e24354d
CUSTOM_ERR_VVT_OUT_OF_RANGE warning false-positive fix #2534
2021-04-08 15:01:12 -04:00
rusefillc
e02f09495b
trigger and VVT duty cycle integration into limp manager #2523
2021-04-07 01:21:28 -04:00
Matthew Kennedy
46e38447e5
Ford redundant ETB tps ( #2519 )
...
* ford tps
* configurable maximum
* initialization
* check consistency when in the low range
* print info
* default
* config field
* config parameter
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-05 15:57:03 -04:00
rusefillc
9753b6e020
'displayLogicLevelsInEngineSniffer' on VVT input reports too much into engine sniffer fix #2528
2021-04-04 23:12:07 -04:00
rusefillc
f877d32be4
engine sniffer into unit tests
2021-04-04 22:48:48 -04:00
rusefillc
41804736e2
engine sniffer into unit tests
2021-04-04 22:41:38 -04:00
Andrey G
3d138958ce
Hip9011 ( #2512 )
...
* hip9011: coexistance with other spi devices
* hip9011: rework so SPI transfer is invoked from thread
also use polling spi exchange to avoid cache problems
* hip9011: move calculations from ADC callback to thread
* hip9011: big cleanup
* hip9011: simplify spi communication
* No need to set knockBandCustom if it is not custom
HIP9011 calculates knockBand from cylinderBore same way
* hip9011: make unit test happy
* hip9011: fix unit test
* hip9011: remove duplicated initialization, reorder
* hip9011: just renames and data type adjustments
* hip9011: rename BAND() to HIP9011_BAND()
* hip9011: move some code from lookup.cpp to logic.cpp
* hip9011: move initEngineNoiseTable to engine_configuration.cpp
* hip9011: move lookup tables to hip9011_logic.c
* hip9011: remove empty files
* hip9011: additional checks
2021-03-30 10:56:25 -04:00
Matthew Kennedy
f0cf4f38ff
fix multi-serial-port insanity ( #2476 )
...
* carve out UART specific
* implement channel
* config cleanup
* use new config
* bootloader
* dead code
* s
* h7 inherits f7
* oops
* ok now it's right
* tests
* cleanup
* call setup
* put that in its own file
* cleanup
* format
* guard
* not needed
* improve guarding
* portable
* allow override of uart mode
* fixes for bootloader
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 09:06:36 -04:00
Matthew Kennedy
8b3aa6c40d
goodbye ignitionOffset ( #2503 )
...
* remove
* set the timing map to do what the offset used to do
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
Matthew Kennedy
4e3e95db2d
replace print/printMsg with scheduleMsg ( #2497 )
...
* start cleaning
* disabled feature means don't print that it's disabled
* cli
* usages
* printMsg -> scheduleMsg
* this is alllll dead now
* no crlf please
* all hope is lost if you manage to hit this line
* tests
* tests
* ok we did actually need that part
* sim
* d
* kinetis
* it did ifdef, not if
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-26 17:23:26 -04:00
Matthew Kennedy
1c473934b9
plumbing for multiple vvt ( #2488 )
...
* plumb multiple vvt
* fix test
* s
* fix barra while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 07:39:23 -04:00
GitHub build-unit-tests Action
8f2950c34d
Trigger wheel definitions
2021-03-22 18:33:55 +00:00
Matthew Kennedy
95b08c433f
Implement nonlinear fuel level sender ( #2473 )
...
* table function
* config fields
* sensor type
* switch consumers
* init the sensor
* ui
* 1mv resolution
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-19 08:39:08 -04:00
Matthew Kennedy
1dd2180f76
VVT uses closed loop controller framework ( #2453 )
...
* vvt uses framework
* builds
* rename, update headers
* s
* testable
* write some basic tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-14 19:31:46 -04:00
Matthew Kennedy
2328c1be6b
Fuel pressure sensor checks ( #2449 )
...
* test for missing sensor
* test negative pressure delta checking logic
* test new hasSensor logic
2021-03-12 23:32:41 -05:00
GitHub build-unit-tests Action
dd2d253efb
Trigger wheel definitions
2021-03-13 03:00:16 +00:00
rusefillc
490d3a6957
test_timer
2021-03-12 00:43:48 -05:00
rusefillc
16b8fb64ca
vBatt -> SensorType::vBatt fix #2260
2021-03-11 23:07:18 -05:00
Matthew Kennedy
053835a1c0
error accumulator ( #2434 )
...
* error accumulator
* makefile
2021-03-08 07:40:46 -05:00
slowriot
47da1278e0
update all compile scripts to use available cores rather than a hardcoded value ( #2425 )
...
* fix typos, spelling
* add two V8 firing orders
* use the available number of CPU cores, not just 4
* add new firing orders to config
* updating generated files to include new v8 firing orders
* reverting update of auto-generated files
* correct firing order labels for new firing orders
* update all compile scripts to use available cores rather than a hardcoded value
2021-03-06 12:55:46 -05:00
Matthew Kennedy
5067b81fce
Compute injection duration later in the pipeline ( #2175 )
...
* injector model, test
* new math
* inject fuel based on new math
* tests
* fix
* it should work like this
* format
* update TPS AE even when we're cutting fuel
* comment
* conversion factor
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-03 07:30:56 -05:00
Andrey G
fbcff6f0c8
hip9011 compilation fix, cosmetic clean-ups ( #2414 )
...
* Board subaru eg33: has HIP9011 knock sensor
* hip9011: lastExecutionCount does not exist any more
* hip9011: extranc commands to header, use logic math for bitfields
2021-02-28 15:42:57 -05:00
Matthew Kennedy
b6de500059
cleanup ( #2386 )
2021-02-23 16:57:14 -05:00
Matthew Kennedy
a50d1d5ee3
start making tunerstudio more sane: part 2 ( #2381 )
...
* ts cleanup part 1
* move more stuff in to the class
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-19 20:48:21 -05:00
Matthew Kennedy
102804db7d
rework FSIO LEelement ( #2374 )
...
* save
* firmware
* test parsing multiple things
* split tests
2021-02-17 23:32:44 -05:00
Matthew Kennedy
39884f8934
use DECLARE_ENGINE_PTR for Engine class ( #2365 )
...
* engine cleanup
* do the cleanup
* one last spot
* expand_engine noop for firmware
* simulator
2021-02-16 16:58:54 -05:00
Matthew Kennedy
4a1d3de9a6
remove unused msg parameter ( #2360 )
...
* dead parameter
* last few
2021-02-16 09:32:16 -05:00
rusefi
bcc6c63046
second bank vvt decoder unit test
2021-02-09 10:16:49 -05:00
rusefi
bc0fc267d8
M62T vanos support #2243
2021-02-08 22:41:31 -05:00
rusefillc
2d99e77c95
M62T vanos support #2243
2021-02-08 21:50:31 -05:00
rusefi
f68ede76bf
M62T vanos support #2243
2021-02-08 21:07:43 -05:00
rusefi
6793b5d8fc
M62T vanos support #2243
2021-02-08 20:38:38 -05:00
rusefi
6b10de5616
refactoring: naming consistency
2021-02-08 18:20:53 -05:00
rusefi
c576f0a9d9
M62T vanos support #2243
2021-02-08 18:08:26 -05:00
rusefi
a349bf1ca8
M62T vanos support #2243
2021-02-08 16:16:26 -05:00
rusefi
a86481f3ba
refactoring: more structure
2021-02-08 15:59:40 -05:00
Matthew Kennedy
423acd384b
simplify MCU selection ( #2308 )
...
* set mcu type in hw_ports
* move f4 linker script
* move f7 linker script
* don't set default linker file in makefiles
* extra line
* prometheus actually didn't depend on anything special for f469
* dead line
* h7
* dead
2021-02-08 02:11:44 -05:00
Matthew Kennedy
7d3cadfc87
baro in sensor model ( #2306 )
...
* baro in sensor model
* missed
* typo
* init baro
* needs an include there
2021-02-07 17:54:41 -06:00
GitHub build-unit-tests Action
391ac5df9c
Trigger wheel definitions
2021-02-07 06:11:28 +00:00
rusefillc
953990d10b
Trigger pattern request Škoda Favorit fix #2302
2021-02-06 20:53:30 -05:00
GitHub build-unit-tests Action
98f761c88a
Trigger wheel definitions
2021-02-07 01:25:21 +00:00
Matthew Kennedy
5ceeac93e9
put vbatt in sensor model ( #2261 )
...
* vbatt in sensor model
* sensor name
* vbatt
* s
* oy vei
* a little bit of cleanup
* memory apparently
* cj125 test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 07:55:40 -06:00
GitHub build-unit-tests Action
72c828ed00
Trigger wheel definitions
2021-02-02 16:21:55 +00:00
GitHub build-unit-tests Action
4221b0b16e
Trigger wheel definitions
2021-02-02 15:03:11 +00:00
GitHub build-unit-tests Action
57b250993c
Trigger wheel definitions
2021-02-02 04:56:18 +00:00
rusefillc
869e4cfc49
vvt/cam events to pass index
2021-01-31 22:24:45 -05:00
Matthew Kennedy
10c31c2955
-g3 to -g ( #2256 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-31 14:13:55 -05:00
GitHub build-unit-tests Action
896b88f654
Trigger wheel definitions
2021-01-19 00:14:52 +00:00
rusefi
10e980e293
Revert "Save more space in the angle cache ( #2228 )"
...
This reverts commit c7ca1b2e
2021-01-18 18:53:00 -05:00
GitHub build-unit-tests Action
ef82dea293
Trigger wheel definitions
2021-01-18 23:42:56 +00:00
Matthew Kennedy
c7ca1b2ef4
Save more space in the angle cache ( #2228 )
...
* store event angles in a scaled field
* tests
* comment
2021-01-18 18:31:06 -05:00
Matthew Kennedy
60f70a3721
clean up some includes ( #2227 )
...
* cleanup
* make c happy
2021-01-16 09:45:45 -05:00
Matthew Kennedy
604b0cd527
templated interpolate2d ( #2221 )
...
* template table2d
* assertions
* oops
* tests
* test bins too
* more assert
* format
* explicitly handle and test NaN
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-11 08:00:15 -05:00
rusefillc
748bc5275b
weird
2021-01-10 20:29:20 -05:00
Matthew Kennedy
571122d461
Start support for multi-bank closed loop fueling ( #2184 )
...
* cfg
* cell
* N banks
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-10 08:10:49 -05:00
Matthew Kennedy
7a90692187
Idle timing uses phase logic, remove falloff ( #2169 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
* wonderful changelog
* now unused parameter
* put back deadzone
* ui
* test deadzone
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-07 08:06:36 -05:00
Andrey G
f96ae7525f
Gpio cleanup #2 ( #1530 )
...
* pin repository: PIN_USED size in now equal to brain_pin_e enum size
expect special values...
* smart gpios: register gpio chip to given base (no auto-allocation)
* drivers: gpio: core: add gpiochip_unregister()
* drivers: gpio: MC33810 intergation
* smart_gpio.cpp: cleanup ifdef mess, minor cleanups
* gpio: core: additional check for gpio ranges overlaps
* unit test: gpio chip: fixed and extended
2021-01-06 18:29:47 -05:00
Matthew Kennedy
f4dcf0f397
generate triggers.txt from parametric test ( #2186 )
...
* add new test
* comment
* remove old
* main cleanup
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 17:58:34 -05:00
Matthew Kennedy
eabb5c7366
flex fuel AFR interpolation ( #2190 )
...
* config
* implement flex
* secondary fuel default
* test
* test works
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
GitHub build-unit-tests Action
9578dfa269
Trigger wheel definitions
2021-01-05 21:14:10 +00:00
Andrey G
b92e3086d0
Adc isAdcChannelValid helper ( #2188 )
...
* Guard define argument
* ADC: isAdcChannelValid
Check for both <= EFI_ADC_NONE and >= EFI_ADC_LAST_CHANNEL
Also check for value out of enum range (corrupted settings)
* Fix unit tests
2021-01-05 16:02:20 -05:00
GitHub build-unit-tests Action
9307c27791
Trigger wheel definitions
2021-01-04 05:38:14 +00:00
GitHub build-unit-tests Action
3edba2d2c3
Trigger wheel definitions
2021-01-03 19:05:07 +00:00
Matthew Kennedy
92ea09b0a6
switch more map to read from sensor model ( #2162 )
...
* hook up map
* check for init
* switch some consumers
* that's the rest of them
* test
* tests
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-02 19:13:10 -05:00
rusefillc
46583b2a19
Revert "Idle timing PID uses phase logic ( #2156 )"
...
This reverts commit 9634a803
2020-12-31 12:22:54 -05:00
Matthew Kennedy
acdf6fdc85
Put map in the sensor model ( #2161 )
...
* hook up map
* check for init
* switch some consumers
* don't do limp for now
* oops
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-30 08:43:49 -05:00
Matthew Kennedy
9634a803f1
Idle timing PID uses phase logic ( #2156 )
...
* use phase computation
* move & simplify implementation
* test
* bad merge
* initialize
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-29 23:50:56 -05:00
Matthew Kennedy
ba2c675ffa
progress to fsio type safety ( #2137 )
...
* rename
* packed type safe fsio value
* comment
* rename
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-27 17:22:11 -05:00
Matthew Kennedy
64d9b4b71a
limp manager can disable etb ( #2143 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* limp can disable etb
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 21:47:27 -05:00
Matthew Kennedy
b9e96322c5
Idle refactor open loop ( #2146 )
...
* impl
* typo
* tests
2020-12-26 19:34:42 -05:00
Matthew Kennedy
ff4ce2fb1f
create limp manager ( #2142 )
...
* move rev limit to limp manager
* call fatal error
* include order
* fix bug
* tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-26 17:30:46 -05:00
Matthew Kennedy
542cb6a420
more testable idle logic ( #2140 )
...
* header
* test
* impl
2020-12-26 08:32:01 -05:00
Matthew Kennedy
17554539d1
rename ( #2136 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-25 08:40:54 -05:00
Matthew Kennedy
3727233e11
fix tach test 2130 ( #2134 )
...
* fix
* comment
2020-12-24 21:20:24 -05:00
rusefillc
7e201990d3
Restore testPulsePerRev #2130
2020-12-24 08:17:43 -05:00
Matthew Kennedy
3d13d03424
Purge e34 config ( #2127 )
...
* remove
* enums
* s
* func test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
Matthew Kennedy
55ebe223a7
Partition configs by board type ( #2106 )
...
* remove old flag
* flags
* reorder switch
* oops
2020-12-22 21:54:40 -05:00
Matthew Kennedy
8737ba62c2
Purge rover v8 config ( #2116 )
...
* bye
* goodbye, rover v8
* that snuck in
* use a different config for that test
2020-12-22 10:05:54 -05:00
Matthew Kennedy
690ab7e917
gpio unit tests ( #2099 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* move gpio mocking
* test gpios
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
* test deinit
2020-12-18 17:19:02 -05:00
Matthew Kennedy
6168bcea80
Fix gpio reinit race condition ( #2098 )
...
* fix unregister api for gpio
* consumers
* guard with a critical section
* index
* guard less
* unregister under lock
* fix reinit
* dead flag
* fix most tests
* initialize properly
* initialize properly
* assertions in tests
* fix message
* we must lock earlier to be truly safe
* this was using huge memory
* devirtualize
2020-12-18 17:18:12 -05:00
rusefillc
55b4e82615
naming consistency
2020-12-18 09:01:18 -05:00
Matthew Kennedy
aeea50ada2
move target computation ( #2091 )
2020-12-17 17:46:51 -05:00
Matthew Kennedy
1838beadfa
only build in config for the correct board ( #2088 )
...
* only build in config for the correct board
* undo
* undo
* undo
* only touch proteus config
* include configs in tests
2020-12-17 17:12:24 -05:00
GitHub build-unit-tests Action
34bd9642d0
Trigger wheel definitions
2020-12-14 00:34:22 +00:00
GitHub build-unit-tests Action
ee97cf4af7
Trigger wheel definitions
2020-12-13 21:52:33 +00:00
GitHub build-unit-tests Action
3141d96915
Trigger wheel definitions
2020-12-13 04:53:28 +00:00
Matthew Kennedy
378d118118
test ( #2071 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-12 23:40:05 -05:00
rusefi
7127048e67
random initial
2020-12-12 21:59:56 -05:00
David Holdeman
840e260b67
Trigger action ( #2070 )
...
* push triggers.txt
* tricky whitespace
* remove from gitignore
* add
* echo output for debug
* change path
2020-12-12 21:36:41 -05:00
Matthew Kennedy
83a65032d6
clang warnings again ( #2055 )
...
* s
* changelog
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-11 13:59:28 -05:00
rusefillc
9b4a1fff7b
clang warnings again #2055
2020-12-11 10:33:00 -05:00
Matthew Kennedy
f2426677db
start fuel pump as soon as trigger events happen ( #2038 )
...
* switch pump fsio logic
* value collision
* fuel pump in tests
* mock time since trigger
* test fp
* init pin in test
* fix gpio outputs in tests
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-10 01:23:24 -05:00
Matthew Kennedy
5f69d23976
fix mock pins array ( #2050 )
...
* fix
* fix probably
2020-12-10 00:10:58 -05:00
Matthew Kennedy
a08e79789d
second lambda (x-series CAN only, for now) ( #2048 )
...
* add sensor
* second sensor
* switch sensor name
* gobblin up your memory
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-09 20:26:23 -05:00
rusefillc
e6bfd9a2ed
trigger lifecycle
2020-12-09 12:19:25 -05:00
Matthew Kennedy
bad0e6b949
require redundant TPS for ETB ( #2041 )
...
* Require redundant tps for ETB (#2037 )
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
* add a test that fails but should not
* fix the bug
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-08 06:24:20 -05:00
rusefi
5bae56a32a
not this line yet?
2020-12-07 01:40:26 -05:00
rusefi
2a1b585bfe
Revert "Revert "Split ETB in to interface + implementation headers ( #2040 )""
...
This reverts commit 4f4bb957
2020-12-07 01:27:27 -05:00
rusefi
bb3cb0ba22
Revert "Require redundant tps for ETB ( #2037 )"
...
This reverts commit 4f1085a8
2020-12-07 01:11:32 -05:00
rusefi
4f4bb95770
Revert "Split ETB in to interface + implementation headers ( #2040 )"
...
This reverts commit d9a82c09
2020-12-07 01:11:19 -05:00
Matthew Kennedy
d9a82c09af
Split ETB in to interface + implementation headers ( #2040 )
...
* split etb interface
* mocks
* fix master while we're at it
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:29:09 -05:00
Matthew Kennedy
4f1085a87a
Require redundant tps for ETB ( #2037 )
...
* mod sensor api
* require redundancy
* fix tests
* check that it fails
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-07 00:05:06 -05:00
Matthew Kennedy
efef2bfe4f
more ETB test coverage ( #2039 )
...
* test no pedal map
* test open loop
* open loop but not throttle
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:59:18 -05:00
Matthew Kennedy
67269aa637
maybe fix sensor init checks ( #2034 )
...
* enums
* don't collide
* auto_generated_enums
* check based on new enum val
* maybe this will make generate tool happy
* add a test
* fix test
* fix and add another test
* make clang happier
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 23:19:57 -05:00
rusefillc
b3d45b909f
Revert "switch rpm calculator to use timer class ( #2005 )"
...
This reverts most of a26ed3eb5a
commit.
2020-12-06 18:05:53 -05:00
Matthew Kennedy
a26ed3eb5a
switch rpm calculator to use timer class ( #2005 )
...
* add api
* rpm calculator
* fix fsio
* fix float
* remove wrong comment
* fix timer
* clang didn't like this
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 16:01:45 -05:00
Matthew Kennedy
c5e3657d45
don't duplicate sensor error logic ( #2032 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 15:00:30 -05:00
Matthew Kennedy
9ccda6bbe7
add isRedundant ( #2031 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 14:55:06 -05:00
rusefillc
29141055ab
one step back #2017
2020-12-06 08:50:10 -05:00
Matthew Kennedy
2d9be1077b
require TPS values to be different ( #2017 )
...
* require values to be different
* fix not
* oops
* missed another spot
* test negative cases too
* resets
* test no sensor case
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:41:49 -05:00
Matthew Kennedy
ffae0cd335
round rpm instead of truncating ( #2023 )
...
* round rpm instead of truncating
* efiround is expensive
* Revert "efiround is expensive"
This reverts commit e5690f89e1b1988aacf5ced1f024d576465a7cd6.
* round is better than rintf
* testing
* it works now?!
* comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-06 00:11:57 -05:00
Matthew Kennedy
e544e8150a
unit tests in clang ( #2012 )
...
* clang errors
* non-test-only
* debugging
* rules on mac
* makefile
* put back
* let's see if this way makes everybody happy
* no, it does nto
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-05 23:21:17 -05:00
rusefillc
8c5fe1bf23
unit tests in clang #2012
2020-12-05 00:22:10 -05:00
shadowm60
864bd7fa73
Dyno view proposal ( #1999 )
...
* DynoView creation
module implementation and unit_tests
* update acc algo
we only calcualte new acceleration value if speed has changed, not on every callback.
* added acceleration ts_channel
* fixed broken unit tests
* fixed accel sign
* review updates
* Update test_dynoview.cpp
fix unit_tests
* Update engine_controller.cpp
Fix .ram4 unused size
* Update test_dynoview.cpp
2020-12-04 20:28:48 -05:00
rusefillc
1a7b0196f9
docs
2020-12-04 16:10:58 -05:00
rusefillc
e138621202
all triggers should be documented way nicer #2001
2020-12-04 11:58:26 -05:00
rusefillc
f021c37cc1
DAIHATSU 3CYLINDER TRIGGER WHEEL SUPPORT fix #2008
2020-12-03 23:12:30 -05:00
shadowm60
6fb745d29c
Launch Control refactoring ( #1992 )
...
* refactor
- called from periodicFastCallback
- removed defines
* Update rusefi.input
removed unused configurations.
added clutch inversion option
* Added new tests
fixed limiting only in case we have launch condition and rpm outside of window
* Update launch_control.cpp
Unintialized config update, now it is working fine with VSS and with clutch as well.
* small fixes
updated after review findings
* Fix breaking engine rev limiter
applyLaunchControlLimiting should not overwrite booleans to false!
* Delay timer in seconds
timer uses ms, so convert seconds to ms
2020-12-01 13:03:42 -05:00
rusefillc
f15efa7f15
dead engine config
2020-11-26 20:53:44 -05:00
Matthew Kennedy
a5ba9d54dc
fix etb unit test idle hardware ( #1991 )
...
* move check to etb
* give it a sensor to read
2020-11-26 19:21:42 -05:00
Matthew Kennedy
750070a496
fix etb wastegate percent output ( #1988 )
...
* wastegate etb should use percent
* percent_t
* fix test
2020-11-25 21:14:06 -05:00
Matthew Kennedy
492498f8d0
Boost tolerance ( #1986 )
...
* tolerate invalid closed loop config when in open loop mode
* fix test
2020-11-25 07:27:24 -05:00
rusefillc
90e5630e60
avoid float -> int64 conversion #1977
...
cherry picking...
2020-11-23 23:33:46 -05:00
Matthew Kennedy
55379463c0
remove ( #1985 )
2020-11-23 20:10:17 -05:00
Matthew Kennedy
747b3d2fa8
fix #1968 ( #1976 )
...
* tanf
* name
* comment, add test
2020-11-22 08:26:17 -05:00
rusefillc
fe93dfd8df
No latest gcov #1973
2020-11-19 21:57:18 -05:00
rusefillc
659b9c1973
No latest gcov #1973
2020-11-19 21:56:48 -05:00
rusefillc
9315b1e8de
No latest gcov #1973
2020-11-19 21:32:14 -05:00
shadowm60
7c793834ef
Launch control unit tests update ( #1972 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
* Launch control unit_tests
updated launch control for a better split
VSS mock for unit tests
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2020-11-19 21:14:38 -05:00
rusefillc
68c8d8c6a2
Starter is engaged on start-up in pull-up configuration #1969
...
usability & test improvement
2020-11-19 17:15:28 -05:00
Matthew Kennedy
ee51da64ad
Launch control testable ( #1967 )
...
* testable launch start
* extract base class
* add a test
* fix ts debug
2020-11-19 08:15:56 -05:00
Matthew Kennedy
f3b7a1d9da
Remove lockAnyContext, replace with CriticalSectionLocker ( #1938 )
...
* switch to CriticalSectionLocker
* that's just about all
* clean up last usage
* include hpp for sim
* need the cpp wrappers in the makefile too
* include dir
* include
2020-11-19 06:56:02 -05:00
rusefillc
47fbb92bff
Starter seems to be engaged forever fix #1965
2020-11-18 23:54:30 -05:00
rusefillc
7c2cb1d2ac
Starter seems to be engaged forever #1965
2020-11-18 23:06:44 -05:00
rusefillc
bec2e0b2e6
Starter seems to be engaged forever #1965
2020-11-18 22:56:05 -05:00
rusefillc
a9e0bffbbd
Starter seems to be engaged forever #1965
2020-11-18 22:47:40 -05:00
rusefillc
53f6f1e661
Starter seems to be engaged forever #1965
2020-11-18 22:42:41 -05:00
rusefillc
c52c6f45c9
Starter seems to be engaged forever #1965
2020-11-18 21:22:01 -05:00
rusefillc
7f688f7616
Starter seems to be engaged forever #1965
2020-11-18 20:53:03 -05:00
rusefillc
ee7e1880a2
Something something unit test ETB does not work #1966
2020-11-18 20:12:58 -05:00
rusefillc
e29911114a
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
rusefillc
35754d298a
Starter seems to be engaged forever #1965
2020-11-18 19:34:09 -05:00
Matthew Kennedy
5d3d85d644
put getTimeNowLowerNt in to mpu_util ( #1950 )
...
* put getTimeNowLowerNt in to mpu_util
* move GPTDEVICE to port_mpu_util
* and remove from efifeatures
2020-11-18 14:17:00 -05:00
Matthew Kennedy
5b0a178605
Fix crc again, for real this time ( #1948 )
...
* re enable
* changelog
* fix
* fix test
* put some tests back
2020-11-15 16:59:02 -05:00
rusefillc
e00a9b91c6
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:44:53 -05:00
rusefillc
43c5c7ff83
occasional tunerstudio CRC errors #1943
...
unit test progress
2020-11-15 12:36:07 -05:00
rusefillc
a42077bef8
occasional tunerstudio CRC errors #1943
...
now with a bit of a unit test
2020-11-15 12:27:47 -05:00
rusefillc
286fa10b15
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:55:26 -05:00
rusefillc
30a0082ed2
occasional tunerstudio CRC errors #1943
...
getting ready for unit test
2020-11-15 11:53:09 -05:00
Matthew Kennedy
0e3673e78c
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
Matthew Kennedy
bb8650179c
consolidate EFI_UNIT_TEST and friends ( #1940 )
...
* restructure
* guard c++
* idle too
* status_loop.h
* consolidate definitions
* use 1/0 instead, check for existence
* missed a few
* dead define
* defs for bootloader
2020-11-11 20:34:39 -05:00
Matthew Kennedy
d992bab241
Move all DECLARE_ENGINE_PTR etc to one place ( #1937 )
...
* restructure
* guard c++
* idle too
* status_loop.h
2020-11-11 19:06:04 -05:00
Matthew Kennedy
02c4d630f6
compensate injector flow based on fuel pressure ( #1931 )
...
* injector compensation
* fix
* ui
* testability & comments
* hella testing
* debug channels
* enum value
* auto generated enums
* update comment
* oops too much
* update config fields
* handle failed pressure sensor
* build
* fix
* add some todos for the future
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-10 23:11:22 -05:00
rusefillc
111b017442
refactoring
2020-11-05 18:10:44 -05:00
Matthew Kennedy
cf3dc9c2c3
convert cranking defaults to mg ( #1921 )
...
* convert cranking defaults to mg
* fix tests
2020-11-03 14:12:26 -05:00
Matthew Kennedy
3e30865e6c
unused tach field ( #1918 )
2020-10-29 15:26:01 -04:00
Matthew Kennedy
09b41bb1bb
Everything in lambda! ( #1893 )
...
* lambda
* default configs, fix build
* config, gauge, UI
* more digits
* change menu text
* fix that while I'm here
* doesn't need extra word
* todo note
* tests
* last test
* missed a config
* update java
* store target lambda
* more java
* format
* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
Matthew Kennedy
a90792fa44
convert mass -> duration later in the pipeline ( #1906 )
...
* cranking duration to mass
* implement
* units
* patch types
* suppress warning
* fix output channels
* add note about how to set it
2020-10-26 07:23:13 -04:00
Matthew Kennedy
f37ed597c5
fix double deadtime ( #1904 )
...
* move global correction factor to fuel mass
* tests
* the fix
2020-10-25 00:12:05 -04:00
Matthew Kennedy
10c1ad7698
use fuel model ( #1901 )
...
* use fuel model
* spit'n'polish
2020-10-23 20:25:47 -04:00
Matthew Kennedy
06f92807cc
second PID config for wastegate ( #1889 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
* consume
* add cfg field
* ui maybe
* fix
* fix
* add wastegate config test
2020-10-19 08:04:27 -04:00
Matthew Kennedy
42bfad807b
Etb wastegate hookup ( #1888 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
2020-10-18 21:57:04 -04:00
Matthew Kennedy
44653da2e5
Etb function cfg: actually read config ( #1884 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-18 17:26:38 -04:00
rusefillc
bd7dcf1709
HW CI has failed 11 times since Oct 2 #1849
2020-10-16 13:54:12 -04:00
Matthew Kennedy
a8057cfc16
write SD header using new Writer class ( #1882 )
...
* write header
* hooray, free memory!
* fix test
* is there really this much free space...?
* no, there is not
2020-10-15 16:00:13 -04:00
Matthew Kennedy
2083b34cf9
simplify getTimeNowNt() ( #1876 )
...
* remove old impl
* add cpp wrapper to os_access
* clean up os_access
* remove touchTimeCounter
* new impl
* put comment about lock free impl
* include cpp wrappers for BL
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-10-15 08:57:13 -04:00
Matthew Kennedy
299a345c1c
etb function config 1 ( #1881 )
...
* this should all be safe...
* test fix
2020-10-14 22:02:09 -04:00
Matthew Kennedy
2a0205e3c4
switch to single precision constants ( #1880 )
...
* adjust builds
* fix test
2020-10-14 20:04:35 -04:00
Matthew Kennedy
605e2590f1
buffered writer - progress on #1463 ( #1875 )
...
* add buffered writer
* rename
2020-10-12 15:10:34 -04:00
rusefillc
07a905b1fe
revering functional part of
...
Etb function cfg, try again #1860
try again from #1831
2020-10-08 17:09:00 -04:00
Matthew Kennedy
1bce3aa4c0
Etb function cfg, try again ( #1860 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-08 14:12:03 -04:00
Matthew Kennedy
cb47cde068
switch from float to expected<float> ( #1862 )
2020-10-06 22:33:00 -04:00
Matthew Kennedy
8cff16e797
FSIO refactoring ( #1861 )
...
* better fsio tests
* condense operators
* minor parser cleanup too
* comments, too!
2020-10-06 21:54:49 -04:00
Matthew Kennedy
5925a5f4bd
const ref-ify trigger ( #1856 )
...
* const ref-ify
* tests
2020-10-05 14:22:59 -04:00
Matthew Kennedy
c885db32f0
use expected for event queue next event ( #1859 )
...
* use expected for event queue next event
* minor cleanup
* tests
2020-10-05 13:53:34 -04:00
rusefillc
367436454d
HW CI has failed 11 times since Oct 2 #1849
...
Revert "ETB function config (#1831 )"
This reverts commit af59c45a
2020-10-03 22:00:00 -04:00
Matthew Kennedy
af59c45adb
ETB function config ( #1831 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-02 20:51:02 -04:00
Matthew Kennedy
f1c04efefa
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
rusefi
2d771018e8
unit test for start/stop hardware and pin repository #1811
2020-09-21 12:29:01 -04:00
rusefi
eef4e800b5
nicer parameter name
2020-09-21 08:57:56 -04:00
rusefi
77f15256b6
unit test for start/stop hardware and pin repository #1811
2020-09-21 08:57:37 -04:00
rusefi
f8f3e74d99
unit test for start/stop hardware and pin repository #1811
2020-09-21 05:02:35 -04:00
Matthew Kennedy
c1699d91d0
fix closed loop fuel ( #1797 )
...
* fix
* add a test
* signature
2020-09-19 03:44:01 -04:00
Matthew Kennedy
1fc55da3ca
two throttles one thread ( #1806 )
...
* two throttles one thread
* look at all this RAM!
2020-09-18 13:47:49 -04:00
Matthew Kennedy
97cb9f45bd
logging simplification: switch bare functions to member functions: try the second ( #1794 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
* fix sniffer
2020-09-13 11:49:25 +03:00
rusefi
256a4a2637
Revert "logging simplification: switch bare functions to member functions ( #1788 )"
...
This reverts commit d941bdc5
2020-09-12 04:36:24 -04:00
Matthew Kennedy
d941bdc502
logging simplification: switch bare functions to member functions ( #1788 )
...
* first pass
* first pass
* const means we don't have to check!
* static
* test fixup
2020-09-12 03:08:11 +03:00
David Holdeman
337106cd24
DebounceButton A/C switch ( #1782 )
...
* change acSwitch name, add mode
* fix
* remove some adc stuff
* remove some adc stuff
* semicolon stupid
* left behind
* add readpinstate
* wrong var name
* add functions back
* fix name
* bool, not void, plus fix name
* move
* not sure what I broke
* try setMockValue
* namespace
* whoops missed one
* switch values because adc was set up for pullup
* try 5
* comment for now
* comment for now
* uncomment tests, add function to mock, add mock to efiReadPin
* fixes
* for F's sake
* if
* add defy
* pass params
* use ASSERT_TRUE/FALSE
* advance time
* remove ifdef from readPin
* try moving if
* move to separate func
* move extern
* move include
* try engine_test_helper
* am confuse
* move func to else
* include hal
* add efi prod check
* remove include
* try extern
* move include
* semicolon stupid
* move extern again
* include
* move mockPinStates
* size
* add if
* add comment
* clean on instantiation
2020-09-10 22:16:20 -04:00
Matthew Kennedy
eebded8caa
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00