Andrey
9b920bf2fa
getBitRangeMsb
2023-11-15 00:28:43 -05:00
andreika-git
7d87aeaa5b
AlternatorController unit-tests
2023-11-10 17:13:50 -05:00
Andrey
950f0d4525
only:vincpy
2023-11-08 21:52:43 -05:00
Matthew Kennedy
87429dcc26
this test worked on everything but apple silicon apparently
2023-11-02 01:33:44 -04:00
Matthew Kennedy
2c049d206a
dead pid auto tune
2023-11-01 17:01:07 -04:00
rusefillc
5e311f99fb
test moved to library
2023-11-01 09:39:33 -04:00
rusefillc
9c54180bf6
T2 ( #5647 )
...
* fix unit-tests
* add cam/vvt support to trigger_emulator
---------
Co-authored-by: andreika-git <andrei.home@gmail.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-10-26 14:10:51 -04:00
Patryk Chmura
0a7cd2b08c
Closed Loop Idle Ignition Timing small improvements ( #5635 )
...
* After-start enrichment handling more similar to OEM and other Standalone EFI systems
* Corrections and tidying-up
* Corrected small mistake in TunerStudio definition
* Compatibility fixes
* Readability fix
* Changed to more appropriate cycles instead of seconds, bugfix for TS
* Typo fix...
* Idle Ignition Timing improvements
* Uninitialized variable for Unit Tests?
* Zero value should disable new feature
---------
Co-authored-by: pchmura4 <>
2023-10-24 17:43:29 -04:00
Matthew Kennedy
029bc9fdac
unit test for wrapAngle
2023-10-24 15:35:45 -04:00
Andrey
f2453ce251
open loop boost does not really require Map sensor
...
only:small-can-board
2023-10-19 21:22:59 -04:00
Andrey
300e08d4c4
only:making boost constraints more obvious, also running boost in simulator
2023-10-19 21:06:09 -04:00
rusefi
3db5c6e3f7
only:minor encapsulation
2023-10-12 23:15:54 -04:00
rusefillc
eac1430b08
only:hd
2023-10-11 23:47:34 -04:00
Matthew Kennedy
ab770b6892
limp test doesn't rely on defaults
2023-10-11 21:20:43 -04:00
Andrey
680d18e433
VVT control is broken on second bank fix #5599
2023-10-07 12:54:45 -04:00
Andrey
3b1fe9da7f
only: VVT refactoring reducing magic index math
2023-10-07 12:34:32 -04:00
rusefillc
64773d8351
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: extra coverage
2023-10-05 23:24:19 -04:00
rusefillc
384973ad2a
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: extra coverage
2023-10-05 23:17:05 -04:00
rusefillc
a2f147ebc0
Retarding exhaust VVT which drives DI pump causes issues #5596
...
only: extra coverage
2023-10-05 23:09:45 -04:00
Andrey
abad7c8e7d
only:fixing test to have HPFP not just in cranking
2023-10-05 20:20:34 -04:00
Andrey
3b2b90436d
only:making test simpler
2023-10-05 19:20:27 -04:00
Matthew Kennedy
a519fd13ad
vvt is engine module
...
* vvt refactoring
* vvt constexpr livedata
* format
* fix null deref
2023-09-26 09:07:59 -04:00
rusefillc
be35a5eb23
fan control is engine module ( #5585 )
...
* fan is engine module
* mockable AC
* mockable AC
* mock AC controller in fan test
* constexpr fan livedata
* isPtr
Co-authored-by: Matthew Kennedy <matthewkennedy@outlook.com>
2023-09-26 07:12:11 -04:00
Andrey
d4916f3c95
only:hello VAG
2023-09-21 20:01:29 -04:00
Andrey
6eb0619d9c
only: 36/2/2/2 is confusing #5566
...
writing raw value into meta file - moving logic closer to where it's needed giving TriggerImage more direct access to meta info
2023-09-16 00:02:59 -04:00
Andrey
eaef8dfb09
only:rename
2023-09-15 23:59:13 -04:00
Matthew Kennedy
bc637c4e6b
rename 2jz -> toyota 3 tooth
2023-09-14 17:42:27 -04:00
Andrey
955f3cb9ca
only: 3/0 cam real test
2023-09-14 08:34:23 -04:00
Andrey
e5f7c9885c
testability: bench test commands should have automated coverage using simulator #5562
2023-09-11 00:03:10 -04:00
Andrey
e74edbe365
only:uint8 scaled test
2023-09-10 13:39:54 -04:00
Andrey
247a0a91b5
spelling is important
2023-09-09 19:54:57 -04:00
Andrey
b5fd6ea044
spelling is important
2023-09-09 19:53:18 -04:00
rusefi
1d64003dd6
only:WrapAround62 goes to libfirmware
2023-08-30 23:47:26 -04:00
rusefi
78e48d3718
only:timer.h goes to libfirmware!
2023-08-30 23:11:24 -04:00
Andrey
63295873b4
reducing/moving technical debt
2023-08-29 16:53:49 -04:00
Andrey
d2f899e737
reducing/moving technical debt
2023-08-29 16:46:04 -04:00
rusefi
720ba01d04
proteus fails to start while powered by stim board #5545
...
only:proteus_f7
2023-08-29 00:46:21 -04:00
Andrey
e9e0ef5a89
"rpmAcceleration" in TS doesn't go lower than 0 #5504
...
only: rpmAcceleration unit test
2023-08-09 04:53:00 -04:00
rusefillc
86a2d1e8e9
better output file name
2023-08-08 20:09:18 -04:00
rusefillc
d77fb3bf24
"Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488
2023-08-06 00:46:33 -04:00
Andrey
f3a5586e36
Custom Trigger Tooth with 1+0 causes endless loop fix #5471
2023-08-05 12:59:11 -04:00
Andrey
0787b4f4a0
Custom Trigger Tooth with 1+0 causes endless loop #5471
...
only:test
2023-08-05 12:44:16 -04:00
rusefillc
77ef4db8ab
Simplified VVT single tooth cam modes. ( #5483 )
...
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
* Simplified VVT single tooth cam modes.
---------
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-08-03 20:24:22 -04:00
rusefillc
450b3cfa92
lua lib
2023-07-31 00:36:20 -04:00
Andrey
db2db5dcfc
only:Vadim is asking for SyncEdge to be reflected on trigger images #5472
2023-07-29 14:12:10 -04:00
Matthew Kennedy
a4fd161606
test lambda monitor response #75
2023-07-26 10:00:39 -04:00
rusefi
0099de49af
ignition timing clamping settings
2023-07-22 00:07:15 -04:00
rusefi
2a5772374c
ignition timing clamping settings
...
only:status quo
2023-07-21 23:45:03 -04:00
Andrey
350df9889d
deadband for PPS #5420
...
only: just a test for now
2023-07-20 17:13:43 -04:00
Andrey
5155369bf6
launch control: Speed threshold depends on launch mode, also zero speed limit handling #5419
2023-07-20 16:26:33 -04:00
Andrey
dabae98f16
launch control: Speed threshold depends on launch mode, also zero speed limit handling #5419
...
only: change zero setting handling
2023-07-20 16:26:11 -04:00
Andrey
3c090129e6
launch control: Speed threshold depends on launch mode, also zero speed limit handling #5419
...
only:TDD
2023-07-20 16:05:16 -04:00
Matthew Kennedy
ba1b6c5cb9
lambda monitor test file
2023-07-18 14:11:59 -04:00
Andrey
8e76a82a26
only:last step of trigger_type_e enum refactoring
2023-07-13 19:30:54 -04:00
Andrey
b8b9a3da07
only:helping lua scripts
2023-07-09 21:29:34 -04:00
rusefillc
bf3b0d61d6
only:proteus_f7
...
lua lib fixes
2023-07-09 19:34:13 -04:00
Andrey
8d7794a265
only:kia CAN
2023-07-07 23:36:23 -04:00
Andrey
24763c4a62
only:kia CAN
2023-07-07 23:25:13 -04:00
Andrey
fec4ffa6cb
only:kia CAN
2023-07-07 21:12:41 -04:00
Matthew Kennedy
7f67ecd02d
simplify adjustCrankPhase
...
(cherry picked from commit 7ae11160d9bfb31a664130e66586e849b8201c8a)
2023-06-28 21:49:51 -04:00
Matthew Kennedy
6b54916d12
real test of 12+1 ( #177 )
2023-06-28 21:17:04 -04:00
Matthew Kennedy
e03bbd00aa
explicit tests for batch and single point
2023-06-26 10:41:16 -04:00
Matthew Kennedy
ae3ae86e75
fix (honestly gross) tests to work in two wire batch
...
(cherry picked from commit 01b4f1191a61012e64e3ee480b3f99a93e5f2073)
2023-06-25 00:25:11 -04:00
Matthew Kennedy
10c5c4ec94
#23 and fix https://github.com/rusefi/rusefi/issues/5353
...
(cherry picked from commit b0c3357cba5a3a08ab481dd9cb76f1ab95114ed4)
2023-06-25 00:25:07 -04:00
Andrey
cd4c78745e
only:Split ConfigGenerator around trigger_defines.txt #5051
2023-06-17 22:41:40 -04:00
Andrey
9207b2fd63
start button logic does not crank started for first X seconds since ECU boot fix #5324
2023-06-15 18:36:50 -04:00
rusefi
1a8cacf7c1
Dashpot for return-to-idle from coasting
2023-06-12 15:39:49 -04:00
Andrey
77c55b9f88
Dashpot for return-to-idle from coasting #5303
...
third step towards unit test
2023-06-11 18:42:58 -04:00
Andrey
926d113725
Dashpot for return-to-idle from coasting #5303
...
second step towards unit test
2023-06-11 18:09:36 -04:00
Andrey
2ae85de636
Dashpot for return-to-idle from coasting #5303
...
small step towards test
2023-06-11 18:04:23 -04:00
Matthew Kennedy
b150b8702d
implement temp sensor pulldown mode
2023-06-10 18:18:34 -04:00
andreika-git
2188ef45a9
more unit tests for trigger_input_adc
2023-06-06 23:59:52 +03:00
rusefillc
551e7d5b38
p from past
2023-06-05 11:44:56 -04:00
andreika-git
19be36d524
more unit-tests with RPM checks for trigger_input_adc
2023-06-02 07:27:37 -04:00
rusefi
99b4ea78d9
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
rusefi
633274055b
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
rusefi
1908896598
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
rusefi
415b3d55df
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 01:45:53 -04:00
Andrey
965cdd466c
nissan BCM
2023-05-31 23:25:33 -04:00
Andrey
0265582f28
setSparkSkipRatio limitation #5231
2023-05-25 18:52:19 -04:00
Andrey
1aa8e879dd
setSparkSkipRatio limitation #5231
2023-05-25 15:17:07 -04:00
Andrey
8c9b17485e
Revert "Allow scheduling_s to come from a pool ( #4841 )"
...
This reverts commit 5250b177
2023-05-25 10:10:17 -04:00
Matthew Kennedy
06cda6cfa4
add postState flag to airmass model calls #107
...
(cherry picked from commit b1b1ec7fdf0ee9b5955541bcaa6be7cf66636412)
2023-05-16 13:02:45 -04:00
andreika-git
7df63c03f6
boostCutPressureHyst impl+tests https://github.com/rusefi/rusefi/issues/4529
2023-05-05 17:28:34 -04:00
Matthew Kennedy
997f2bfb21
Test fix due to scaling change
...
(cherry picked from commit 99fbf7f01f703152fc8e7c6db71ce888dbd1f3c5)
2023-05-04 22:00:42 -04:00
Matthew Kennedy
13bf4af577
Test fix due to scaling change
...
(cherry picked from commit 7cc3fb54726ffed4f6f285c275329ba47aba138a)
2023-05-04 22:00:42 -04:00
Matthew Kennedy
3d1dc5a442
table-only map fallback ( #46 )
...
* table-only map fallback
* InSequence
(cherry picked from commit 4cd08fbc4b8205028c6f4aaa359264f672dd3798)
2023-05-04 11:02:39 -04:00
Matthew Kennedy
56f2bfab07
happy tests
...
(cherry picked from commit 416cfa1a924d510acfb3573be4031f1cd23c9672)
2023-04-30 10:54:38 -04:00
Matthew Kennedy
831e016bc4
register/unregister
...
(cherry picked from commit c682c49d4608cb071e512f926b2729e6927e1d7d)
2023-04-30 10:54:38 -04:00
Matthew Kennedy
4e7e25585e
gear detection in to the sensor model
...
(cherry picked from commit 82794403f86023d36a211e349ca2ff530eb2eb3c)
2023-04-30 10:54:38 -04:00
Matthew Kennedy
769718771c
better idle VE table transition
...
(cherry picked from commit bdeeb82f932d91fdae86ba5f39c8ae3a18dcfa32)
2023-04-30 00:21:52 -04:00
Matthew Kennedy
a19baddd47
support abs+gauge+diff fuel pressure #32
...
(cherry picked from commit cb0e81b062c1b83038b69ac416f71b37956a0f9b)
2023-04-30 00:20:11 -04:00
Matthew Kennedy
757d12e97b
convert throttle model to g/s instead of kg/s
...
(cherry picked from commit c47d7394c5ebf43c45869fcd44a30ec505e3e84e)
2023-04-29 23:23:00 -04:00
Matthew Kennedy
1a1372ffe9
throttle model tests
...
(cherry picked from commit d14d442157c76fb901ed3647ad5ecdcd3c9c79ad)
2023-04-29 19:29:13 -04:00
Matthew Kennedy
a9dd5ee404
Throttle model #63
...
(cherry picked from commit 7ee63df142fc363c4ab927a5ba9078aab9bad70d)
2023-04-29 19:14:53 -04:00
Matthew Kennedy
9ae8e18757
only: cherry picking: it's going to be painful
2023-04-29 15:14:58 -04:00
Andrey
e748e65638
only: cherry picking: it's going to be painful
2023-04-29 15:07:43 -04:00
Matthew Kennedy
3247ff1cd7
exact miata test
...
(cherry picked from commit 3d72c297b7036ef9f23ee5e526b06f0832a50033)
2023-04-29 12:47:29 -04:00
Matthew Kennedy
4935cf5fb3
more dead stuff
...
(cherry picked from commit b9d065ae4e867e65d2ab9049961a4044d967013d)
2023-04-29 05:15:34 -04:00
Matthew Kennedy
3249ae2a28
test builds
2023-04-29 00:44:00 -04:00
Matthew Kennedy
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
Matthew Kennedy
01f7e4068d
rename obd_code_e -> ObdCode
...
(cherry picked from commit d6534157a03d19bb2e8aeece301642c053a081d0)
2023-04-29 00:44:00 -04:00
Matthew Kennedy
7396d466c4
cj125
...
(cherry picked from commit fd09ad7b4f2a9c450aedf4a535db4edd24bdcee1)
2023-04-29 00:15:54 -04:00
rusefillc
f10bb77666
Merge branch 'master' of https://github.com/rusefi/rusefi
2023-04-28 22:53:42 -04:00
Andrey
da6d394482
it's going to be painful
2023-04-28 22:48:02 -04:00
Matthew Kennedy
bb49b22294
joystick, lcd
...
(cherry picked from commit 61c17791b89fc6b5ae17df96d9498c088afdb09f)
2023-04-28 22:32:37 -04:00
Matthew Kennedy
c5abc06429
nobody should use NA6 VAF
...
(cherry picked from commit 0072e8f33cd9645ee67ab8fe9a3cc0d35001081a)
2023-04-28 21:52:48 -04:00
Matthew Kennedy
2857e9527d
remove specs_s struct, flatten config
...
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
Andrey
d7b9961c4b
only:honda
2023-04-22 11:29:15 -04:00
Andreika
c17e2adfb7
RPM limit fix and unit-tests ( #5238 )
...
* fix rpm limit timing/fuel corrections
* rpm limit timing - more unit-tests
2023-04-15 12:03:47 -04:00
Andrey
f296398098
TEST(etb, intermittentTps) local WSL and GHA runs produce different results #5233
...
only:mre_f4
2023-04-11 20:01:01 -04:00
Andrey
a18f75f3f9
sensor checker is not checking sensors fix #5232
...
only:mre_f4
2023-04-11 18:33:15 -04:00
Andrey
954da551f7
sensor checker is not checking sensors fix #5232
2023-04-11 16:06:38 -04:00
Andrey
a2930e60b8
todo: warnings would have been nice!
2023-04-11 16:03:53 -04:00
Andreika
919ed2d934
RPM soft limit and hysteresis #5214 , #5224 ( #5228 )
...
* [DRAFT] RPM soft limit and hysteresis #5214 , #5224
* fix m_timingRetard
* fix rpmHardLimitHyst
* unit-tests for #5214 , #5224
2023-04-10 17:18:51 -04:00
Andrey
0098a3d4b9
Clean-up all the 4g drama #5213
2023-04-01 15:40:24 -04:00
Andrey
6c1a8d501e
4g is symmetrical crank not just four stroke crank #5211
...
only:alphax-4chan
2023-03-30 23:31:47 -04:00
Andrey
f53937ae87
K
...
only:hellen-honda-k
2023-03-29 22:57:31 -04:00
Andrey
91e1eb825f
K
...
only:hellen-honda-k
2023-03-28 21:42:20 -04:00
Andrey
5ff4db0d65
rusEFI needs K-line firmware support #3248
...
something seems to not be working right, test time
2023-03-10 18:36:03 -05:00
Andreika
c9c33e02e9
weird: happy running car shows unrealistic vvtSyncGapRatio #5152 ( #5163 )
2023-03-08 16:52:56 -05:00
Andrey
e9da0eeed2
K
...
only:mre_f4
2023-03-04 16:00:50 -05:00
Andrey
e08cdf0fb6
trigger refactoring
...
only:mre_f4
2023-03-03 00:21:40 -05:00
Andrey
c08e4c3af5
only:mre_f4
2023-03-01 17:20:34 -05:00
Andrey
68fee9905f
Native SENT TPS input #5079
...
hasValidFast progress!
only:mre_f4
2023-03-01 15:23:38 -05:00
Andrey
c3765829e0
Native SENT TPS input #5079
...
status quo
only:mre_f4
2023-03-01 15:21:35 -05:00
Andrey
976b3c0306
Native SENT TPS input #5079
...
only:mre_f4
2023-03-01 14:26:30 -05:00
Andrey
40b61375e3
i love (unit) testing!
2023-02-23 05:12:20 -05:00
Andrey
5a735c9059
Native SENT TPS input #5079
...
only:alphax-4chan
2023-02-22 13:41:43 -05:00
Andrey
eed7521035
docs
...
only:alphax-4chan
2023-02-22 09:28:34 -05:00
Andrey
e4fa54ac5c
Feb20: 3rd ticket for 4g9x mess #5111
...
adding more lightness
only: alphax-4chan
2023-02-21 16:10:21 -05:00
Andrey
66178285b1
making test stronger
2023-02-20 22:25:24 -05:00
Andrey
9c31c1f02a
just more test, does not help :(
2023-02-20 20:37:40 -05:00
Andrey
5ec7341335
just a rename
2023-02-20 20:37:39 -05:00
Andrey
57baf7517b
Feb20: 3rd ticket for 4g9x mess #5111
...
adding lightness
2023-02-20 18:22:51 -05:00
Andrey
f99f0e1dcf
minor bugfix
2023-02-18 23:58:06 -05:00
Andrey
38dd0bcf3a
TDD for minor bug
2023-02-18 23:14:02 -05:00
rusefi
096be69c20
DC is not ETB
2023-02-18 22:39:45 -05:00
Andrey
abab788d20
Nick wonders if DC wastegate is still FUBAR #5075
2023-02-17 22:17:09 -05:00
Matthew Kennedy
325417caa7
fix 4g63 vs 9x naming, add cam-only test ( #5093 )
2023-02-16 23:22:34 -05:00
Nathan Schulte
802f6b47b1
explicit RedundantSensor redundancy unit tests ( #5085 )
2023-02-16 07:18:18 -05:00
Matthew Kennedy
632cf9dd2d
remove useETBforIdleControl ( #5054 )
...
* remove useETBforIdleControl
* etb integrated
* jni weirdness
2023-02-12 16:49:12 -05:00
Matthew Kennedy
6e89e71d0a
more flexible GPPWM ( #5032 )
...
* gppwm improvements!
* test
* ui
* autoscale
2023-02-06 08:53:31 -04:00
Matthew Kennedy
827dc22757
rewrite neon trigger ( #5003 )
...
* rewrite neon trigger
* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Matthew Kennedy
9630edfbf8
mitsu 4g63 ( #5001 )
...
* mitsu 4g63
* file header
2023-01-24 06:53:40 +05:30
Matthew Kennedy
d92b90c0a5
emit v2 mlg ( #4979 )
...
* emit v2 mlg
* missed a spot
* s
* s
* binary log unit test
* sd generator test
* oop
* getcategory
* write zeroes instead of null pointer in case of no category
2023-01-21 07:31:40 +05:30
rusefillc
5368f60b22
h-bridge wastegate not alive on bench #4965
...
fixing master
2023-01-18 02:12:34 -05:00
Andrey
6588e813ae
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-15 08:26:38 -05:00
Andrey
9abdab795d
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 23:21:23 -05:00
Andrey
0c1859b77e
totalFuel and totalIgnition correction gauges in Tunerstudio #4955
2023-01-14 15:33:17 -05:00
Matthew Kennedy
d5b00e1187
don't warn if we intentionally skipped this spark ( #4961 )
...
* don't warn if we intentionally skipped this spark
* header
* real nb2
2023-01-10 19:07:44 -05:00
Matthew Kennedy
eb56c2897a
detect and ignore doubled trigger edges ( #4656 )
...
* isToothExpectedNow
* s
* s
* kick ci
* only warn at high enough RPM to detect non-smooth trigger
* 4b11 test
2023-01-10 16:07:17 -05:00
Matthew Kennedy
1eca0ca1bd
Jammed ETB detection ( #4873 )
...
* jammed ETB detection
* autoscale
* comment
* cleanup
* implement test, cleanup
2023-01-10 15:31:04 -05:00
Andrey
289171a85a
symmetrical shapes are not rendered right #4956
2023-01-08 22:37:35 -05:00
rusefillc
2e882986f4
refactoring
2023-01-08 22:30:57 -05:00
rusefillc
68dcbd214e
sweet 4g93 data
2023-01-07 17:31:13 -05:00
Andrey
0f1d46238f
Mitsubishi 4G93 Trigger issues #4918
2023-01-07 16:28:57 -05:00
Matthew Kennedy
e5d199272d
improve iat ignition table ( #4948 )
...
* iat ignition table
* changelog
2023-01-06 21:59:34 -05:00
Andrey
987e59f7cc
Mitsubishi 4G93 Trigger issues #4918
...
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey
def809aa39
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey
c9d88d2605
a bit of dead code
2023-01-03 13:59:25 -05:00
Andrey
d0f6fa8ea3
let's try again
2023-01-03 08:38:42 -05:00
Andrey
603f188b55
a bit of dead code
2023-01-03 07:49:17 -05:00
Andrey
c8b998a911
test coverage for antilag #4920
...
fuel correction bugfix & test
2022-12-31 14:48:25 -05:00
Andrey
1afa6fa99a
test coverage for antilag #4920
...
bugfix?
2022-12-30 12:21:04 -05:00
Andrey
7138b9d1c1
test coverage for antilag #4920
2022-12-30 12:17:53 -05:00
Andrey
57d76d902f
test coverage for antilag #4920
2022-12-30 12:11:57 -05:00
rusefillc
24cdca5515
refactoring: method name
2022-12-27 00:13:13 -05:00
rusefillc
e189d6517b
random Frankenso clean-up
2022-12-14 19:29:01 -05:00
Matthew Kennedy
5250b177c2
Allow scheduling_s to come from a pool ( #4841 )
...
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
* injection events use scheduling pool
* knock and prime
* bench test
* dropped this: *
* extract action before execute
* comment
* init allocated timers
* metrics
* dropped this: ,
* guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy
994ee2f22f
Combine angle based event ( #4884 )
...
* Remove AngleBasedEventOld/New, only AngleBasedEvent now
* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy
2c58579a8d
switch hpfp and aux valves to AngleBasedEventNew ( #4882 )
...
* switch hpfp to AngleBasedEventNew
* aux valves too!
2022-12-10 16:15:11 -05:00
rusefillc
5e62595d69
reduce flash footprint by smarter code generation #4163
2022-12-03 00:51:41 -05:00
Matthew Kennedy
466833d95a
ETB error counter logic ( #4854 )
...
* simplify ETB error counter logic
* dropped this: {
* happy test
* reorder logic, test etbErrorCode
* test that fails
* independent TPS and PPS counters
* missed a file
* happy test
2022-11-30 22:20:09 -05:00
Andrey
32e502c569
ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832
2022-11-30 21:23:13 -05:00
Andrey
405b23d682
ETB overheats due to constant isTpsError true/false/true/false jitter: this seems obvious enough to disable ETB at least on non running engine #4832
2022-11-30 20:08:19 -05:00
Andrey
e6993aa248
ETB duty cycle jitter: only monitoring within this ticket #4833
2022-11-30 19:48:08 -05:00
rusefi
5499938d52
x2 spelling
2022-11-30 17:14:16 -05:00
Andrey
4e74882c5e
ETB duty cycle jitter #4833
...
need whole output not just closed loop part
2022-11-30 15:25:50 -05:00
Matthew Kennedy
151416b005
default fuel cleanup and injection phase change ( #4836 )
...
* default fuel cleanup and injection phase change
* happy tests
* changelog
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Andrey
6ad3ce13d6
ETB duty cycle jitter #4833
2022-11-29 20:51:28 -05:00
Andrey
98e886e00b
mock invalid & current state of ETB error counter
2022-11-29 20:36:03 -05:00
Andrey
9a1c7b36ba
refactoring: extracting method
2022-11-29 20:11:34 -05:00
Andrey
21b217f132
ETB duty cycle jitter #4833
...
do-you-TDD
2022-11-29 16:05:36 -05:00
Andrey
3070e1b3c8
ETB duty cycle jitter #4833
2022-11-29 14:59:08 -05:00
Andrey
368517780d
ETB duty cycle jitter #4833
2022-11-29 14:02:44 -05:00
Andrey
607a5677d4
ETB overheats due to constant isTpsError true/false/true/false jitter #4832
2022-11-29 11:42:09 -05:00
Andrey
4dd9217327
unit test compile more of ETB code
2022-11-28 23:41:51 -05:00
Andrey
5b88c6b535
exp average is pretty cool
2022-11-28 19:22:45 -05:00
Andrey
bb59bbbe51
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 21:16:50 -05:00
Andrey
61de170d06
ETB duty cycle jitter #4833
...
weird, whatever for now :(
2022-11-27 20:55:10 -05:00
Andrey
b00a7e506b
ETB duty cycle jitter #4833
...
a step back to safety
2022-11-27 19:26:28 -05:00
rusefillc
55062b1ef6
refactoring: constexpr fuel computer ( #4830 )
...
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
* refactoring: constexpr fuel computer
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 12:25:04 -05:00
rusefillc
23698be5f8
without ValueProvider3D interface how do we mock? ( #4829 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-11-26 11:23:54 -05:00
Andrey
3b7b8e3f33
nissan
2022-11-23 23:45:25 -05:00
rusefillc
8eaa901595
avoid ctime in GPS UART ( #4824 )
...
Co-authored-by: Nathan Schulte <nmschulte@desmas.net>
2022-11-23 13:20:36 -05:00
Nathan Schulte
fd1115d01a
code style, GPS fixes (test, firmware) ( #4822 )
...
* tidy NMEA
* const in nmea
* correct gps test output
* fix GPS UART print statements
* cleanup feature toggles in settings
* fix comment typos, misc whitespace
2022-11-23 07:01:34 -04:00
Andrey
6ca9b6eda7
refactoring: default parameter, global replace
2022-11-16 14:28:43 -05:00
Andrey G
27166f4b23
SENT updates ( #4774 )
...
* SENT: simplify
* SENT: add crc6 routine, check crc for slow channels enhanced messages
* SENT: helper to get Slow Channel values
* SENT: getTickTime() report tick unit time
* unit_tests: SENT: update tests
2022-11-12 16:57:20 -05:00
Andrey
3def9396de
Nissan
2022-11-12 13:06:55 -05:00
Andrey G
64be738874
SENT unit tests ( #4769 )
...
* unit_tests: sent: zero-init
* sent: SENT_SLOW_CHANNELS_MAX to header
* unit_tests: sent: clock, falling edges
* SENT: support and autodetect if device sends pause pulse
Also rework tick time calculation
* unit_tests: SENT: verbose debug on request
* unit_tests: SENT: actual checks
* unit_tests: SENT: extract common code for reuse
* unit_test: SENT: add test with fuel pressue captured data
* unit_test: SENT: add test with Ford ETB CLOSED captured data
2022-11-11 17:25:02 -05:00
Matthew Kennedy
5c50ad2db4
infer useOnlyRisingEdge by trigger type ( #4621 )
...
* most of the plumbing
* easy tests
* trigger types that are rise only
* configs
* change mode of various triggers
* vvt
* 898 test is now impossible 🥳
* s
* instant rpm test
* actually remove useOnlyRisingEdgeForTrigger
* remove vvtCamSensorUseRise
* s
* print
* one happy test
* another test
* happy testSomethingWeird
* happy testCamInput
* maybe fix it a different way
* better
* quad cam
* nb2 happy
* bad merge
* vvt test
* trigger.test1995FordInline6TriggerDecoder
* hellen gm e67
* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy
7bd9dbf89e
fix vvt logging logic ( #4747 )
...
* fix vvt logging logic
* put that back
* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
Andrey
a25c9ab520
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-07 00:06:42 -05:00
rusefillc
6d3e71fae3
Ford SENT ETB bench test in NJ #4745
...
we shall unit test SENT
2022-11-06 23:21:54 -05:00
rusefi
1f3ab0cf24
reducing ugly
2022-11-06 21:28:38 -05:00
rusefi
9ccb0ccb0c
https://rusefi.com/forum/viewtopic.php?p=46603#p46603
...
calling 'setTimeout' on bad self (cpp class not export)
2022-11-06 20:09:01 -05:00
Andrey
a5136a0eae
trigger refactoring: instance RPM #4740
2022-11-06 11:05:57 -05:00
rusefillc
36d5b1fbb6
minor trigger refactoring
2022-11-06 00:59:29 -04:00
Matthew Kennedy
f4f5f69ee6
duplicate log field names ( #4730 )
...
* remove duplicate target lambda/afr
* names on fuel computer
* remove more copies
* sensor.java
* everybody loves hard dependencies on generated fields
* target afr gauge fix
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-05 20:23:09 -04:00
Matthew Kennedy
1269428044
remove idle timing deadzone ( #4731 )
...
* remove idle timing deadzone
* test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-04 15:02:20 -04:00
Andrey
ccca90cb55
Nissan defaults
2022-11-02 12:05:51 -04:00
rusefi
93f9e81e9e
huh, we can pole larger method here
2022-10-26 12:08:27 -04:00
Matthew Kennedy
24650f6460
implement "ford mode" injector correction ( #4686 )
...
* implement "ford mode"
* missed the enum value
2022-10-20 22:25:39 -04:00
Matthew Kennedy
f760ae11c1
simplify initializeSkippedToothTrigger ( #4674 )
2022-10-17 16:05:27 -04:00
rusefillc
d13a851c97
triggerImage: todo: support symmetrical crank
2022-10-16 10:33:38 -04:00
rusefillc
5fb9f7c2df
triggerImage: todo: support symmetrical crank
2022-10-16 02:59:57 -04:00
rusefillc
d91211106c
triggerImage: todo: support symmetrical crank
2022-10-16 02:44:57 -04:00
Matthew Kennedy
aa881efe89
fix 36-2-1 trigger ( #4645 )
...
* fix
* test files
* test real 4b11
* test.mk
* better angle error math
* test GM too
* changelog
2022-10-09 21:22:05 -04:00
Matthew Kennedy
d6647025cc
2jz test ( #4638 )
2022-10-05 20:48:28 -04:00
Andrey
83afa58baf
Mark is asking for VIN number field #3967
2022-10-04 21:12:51 -04:00
Matthew Kennedy
940e0dc369
require ignition on for firing ( #4628 )
...
* require ignition on for firing
* too much havoc for a unit test
* patch up references
* last one
* fix changelog mangling
* fix the changelog template too
* bad merge
* fix the template again
* s
* fake battery voltage on hw ci
* ugh merge
* ugh merge
2022-10-04 20:36:03 -04:00
Matthew Kennedy
ec5d48fb5b
remove 898 ( #4634 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-10-04 20:12:57 -04:00
Matthew Kennedy
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
b089825a4a
schedule ignition charge by angle instead of tooth ( #4513 )
...
* schedule ignition charge by angle
* same mistake as #4536
* s
* wrap sparkAngle too
* AngleBasedEventNew
* function moved
* implement scheduleOrQueue
* prints
2022-09-25 11:00:55 -04:00
Matthew Kennedy
ae6c44634b
better k gaps ( #4623 )
2022-09-25 09:14:29 -04:00
Matthew Kennedy
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Andrey
612d52645a
Honda K cam wheels #3405
2022-09-25 00:26:42 -04:00
Andrey
9d27780974
Honda K cam wheels #3405
2022-09-24 23:49:41 -04:00
Andrey
111220d38c
more inclusive configuration name
2022-09-24 23:49:41 -04:00
Andrey
cff779dd78
K progress
2022-09-24 23:18:57 -04:00
Andrey
a38d87b0e0
fancy default and reusing constant
2022-09-24 23:01:42 -04:00
Andrey
93e64a61a6
fancy
2022-09-24 22:54:58 -04:00
Andrey
33be12541b
K
2022-09-24 15:37:51 -04:00
Andrey
0eef498b3e
refactoring: extract constant
2022-09-24 15:33:01 -04:00
Matthew Kennedy
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
c4699efe91
honda K enum rename
2022-09-23 20:13:14 -04:00
rusefillc
2f18168d47
K20
2022-09-23 20:13:14 -04:00
rusefillc
ed72758a5d
K20
2022-09-23 18:25:24 -04:00
Matthew Kennedy
dfe1b47b4d
remove ignitionPin ( #4608 )
...
* remove ignitionPin
* now that's gone
* BMW test
2022-09-23 17:30:10 -04:00
Matthew Kennedy
af7e4f6fe5
two modes trigger scheduler ( #4598 )
...
* two modes trigger scheduler
* asOld
* hpfp
2022-09-20 05:28:23 -04:00
rusefillc
60e703e079
B6
2022-09-17 23:49:24 -04:00
Andrey
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey
82cda62bac
inline method to reduce confusion
2022-09-14 01:34:52 -04:00
Andrey
6b0941b8ed
inline method to reduce confusion
2022-09-14 01:24:19 -04:00
Andrey
954ddacd96
GM
2022-09-14 00:03:38 -04:00
Andrey
8ce57d5599
code formatting
2022-09-13 23:44:38 -04:00
Andrey G
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00