Commit Graph

440 Commits

Author SHA1 Message Date
rusefi 9c77bc709a only: better method name 2024-04-10 00:02:39 -04:00
Andrey 090599c27e bosch quick start decoding issue or else #6281
test VVT decoding from file
2024-03-24 08:03:32 -04:00
Andrey d0dd8b1d4b bosch quick start decoding issue or else #6281 2024-03-24 00:23:31 -04:00
Andrey 739131180b bosch quick start decoding issue or else #6281
only:test coverage
2024-03-23 23:22:37 -04:00
rusefillc bbc2c0aab8 bosch quick start decoding issue or else #6281
only: real vehicle data
2024-03-23 22:46:01 -04:00
Matthew Kennedy a50fdf34d4 avoid UB in tests 2024-03-23 07:54:27 -04:00
rusefillc 5a06e47fd3 better names for 3/5 GM 24xs 2024-03-22 13:44:18 -04:00
Andrey 9a43bc2758 only:additional coverage 2024-03-20 10:31:23 -04:00
rusefillc fbea4c3731 only: renaming test 2024-03-20 10:20:40 -04:00
rusefillc a05c0ef730 engine type clean-up 2024-03-06 00:13:11 -05:00
rusefillc f4b1a7bae0 engine type clean-up 2024-03-06 00:13:11 -05:00
Andrey df6ec17a64 odd fire timing_offset_cylinder not accounted by injection #6095
only: TDD to the win
2024-02-29 09:49:03 -05:00
Andrey 41d5b527cc only: NICE! these values actually mean something! 2024-02-28 23:22:01 -05:00
Andrey b335244601 only: reducing magic numbers in unit tests 2024-02-28 20:44:22 -05:00
Andrey 8fe5c4a1c9 only: wow hello 2013 2024-02-28 20:28:38 -05:00
Andrey 389c6e64e9 only: reducing magic numbers in unit tests 2024-02-28 20:20:41 -05:00
Andrey 17275e4f4b maximumIgnitionTiming does not account timing_offset_cylinder #5894
only: renaming field so that we do not have two entities with same name and different meaning
2024-02-28 19:34:13 -05:00
rusefillc 81c050a75b only: dead ET camaro 2024-01-16 11:53:22 -05:00
rusefillc fb899cdefb only: inline method & dead code 2024-01-16 11:02:26 -05:00
Matthew Kennedy 8f42f8ccc8 Staged injection support; use two sets of injectors on the same engine fix #5247 2024-01-07 23:14:18 -05:00
Matthew Kennedy 1302f780b2 unused parameters 2024-01-07 22:36:20 -05:00
Matthew Kennedy 1f64950e33 Staged injection support; use two sets of injectors on the same engine #5247
two injection models for two stages
2024-01-07 22:36:20 -05:00
Matthew Kennedy 26b351ba40 Remove/make injector duty limit configurable fix #4798 2024-01-07 22:36:18 -05:00
Andrey ca18c5ba4e only:towards https://github.com/rusefi/rusefi/pull/4841 2024-01-07 16:39:15 -05:00
Andrey 391b5947e8 only: actually using msg in assertions 2024-01-07 13:43:30 -05:00
Andrey 540e142c28 6G72 Trigger Pattern #5593 2023-12-06 23:02:08 -05:00
rusefi 10198684f9 6G72 Trigger Pattern #5593
real data
2023-12-06 22:07:27 -05:00
rusefillc 723b9d5995 only:K 2023-11-25 20:18:24 -05:00
rusefillc 9c54180bf6
T2 (#5647)
* fix unit-tests

* add cam/vvt support to trigger_emulator

---------

Co-authored-by: andreika-git <andrei.home@gmail.com>
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-10-26 14:10:51 -04:00
Andrey 680d18e433 VVT control is broken on second bank fix #5599 2023-10-07 12:54:45 -04:00
Andrey 6eb0619d9c only: 36/2/2/2 is confusing #5566
writing raw value into meta file - moving logic closer to where it's needed giving TriggerImage more direct access to meta info
2023-09-16 00:02:59 -04:00
Andrey eaef8dfb09 only:rename 2023-09-15 23:59:13 -04:00
Matthew Kennedy bc637c4e6b rename 2jz -> toyota 3 tooth 2023-09-14 17:42:27 -04:00
Andrey 955f3cb9ca only: 3/0 cam real test 2023-09-14 08:34:23 -04:00
Andrey 247a0a91b5 spelling is important 2023-09-09 19:54:57 -04:00
Andrey b5fd6ea044 spelling is important 2023-09-09 19:53:18 -04:00
Andrey d2f899e737 reducing/moving technical debt 2023-08-29 16:46:04 -04:00
Andrey e9e0ef5a89 "rpmAcceleration" in TS doesn't go lower than 0 #5504
only: rpmAcceleration unit test
2023-08-09 04:53:00 -04:00
rusefillc 86a2d1e8e9 better output file name 2023-08-08 20:09:18 -04:00
rusefillc d77fb3bf24 "Single Tooth" renamed to "Half Moon", more proper "Single Tooth" crank trigger as a new trigger fix #5488 2023-08-06 00:46:33 -04:00
Andrey f3a5586e36 Custom Trigger Tooth with 1+0 causes endless loop fix #5471 2023-08-05 12:59:11 -04:00
Andrey 0787b4f4a0 Custom Trigger Tooth with 1+0 causes endless loop #5471
only:test
2023-08-05 12:44:16 -04:00
rusefillc 77ef4db8ab
Simplified VVT single tooth cam modes. (#5483)
* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

* Simplified VVT single tooth cam modes.

---------

Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2023-08-03 20:24:22 -04:00
Andrey db2db5dcfc only:Vadim is asking for SyncEdge to be reflected on trigger images #5472 2023-07-29 14:12:10 -04:00
rusefi 0099de49af ignition timing clamping settings 2023-07-22 00:07:15 -04:00
rusefi 2a5772374c ignition timing clamping settings
only:status quo
2023-07-21 23:45:03 -04:00
Andrey 8e76a82a26 only:last step of trigger_type_e enum refactoring 2023-07-13 19:30:54 -04:00
Matthew Kennedy 7f67ecd02d simplify adjustCrankPhase
(cherry picked from commit 7ae11160d9bfb31a664130e66586e849b8201c8a)
2023-06-28 21:49:51 -04:00
Matthew Kennedy 6b54916d12 real test of 12+1 (#177) 2023-06-28 21:17:04 -04:00
Matthew Kennedy e03bbd00aa explicit tests for batch and single point 2023-06-26 10:41:16 -04:00
Matthew Kennedy ae3ae86e75 fix (honestly gross) tests to work in two wire batch
(cherry picked from commit 01b4f1191a61012e64e3ee480b3f99a93e5f2073)
2023-06-25 00:25:11 -04:00
Matthew Kennedy 10c5c4ec94 #23 and fix https://github.com/rusefi/rusefi/issues/5353
(cherry picked from commit b0c3357cba5a3a08ab481dd9cb76f1ab95114ed4)
2023-06-25 00:25:07 -04:00
Andrey cd4c78745e only:Split ConfigGenerator around trigger_defines.txt #5051 2023-06-17 22:41:40 -04:00
andreika-git 2188ef45a9 more unit tests for trigger_input_adc 2023-06-06 23:59:52 +03:00
andreika-git 31a9c354ec more unit-tests with RPM checks for trigger_input_adc 2023-06-02 00:09:00 +03:00
rusefi 99b4ea78d9 Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefi 633274055b Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 10:29:05 -04:00
rusefi 415b3d55df Technical debt: ENUM_32_BITS #3874
poking the bear
2023-06-01 01:45:53 -04:00
Andrey 8c9b17485e Revert "Allow scheduling_s to come from a pool (#4841)"
This reverts commit 5250b177
2023-05-25 10:10:17 -04:00
Matthew Kennedy 06cda6cfa4 add postState flag to airmass model calls #107
(cherry picked from commit b1b1ec7fdf0ee9b5955541bcaa6be7cf66636412)
2023-05-16 13:02:45 -04:00
Matthew Kennedy 9ae8e18757 only: cherry picking: it's going to be painful 2023-04-29 15:14:58 -04:00
Andrey e748e65638 only: cherry picking: it's going to be painful 2023-04-29 15:07:43 -04:00
Matthew Kennedy 61e5b4b1ad change ObdCode to enum class builds firmware 2023-04-29 00:44:00 -04:00
Andrey da6d394482 it's going to be painful 2023-04-28 22:48:02 -04:00
Matthew Kennedy c5abc06429 nobody should use NA6 VAF
(cherry picked from commit 0072e8f33cd9645ee67ab8fe9a3cc0d35001081a)
2023-04-28 21:52:48 -04:00
Matthew Kennedy 2857e9527d remove specs_s struct, flatten config
(cherry picked from commit f090a97b0b7771dfe02e4b4bb9919d50a6a11ef5)
2023-04-28 20:59:11 -04:00
Andrey 0098a3d4b9 Clean-up all the 4g drama #5213 2023-04-01 15:40:24 -04:00
Andrey 6c1a8d501e 4g is symmetrical crank not just four stroke crank #5211
only:alphax-4chan
2023-03-30 23:31:47 -04:00
Andrey f53937ae87 K
only:hellen-honda-k
2023-03-29 22:57:31 -04:00
Andrey 91e1eb825f K
only:hellen-honda-k
2023-03-28 21:42:20 -04:00
Andreika c9c33e02e9
weird: happy running car shows unrealistic vvtSyncGapRatio #5152 (#5163) 2023-03-08 16:52:56 -05:00
Andrey e08cdf0fb6 trigger refactoring
only:mre_f4
2023-03-03 00:21:40 -05:00
Andrey e4fa54ac5c Feb20: 3rd ticket for 4g9x mess #5111
adding more lightness

only: alphax-4chan
2023-02-21 16:10:21 -05:00
Andrey 9c31c1f02a just more test, does not help :( 2023-02-20 20:37:40 -05:00
Andrey 5ec7341335 just a rename 2023-02-20 20:37:39 -05:00
Andrey 57baf7517b Feb20: 3rd ticket for 4g9x mess #5111
adding lightness
2023-02-20 18:22:51 -05:00
Matthew Kennedy 325417caa7
fix 4g63 vs 9x naming, add cam-only test (#5093) 2023-02-16 23:22:34 -05:00
Matthew Kennedy 827dc22757
rewrite neon trigger (#5003)
* rewrite neon trigger

* we were testing the same thing four times, maybe test it once
2023-01-24 18:33:15 +05:30
Matthew Kennedy 9630edfbf8
mitsu 4g63 (#5001)
* mitsu 4g63

* file header
2023-01-24 06:53:40 +05:30
Andrey 6588e813ae totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-15 08:26:38 -05:00
Andrey 9abdab795d totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 23:21:23 -05:00
Andrey 0c1859b77e totalFuel and totalIgnition correction gauges in Tunerstudio #4955 2023-01-14 15:33:17 -05:00
Matthew Kennedy d5b00e1187
don't warn if we intentionally skipped this spark (#4961)
* don't warn if we intentionally skipped this spark

* header

* real nb2
2023-01-10 19:07:44 -05:00
Matthew Kennedy eb56c2897a
detect and ignore doubled trigger edges (#4656)
* isToothExpectedNow

* s

* s

* kick ci

* only warn at high enough RPM to detect non-smooth trigger

* 4b11 test
2023-01-10 16:07:17 -05:00
Andrey 289171a85a symmetrical shapes are not rendered right #4956 2023-01-08 22:37:35 -05:00
rusefillc 2e882986f4 refactoring 2023-01-08 22:30:57 -05:00
rusefillc 68dcbd214e sweet 4g93 data 2023-01-07 17:31:13 -05:00
Andrey 0f1d46238f Mitsubishi 4G93 Trigger issues #4918 2023-01-07 16:28:57 -05:00
Matthew Kennedy e5d199272d
improve iat ignition table (#4948)
* iat ignition table

* changelog
2023-01-06 21:59:34 -05:00
Andrey 987e59f7cc Mitsubishi 4G93 Trigger issues #4918
a good case for NAN?
2023-01-03 21:17:32 -05:00
Andrey def809aa39 Mitsubishi 4G93 Trigger issues #4918
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey c9d88d2605 a bit of dead code 2023-01-03 13:59:25 -05:00
Andrey d0f6fa8ea3 let's try again 2023-01-03 08:38:42 -05:00
Andrey 603f188b55 a bit of dead code 2023-01-03 07:49:17 -05:00
Matthew Kennedy 5250b177c2
Allow scheduling_s to come from a pool (#4841)
* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

* injection events use scheduling pool

* knock and prime

* bench test

* dropped this: *

* extract action before execute

* comment

* init allocated timers

* metrics

* dropped this: ,

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-12-10 17:55:51 -05:00
Matthew Kennedy 994ee2f22f
Combine angle based event (#4884)
* Remove AngleBasedEventOld/New, only AngleBasedEvent now

* this 7 year old comment of old test code can go away
2022-12-10 17:07:02 -05:00
Matthew Kennedy 151416b005
default fuel cleanup and injection phase change (#4836)
* default fuel cleanup and injection phase change

* happy tests

* changelog

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-11-29 23:41:49 -05:00
Matthew Kennedy 5c50ad2db4
infer useOnlyRisingEdge by trigger type (#4621)
* most of the plumbing

* easy tests

* trigger types that are rise only

* configs

* change mode of various triggers

* vvt

* 898 test is now impossible 🥳

* s

* instant rpm test

* actually remove useOnlyRisingEdgeForTrigger

* remove vvtCamSensorUseRise

* s

* print

* one happy test

* another test

* happy testSomethingWeird

* happy testCamInput

* maybe fix it a different way

* better

* quad cam

* nb2 happy

* bad merge

* vvt test

* trigger.test1995FordInline6TriggerDecoder

* hellen gm e67

* changelog
2022-11-08 21:48:39 -05:00
Matthew Kennedy 7bd9dbf89e
fix vvt logging logic (#4747)
* fix vvt logging logic

* put that back

* flip condition to avoid branch on uninitialized value
2022-11-07 10:52:17 -05:00
rusefi 1f3ab0cf24 reducing ugly 2022-11-06 21:28:38 -05:00