rusefi
f77f356e6d
reducing code duplication
2023-06-11 23:17:13 -04:00
rusefi
731fd89ef7
reducing magic constant
2023-06-11 23:13:36 -04:00
rusefi
1908896598
Technical debt: ENUM_32_BITS #3874
...
poking the bear
2023-06-01 10:29:05 -04:00
Mingjie Shen
495f0ea8c4
Fix invoking virtual functions from constructors
...
Virtual functions should not be invoked from a constructor or destructor
of the same class. Confusingly, virtual functions are resolved
statically (not dynamically) in constructors and destructors for the
same class. The call should be made explicitly static by qualifying it
using the scope resolution operator.
2023-05-24 15:27:09 -04:00
Matthew Kennedy
61e5b4b1ad
change ObdCode to enum class builds firmware
2023-04-29 00:44:00 -04:00
rusefillc
3031818f3e
weird: happy running car shows repetitive pattern of unrealistic vvtSyncGapRatio fix #5152
2023-03-21 19:39:39 -04:00
Andrey
def809aa39
Mitsubishi 4G93 Trigger issues #4918
...
adding more info on the trigger images
2023-01-03 15:44:13 -05:00
Andrey
603f188b55
a bit of dead code
2023-01-03 07:49:17 -05:00
Andrey
1475ecf273
trigger refactoring: instance RPM fix #4740
2022-11-06 12:03:55 -05:00
Andrey
83e736b06a
trigger refactoring: instance RPM #4740
2022-11-06 11:47:23 -05:00
Andrey
7b10b32958
trigger refactoring: instance RPM #4740
2022-11-06 11:45:51 -05:00
Andrey
79afd2b6fa
trigger refactoring: instance RPM #4740
2022-11-06 11:41:27 -05:00
Andrey
d75bf59cdc
trigger refactoring: instance RPM #4740
2022-11-06 11:12:20 -05:00
Andrey
b5796c121d
trigger refactoring: instance RPM #4740
2022-11-06 10:58:04 -05:00
rusefillc
e3fd84ed08
minor trigger refactoring
2022-11-06 00:32:38 -04:00
rusefillc
a0c234c76d
learning C++
2022-11-06 00:17:24 -04:00
rusefillc
d4bb6a3a5e
more fancy
2022-11-06 00:10:50 -04:00
Andrey
b57bf2903a
minor trigger refactoring
2022-11-05 21:43:12 -04:00
rusefillc
6c3899f401
dead lines
2022-11-05 17:21:30 -04:00
rusefillc
500b3e8678
dead lines
2022-11-05 15:20:02 -04:00
Andrey G
e7b06cbfca
compile warnings: signed vs unsigned and unused ( #4713 )
2022-10-30 09:47:53 -04:00
Matthew Kennedy
cb86c014cf
fix instant rpm clearing bug ( #4629 )
...
* improve instant rpm
* changelog
2022-09-29 07:15:59 -04:00
Matthew Kennedy
ca623eb6ee
plumbing parts of 4621 ( #4622 )
...
* plumbing parts of 4621
* show error list
* exit on error too!
* this test has some unhealthy undefined behavior
* no uninitialized values
* no that doesn't work
* remove the invalid data and the bug becomes obvious
2022-09-25 18:49:54 -04:00
Matthew Kennedy
b45f84fe20
#4619 ( #4620 )
2022-09-25 07:40:28 -04:00
Matthew Kennedy
7139ddcda2
explicitly pass which edges we sync trigger on ( #4607 )
...
* require sync edge type
* s
* fix neon
* info printing
* put enums back
* auto gen enum fiddling
2022-09-23 20:39:41 -04:00
rusefillc
fc9fb5724c
tear down Engine god object #4511
2022-09-15 22:06:16 -04:00
rusefillc
13bd9ab641
tear down Engine god object #4511
2022-09-15 22:00:07 -04:00
rusefillc
52f52376de
tear down Engine god object #4511
2022-09-15 21:55:15 -04:00
rusefillc
ec0e567989
tear down Engine god object #4511
2022-09-15 21:46:01 -04:00
Andrey
0e91914266
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:35:55 -04:00
Andrey
2c0ce0ec7d
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 02:17:04 -04:00
Andrey
6cdb0dc0af
deep rabbit holes are the best ones!
...
refactoring: encapsulation
2022-09-14 01:53:17 -04:00
Andrey G
91d4844e38
time routines refactor ( #4563 )
...
* Extract time helpers from engine_controller_misc to efitime.cpp
* Rename currentTimeMillis() to getTimeNowMs()
We have getTimeNowNt(), getTimeNowUs(), currentTimeMillis() and getTimeNowSeconds()
Align a bit.
find . -type f -name '*.c*' -exec sed -i 's/currentTimeMillis/getTimeNowMs/g' {} \;
* Rename getTimeNowSeconds() to getTimeNowS()
To align with Nt, Us, Ms versions.
* Some comments about getTimeNowLowerNt()
2022-09-11 13:06:03 -04:00
rusefillc
2a05a31550
refactoring: type safety
2022-09-11 03:46:50 -04:00
rusefillc
851e8e48d3
refactoring: type safety
2022-09-11 02:57:35 -04:00
rusefillc
6e71b72acc
refactoring - reducing API between FW and Java
2022-09-11 02:16:47 -04:00
rusefillc
9e9c0217b8
huh? dead code? how can we get NAN from eventAngles table? ( #4549 )
2022-09-07 23:45:33 -04:00
Andrey
8e49542600
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 22:24:28 -04:00
Andrey
00fea2cbe5
trigger: in corner cases like NB2 and VQ35 those are not revolutions
2022-09-07 21:45:59 -04:00
Andrey
ab4b451195
os_access.h dead?
2022-09-07 15:56:45 -04:00
Matthew Kennedy
aeeef3dbd0
reset instant RPM in case of cam resync ( #4544 )
2022-09-06 21:38:35 -04:00
Matthew Kennedy
9407150544
more granular trigger error messages ( #4526 )
...
* granular trigger error messages
* adjust test expectations
* explicitly test behavior
2022-09-04 09:15:24 -04:00
rusefillc
85490a497d
separate atomic picked from https://github.com/rusefi/rusefi/pull/4493 ( #4495 )
...
Co-authored-by: rusefillc <sdfsdfqsf2334234234>
2022-08-27 22:26:56 -04:00
rusefillc
859a66bb3b
poke 3
2022-08-23 09:02:38 -04:00
rusefillc
7e690b0899
poke 2
2022-08-22 23:43:06 -04:00
rusefillc
c0923f6efe
poke 1
2022-08-22 23:42:48 -04:00
rusefillc
841b40d8ac
RE: reasons for verbose messages
2022-08-22 22:52:48 -04:00
rusefi
25778f0890
trigger gap logging: it's a mess :(
2022-08-21 12:38:29 -04:00
rusefillc
f61cfcfd95
todo: huh? dead code? how can we get NAN from eventAngles table?
2022-08-11 20:05:29 -04:00
rusefillc
b5c2b70e23
refactoring: better field name
2022-08-09 20:32:39 -04:00