Matthew Kennedy
750070a496
fix etb wastegate percent output ( #1988 )
...
* wastegate etb should use percent
* percent_t
* fix test
2020-11-25 21:14:06 -05:00
Matthew Kennedy
492498f8d0
Boost tolerance ( #1986 )
...
* tolerate invalid closed loop config when in open loop mode
* fix test
2020-11-25 07:27:24 -05:00
Matthew Kennedy
866038900f
adjust boost ( #1975 )
2020-11-22 18:30:19 -05:00
Matthew Kennedy
66687158c5
no feed forward for wastegate ( #1971 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-11-19 20:51:30 -05:00
rusefillc
ee7e1880a2
Something something unit test ETB does not work #1966
2020-11-18 20:12:58 -05:00
rusefillc
e29911114a
Starter seems to be engaged forever #1965
2020-11-18 20:01:02 -05:00
rusefillc
4c9c8d42bf
Starter seems to be engaged forever #1965
2020-11-18 19:51:51 -05:00
Matthew Kennedy
774de10f40
undo 1946 ( #1957 )
2020-11-17 17:07:56 -05:00
rusefillc
014cae25db
DC not ETB refactoring
2020-11-16 20:07:12 -05:00
rusefillc
cd7cefb669
DC not ETB refactoring
2020-11-16 20:05:35 -05:00
rusefillc
5ad36e655f
DC not ETB refactoring
2020-11-16 19:51:36 -05:00
rusefillc
2a3a2d7191
DC not ETB refactoring
2020-11-16 19:43:00 -05:00
rusefillc
724abc68f5
DC not ETB refactoring
2020-11-16 19:28:30 -05:00
Matthew Kennedy
2f4294ac4d
minor perf tweaks ( #1946 )
...
* only start PWM if needed
* put important stuff first
* use conversion
* this broke the logic
2020-11-16 00:06:11 -05:00
Matthew Kennedy
0e3673e78c
remove idle thread; just call from periodicSlowCallback ( #1924 )
...
* remove thread
* remove ui
2020-11-11 21:47:19 -05:00
Matthew Kennedy
d992bab241
Move all DECLARE_ENGINE_PTR etc to one place ( #1937 )
...
* restructure
* guard c++
* idle too
* status_loop.h
2020-11-11 19:06:04 -05:00
Matthew Kennedy
3241a43a2d
extract idle hardware to its own file ( #1923 )
...
* extract idle hardware
* should fix the build
2020-11-03 18:06:32 -05:00
rusefi
2c322006d8
Output pin init/deinit needs a linked list #1803
2020-11-03 00:09:42 -05:00
Matthew Kennedy
6605877326
gppwm debug ( #1895 )
...
* dbg gppwm
* fix channel
* TS guard
2020-10-21 22:49:38 -04:00
rusefi
9060aff46c
code style
2020-10-21 22:13:18 -04:00
rusefi
2ce0bef9b9
refactoring
2020-10-19 22:44:44 -04:00
Matthew Kennedy
06f92807cc
second PID config for wastegate ( #1889 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
* consume
* add cfg field
* ui maybe
* fix
* fix
* add wastegate config test
2020-10-19 08:04:27 -04:00
Matthew Kennedy
42bfad807b
Etb wastegate hookup ( #1888 )
...
* remove
* cleanup
* implement ETB parts
* hook up to boost controller
* tests
2020-10-18 21:57:04 -04:00
Matthew Kennedy
ee5d0bf07b
remove ( #1887 )
2020-10-18 20:49:42 -04:00
Matthew Kennedy
44653da2e5
Etb function cfg: actually read config ( #1884 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-18 17:26:38 -04:00
Matthew Kennedy
749282c807
more safe parts probably ( #1883 )
2020-10-15 22:04:42 -04:00
Matthew Kennedy
299a345c1c
etb function config 1 ( #1881 )
...
* this should all be safe...
* test fix
2020-10-14 22:02:09 -04:00
rusefillc
07a905b1fe
revering functional part of
...
Etb function cfg, try again #1860
try again from #1831
2020-10-08 17:09:00 -04:00
Matthew Kennedy
1bce3aa4c0
Etb function cfg, try again ( #1860 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-08 14:12:03 -04:00
rusefillc
367436454d
HW CI has failed 11 times since Oct 2 #1849
...
Revert "ETB function config (#1831 )"
This reverts commit af59c45a
2020-10-03 22:00:00 -04:00
Matthew Kennedy
af59c45adb
ETB function config ( #1831 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
* add config
* better spot for it
* use config init values
* handle null controller array
* fatal error testability
* test new init config
* defaults
* fix for default config
2020-10-02 20:51:02 -04:00
Matthew Kennedy
f1c04efefa
replace ETB index with function enum ( #1807 )
...
* two throttles one thread
* look at all this RAM!
* add enum
* switch from index to function
* test fixup
* improve init logic
* remove old vw idle mode bit
2020-09-28 16:33:07 -04:00
Matthew Kennedy
1fc55da3ca
two throttles one thread ( #1806 )
...
* two throttles one thread
* look at all this RAM!
2020-09-18 13:47:49 -04:00
Matthew Kennedy
eebded8caa
scale tables using type system ( #1776 )
...
* store scale in the type
* efi ratio
* boost control scaling
* fix boost tests
2020-09-10 18:44:10 -04:00
rusefi
cb2173aad2
merge got confused
2020-09-07 15:05:47 -04:00
rusefi
f33b3eda8a
Merge remote-tracking branch 'origin/Hellen_fork_point' into master
...
# Conflicts:
# firmware/controllers/algo/engine.h
# firmware/hw_layer/drivers/drivers.mk
# firmware/hw_layer/stepper.h
# firmware/integration/rusefi_config.txt
# firmware/tunerstudio/rusefi.input
# simulator/simulator/efifeatures.h
2020-09-07 15:02:11 -04:00
rusefi
ec0d3a8eb2
Hellen says isIdleMotorBusy
...
(cherry picked from commit b24246791e
)
2020-09-07 14:43:29 -04:00
rusefi
b24246791e
Hellen says isIdleMotorBusy
2020-09-07 14:12:21 -04:00
Matthew Kennedy
95798a5246
fix broken master, inject engine ptr to rpmcalculator ( #1759 )
...
* fix
* oops
2020-09-05 18:49:42 -04:00
rusefi
675cce3854
less hacky testing implementation
2020-09-03 22:52:29 -04:00
rusefi
ca21d5b4c2
refactoring
2020-09-03 19:29:15 -04:00
rusefi
540eef5e0d
VVT support for VAG trigger #883
2020-08-25 00:59:07 -04:00
Matthew Kennedy
7a3b87656f
guard ( #1726 )
...
* implement
* add bench mode
* add ts cal mode
* TS impl
* include guard
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-23 23:46:33 -04:00
Matthew Kennedy
12bc5eb28b
Auto cal dual etb ( #1725 )
...
* implement
* add bench mode
* add ts cal mode
* TS impl
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-23 23:41:35 -04:00
Matthew Kennedy
225e403973
parameter names
2020-07-29 02:22:31 -07:00
rusefi
b2db6b604d
Weird VAG: DC motor idle valve not ETB #1637
...
misc progress
2020-07-26 15:22:14 -04:00
rusefi
a8f45d960a
Weird VAG: DC motor idle valve not ETB #1637
...
etbTarget gauge in DC idle mode
2020-07-26 15:07:45 -04:00
rusefi
c649b05ebd
Weird VAG: DC motor idle valve not ETB #1637
...
should be better this way
2020-07-26 12:19:30 -04:00
rusefi
3857607fc2
Weird VAG: DC motor idle valve not ETB
...
#1637
Seattle we might have a problem!
2020-07-26 12:03:36 -04:00
rusefi
d5739815b4
Weird VAG: DC motor idle valve not ETB #1637
2020-07-26 10:54:51 -04:00
Matthew Kennedy
d1fde4fe93
make reality match the test
2020-07-26 03:15:17 -07:00
Matthew Kennedy
51a69c7478
clamp idle in VW mode
2020-07-26 03:05:59 -07:00
Matthew Kennedy
7003d6c7ba
implement
2020-07-26 02:55:35 -07:00
Matthew Kennedy
5e681cac1a
add new options
2020-07-23 02:51:08 -07:00
Andrei
b7b50e5cb3
Idle PID improvements
2020-07-22 18:39:09 +03:00
rusefi
5feb91dc8f
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 21:35:01 -04:00
rusefi
f7da86983a
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 21:13:04 -04:00
rusefi
0079e8d3f0
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 19:06:26 -04:00
rusefi
13aef2dd77
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:25:48 -04:00
rusefi
677d5888ed
EFI_IDLE_INCREMENTAL_PID_CIC should be a runtime parameter #806
2020-07-12 18:11:10 -04:00
rusefi
8f4dd3e175
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 15:06:55 -04:00
rusefi
29e3c71df4
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 14:19:51 -04:00
rusefi
1f4c632cf2
https://rusefi.com/forum/viewtopic.php?p=37401#p37401
2020-07-10 14:03:07 -04:00
rusefi
720ade2319
migrate amazing idle from FSIO to less opaque TS #1581
2020-07-08 01:12:08 -04:00
rusefi
b1ab455f31
idle_min through FSIO not working as intended
...
#1553
we now re-activated idle PID even in deadzone for half a second after A/C toggle
2020-07-06 16:40:16 -04:00
Matthew Kennedy
26478ec394
Switch fueling to new axes ( #1574 )
...
* switch tables
* missed one
2020-07-05 18:14:55 -04:00
rusefi
23e6ea5475
idle_min through FSIO not working as intended #1553
2020-07-04 22:01:12 -04:00
rusefi
e854410778
idle_min through FSIO not working as intended #1553
...
better idle state logging
2020-07-01 19:10:42 -04:00
rusefi
33eb2eab62
idle_min through FSIO not working as intended #1553
...
making logging less confusing
2020-07-01 16:37:25 -04:00
rusefi
127dd67838
restoring ldmp
2020-06-17 19:03:10 -04:00
Matthew Kennedy
65625deb32
only setup etb if primary sensor configured instead of proxy ( #1489 )
...
* only setup etb if primary sensor configured instead of proxy
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-06-16 21:38:09 -04:00
Matthew Kennedy
b906d12268
Fix gppwm properly ( #1487 )
...
* directly control output in onoff mode
* test fixing
2020-06-11 20:43:26 -04:00
rusefi
98e73987a3
docs
2020-06-01 08:50:54 -04:00
Matthew Kennedy
3a7c6f242b
Hardware pwm ( #1283 )
...
* hard pwm
* fix, comments
* PC6-9 and PD12-15
* PB6-9
* dynamic frequency
* f7 mcuconf
* format
* relocate to common, support variable frequency
* error handling
* oops
* fix test build
* noop kinetis
* better guards
* guard for bl
* guards don't work if they have typos
* more mapping
* oops
* don't use for slow pwm
* enable pwm
* guard properly
* save a little memory
* use less mem
* correct timers
* all your ram are belong to us
* update limit & comment
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-28 16:02:41 -04:00
rusefi
a4329169e9
better file name
2020-05-25 13:02:05 -04:00
Matthew Kennedy
4f334c91d5
warnings ( #1462 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-21 01:08:07 -04:00
Matthew Kennedy
9dda1a21bc
Redundant tps ( #1427 )
...
* add redundant sensor
* add tests
* add configure, info printing
* tests
* tests
* partial hookup
* fix
* fix
* bad makefile merge
* use second TPS config
* update test
* update test
* sensor names
* set second pin by default
* fix auto cal
* auto cal both sensors
* add reconfigure of secondary sensors
* gobblin' up your ram
* slow down write a little bit
* put split in debug gauge
* s
Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
rusefi
4364eea7a2
refactoring: extracting magic constant
2020-05-08 22:05:44 -04:00
rusefi
b4f6c6488f
helping build
2020-05-08 21:39:35 -04:00
dron0gus
f78889c1b3
idle thread: debug output for bipolar stepper ( #1409 )
2020-05-08 20:05:05 -04:00
dron0gus
5987fb8b88
[SAFE] Debug cleanups ( #1403 )
...
* electronic throttle: inprove debug
* idle thread: show debug info for configured idle driver
* gpio-chips: make private functions static
2020-05-06 20:06:50 -04:00
Matthew Kennedy
74d13c391f
Rewrite boost control in new closed loop framework ( #1342 )
...
* rewrite boost
* test
* fix build
* tests
* open loop test
* test closed loop
* fix names
* typo
* tests
* mock boost setOutput
* needs more virtual
* fix boost logic
* switch to TPS based open loop
* fix test
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:40:42 -04:00
Matthew Kennedy
20a95bdcf1
ETB auto-PID: auto set values in TS ( #1400 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* auto cal
* wire up bench testing
* auto gains too
* s
* fix
* rearrange a bit
* inject
* remove unused bit
* mock repair
* move
* add maintainconstantvalue
* add disable button
* cleaning
* move state inside
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-06 08:39:02 -04:00
Matthew Kennedy
3052f2ab7b
Support 4 h-bridges ( #1392 )
...
* update dc motor api
* add more etbio
* get out of two arrays
* hand generate enough
* forgot engine param
* ram
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-02 17:54:28 -04:00
rusefi
965c06c079
https://github.com/rusefi/rusefi_documentation/issues/37
2020-04-29 18:41:40 -04:00
Matthew Kennedy
ba6ec4ac51
TPS Auto Calibration with ETB ( #1382 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* auto cal
* wire up bench testing
* s
* fix
* rearrange a bit
* inject
* remove unused bit
* mock repair
* guard for ECUs without ETB
2020-04-28 19:31:41 -04:00
Matthew Kennedy
d728b1ca48
Minor ETB improvements ( #1381 )
...
* fix pid reset and pedal failure
* pause control later
* test pauseEtbControl
* update tooltip + field name
* update test
2020-04-28 16:52:40 -04:00
rusefi
44facf1140
useful content from Move ETB control to a thread #1374
2020-04-28 08:05:18 -04:00
Matthew Kennedy
fe4b531aeb
Move ETB control to a thread ( #1374 )
...
* switch to thread
* actually use default frequency define
* crank ADC too
* make space in RAM
* remove TS field
* this should work for test
* fix dt
* re-resize ram
2020-04-28 07:22:31 -04:00
rusefi
1b84406e77
dead code
2020-04-26 17:40:12 -04:00
Matthew Kennedy
f128b33694
General purpose PWM: implementation & tests ( #1366 )
...
* config
* significant digits
* renumber enum, no need for a "none"
* ui
* impl base
* error handle MAP
* init & update
* don't need arg
* don't lie about sensor
* fix test build
* test stub
* initialize
* null check
* fix clamping
* test output
* types & enums
* don't need param
* test getOutput
* fix
* output pin instead of brain pin
* default config
2020-04-26 14:06:28 -04:00
Matthew Kennedy
df2db7036d
ETB autotune in its own function ( #1350 )
...
* pull out autotune
* oops
2020-04-22 22:22:28 -04:00
Matthew Kennedy
99489cff67
Improve ETB idle control ( #1319 )
...
* compress idle pos
* fix tests for new behavior
2020-04-20 17:29:03 -04:00
Matthew Kennedy
1a5e0a42f8
Inject idle to ETB ( #1335 )
...
* inject idle position
* pointer
* etb idle tests
* extract mocks
* ops
* test negative case too
* don't convert for etb
* guard
2020-04-20 16:26:35 -04:00
rusefi
656331ebe9
reducing code duplication
2020-04-20 15:57:03 -04:00
Matthew Kennedy
e04008610a
ETB: inject pedal map ( #1334 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
* inject pedal map
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 14:34:45 -04:00
rusefi
934898f903
idle duty cycle clamping
2020-04-20 14:11:40 -04:00
Matthew Kennedy
0619575716
ETB testing: output, position clamping ( #1333 )
...
* add clampf
* more tests
* public
* missed a mock
* fix output duty clamping
* do it that way
* more
* ah ha!
* test negative too
* clamp pedal
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-20 13:52:20 -04:00
rusefi
ad7c4f23bc
Better handling in case of ETB idle without ETB #1332
2020-04-19 23:55:27 -04:00
Matthew Kennedy
8aac233a5f
rewrite etb tests with gmock ( #1330 )
2020-04-19 20:32:41 -04:00