Commit Graph

1065 Commits

Author SHA1 Message Date
rusefillc 60cf2cdbcf Default GPPWM note 2022-08-27 15:19:35 -04:00
Matthew Kennedy 0b10f7dca8
hellen board ID detect improvements (#4307)
* move call

* board detections work correctly

* improve detector

* s

* break instead of return

* tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-07-02 05:19:02 -04:00
Matthew Kennedy 3284282be7
rescale RPM values (#4300)
* rpm configs

* fix

* s

* s

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2022-06-29 18:48:30 -04:00
Matthew Kennedy b92c0149d6
get rid of setSerialConfigurationOverrides (#4274)
* get rid of setSerialConfigurationOverrides

* missed a few

* kinetis
2022-06-23 19:42:09 -04:00
rusefi 983682d11f miata 96 defaults 2022-06-23 14:30:41 -04:00
Matthew Kennedy 4d7fe35c5c
clean up sd overrides (#4272) 2022-06-23 09:15:51 -04:00
rusefi a552d58d42 verbose trigger sync should reuse engineSnifferRpmThreshold #4259
reducing complexity
2022-06-18 14:17:36 -04:00
Matthew Kennedy 4ada633206
Remove third trigger channel (#4226)
* remove third trigger

* clean up the honda mess

* there was nothing novel about this engine config

* include

* missed a few

* s

* x

* changelog

* don't set the third trigger input

* don't redefine the same thing 3 times

* only two inputs!

* test
2022-06-01 21:24:20 -04:00
rusefillc 4a9789e6c4 B6 test mule 2022-05-21 02:25:43 -04:00
rusefillc 8c6dee61a5 B6 test mule 2022-05-21 01:45:09 -04:00
Andrey e62877964a Move curves out of engineConfiguration in order to reduce RAM usage #4127 2022-05-01 23:43:43 -04:00
Matthew Kennedy e4a0979dc2
Brain pin is enum class (#4108)
* change most usages to Gpio::

* board configs

* engine configs etc

* isBrainPinValid, smart gpio

* generator

* generator

* generator

* connector yamls

* kinetis enums

* cypress txt

* kinetis config

* frankenso

* config generator

* actually do it for the others

* disable skips for pr ci

* fix tle8888

* misc

* weird cast from int

* needs this operator too

* this can be an unsigned subtract

* happy tests

* s

* kinetis isConfigurationChanged weirdness

* missed J/K

* cypress efifeatures

* build script mistake (!)

* mistake in smart gpio

* debounce

* eg33

* kinetis, so needy

* it's pretty green, we can skip these again
2022-04-28 17:32:39 -04:00
Matthew Kennedy 16de438ab8
knock threshold table fix (#4077)
* fix knock threshold table

* defaults

* knock controller is engine module

* testable

* test builds

* knock tests work

* s

* format

* everyone loves changelogs
2022-04-18 08:03:16 -04:00
rusefillc a90ca2b200 Hellen NB2 default tune #4038 2022-04-10 19:11:34 -04:00
Andrey 4f7793649d MAP value thresholds #4030 2022-04-03 18:48:34 -04:00
Andrey 204ac3961b Trigger setup in TS is highly confusing: hide operation mode from users? #4031
WOW it works?!
2022-04-03 02:30:43 -04:00
Andrey cc9a1136c4 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 02:21:37 -04:00
Andrey 6aa948a666 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:43:28 -04:00
Andrey 95d36b37e3 Trigger setup in TS is highly confusing: hide operation mode from users? #4031 2022-04-03 00:34:18 -04:00
rusefillc 6b5747d4c8 refactoring: method rename 2022-04-02 21:01:29 -04:00
Matthew Kennedy 307b33837d
core 8 overrides and stepper-as-brain-pin (#3962)
* core 8 overrides and stepper-as-brain-pin

* oops, change the pin not the mode

* a little bit of #3963 makes everyone happy
2022-02-26 09:14:37 -05:00
rusefillc c945d48e2b better default 2022-02-10 00:53:44 -05:00
rusefillc 4df1467a3a N73 2022-02-09 17:29:09 -05:00
rusefi c50bf8666b helping build 2022-02-06 18:13:35 -05:00
rusefi d45b8361c2 I2C EEPROM support #3860 2022-02-06 13:59:08 -05:00
rusefi 7e96c3ee05 L9779WD driver L9779 #3768 2022-02-06 13:56:50 -05:00
rusefillc 51e9b1a50a I2C EEPROM support #3860 2022-02-06 12:39:41 -05:00
Matthew Kennedy 06437f304f
dead StartupFuelPumping (#3883)
* dead

* test

* dead config too
2022-02-03 08:01:21 -05:00
rusefillc 1e91573219 packing unused 2022-02-01 22:19:24 -05:00
Matthew Kennedy d2d73b6fcf
remove me7pnp (#3878)
* remove

* s

* HW_MICRO_RUSEFI
2022-02-01 21:46:06 -05:00
Matthew Kennedy a718f3a30a
Remove fsio part 1 (#3871)
* dead includes

* move last logic out of fsio

* dead functions
2022-02-01 15:42:04 -05:00
Matthew Kennedy c6f45c5022
warnings fixes (#3851)
* unused things

* !!! actual bug !!!

* dead

* unused

* unused

* multi-bus lua RX was just broken

* make the compiler angry about it

* dead config

* alphax 2

* just call, no store

* compiler too angry
2022-01-31 18:37:42 -05:00
rusefillc 963c168788 Code style for methods with zero arguments #3535 2022-01-11 22:26:24 -05:00
rusefillc 0d8e4d5222 AlphaX few bytes of progress 2022-01-10 01:47:06 -05:00
Andreika 1b9037314a
Hellen mcu module detector (experimental) (#3756)
* Hellen mcu module detector (experimental)

* make unit-tests happy

* make unit-tests even more happy

* move Hellen-specific stuff to hellen_common.cpp

* fix other hellen config builds

* helping non-Hellen builds too

* helping alpha2ch build

* helping build

* cleanup

* help unit-tests

Co-authored-by: Andrei <andreikagit@users.noreply.github.com>
2022-01-09 17:40:08 -05:00
rusefillc 212687dd10 extracting common hellen to it's own file 2022-01-08 20:16:01 -05:00
rusefillc 21f3f26506 benchTest flexibility 2022-01-03 03:35:26 -05:00
rusefillc e9498f64db GDI/HPFP: Set HPFP current/timing params on MC33816 #3736 follow-up 2022-01-03 02:13:47 -05:00
rusefillc d83b7f19af HellenNA8_96 config folder #3724 2021-12-29 21:23:47 -05:00
rusefillc 1856ff7ac0 reviving Passat 2021-12-29 20:24:04 -05:00
rusefillc 63c6621dd0 E65 2021-12-23 16:59:30 -05:00
Matthew Kennedy a4871c703c
Autoscale all the things! (#3713)
* Map3D accepts any scaled_channel type

* consistency

* reinstate test

* fix ratio

* throttle, boost, gppwm

* scale ignition and VE

* tests
2021-12-22 08:09:41 -05:00
rusefillc f27b4dbd95 dead code? 2021-12-16 21:06:23 -05:00
Matthew Kennedy 4148ee76bf
smarter priming logic (#3674)
* ignition controller detects rising edge on voltage

* update test

* comment

* ignore negative transients

* tweak

* test

* priming happens on ignition-on

* priming has its own scheduling

* config & UI

* dead config

* implementation

* look, the test caught a bug

* keep the watchdog happy

* bad merge

* changelog

* easier to read the test

* test naming
2021-12-08 16:20:19 -05:00
Andrey 50038167d8 MAP phase sensing #3544
new implementation seems complete?
2021-12-07 21:08:25 -05:00
Matthew Kennedy a37c9bca9e
Remove the EFI_NO_CONFIG_WORKING_COPY option (#3630)
* no working copy

* oops
2021-11-29 16:44:45 -05:00
rusefillc 818d12f68e why so many channels are hidden in debug ? #3614 2021-11-29 10:16:45 -05:00
Matthew Kennedy d5363b814a
better VSS configuration (#3542)
* vss uses real values

* some defaults

* test and correct math

* km, not miles!

* comment

* tooltip

* that macro went away

* 100hz and default settings gives 9kph

* changelog

* order of operations safety

* make the test like the pwm test

* housekeeping

* this is why we need sensor automation

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-27 08:49:07 -05:00
Andrey 12d5106614 isCylinderCleanupEnabled would be nice by default 2021-11-24 23:32:55 -05:00
rusefillc 794ec5e2b8 well Lua wants to be BIG 2021-11-23 16:40:04 -05:00
Matthew Kennedy 3334a6963c
oh my god we've had no asserts (#3595) 2021-11-22 17:52:03 -05:00
rusefillc a369e7e3d3 unusedLogFormat 2021-11-22 13:37:06 -05:00
Matthew Kennedy bb57a4b084
detect more overflows with asan (#3582)
* overflow detector

* type list dynamic allocate

* fix the buffer length

* comment

* pr fb

* sanitize sim

* fix sim sanitizer bug

* didn't mean to turn off optimization for sim

* asan can do that, if you turn it on!

* cleaning
2021-11-20 01:38:39 -05:00
Scott Smith 69d36dad6e
Final cleanup of ENGINE macros (#3567)
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith 988aacdd91
Create a base class EngineModule for that contains various useful callbacks. (#3548)
* Create a base class EngineModule for that contains various useful callbacks.

This cleans up the API by not requiring the notifiers to know about who wants callbacks.  The only
place you need to update to add a module is in one place.

* Add mockability.

* Convert InjectorModel to a Mockable EngineModule
2021-11-17 20:13:19 +03:00
Scott Smith 823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc (#3565)
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"

git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Scott Smith 70ad9724c0
Make engine* and friends be const pointers in production. (#3564)
This allows the compiler to see through the pointer and make accesses faster.
It saves 1336 bytes of text.
2021-11-17 03:53:17 -05:00
Matthew Kennedy 8cdac4cac0
remove engine pointer passing (#3556)
* some

* more

* more

* the last?!
2021-11-16 04:15:29 -05:00
Andrey 0cc88ec6e2 Not all launch control options are used #3554 2021-11-15 21:13:01 -05:00
rusefillc 68ebb8045d Epic: Remove FSIO #2928 2021-11-14 11:04:51 -05:00
rusefillc 22c872d8d8 Epic: Remove FSIO #2928 2021-11-14 10:57:19 -05:00
rusefillc c22215cea7 Epic: Remove FSIO #2928 2021-11-14 10:39:47 -05:00
rusefillc 991d0c5001 Epic: Remove FSIO #2928 2021-11-14 08:33:19 -05:00
rusefillc 0a9682c553 Epic: Remove FSIO #2928 2021-11-14 07:24:50 -05:00
rusefillc a9bcce88d0 script settings need names! 2021-11-13 22:47:46 -05:00
rusefillc 8333234737 Something something Automatic Compression Release #3442 2021-11-13 04:24:53 -05:00
rusefi 8aaecb568e pid demo progress 2021-11-08 17:31:33 -05:00
rusefillc ce45a907a7 a bit of dead code 2021-11-06 23:39:56 -04:00
rusefillc b244c59cd8 a bit of dead code 2021-11-06 21:19:56 -04:00
rusefillc 4f738b366e a bit of dead code 2021-11-06 21:01:01 -04:00
rusefillc 7b8821955b a bit of dead code 2021-11-06 18:43:19 -04:00
rusefillc 1ead914f93 more curves! also names for curves 2021-11-04 23:59:04 -04:00
rusefillc 85984928ca more curves! also names for curves 2021-11-04 23:19:44 -04:00
rusefi 1d9aa8bd12 turboSpeedSensorMultiplier 2021-11-04 19:35:58 -04:00
rusefillc db310a4bd0 most dead miata config 2021-11-04 09:56:05 -04:00
rusefillc 7e4ade6b0f better VVT default? 2021-10-31 15:25:43 -04:00
rusefillc 4c164aaf5c Honda K & default VVT pid 2021-10-29 12:16:19 -04:00
rusefi 75d8d334b7 secondary MRE 2021-10-27 19:54:45 -04:00
Andrey e6faf2fa15 UNUSED 2021-10-26 21:24:16 -04:00
Andrey 45280d7435 MRE_SECONDARY_CAN 2021-10-26 21:05:38 -04:00
rusefillc 87b3df1cf5 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 14:17:37 -04:00
rusefillc bf7ae2c76e generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 13:10:38 -04:00
rusefillc eead8fa1f6 generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:31:32 -04:00
rusefillc c6d47c1a8a generate java enum from C enum? generate both C and java from yaml? #2102 2021-10-24 09:16:11 -04:00
rusefillc e6b92ddb0c very old very dead code 2021-10-20 10:45:43 -04:00
rusefillc 66e0ecf0f2 honda 2021-10-12 18:31:48 -04:00
rusefillc 7e57239cae hyundai 2021-10-11 15:04:27 -04:00
rusefillc 376b227480 hyundai 2021-10-11 14:22:35 -04:00
rusefillc 2a87208380 hyundai 2021-10-11 12:37:24 -04:00
rusefillc f57ac55d9e NB1 defaults #3299 2021-10-02 23:21:43 -04:00
rusefillc 0f1a640258 proteus adapters 2021-10-02 13:20:19 -04:00
rusefillc b64c499848 nb1 is 144 pin 2021-09-27 22:26:09 -04:00
Andrey 65f8caa686 vr threshold test configuration 2021-09-26 02:21:21 -04:00
rusefi 2d74840296 hellen and else are confused about pins they do not know about 2021-09-25 19:37:30 -04:00
rusefi 26dc3303bd hellen and else are confused about pins they do not know about 2021-09-25 19:06:24 -04:00
Matthew Kennedy 8cd132b8a8
dead knock code (#3255)
* more unification

* hip stub

* comment

* guard

* channel idx

* include

* hip

* move in to engine

* hip9011

* dead stuff

* dead

* fsio

* lcd

* more dead
2021-09-21 20:40:20 -04:00
rusefillc 3e50319eb7 merc128: engine config defaults #3236 2021-09-18 21:27:17 -04:00
rusefillc 9d0c043dc1 merc128: engine config defaults #3236 2021-09-18 00:17:52 -04:00
rusefillc 092cca03ab merc128: engine config defaults #3236 2021-09-17 23:10:36 -04:00
Matthew Kennedy a18b86a09b
start allowing ADC change while running (#3100)
* allow re-register of the same sensor

* add api to unsubscribe

* do it for tps

* clear the pin

* happy test

* maybe make afr happy for now

* tests build

* happy simulator

* active configuration

* check valid

* we need vbatt now

* manage all pin init in init_sensors.cpp

* don't need that

* cleanup

* thermistors

* do two phase reinit in the right place

* config vs engine

* finally the tests are happy
2021-08-24 16:41:16 -04:00
rusefillc 767496f3f4 94/95 miata presets #3191 2021-08-24 16:03:50 -04:00
Andrey 03ffa82d8e zero dwell warning at zero RPM #3153 2021-08-16 09:11:22 -04:00
rusefillc e786af1c83 NB2 36 2021-08-10 02:34:59 -04:00
rusefillc 63e53aebc0 Implement auto knock threshold sampling #3033 2021-08-09 17:07:38 -04:00
Andrey 0df437e749 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 07:04:18 -04:00
Andrey 08dff4ceb6 Nissan 4 cylinder QR trigger wheel #3118 2021-08-08 06:16:19 -04:00
rusefillc 8cffec5c31 HELLEN_154_HYUNDAI 2021-08-03 13:51:33 -04:00
Matthew Kennedy b52d50bbf2
Use pch in lots of files (#3066)
* most engine.h

* most engine_configuration

* more

* more

* more

* more

* more

* moooooore

* ok I'm done for now

* oops
2021-07-26 01:05:17 -04:00
rusefi ee1426387b Red test mule cranking to idling is weird #3050 2021-07-24 11:56:29 -04:00
Andrey a8afb6eb85 trailing spark outputs #2931 2021-07-21 19:55:14 -04:00
Matthew Kennedy 2ce7777865
don't require EXTERN_ENGINE in every file (#2969)
* move enginePins

* no more extern engine

* uses

* more

* extern config too

* put this where it belongs

* include correct header

* merge
2021-07-16 18:13:33 -04:00
Andrey 23be588af6 trigger signal debug pins - logic level output #2959 2021-07-15 01:28:44 -04:00
Andrey 70872c8bf4 trigger signal debug pins - logic level output #2959 2021-07-14 22:35:29 -04:00
rusefi 6b25e220e6 VAG canned tunes 2021-07-09 01:53:09 -04:00
Andrey 3d0ba4af5c VAG canned tunes 2021-07-08 20:42:35 -04:00
rusefillc c229aeb46c
mobile browser coding 2021-07-08 18:09:03 -04:00
rusefi 4ead86c521 VAG canned tunes 2021-07-08 16:35:58 -04:00
Matthew Kennedy 188bf9bd57
hellen 128 defaults (#2912)
* all the pins

* s

* ign
2021-07-06 01:03:07 -04:00
Matthew Kennedy 142e44d82b
misc (#2899)
* dead fields

* defaults

* ui

* configs
2021-07-04 09:22:42 -04:00
Andrey bd5ff4b5a5 Nissan progress 2021-07-02 16:31:10 -04:00
Andrey a039c52897 Nissan progress 2021-07-02 16:26:23 -04:00
Andrey 82439b3ffd so many wonderful discoveries 2021-06-27 00:54:38 -04:00
Andrey 4463ca1fdb depressing code comment 2021-06-26 23:01:47 -04:00
Matthew Kennedy ce4eb2b55d
fix trigger changed logic (#2860)
* reenable

* fix

* longer interval between updates

* only deinit hard trigger outputs if necessary

* init logic

* init order

* warning

* guard

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-25 19:38:42 -04:00
Andrey 266e50f4ca Trigger: warning code on normal engine start up #669
making more code unit-testable
2021-06-25 11:50:23 -04:00
Andrey 35a63cad89 Revert "TS Burned All Data engine stop #2839"
This reverts commit dcb52a5b
2021-06-21 08:53:39 -04:00
Andrey dcb52a5b37 TS Burned All Data engine stop #2839
second guess
2021-06-21 03:10:59 -04:00
Andrey 3aab93b122 TS Burned All Data engine stop #2839
first wild guess
2021-06-21 02:51:12 -04:00
Andrey 640097f327 Review default H64 tune #2815 2021-06-13 21:27:03 -04:00
Matthew Kennedy e7f17b0365
move ign & cranking defaults (#2791)
* ignition defaults

* cranking

* s
2021-06-03 14:40:19 -04:00
Matthew Kennedy 981e8f5047
defaults cleanup: base engine & fuel (#2790)
* build

* fuel and base

* fix build

* cleanup

* extern

* tps/tps

* alternator

* tps

* iat timing

* cranking RPM

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-06-03 00:50:07 +03:00
Matthew Kennedy 790ac08a2e
Cranking defaults (#2787)
* defaults

* more

* cranking fuel

* cranking timing

* cranking time digits

* ugh these tests shouldn't depend on defaults
2021-06-02 08:21:36 +03:00
Matthew Kennedy de7879b6e4
convert a table to scaled_channel (#2724)
* scaled VE table

* use setTable

* efi::clear

* ratio -> struct
2021-05-20 20:00:32 -04:00
Andrey a762853d3b refactoring magic constant STOICH_RATIO 2021-05-20 02:39:20 -04:00
rusefillc 73bc91dee4 Improve default H64 tune #2709 2021-05-19 03:50:28 -04:00
Matthew Kennedy b373c03db8
Lua script editor in console (#2699)
* stub

* implement reset

* console

* just use the console command

* cleanup

* s

* s

* ui

* write in chunks

* fix write

* tab size, script read

* parse script properly

* put lua script in flash, tiny for now

* generated fields
2021-05-18 20:58:39 +03:00
Matthew Kennedy 04f9019df2
Post cranking fuel tweaks (#2718)
* post cranking factor limits

* sensible defaults

* but not for tests

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-05-17 17:24:29 -04:00
Matthew Kennedy dd6105cfa3
shrink canned tables (#2651)
* helper

* use it miata

* do type safe copy

* miata vvt

* etb

* default iat correction

* magic is afoot here

* hunchback

* misc

* neon

* neon

* aspire

* citroen

* neon

* missed one

* dead

* festiva

* remove andreyism

* very dead

* no need for copy of that function

* cleanup
2021-05-09 14:37:16 -04:00
Andrey G e18ba01fe5
hip9011 (#2658)
* hip9011: isolate debug stuff

* hip9011: renames

* hip9011: start sensing knockDetectionWindowStart degres from fire

* engine: more realistic values for knock window

* hip9011: remove magic CS toggling

* hip9011: EFI_HIP_9011_DEBUG should depend on EFI_HIP_9011
2021-05-08 18:43:55 -04:00
Matthew Kennedy bb0662791b
use setTable (#2621) 2021-05-04 10:03:41 -04:00
rusefillc 4dc461891a 2021 is the year of Hellen 2021-05-03 00:01:53 -04:00
rusefillc 9be7f2c582 50% duty cycle is the default for tach signal 2021-05-02 23:47:47 -04:00
rusefillc ecdcf8112b 2021 is the year of Hellen 2021-05-02 19:02:30 -04:00
rusefillc 10a6da8ac0 https://rusefi.com/forum/viewtopic.php?p=40654 2021-04-26 17:32:00 -04:00
Matthew Kennedy c26987b96b
Destroy all shared logger (#2574)
* most of shared logger

* a few more

* one more

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 14:28:48 -04:00
Matthew Kennedy ad71016862
rip the bandaid: find-replace most of scheduleMsg (#2572)
* biiiig find replace

* more trivial find replace

* pwm

* almost all of them

* few more

* gpio

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-21 12:53:13 -04:00
Matthew Kennedy bbb6b6dd14
remove simple cases of LoggingWithStorage (#2569)
* remove simple cases

* more simple

* serial

* s

* more

* try memory

* easy

* mmc acc

* that's how much memory

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-04-19 08:11:59 -04:00
rusefillc 5aca0dec1a hellen64 scripts and pinout #2565 2021-04-18 10:42:50 -04:00
Matthew Kennedy 5e2e18d2b9
improve sensor chart flush behavior (#2545)
* disable sensor chart

* type signature, guards

* we can't log the message as that confuses the parser

* dead

* this syntax was technically illegal

* more

* turn it back on

* remove config

* api

* implement

* ui

* java ui
2021-04-12 14:05:52 -04:00
rusefillc 20fcaafb92 https://github.com/rusefi/hellen72/issues/25 2021-04-10 23:30:36 -04:00
rusefillc 2b094849c5 linking error on jenkins and Andrey's windows desktop fix #2520 2021-04-03 23:34:56 -04:00
Matthew Kennedy 1dffcf5729
make board config override actually usable (#2508)
* new function

* hellen

* MRE

* proteus

* put those function declarations in a reasonable place

* put the comment back

* weak

* move that to a reasonable place

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-31 14:46:50 -04:00
Andrey G 3d138958ce
Hip9011 (#2512)
* hip9011: coexistance with other spi devices

* hip9011: rework so SPI transfer is invoked from thread

also use polling spi exchange to avoid cache problems

* hip9011: move calculations from ADC callback to thread

* hip9011: big cleanup

* hip9011: simplify spi communication

* No need to set knockBandCustom if it is not custom

HIP9011 calculates knockBand from cylinderBore same way

* hip9011: make unit test happy

* hip9011: fix unit test

* hip9011: remove duplicated initialization, reorder

* hip9011: just renames and data type adjustments

* hip9011: rename BAND() to HIP9011_BAND()

* hip9011: move some code from lookup.cpp to logic.cpp

* hip9011: move initEngineNoiseTable to engine_configuration.cpp

* hip9011: move lookup tables to hip9011_logic.c

* hip9011: remove empty files

* hip9011: additional checks
2021-03-30 10:56:25 -04:00
Matthew Kennedy 523bef2eb6
fix (#2511) 2021-03-30 07:28:22 -04:00
Matthew Kennedy 8b3aa6c40d
goodbye ignitionOffset (#2503)
* remove

* set the timing map to do what the offset used to do

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-28 08:00:09 -04:00
Matthew Kennedy 6491c83f73
read configuration from flash exactly once (#2481)
* early hw init

* s

* read configuration exactly once

* cleanup

* housekeeping

* test friendly

* ugh bad merge

* that is a noop

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-25 18:16:26 -04:00
Matthew Kennedy 51a5b4d6d5
rename setBoardConfigurationOverrides (#2479)
* rename

* proteus

* comments

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-22 14:15:09 -04:00
Matthew Kennedy 95b08c433f
Implement nonlinear fuel level sender (#2473)
* table function

* config fields

* sensor type

* switch consumers

* init the sensor

* ui

* 1mv resolution

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-19 08:39:08 -04:00
Matthew Kennedy b087f328f7
default config, UI tweaks (#2444)
* s

* fix this while we're at it

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-03-12 00:16:24 -05:00
rusefi 6f065274e4 aux pid is now VVT 2021-02-10 12:41:38 -05:00
rusefi c576f0a9d9 M62T vanos support #2243 2021-02-08 18:08:26 -05:00
rusefi a349bf1ca8 M62T vanos support #2243 2021-02-08 16:16:26 -05:00
Andrey G 08a5421090
Add subaru eg33 (#2294)
* engine: Subaru SVX EG33 engine configuration

Not tested yet. Just basic settings and placeholder

* board: add Dron_Gus's Subaru EG33 p'n'p board

* board: subaru eg33: linker script: stack, bss and heap to ram0

* board: subaru eg33: add mapping.yaml

* board: subaru eg33: scripts for autogenerated

* board: subaru eg33: fix DMA conflict (ADC1 vs SPI5)

* board: subaru eg33: enable ADC3

* board: subaru eg33: Autogenerated

* board: subaru eg33: disable fsio control of Main Relay

Default MAIN_RELAY_LOGIC cause error during parsing

* board: subaru eg33: configuration hack to fix usbconsole.c

* gen_config: generate config for Subaru SVX board too
2021-02-06 12:50:34 -06:00
Matthew Kennedy 9f0ebaac49
Proteus analog input ci (#2271)
* test vbatt

* test proteus vbatt

* tolerance

* these don't work on proteus

* new engine type

* test analog input

* more test points, less tolerance

* console build needs this file generated

* only include for hw ci builds

* wiring info

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-02-03 13:34:48 -06:00
Matthew Kennedy e0b2802a43
Map fallback logic, TS cleanup (#2247)
* add new field

* UI

* set default

* consume new parameter

* some cleanup while we're at it
2021-01-27 20:31:29 -05:00
rusefillc 1ed7d16d50 knock-knock 2021-01-23 00:00:34 -05:00
rusefillc 6bc882f30a Hellen72 2021-01-22 02:02:16 -05:00
rusefillc edd89c34f9 HELLEN_NB2 2021-01-22 01:47:01 -05:00
Matthew Kennedy eabb5c7366
flex fuel AFR interpolation (#2190)
* config

* implement flex

* secondary fuel default

* test

* test works

* rename

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-01-05 16:27:23 -05:00
rusefillc 9587b7bb54 hellen 2021-01-01 01:10:28 -05:00
rusefillc 1ebce57721 proteusBoardTest 2020-12-26 10:41:33 -05:00
Matthew Kennedy 3d13d03424
Purge e34 config (#2127)
* remove

* enums

* s

* func test

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-12-24 07:31:25 -05:00
Matthew Kennedy 55ebe223a7
Partition configs by board type (#2106)
* remove old flag

* flags

* reorder switch

* oops
2020-12-22 21:54:40 -05:00
Matthew Kennedy ba9de3a604
Purge fiesta config (#2117)
* config

* this had a feature flag?

* enums

* goodbye, fiesta
2020-12-22 17:22:05 -05:00
rusefillc 2d2225bfdb PROTEUS_QC_TEST_BOARD 2020-12-22 10:13:27 -05:00
Matthew Kennedy 8737ba62c2
Purge rover v8 config (#2116)
* bye

* goodbye, rover v8

* that snuck in

* use a different config for that test
2020-12-22 10:05:54 -05:00
rusefillc 55b4e82615 naming consistency 2020-12-18 09:01:18 -05:00
Matthew Kennedy aeea50ada2
move target computation (#2091) 2020-12-17 17:46:51 -05:00
Matthew Kennedy 1838beadfa
only build in config for the correct board (#2088)
* only build in config for the correct board

* undo

* undo

* undo

* only touch proteus config

* include configs in tests
2020-12-17 17:12:24 -05:00
rusefillc 26fbf0527a trigger and start button pins not displayed by "pins" command fix #2084 2020-12-16 22:53:26 -05:00
rusefillc a47129693a trigger and start button pins not displayed by "pins" command #2084
progress but not complete fix yet
2020-12-16 22:00:42 -05:00
rusefillc bd279edd8e pnp progress 2020-12-15 00:09:35 -05:00
rusefi 7f65e95a65 subi 2020-12-13 11:39:10 -05:00
rusefillc ea8e09ba13 fix warnings found by clang #2014 2020-12-08 13:59:40 -05:00
rusefillc 9f13d39003 MRE_SUBARU_EJ18 2020-12-06 14:16:40 -05:00
rusefillc 166f4fc381 MRE_SUBARU_EJ18 2020-12-06 13:08:09 -05:00
rusefillc b982d02298 miata 94 2020-11-28 22:49:28 -05:00
rusefillc 0840b91f7f dead engine config
one step back
2020-11-26 21:21:25 -05:00
rusefillc 334f0a5a8a dead engine config 2020-11-26 21:07:34 -05:00
rusefillc 55b763f62e dead engine config 2020-11-26 20:26:12 -05:00
rusefi 0d441be869 better default value 2020-11-25 17:02:28 -05:00
rusefillc 07e25ccf3c https://rusefi.com/forum/viewtopic.php?p=38367#p38367
idle position/waste gate position sensor usability
2020-11-14 18:05:27 -05:00
Matthew Kennedy cf3dc9c2c3
convert cranking defaults to mg (#1921)
* convert cranking defaults to mg

* fix tests
2020-11-03 14:12:26 -05:00
rusefi 2b7e33404f wall wetting default 2020-10-31 19:28:27 -04:00
Matthew Kennedy 3e30865e6c
unused tach field (#1918) 2020-10-29 15:26:01 -04:00
rusefillc 3635bac90a [EPIC] [Feature Request] Transmission Control #1454 2020-10-28 01:23:05 -04:00
rusefillc b4e3927a92 TCU 2020-10-28 01:01:30 -04:00
Matthew Kennedy 09b41bb1bb
Everything in lambda! (#1893)
* lambda

* default configs, fix build

* config, gauge, UI

* more digits

* change menu text

* fix that while I'm here

* doesn't need extra word

* todo note

* tests

* last test

* missed a config

* update java

* store target lambda

* more java

* format

* hopefully enough java for CI to pass
2020-10-26 18:15:17 -04:00
Matthew Kennedy a90792fa44
convert mass -> duration later in the pipeline (#1906)
* cranking duration to mass

* implement

* units

* patch types

* suppress warning

* fix output channels

* add note about how to set it
2020-10-26 07:23:13 -04:00
Matthew Kennedy 4e249889a6
implement fuel pressure sensors (#1897)
* add

* remove old

* remove more old

* makefile

* fix init

* patch up other stuff

* actually fix it this time

* raw output channels

* gauges, UI

* scaled channel

* fix field ordering
2020-10-23 07:31:47 -04:00
rusefillc 5f15b8e48b tachPulsePerRev needs a safer default, MRE config needs a value 2020-10-06 00:56:49 -04:00
Matthew Kennedy 16bfd39bac
Remove dead & useless config (#1834)
* remove dead config

* remove enum
2020-09-29 06:34:39 -04:00
rusefi 2d771018e8 unit test for start/stop hardware and pin repository #1811 2020-09-21 12:29:01 -04:00
David Holdeman 337106cd24
DebounceButton A/C switch (#1782)
* change acSwitch name, add mode

* fix

* remove some adc stuff

* remove some adc stuff

* semicolon stupid

* left behind

* add readpinstate

* wrong var name

* add functions back

* fix name

* bool, not void, plus fix name

* move

* not sure what I broke

* try setMockValue

* namespace

* whoops missed one

* switch values because adc was set up for pullup

* try 5

* comment for now

* comment for now

* uncomment tests, add function to mock, add mock to efiReadPin

* fixes

* for F's sake

* if

* add defy

* pass params

* use ASSERT_TRUE/FALSE

* advance time

* remove ifdef from readPin

* try moving if

* move to separate func

* move extern

* move include

* try engine_test_helper

* am confuse

* move func to else

* include hal

* add efi prod check

* remove include

* try extern

* move include

* semicolon stupid

* move extern again

* include

* move mockPinStates

* size

* add if

* add comment

* clean on instantiation
2020-09-10 22:16:20 -04:00
rusefi 9bea1190a4 Merge remote-tracking branch 'origin/Hellen_fork_point' into master
# Conflicts:
#	firmware/controllers/algo/engine_configuration.cpp
2020-09-07 15:55:43 -04:00
rusefi be0bbf3dc8 Hellen says merge #1772 misc #2 2020-09-07 15:53:26 -04:00
Matthew Kennedy 0e14e51179
reorder ADC channel index (#1763)
* change config

* correct logic

* clearing these no longer needed

* test expected this to be set
2020-09-06 18:25:26 -04:00
rusefi faea28e521 OBD-II default rate is 500kbps 2020-09-01 22:24:25 -04:00
rusefi 6f6eb0f561 BCM 2020-08-29 14:29:34 -04:00
rusefi 7a3b6387b5 BCM 2020-08-29 10:06:14 -04:00
rusefi f225e63544 Revert "removing a bit of dead code?"
This reverts commit b5ab6930
2020-08-25 15:50:50 -04:00
rusefi b5ab693083 removing a bit of dead code? 2020-08-25 15:19:37 -04:00
Matthew Kennedy c53979a017
Configurable stoichiometric ratio (#1710)
* configurable stoich ratio

* afr table always in gas afr

* default

* typo

* use defined ratio

* do it in config too

* missed a spot

* oops wrong one

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-08-21 19:43:30 -04:00
rusefi 553820ecc8 gimme my preset! 2020-08-19 20:40:10 -04:00
rusefi e936c2742c self-stimulation RPM is wrong by 50% if switching from NA6 to NB2 configuration fix #1682 2020-08-08 17:00:14 -04:00
rusefi 5925ca5125 trigger and VSS hw integrated testing #1668 2020-08-08 11:45:02 -04:00
Matthew Kennedy 80663b25a9 missed a spot 2020-08-03 12:22:41 -07:00
Matthew Kennedy 51804a4eb9 no more setFuelMap 2020-08-03 12:14:11 -07:00
rusefi 2c653ad333 @andreika I believe this is no longer needed since all fields have TS metadata? 2020-08-02 15:34:47 -04:00
Matthew Kennedy 978fa20916 Merge remote-tracking branch 'upstream/master' into remove-plain-maf 2020-07-31 14:56:29 -07:00
rusefi 1703152427 reducing code duplication? 2020-07-29 23:01:55 -04:00
rusefi cf4bfa8d91 NA6 progress 2020-07-29 21:38:34 -04:00
rusefi c7590aa8a4 NA6 progress 2020-07-29 15:51:01 -04:00
Matthew Kennedy 67e4fcb2a2 goodbye plain maf 2020-07-23 02:46:45 -07:00
rusefi 29e3c71df4 https://rusefi.com/forum/viewtopic.php?p=37401#p37401 2020-07-10 14:19:51 -04:00
rusefi 42541da76c more on wipeString 2020-07-05 14:09:43 -04:00
rusefi 9f3106db39 refactoring 2020-07-05 13:34:51 -04:00
rusefi 015293ee43 wipe strings in configuration images 2020-07-05 11:16:07 -04:00
rusefi dec8aafa38 BUG? handleCrc32Check does not use 'offset' parameter #1429 2020-06-19 00:17:05 -04:00
rusefi 7d8384d7fa 1 byte issue in TuneReadWriteTest fix #1512 2020-06-18 23:29:08 -04:00
rusefi fc5dd7d0c3 a few unneeded properties 2020-06-13 22:46:10 -04:00
rusefi 1a645bda1a unused parameter 2020-06-13 22:30:43 -04:00
rusefi d1a30f362c tuneCrc16 - we use it to match logs to tunes 2020-06-04 20:43:52 -04:00
Matthew Kennedy b11c5cd8c8
switch some firmware warnings to errors (#1465)
* warnings as errors

* throw instead of exit

* test massaging

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-23 10:46:28 -04:00
rusefi 6b35e01f7d code style 2020-05-22 18:07:19 -04:00
rusefi db2e6ec60f HW test progress 2020-05-21 21:45:01 -04:00
rusefi 82e788ef3a MRE pre-sets 2020-05-21 20:44:14 -04:00
rusefi aac7712df5 test fixture progress 2020-05-21 18:36:32 -04:00
Matthew Kennedy 9dda1a21bc
Redundant tps (#1427)
* add redundant sensor

* add tests

* add configure, info printing

* tests

* tests

* partial hookup

* fix

* fix

* bad makefile merge

* use second TPS config

* update test

* update test

* sensor names

* set second pin by default

* fix auto cal

* auto cal both sensors

* add reconfigure of secondary sensors

* gobblin' up your ram

* slow down write a little bit

* put split in debug gauge

* s

Co-authored-by: Matthew Kennedy <matthew@mck-mbp-15.local>
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-05-18 14:32:00 -04:00
Matthew Kennedy c7fadd475f
configuration for secondary (redundant) TPS sensors (#1419)
* add new fields

* add tps 2 secondary

* sensible error detection limits

* UI mods

* grey out as appropriate

* defaults

* either it's unused or its not
2020-05-10 16:13:15 -04:00
rusefi fcbba66e89 rusEFI online engine crc 2020-05-09 22:43:39 -04:00
rusefi e9e95ec5f3 Merge remote-tracking branch 'origin/master' 2020-05-07 00:56:22 -04:00
rusefi 016da58bbd field useful for rusEFI online catalog 2020-05-07 00:55:59 -04:00
Matthew Kennedy aa3bf51723
short term fuel trim: part 1 (#1402)
* add cell

* add stft cell tests

* add bit

* minimally generate

* config defaults
2020-05-06 21:00:40 -04:00
rusefi f456799310 reducing confusion? 2020-05-02 22:06:11 -04:00
Matthew Kennedy f128b33694
General purpose PWM: implementation & tests (#1366)
* config

* significant digits

* renumber enum, no need for a "none"

* ui

* impl base

* error handle MAP

* init & update

* don't need arg

* don't lie about sensor

* fix test build

* test stub

* initialize

* null check

* fix clamping

* test output

* types & enums

* don't need param

* test getOutput

* fix

* output pin instead of brain pin

* default config
2020-04-26 14:06:28 -04:00
Matthew Kennedy 83cca6ec7a
allow overriding configuration (#1341)
* config overrides

* proteus too

* comment

* remove wno-error

* comment
2020-04-26 00:07:59 -04:00
dron0gus 474d5e64cf
Update chibios (#1364)
* Update ChibiOS

* Fix coexistance of ChibiOS and our flash drivers

* Add 'int' = internal prefix for all on-chip flash functions

This avoid conflict with ChibiOS functions available after
enabling HAL_USE_EFL

* Exclude ChibiOS flash driver from bootloader

* Makefile magic?

* Kinetis: fix build after ChibiOS update and switching to SMART_BUILD

* Bootloader now use SMART_BUILD too
2020-04-25 16:32:32 -04:00
Matthew Kennedy a8f466c615
trigger emulator refactoring (#1358)
* trigger gen refactoring

* missed one

* fix makefile

* commentary

Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2020-04-24 14:00:06 -04:00
Matthew Kennedy 1bad5f3047
don't store self stim in config (#1356)
* kill

* add bench test

* fix
2020-04-23 22:38:14 -04:00