rusefillc
9571f1fe67
Mitsubishi 4B11 support #4013
2022-03-19 15:52:42 -04:00
rusefillc
aa7624950a
Mitsubishi 3A92 Support (Issue #4011 )
2022-03-19 12:01:57 -04:00
rusefillc
1d64929f33
Remove Miata MX5 NB1 trigger fix #3488
2022-01-31 18:20:43 -05:00
rusefillc
e464dd4a52
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 20:55:50 -05:00
rusefillc
3898f0ce7d
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
rusefillc
890d7769a0
Bosch Quick Start on B6 Passat is confused about phase #3812
2022-01-19 16:42:05 -05:00
Matthew Kennedy
0932fcf94c
Improve NA/NB miata sync parameters ( #3730 )
...
* NA sync parameters
* NB vvt pattern too
* zach's car says tighten the gap
* look at that, we sync one cycle sooner!
2022-01-01 21:39:04 -05:00
Matthew Kennedy
d5c4b79b1a
Nb2 crank sync special case ( #3727 )
...
* extract isSyncPoint
* test because why not
* check vvt resync nb2
* custom nb decoder
* test only resyncs once!
* good job valgrind, you found a bug!
2021-12-31 15:47:25 -05:00
Matthew Kennedy
95ad75318d
improved noFiringUntilVvtSync logic ( #3696 )
...
* s
* poke
* poke again for science
* kick for science
* kick
* kick
* comment kick
* s
* don't try to compare the array decay pointer to 0 (!)
* collateral damage
* adjust miata sync
* reset trigger states correctly on engine stop
* s
* nissan MR too
2021-12-27 12:09:38 -05:00
rusefillc
4292c2fb1d
MAP phase sensing fix #3544
...
removing dead implementation
2021-12-16 21:28:27 -05:00
Matthew Kennedy
256df56fa7
Honda K 12+1 decoder adjustment ( #3694 )
...
* adjust trigger
* real cranking
* mk
2021-12-14 21:10:01 -05:00
Matthew Kennedy
7e3765650f
adjust mr18 vvt trigger ( #3691 )
...
* adjust mr18 trigger
* second gap, why not
2021-12-13 16:33:34 -04:00
rusefillc
fda7a3a775
Engine phase wrap around in log #3645
...
refactoring & docs
2021-12-02 17:06:20 -05:00
Andrey
0ec8b8d46c
reliable 32/2 trigger shape
2021-11-25 20:45:58 -05:00
Andrey
48ed80ffb9
MAP phase sensing #3544
2021-11-24 23:06:52 -05:00
Andrey
228d5ee810
MAP phase sensing #3544
2021-11-24 22:41:49 -05:00
Scott Smith
ba4a00d3bb
Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData ( #3519 )
...
* Drop SingleChannelStateSequence in favor of MultiChannelStateSequenceWithData
Most all the users were Multi* anyways, so just improve that:
1. Allow up to 8 waveforms to share one byte per timestamp. It could be better but this is simple
and gets most of the benefit.
2. Use a wrapper structure to handle reserving space for the arrays. Makes the interface simpler
and more rigid. Also saves 4 bytes per Multi*. Downside is access is now via -> and *,
not . and (nothing).
Saves 224 bytes of BSS, 1832 bytes of RAM4/CCM, 952 bytes of TEXT, and 103 bytes of RODATA
* Instantiate a base_t to make debugging easier.
Also fixes crash on real firmware by using &m_base instead - LTO optimization issue?
* No magical templated StaticAlloc thingy. Just virtual functions.
2021-11-21 04:56:07 -05:00
Matthew Kennedy
bb57a4b084
detect more overflows with asan ( #3582 )
...
* overflow detector
* type list dynamic allocate
* fix the buffer length
* comment
* pr fb
* sanitize sim
* fix sim sanitizer bug
* didn't mean to turn off optimization for sim
* asan can do that, if you turn it on!
* cleaning
2021-11-20 01:38:39 -05:00
rusefillc
ecac07f938
brave refactoring
2021-11-19 23:56:52 -05:00
Matthew Kennedy
692e3d7e9f
adjust miata sync conditions ( #3577 )
2021-11-19 02:30:05 -05:00
Scott Smith
69d36dad6e
Final cleanup of ENGINE macros ( #3567 )
...
Fix some uses of ENGINE() not detected by regex due to parenthesis.
Remove now empty engine_ptr.h
Don't worry about EFI_* not being defined, the compiler defaults to 0 if they aren't.
2021-11-17 13:45:10 -05:00
Scott Smith
823d9a07e0
Programmatically replace ENGINE() and CONFIG() with engine-> etc ( #3565 )
...
git grep -l -w ENGINE | xargs sed -i -r "s/ENGINE\(([]a-zA-Z_0-9.[]+)\)/engine->\1/g"
git grep -l -w CONFIG | xargs sed -i -r "s/([^a-zA-Z_])CONFIG\(([]a-zA-Z_0-9.[]+)\)/\1engineConfiguration->\2/g"
2021-11-17 03:54:21 -05:00
Matthew Kennedy
8cdac4cac0
remove engine pointer passing ( #3556 )
...
* some
* more
* more
* the last?!
2021-11-16 04:15:29 -05:00
rusefillc
0813266ee1
trigger refactoring & docs
2021-11-14 15:35:11 -05:00
Matthew Kennedy
a7ba539e70
math is fun ( #3545 )
...
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-14 15:32:35 -05:00
Matthew Kennedy
d591a5ad26
mercedes two lobe trigger testing ( #3543 )
...
* mercedes
* config
* break;
* I did the gap ratio math wrong
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-11-13 21:50:04 -05:00
Scott Smith
713083baa5
Convert TriggerWaveform::wave to a pointer in preparation for code-defined sequences. ( #3528 )
...
It will eventually be class to support dynamic universal patterns in addition to ROM-based
tables.
2021-11-11 13:19:25 -05:00
Scott Smith
2f4d123052
Change users of MultiChannelStateSequence to use the API ( #3524 )
...
Better than reaching into members that should be private. I didn't feel like actually making
them private though, as one user validates pinStates isn't NULL.
2021-11-11 09:19:22 -05:00
Scott Smith
d4c4db9a12
Move phaseCount into MultiChannelStateSequence ( #3520 )
...
We can them drop the field from a bunch of callers, simplifying the code.
2021-11-10 19:47:27 -05:00
Scott Smith
dac67235c4
Don't keep a separate MultiChannelStateSequence for the trigger emulator, version 2. ( #3517 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-10 07:01:20 -05:00
rusefillc
1db9a02f1d
Revert "Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )"
...
This reverts commit 280dfa94e7
.
2021-11-09 20:42:23 -05:00
Scott Smith
280dfa94e7
Don't keep a separate MultiChannelStateSequence for the trigger emulator. ( #3513 )
...
All it wants is to use the main trigger state, so don't bother copying it. Instead, change
PwmConfig to take a const pointer to a Multi.*Sequence, then make all the users adapt. Worse
fallout is that SimplePwm now has its own Multi.*Sequence, but PwmConfig is downgraded to a
pointer, so that's only a net +4 bytes. And we can make the overhead of Multi.*Sequence much lower
using embedded arrays, which only the caller can do since it knows the maximum size... (for another
day...)
Also remove SimplePwm's 2nd copy of SingleChannelStateSequence. It served no purpose.
Saves 1992 bytes of BSS and 24 bytes of RAM4 (latter probably due to SimplePwm change)
2021-11-09 14:35:07 -05:00
Scott Smith
158f719d95
Save ~2800 bytes of RAM by not caching angle->trigger mapping ( #3506 )
...
Memory seems more valuable than CPU; use the O(lg n) lookup by angle. A side effect is that it
seems to fix trigger lookup for the second phase of TRIGGERTYPE 53 544 TT_TRI _TACH 0.00
2021-11-09 07:03:27 -05:00
Andrey
9ac1575777
reducing complexity
2021-11-07 01:57:32 -05:00
rusefillc
5de6c2a270
typo
2021-11-07 01:51:05 -05:00
rusefillc
20784db801
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:34:16 -04:00
rusefillc
0af09f596c
refactoring - magic constant bad
...
cypress and kinetis both have this macro already
2021-11-07 01:28:28 -04:00
rusefillc
656b8c3429
refactoring - magic constant bad
2021-11-07 00:03:16 -04:00
Matthew Kennedy
036c1b17d3
make master happy ( #3467 )
2021-11-05 16:01:13 -04:00
Matthew Kennedy
2b9696442e
nissan MR18DE VVT cam pattern ( #3466 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
* enums
* image
* image
* implement decoder
* reshuffle
* don't case unused
* dead trigger enums
2021-11-05 15:33:22 -04:00
Matthew Kennedy
365691cb37
nissan 4yl crank pattern ( #3462 )
...
* refactoring nissan trigger
* comments
* plumbing
* b
2021-11-05 07:15:03 -04:00
Andrey
61777564d4
Honda K cam wheels #3405
2021-10-30 21:09:58 -04:00
Andrey
a6a969390f
Honda K cam wheels #3405
2021-10-28 19:26:59 -04:00
Andrey
de350131e6
Honda K cam wheels #3405
2021-10-28 11:40:31 -04:00
Andrey
484d078752
Honda K cam wheels #3405
2021-10-26 22:47:19 -04:00
rusefi
30f9c57f70
Honda K cam wheels #3405
2021-10-26 17:29:26 -04:00
rusefillc
4ef959a60e
generate java enum from C enum? generate both C and java from yaml? #2102
2021-10-25 11:05:45 -04:00
Andrey
229419d04b
Honda K cam wheels #3405
2021-10-24 17:12:19 -04:00
rusefillc
eb05f4594e
very old very dead code
2021-10-20 12:57:07 -04:00
rusefillc
8a2472126a
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 19:59:51 -04:00
Andrey
b0ae87054a
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 19:29:58 -04:00
rusefillc
eccdf18eec
https://rusefi.com/forum/viewtopic.php?f=5&t=2143 Suzuki G13B tooth pattern
2021-10-04 11:25:27 -04:00
rusefillc
58cd414c0a
miata NB1 is a weird half-VR/half-Hall sensor
2021-09-29 14:31:36 -04:00
Matthew Kennedy
35e1a7cc0c
fix ( #3253 )
2021-09-21 00:27:14 -04:00
rusefillc
7fc88fa304
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
2021-09-12 13:58:03 -04:00
Andrey
301f5e7ec4
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
2021-09-12 11:56:12 -04:00
rusefi
83c0372729
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
...
Ford TFI PIP
2021-09-11 23:42:05 -04:00
rusefi
48c516f9f7
https://rusefi.com/forum/viewtopic.php?f=5&t=2117
...
Ford TFI PIP
2021-09-11 23:16:22 -04:00
Matthew Kennedy
c72bd07179
enable address sanitizer ( #3217 )
...
* enable asan
* lua
* this is dead and leaky
* leaky nissan
* fix pwm generator use-after-stack
* initializers
* prevent problems in case of invalid trigger shape
Co-authored-by: Matthew Kennedy <makenne@microsoft.com>
2021-09-05 05:56:59 -04:00
Andrey G
39664d98a0
Subaru svx trigger update (not vvt) ( #3210 )
...
* trigger: subaru: SVX: some comments
* trigger: subaru: svx: fix crank 2 offset
* trigger: subaru: svx: rework a bit
* trigger: subaru: svx: fix dtc position
2021-09-04 11:42:12 -04:00
rusefillc
526340de78
Subaru svx vvt #3210
...
helping or not
2021-08-31 06:05:57 -04:00
rusefillc
1a1b7f95c0
Subaru svx vvt #3210
...
helping or not
2021-08-31 05:54:04 -04:00
rusefillc
6ea76921f4
docs
2021-08-31 04:27:31 -04:00
rusefillc
3d4ff9083b
Pavel says there are issues
2021-08-11 04:16:51 -04:00
Andrey
08dff4ceb6
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 06:16:19 -04:00
Andrey
167f2dbba0
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 04:56:56 -04:00
Andrey
a2d18fa0b7
Nissan 4 cylinder QR trigger wheel #3118
2021-08-08 04:45:40 -04:00
Matthew Kennedy
b52d50bbf2
Use pch in lots of files ( #3066 )
...
* most engine.h
* most engine_configuration
* more
* more
* more
* more
* more
* moooooore
* ok I'm done for now
* oops
2021-07-26 01:05:17 -04:00
rusefillc
23842bf143
safer NB2 progress ( #3041 )
...
* safer NB2 progress
* one step back
2021-07-23 16:43:24 -04:00
Matthew Kennedy
d520d12490
adjust nb2 vvt sync ( #3019 )
...
* test existing implementation
* nb2 vvt pattern sync
* update test
2021-07-21 20:07:28 -04:00
Matthew Kennedy
5f3464b204
Fix prepareEventAngles for symmetrical crank triggers ( #2982 )
...
* fix and make code legible
* update test to check every tooth
* symmetrical crank
* simplify findTriggerPosition
* make getAngle intelligable
2021-07-17 23:27:20 -04:00
Andrey
9345e5d2e0
NB2 trigger shape does not seem to match JimStim #2980
...
only first steps of unit test
2021-07-17 17:47:32 -04:00
rusefillc
6da3310d97
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 02:03:55 -04:00
Andrey
180d7bc899
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 01:10:13 -04:00
Andrey
ffe2fe3271
refactoring
2021-07-17 00:56:50 -04:00
Andrey
d583c91a7a
refactoring
2021-07-17 00:53:51 -04:00
Andrey
d16d6dd58d
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:46:39 -04:00
Andrey
f54b3cd1b2
refactoring
2021-07-17 00:46:39 -04:00
Andrey
df558303d3
kaiju is asking for vq30de trigger wheel decoder #2974
2021-07-17 00:27:56 -04:00
Matthew Kennedy
2ce7777865
don't require EXTERN_ENGINE in every file ( #2969 )
...
* move enginePins
* no more extern engine
* uses
* more
* extern config too
* put this where it belongs
* include correct header
* merge
2021-07-16 18:13:33 -04:00
rusefillc
090725d273
reducing warnings
2021-07-13 14:50:10 -04:00
Andrey
293bf45763
refactoring - reusing magic constant
2021-07-05 23:07:36 -04:00
Andrey
1660a5b3fd
Nissan progress
2021-07-02 19:57:26 -04:00
Andrey
ab8bb3a5cb
Nissan VVT trigger decoder #2887
2021-07-01 23:53:53 -04:00
Andrey
ae7937402c
Nissan VVT trigger decoder #2887
2021-07-01 22:27:43 -04:00
Andrey
fccd13247b
Nissan VVT trigger decoder #2887
2021-07-01 21:48:47 -04:00
Matthew Kennedy
025c32de00
Stricter miata sync ( #2891 )
...
* strict mazda trigger shape
* this is an even better gap
* sync point moved so things are different now
* fix
* update instantrpm in test
* s
* s
* this is safer
* test
* tests
* instant rpm
* cleanup
2021-07-01 21:29:04 -04:00
Andrey
50e25605b8
Nissan VVT trigger decoder #2887
2021-07-01 17:28:52 -04:00
Andrey
41060a1235
VW warnings on cranking #2861
...
same resilience for some other triggers
2021-06-27 13:29:09 -04:00
Andrey
2e252022aa
VW warnings on cranking #2861
2021-06-27 12:31:18 -04:00
Andrey
eaff083377
refactoring - explicit read method
2021-06-26 22:17:07 -04:00
Andrey
1822426d0c
refactoring - explicit read method
2021-06-26 22:11:42 -04:00
Andrey
a5eeb19c4d
refactoring - explicit read method
2021-06-26 22:07:45 -04:00
rusefillc
0af5de0934
Minor change of Miata NA trigger shape #2855 #669 ( #2856 )
...
* Minor change of Miata NA trigger shape #2855 #669
* Minor change of Miata NA trigger shape #2855 #669
2021-06-25 14:12:18 -04:00
Andrey
3092164e48
Minor change of Miata NA trigger shape #2855 #669
2021-06-24 22:21:30 -04:00
Andrey
03f18cd0c8
OMG dead code?!
2021-06-24 22:01:57 -04:00
Andrey
c13bb8dbe1
looks like this parameter is very well used now?
2021-06-21 02:12:14 -04:00
Andrey G
e561836c58
trigger: subaru 7+6: update cranck angles, add comments ( #2789 )
2021-06-02 19:19:52 +03:00
Andrey G
8ee700bf76
Subaru svx ( #2777 )
...
* Revert "hiding 3rd channel for now"
This reverts commit 50682816ac
.
* trigger subaru SVX: disable cranck #2 channel
* Board subaru-eg33: fix D10 pin defined twice
* Board subaru-eg33: renumber ignition ouput according cylinder order
* board subaru eg33: use common_make.sh to get dfu files
* board subaru-eg33: update default configuration
2021-05-31 04:25:57 -04:00
Andrey
39bc62ff2e
SVX
2021-05-30 19:59:13 -04:00