Commit Graph

1825 Commits

Author SHA1 Message Date
Daniel Chew 303385bfbd
enable verbose property to return metadata for ws endpoint (#271)
* enable verbose property to return metadata for ws endpoint

* remove console log

* fix test cases failing

* fix spelling errors

* update callback and listener to use PriceInfo

* isolate verbose flag to each client and add tests

* isolate verbose flag from clients
2022-09-07 23:27:44 +08:00
Ali Behjati bd90203cdf
Fix a bug in the id of price attestation (#273) 2022-09-07 14:57:15 +02:00
Ali Behjati dd3f5a57ee
Abehjati/fix-deployment-bugs (#272)
* Fix migration files

* Use another rpc endpoint for bnb

* Fix the bogus commit hash replacement instruction

* Use a more clear placeholder
2022-09-07 12:00:18 +02:00
Stanisław Drozd 15f3175f91
p2w: Make commitment usage consistent (#270)
This changeset adjusts p2w_autoattest.py commitment to confirmed and
fixes a get_transaction() failure that happened due to the upstream
default finalized commitment setting (RpcClient's set value is not
used). This is fixed by using the chosen commitment explicitly via
get_transaction_with_config()
2022-09-06 16:21:02 +02:00
Stanisław Drozd 94aab8af8f
Drozdziak1/p2w init rent adjustment (#269)
* pyth2wormhole: add rent adjustment to the initialize() instruction

* pyth2wormhole migrate(): Leave a note about rent adjustment

The migrate() ix won't be called in the nearest future - it does not
make sense to bloat the program bytecode with the rent adjustment. The
note describes the what and why in detail.
2022-09-06 16:06:07 +02:00
Ali Behjati 65c273fa0a
Add pythnet migration files (#246)
* Add pythnet migration files

Also:
- Add related env vars for testnet networks. Mainnet ones to be added
when it's ready.
- Rename Pyth2Wormhole env vars to solana

* Add mainnet emitter

* Fix migration file numbers

* Address Jayant comments
2022-09-06 13:03:21 +02:00
Daniel Chew b846fc3c84
add new latest_price_info endpoint (#264)
* add new latest_price_info endpoint

* add verbose query param to latest_price_feeds

* add back logging statement for VAA

* trigger CI
2022-09-06 00:02:57 +08:00
Stanisław Drozd aa7be4d1be
Drozdziak1/p2w client error logging and docker caching (#268)
* p2w-client: Fix silent logs, restore program log printing

For some time now, p2w-client error reporting would fail to show
daemon mode errors. The logs would only mention resends without ever
showing failed attempts.

with solana-program 1.10.31 came a newer, inferior program log
reporting which only says "N program logs" instead of saying what they
are. This changeset prints errors verbatim using formatted debug
"{:#?}" syntax.

* Docker: Improve p2w-attest/solana-devnet caching

This commit speeds up caching in two ways:

1. By severing the dependency on bridge-client in
Dockerfile.p2w-attest - mainly because of unnecessary `cargo install`
builds which even with target dir caching can take ~1 minute. The
bridge/token-bridge client binaries are not useful to p2w-client anyway.

2. By attaching cargo-install commands to a target dir cache via the
--target-dir option in cargo
2022-09-05 17:00:24 +02:00
Ali Behjati 5c48dacee0
Hack the rent exempt bug (#265)
* Hack the rent exempt bug

* Fix compile bug

* Fix account resize potential problem

* Use invoke transfer instead of playing with lamports
2022-09-05 13:32:41 +02:00
Ali Behjati 19e34f5c00
Fix bugs related to P2WMessage being owned by wormhole (#266)
* Fix caused by wormhole owning P2WMessage

* Refactor the code

* Comment the integration test

It seems that solana test suite has bug,
An error occurs after tx is finished successfully. Also,
it appears as a segfault for Reisen.

* Add more comments

* Add manual check for seeds

* Add more comments

* minor comment change

* Improve comments
2022-09-05 12:36:59 +02:00
Stanisław Drozd 19047c13b4
p2w-client: add get-emitter for printing emitter address (#267)
* p2w-client: add get-emitter for printing emitter address

* Move get-emitter before CLI checks
2022-09-05 12:01:12 +02:00
Ali Behjati b4c8f2e470
Refactor our CW contract + cleanups (#262)
* Use the cw sdk

* Fix clippy warnings

* Use Addr instead of String

* Format the code (cargo +nightly fmt)

* Depend on wormhole git instead of local dependency

* Add error enum

* refactor

* Refactor errors

* certusone->wormhole-foundation rename

It will fix some compile problems

* Build wormhole contract from their repo

* remove wormhole package

* Remove memmap2 patch

It was not needed anymore with the newer
verison of solana (wormhole removed it too)

* Rename pyth-bridge to pyth-cosmwasm
2022-09-02 12:39:51 +02:00
Daniel Chew 8cea878c34
remove resource memory limit (#263) 2022-09-02 12:36:56 +02:00
Stanisław Drozd 6382f540db
Wormhole message reuse via post_message_unreliable (#261)
* pyth2wormhole: Implement reusable message PDAs

This changeset converts attest() to use a new PDA for
reusable/unreliable wormhole message account. Each PDA is tied to a
given attest() payer with an index that lets them rotate a number of
message accounts. Keeping the appropriate timing of the reuses is up
to the message owner, who should rotate a number of PDAs.

* pyth2wormhole-client: Add a message acc rotation impl

* p2w attest(): Integrate with bumped wormhole and fix call issues

* p2w-client: Format code, fix test_attest, refactor message index

* Dockerfile.client, Dockerfile.p2w-attest: Improve caching

The main improvement comes from running cargo-install from within a
workspace which lets us cache target/

* p2w-client: Make reusable messages configurable in yaml

* p2w on-chain: refactor to unreliable-only, adjust msg balance, nits

* p2w-client: P2WMessageIndex -> P2WMessageQueue, queue tests

* p2w-client: Add a hard limit to the message account queue
2022-09-01 18:47:24 +02:00
Stanisław Drozd a2a0f6e15b
Start depending on the upstream out-of-tree Wormhole (#258)
* Add out-of-tree dependency on wormhole v2.8.9

This lets us outsource all wormhole/solitaire code to the upstream
certusone repo

* Docker.client: Use cargo-install to install binaries from github

* p2w: fix solana-program wasm-bindgen

* pyth2wormhole: Fix code-level errors against newer solitaire

* p2w: Use upstream wormhole rust code, bump guardian to 2.8.9

* guardian: ensure solana is on, spy: bump image to 2.8.9

Co-authored-by: Reisen <reisen@morphism.org>
2022-08-29 16:18:41 +02:00
Jayant Krishnamurthy b485ef4d16
Use Confirmed confirmation level instead of Finalized (#256)
Co-authored-by: Jayant Krishnamurthy <jkrishnamurthy@jumptrading.com>
2022-08-29 11:23:17 +02:00
Ali Behjati 56563599ac
Abehjati/update-target-chains (#260)
* Disable storage collision check on some migrations

Some changes after them have storage collision and this requires them to
disable it too

* Add new implementation memory layouts
2022-08-26 12:01:30 +02:00
Daniel Chew 3100ab9e53
add api endpoint to get all supported price feed ids for price service (#259)
* add new /price-feed-ids rest endpoint

* add docker-compose.yaml and update README

* Update third_party/pyth/price-service/README.md

Co-authored-by: Ali Behjati <bahjatia@gmail.com>

Co-authored-by: Ali Behjati <bahjatia@gmail.com>
2022-08-26 07:27:03 +08:00
Ali Behjati a17b27f3d1
Eth contract fix memory + new sdk + refactor (#257)
* Update sdk version

* Update the contract according to the sdk changes

- Change some memory modifiers to improve gas efficiency
- Implement getValidTimePeriod() and remove old staleness logic
- Update the tests

* Update latest migration descriptions

* Add version

* Update Deploying.md

* Add test to validate version of the contract

* Add deploy commit hash

* Rename the placeholder

* Fix placeholder
2022-08-24 19:33:49 +02:00
Ali Behjati 995c886804
Update solidity sdk version (#255)
* Update solidity sdk package.

* Add migration files
2022-08-23 09:48:24 +02:00
Ali Behjati f09c46b1cd
Make validTimePeriod configurable (#249)
* Make validTimePeriod configurable
2022-08-22 20:13:13 +02:00
Ali Behjati c058f2fff7
Rename image push gh actions (#254) 2022-08-22 13:28:57 +02:00
Ali Behjati 586eba0eb9
Abehjati/release-price-service (#251)
* npm audit fix

* Update package name

* Remove guardian image and use official ones

* Update README

* Fix config file name

* Use aws public repo
2022-08-22 10:05:22 +02:00
Stanisław Drozd 130c0522f0
pyth2wormhole: Fix a cfg migration bug, fix cfg lockout (see below) (#253)
This commit resolves a runtime problem in migrate() which occurred on devnet, as
well as invalid mutability for the old config and misuse of the
checked_sub() method.

The runtime problem came from a non-zero balance existing on
not-yet-used PDA. Effectively, this means permissionless
initialization of PDAs on Solana. Anyone can send lamports to any
account on Solana (existing or not), and it doesn't take much funds to
keep an empty account exempt. While it is possible to recover from it,
this case is relatively rare and takes a lot of code to
automate. Instead, we settle for a dumb bump of the config PDA
seed (see config.rs).

This measure is best used sparingly, as it imposes the same static
seed on all SOL networks. This will cause headaches if the attester
tooling grows a third-party user base.
2022-08-19 08:45:47 -07:00
Ali Behjati 22cdd5efb1
Abehjati/update-eth-contract-prev-price (#252)
* Set prev* to current* when price gets stale

* Add new solidity sdk

* Add migration files for this update

* rename diff to absDiff

Strangely, although you cannot use parent private method, you cannot
define a method with same name

* Add a comment to explain the prevPrice replacement
2022-08-19 13:42:19 +02:00
Ali Behjati 2a5b98187b
Add p2w-attest image (#250)
* Add p2w-attest image

Also rename pyth-price to xc-server

* bugfix
2022-08-16 10:53:08 +02:00
Ali Behjati 6fc11fc289
Upgrade testnet contracts (#248)
* Upgrade testnet contracts

And fixes some issues for it. Specially it uses
unsafeSkipStorage to skip OZ collision check
as they are very conservative and doesn't
cover our valid memory changes.
We should be very careful in memory
changes now that we cannot use
OZ collision check.

* Address Tom comments
2022-08-10 15:58:13 +02:00
Ali Behjati 2361793147
Enable multiple datasource in cw contract (#247) 2022-08-02 11:30:32 +02:00
Ali Behjati d5186f8d56
Update 4_pyth_add_events_and_update_fee.js (#244) 2022-07-29 15:57:10 +02:00
Ali Behjati f0e88848eb
Abehjati/cleanup-cosmwasm (#243)
* Remove unneeded stuff and warnings

* Remove old readme and replaye pyth readme with it

* Fix build issue

* Revert wormhole contract.rs change

* Address review comments

* Address review comments

* Make Readme more clear
2022-07-29 09:53:21 +02:00
Ali Behjati bf021010cc
evm-watcher: Add logic to group events for dispatch (#242)
* Add logic to group events for dispatch

* Add comment about one important assumption

* Address review comments
2022-07-28 16:04:57 +02:00
Ali Behjati 5320c58cf6
Implement the new IPyth events and methods (#241)
* Implement the new IPyth events and methods

* Check contracts gets the fees in tests

* Fix the fee variable position to avoid conflict

* Add migration files.

* Add events to migration names and docs

* Fix pyth contract address in tests

Very strangely after adding migration steps the old address
used in evm relay became wormhole implementation address
I looked at eth-0/tests container logs and saw the
address is entirely different (before and after the change)

* Fix previous migration bug.

* rename instance to proxy to be more clear

* Update Deploying.md
2022-07-28 14:56:13 +02:00
Ali Behjati 07bf9dbee2
Abehjati/use-cw-1-for-contracts (#240)
* Bump version of cw packages from 0.16.0 to 1.0.0

* Fix build

* Update wormhole details

* Update js packages

* Update dockers, configs, to use cosmwasm 2 in tilt

* Update wormhole and pyth addresses everywhere

The migration file is probably not necessary for us.
To be deleted later.

* Update gh action name
2022-07-20 16:35:01 +02:00
Ali Behjati 59ac319305
Abehjati/rename-terra-to-cw (#239)
* Rename terra folder to cosmwasm

* Update dockers and tilt

* Update gh action
2022-07-19 16:26:41 +02:00
Stanisław Drozd f0552e5f1b
pyth2wormhole-client: refactor into fully-async futures-based approach (#219)
* pyth2wormhole-client: refactor into fully-async futures-based approach

commit-id:2ed35045

* p2w-client: Change inconsistent rpc constructor

commit-id:cb3b2ff2

* p2w-client: Move job creation to a function, simplify comment

commit-id:35328b38

* pyth2wormhole-client: Use get_multiple_accounts

commit-id:7fc85157

* Implement a rate-limited mutex for RPC client

commit-id:1a243063

* pyth2wormhole-client: only guard beginning new requests in RLMutex

commit-id:d8251474

* pyth2wormhole-client: RLMutex: ensure the inner guard is not dropped

commit-id:c3513f5e

* pyth2wormhole-client: Clarify attestation_sched_futs comment

commit-id:97033670

* pyth2wormhole-client: Use CommitmentConfig's native FromStr parsing

commit-id:835d7125

* pyth2wormhole-client: doc comment typo

commit-id:5ee388de

* pyth2wormhole-client: move closures to their own async functions

This makes the main.rs async attestation routines easier to read.

commit-id:3565a744

* pyth2wormhole-client: fix merge typo

* pyth2wormhole-client: Apply Tom's readability advice

* pyth2wormhole-client reword attestation_sched_job() comment

* pyth2wormhole-client: expand attestation_sched_job() comment

* pyth2wormhole-client:   e  x  p  a  n  d   the comment

* Trigger CI

* p2w-client/main.rs: correct missing awaits after merge
2022-07-18 14:40:03 +02:00
Ali Behjati e76181ace6
Add pyth-evm-watcher to tilt (#238) 2022-07-15 17:37:58 +02:00
Ali Behjati 1f785d5a7f
Add watcher base files and structures (#237)
* Add watcher base files and structures

* Add missed files!

* Update package.json info

* Update PythUpdateEvent

* Restructure the code

* Fix division
2022-07-15 14:37:48 +02:00
Stanisław Drozd 9dbfbd4174
[WIP] p2w-client: Implement a migrate command and instruction generator (#232)
* p2w-client: Implement a migrate command and instruction generator

* Fix minor bug in gen_migrate_tx

* Fix migration test and add a test for success

Co-authored-by: Ali Behjati <bahjatia@gmail.com>
2022-07-13 15:57:16 +02:00
Stanisław Drozd 3d62f2b4f5
guardiand: Bump wormhole sources (#236)
Before this change, a fresh build from scratch would cause a guardian
software compilation error ("Failure: empty digest") that would
normally be hidden by caching in CI.
2022-07-13 13:39:38 +02:00
Tom Pointon 8f8eee7c92
Make Pyth contract abstract (#234) 2022-07-13 11:02:37 +01:00
Tom Pointon b062cd51fa
Remove unnecessary payable marker from wormhole address (#235) 2022-07-13 11:02:22 +01:00
Jonathan Claudius b7331ad10a
Add bug bounty and audits (#233) 2022-07-12 18:02:47 -04:00
Ali Behjati c69d372ea5
Update Deploying.md (#231) 2022-07-07 18:37:31 +02:00
Ali Behjati 6a46dfcb6e
Use single server for both ws and http (#230)
* Use single server for both ws and http

* Format code
2022-06-30 12:51:06 +02:00
Stanisław Drozd da1f19bf0b
ethereum: Add support for multiple emitter/chain ID pairs (#228)
* ethereum: Add support for multiple emitter/chain ID pairs

* ethereum: Simplify data source methods, add tests, fix flag bug

* ethereum: Fix incorrect removeDataSource condition, harden its test

* ethereum: Add the multi-source migration to prod-receiver

* PythState.sol: rephrase comment about new data source API

* ethereum/test/pyth.js: run prettier formatting

* ethereum: replace multi-source migration with addDataSource call

* ethereum: mark older chain/emitter ID state as deprecated
2022-06-29 15:10:53 +02:00
Ali Behjati 21dfc32e43
Abehjati/pyth-evm-contract-fire-event (#229)
* Use new solidity sdk

* Emit events in contract

* Fix max gas issue that caused error

* Add tests for PriceUpdate event

* Delete a test network file
2022-06-27 17:41:55 +02:00
Ali Behjati 4667c5fd12
Fix wrong branch names (#227)
* Fix wrong branch names

* add logging

* Add more log and test buildkit

* Remove loggings
2022-06-23 18:41:13 +02:00
Ali Behjati 4d5664a79f
Add image push ci for price service (#225)
* Add image push ci

* Update image-push.yml
2022-06-23 12:48:47 +02:00
Stanisław Drozd bbad8fb544
pyth2wormhole: Add an is_active flag to on-chain config (#224)
* pyth2wormhole: Add an is_active flag to on-chain config

This new flag will help enable/disable attester contracts between deployments

* p2w-client: typo

* p2w-client: add is_active to init

* pyth2wormhole config.rs: mention removing old structs, reword

* pyth2wormhole: remove unused config data struct from migrate()

* pyth2wormhole migrate(): leave a note about AccountState::Uninitialized

* Update solana/pyth2wormhole/program/src/migrate.rs

Co-authored-by: Reisen <Reisen@users.noreply.github.com>

* Update solana/pyth2wormhole/program/src/migrate.rs

Co-authored-by: Reisen <Reisen@users.noreply.github.com>

* Update solana/pyth2wormhole/program/src/migrate.rs

Co-authored-by: Reisen <Reisen@users.noreply.github.com>

* p2w program: missing deref typo

Co-authored-by: Reisen <Reisen@users.noreply.github.com>
2022-06-22 13:37:15 +02:00
Ali Behjati 1a12005fbf
Use attestationTime instead of seqnum (#226)
SeqNum is not suitable for multiple sources, attestationTime is good
but we should be careful of solana clock falling behind

Also use this time for freshness metric because it's more useful.
2022-06-22 13:31:54 +02:00