blockworks-foundation
/
solana-improvement-documents
mirror of https://github.com/blockworks-foundation/solana-improvement-documents.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: pre-linting CI errors (#42)

This commit is contained in:
Jacob Creech 2023-03-21 22:46:04 -05:00 committed by GitHub
parent 1f9a233350
commit 4762b28483
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
proposals/0007-access-policy.md
View File

@ -35,7 +35,8 @@ in accordance with Github access policies.
## Motivation ## Motivation
Shamelessly borrowing from [Mozilla's access Shamelessly borrowing from [Mozilla's access
policy](https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/): policy](https://www.mozilla.org/en-US/about/governance/policies/commit/access-policy/)
:
``` ```
There are two sorts of control which can be used to stop people checking in - There are two sorts of control which can be used to stop people checking in -

21
proposals/0022-multi-stake.md
View File

@ -18,7 +18,8 @@ for simpler stake movement through more activations, deactivations, or redelegat
## New Terminology ## New Terminology
* "multi stake": a stake account with multiple `Delegation` instances * "multi stake": a stake account with multiple `Delegation` instances
* "small stake": a stake whose delegation is less than current minimum stake delegation amount * "small stake": a stake whose delegation is less than current minimum stake
delegation amount
## Motivation ## Motivation
@ -69,9 +70,9 @@ Unfortunately, small stakes can still bloat the stakes cache from a memory level
* Don't include small stakes in the cache, but track them in transactions * Don't include small stakes in the cache, but track them in transactions
In this solution, on every transaction that manipulates a small stake delegation, it In this solution, on every transaction that manipulates a small stake
includes its delegation amount in the validator's voting power, but doesn't delegation, it includes its delegation amount in the validator's voting power,
add its pubkey and `Delegation` to the cache. but doesn't add its pubkey and `Delegation` to the cache.
The runtime tracks the pre and post state of every account, and for a successful The runtime tracks the pre and post state of every account, and for a successful
transaction, subtracts the old small stake delegation amount, and adds the new small transaction, subtracts the old small stake delegation amount, and adds the new small
@ -81,9 +82,9 @@ During rewards payout, small stakes are completely omitted, since they are not
present in the cache. present in the cache.
This is incredibly brittle, however, and introduces more overhead in the runtime. This is incredibly brittle, however, and introduces more overhead in the runtime.
The bank must hold onto pre-states for all transactions to debit the stakes cache. And, The bank must hold onto pre-states for all transactions to debit the stakes
if called from the outside, all `store_accounts` functions on the bank could easily cache. And, if called from the outside, all `store_accounts` functions on the
invalidate the stakes cache. bank could easily invalidate the stakes cache.
For example, if you store a small stake directly, what does the cache do? What For example, if you store a small stake directly, what does the cache do? What
was the pre-state of that small stake? There's no way to know. was the pre-state of that small stake? There's no way to know.
@ -152,7 +153,8 @@ that try to deserialize any stake account.
The network benefits as a whole: The network benefits as a whole:
* stake accounts are more flexible for adding or removing stake, without splits and merges * stake accounts are more flexible for adding or removing stake, without splits
and merges
* stakers can easily redelegate without missing out on rewards * stakers can easily redelegate without missing out on rewards
## Security Considerations ## Security Considerations
@ -181,4 +183,5 @@ For small stake deposit, you simply transfer the lamports and activate the new a
If a user wishes to withdraw, the program first withdraws from the activating amount. If a user wishes to withdraw, the program first withdraws from the activating amount.
If there is no more activating amount available, then the pool deactivates from If there is no more activating amount available, then the pool deactivates from
the main delegation and provides a ticket to the user, used to claim their lamports after deactivation. the main delegation and provides a ticket to the user, used to claim their lamports
after deactivation.