db23295e1c
removes legacy weighted_shuffle and weighted_best methods ( #24125 )
...
Older weighted_shuffle is based on a heuristic which results in biased
samples as shown in:
https://github.com/solana-labs/solana/pull/18343
and can be replaced with WeightedShuffle.
Also, as described in:
https://github.com/solana-labs/solana/pull/13919
weighted_best can be replaced with rand::distributions::WeightedIndex,
or WeightdShuffle::first.
2022-04-05 19:19:22 +00:00
4ea59d8cb4
Set drop callback on first root bank ( #23999 )
2022-04-05 13:02:33 -05:00
2282571493
removes outdated and flaky test_skip_repair from retransmit-stage ( #24121 )
...
test_skip_repair in retransmit-stage is no longer relevant because
following: https://github.com/solana-labs/solana/pull/19233
repair packets are filtered out earlier in window-service and so
retransmit stage does not know if a shred is repaired or not.
Also, following turbine peer shuffle changes:
https://github.com/solana-labs/solana/pull/24080
the test has become flaky since it does not take into account how peers
are shuffled for each shred.
2022-04-05 16:02:53 +00:00
eb65ffb779
Optimize replay waking up ( #24051 )
...
* timeout for validator exits
* clippy
* print backtrace when panic
* add backtrace package
* increase time out to 30s
* debug logging
* make rpc complete service non blocking
* reduce log level
* remove logging
* recv_timeout
* remove backtrace
* remove sleep
* wip
* remove unused variable
* add comments
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* whitespace
* more whitespace
* fix build
* clean up import
* add mutex for signal senders in blockstore
* remove mut
* refactor: extract add signal functions
* make blockstore signal private
* increase replay wake up channel bounds
* reduce replay wakeup signal bound to 1
* reduce log level
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
2022-04-05 08:57:12 -05:00
4a11fa072f
hash_account_with_rent_epoch ( #24104 )
2022-04-05 08:10:31 -05:00
ba92ba0e06
Zk instructions check length ( #24103 )
...
* zk-token-sdk: add a length check before decoding proof instruction
* zk-token-sdk: fix minor spelling
* zk-token-sdk: one-liner for length check
* zk-token-sdk: one-liner fix
2022-04-05 08:40:45 -04:00
2b718d00b0
removes legacy compatibility turbine peers shuffle code
2022-04-05 12:04:12 +00:00
d0b850cdd9
removes turbine peers shuffle patch feature
2022-04-05 12:04:12 +00:00
855801cc95
removes deterministic-shred-seed feature
2022-04-05 12:04:12 +00:00
e051c7c162
Removes KeyedAccount from tests in stake instruction. (Part 3) ( #24110 )
...
* Moves test from stake state to stake instruction.
* Migrates test_split_source_uninitialized.
* Migrates test_split_split_not_uninitialized.
* Migrates test_split_more_than_staked.
* Migrates test_split_with_rent.
* Migrates test_split_to_account_with_rent_exempt_reserve.
* Migrates test_split_from_larger_sized_account.
* Migrates test_split_from_smaller_sized_account.
* Migrates test_split_100_percent_of_source.
* Migrates test_split_100_percent_of_source_to_account_with_lamports.
* Migrates test_split_rent_exemptness.
2022-04-05 12:36:01 +02:00
6fb99891f2
stopped "autolock_bot_PR.yml" action file.
2022-04-05 11:41:23 +05:30
41f2fd7fca
Implement get_account_with_config ( #23997 ). ( #24095 )
2022-04-04 22:58:58 +00:00
ee6bb0d5d3
track fec set turbine stats ( #23989 )
2022-04-04 14:44:21 -07:00
6a7f6585ce
persist historical_roots ( #24029 )
2022-04-04 13:13:11 -05:00
132f08486a
remove basically duplicate function ( #24107 )
2022-04-04 12:55:05 -05:00
997db7637c
do simple math without floats
2022-04-04 12:32:00 -05:00
6ba4e870c4
Blockstore should drop signals before validator exit ( #24025 )
...
* timeout for validator exits
* clippy
* print backtrace when panic
* add backtrace package
* increase time out to 30s
* debug logging
* make rpc complete service non blocking
* reduce log level
* remove logging
* recv_timeout
* remove backtrace
* remove sleep
* wip
* remove unused variable
* add comments
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* whitespace
* more whitespace
* fix build
* clean up import
* add mutex for signal senders in blockstore
* remove mut
* refactor: extract add signal functions
* make blockstore signal private
* let compiler infer mutex type
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
2022-04-04 11:38:05 -05:00
f8f3edac3c
update comment ( #24108 )
2022-04-04 11:06:01 -05:00
2820b64eb3
roots_original -> historical_roots ( #24063 )
2022-04-04 09:12:12 -05:00
ef3e3dce7a
hides implementation details of vote-accounts from public interface ( #24087 )
2022-04-04 13:20:26 +00:00
04158ee455
fix: stop logging to console when send tx fails ( #23511 )
...
There is no need to log the error to the console. Developers can simply catch the error and handle it themselves without it cluttering production logs.
2022-04-04 19:11:20 +08:00
4c058b48b6
Explorer: remove link from discord security contact ( #24097 )
2022-04-04 18:12:53 +08:00
2fff8bbcc8
stopped autolock_bot_closed_issues.yml
2022-04-04 10:04:49 +05:30
b14b8b1efa
Un-deprecate `MINIMUM_STAKE_DELEGATION` ( #24089 )
2022-04-03 15:09:41 -05:00
7cb3b6cbe2
demotes WeightedShuffle failures to error metrics ( #24079 )
...
Since call-sites are calling unwrap anyways, panicking seems too punitive
for our use cases.
2022-04-03 16:20:06 +00:00
fa7eb7f30c
improves Stakes::activate_epoch performance ( #24068 )
...
Tested with mainnet stakes obtained from the ledger at 5 recent epoch
boundaries, this code is ~30% faster than current master.
Current code:
epoch: 289, elapsed: 82901us
epoch: 290, elapsed: 80525us
epoch: 291, elapsed: 79122us
epoch: 292, elapsed: 79961us
epoch: 293, elapsed: 78965us
This commit:
epoch: 289, elapsed: 61710us
epoch: 290, elapsed: 55721us
epoch: 291, elapsed: 55886us
epoch: 292, elapsed: 55399us
epoch: 293, elapsed: 56803us
2022-04-02 22:48:51 +00:00
0ca5a0ec68
prior_roots -> historical_roots ( #24064 )
2022-04-02 12:01:43 -05:00
ec97d6d078
rename remove_old_roots ( #24059 )
2022-04-02 12:01:13 -05:00
3ca4fffa78
root -> alive_root ( #24062 )
2022-04-02 12:00:52 -05:00
ffa4cafe1c
Revert sequential execution of validator_exit and validator_parallel_exit tests ( #24048 )
...
* handle channel disconnect
* revert sequential execution of validator_exit and parallel_validator_exit tests
2022-04-02 10:22:47 -05:00
4968e7d38c
Fix typo in documentation ( #24076 )
2022-04-02 08:09:41 -05:00
2c6a3280e4
Include PR lables section and add "feature-gate" in CONTRIBUTING.md ( #24056 )
...
Added "PR / Issue Labels" section to CONTRIBUTING.md listing commonly used labels
and when to use them.
2022-04-01 22:30:37 -07:00
2af6753808
Add GetMinimumDelegation stake program instruction ( #24020 )
2022-04-02 05:11:10 +00:00
792bbf75ab
Support sending versioned txs in AsyncClient ( #23982 )
2022-04-02 11:12:02 +08:00
694292f7fa
add candy machine v2 to known program names ( #24072 )
...
Co-authored-by: Noah Gundotra <noahgundotra@noahs-mbp.mynetworksettings.com>
2022-04-02 02:28:19 +00:00
f1f8f5458d
Threads for discrete log ( #23867 )
...
* zk-token-sdk: add multi-thread for discrete log
* zk-token-sdk: some clean-up
* zk-token-sdk: change default discrete log thread to 1
* zk-token-sdk: allow discrete log thread nums to be chosen as param
* zk-token-sdk: join discrete log threads
* zk-token-sdk: join thread handles before returning
* zk-token-sdk: Apply suggestions from code review
Co-authored-by: Michael Vines <mvines@gmail.com>
* zk-token-sdk: update tests to use num_threads
* zk-token-sdk: simplify discrete log by removing mpsc and just using join
* zk-token-sdk: minor
Co-authored-by: Michael Vines <mvines@gmail.com>
2022-04-01 20:01:24 -04:00
8a18c48e47
Removes `KeyedAccount` from tests in stake instruction. (Part 2) ( #24053 )
...
* Migrates test_initialize_minimum_stake_delegation.
* Migrates test_delegate_minimum_stake_delegation.
* Migrates test_split_minimum_stake_delegation.
* Migrates test_split_full_amount_minimum_stake_delegation.
* Migrates test_split_destination_minimum_stake_delegation.
* Migrates test_withdraw_minimum_stake_delegation.
* Migrates test_behavior_withdrawal_then_redelegate_with_less_than_minimum_stake_delegation.
2022-04-02 01:08:55 +02:00
0b7d0476c8
fix a typo ( #24070 )
2022-04-01 15:16:51 -07:00
0b5ed87220
(LedgerStore) Enable performance sampling in column family get() ( #23834 )
...
#### Summary of Changes
This PR enables RocksDB read side performance metrics to report to blockstore_rocksdb_read_perf.
The sampling rate is controlled by an env arg `SOLANA_METRICS_ROCKSDB_PERF_SAMPLES_IN_1K`,
specifies the number of perf samples for every 1000 operations. The default value is set to 10, meaning
we will report 10 out of 1000 (or 1/100) reads.
The metrics are based on the RocksDB [PerfContext](https://github.com/facebook/rocksdb/blob/main/include/rocksdb/perf_context.h ).
It includes many useful metrics including block read time, cache hit rate, and time spent on decompressing the block.
2022-04-01 13:13:32 -07:00
c9a476e24d
handle channel disconnect ( #24036 )
2022-04-01 13:47:06 -05:00
df4d92f9cf
Revert voting service to use UDP instead of QUIC ( #24032 )
2022-04-01 09:34:18 -07:00
97170a5d38
Bump bytemuck version in solana-program for consistency ( #24043 )
2022-04-01 22:25:53 +08:00
1b45c509c3
Refactor: Use `InstructionContext::get_instruction_data()` ( #24014 )
...
* Adds transaction_context and instruction_context where invoke_context.get_keyed_accounts() is used.
* Use instruction_context.get_instruction_data() instead of an explicit parameter.
* Removes instruction_data parameter from Executor::execute().
* Removes instruction_data parameter from ProcessInstructionWithContext.
2022-04-01 15:48:05 +02:00
cf59c000d9
Add issue template for feature gate tracking issues ( #24040 )
...
* Add issue template for feature gate tracking issues
* review feedback
2022-04-01 21:16:56 +08:00
436048ca2b
explorer: Add Chainlink programs to known addresses ( #24037 )
2022-04-01 07:54:54 +00:00
0188e2601b
Add feature gate prompt and backport label automation ( #24023 )
2022-04-01 14:41:55 +08:00
51b37f0184
Modify rpc_completed_slot_service to be non-blocking ( #24007 )
...
* timeout for validator exits
* clippy
* print backtrace when panic
* add backtrace package
* increase time out to 30s
* debug logging
* make rpc complete service non blocking
* reduce log level
* remove logging
* recv_timeout
* remove backtrace
* remove sleep
* remove unused variable
* add comments
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* Update core/src/validator.rs
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
* whitespace
* more whitespace
* fix build
Co-authored-by: Trent Nelson <trent.a.b.nelson@gmail.com>
2022-03-31 16:44:23 -05:00
8b72200afb
Thin client quic ( #23973 )
...
Change thin-client to use connection-cache
2022-03-31 15:47:00 -04:00
31997f8251
hash calc scanning takes config ( #24016 )
2022-03-31 14:26:37 -05:00
98525ddea9
Make tpu_use_quic a flag only without argument ( #24018 )
2022-03-31 10:04:24 -07:00
behzad nouri
carllin
HaoranYi
Jeff Washington (jwash)
samkim-crypto
Alexander Meißner
axleiro
hana
Jeff Biseda
Tao Zhu
Bryon M
Nico Gründel
Brooks Prumo
blake
Yueh-Hsuan Chiang
Justin Starry
Noah Gundotra
Pankaj Garg
Blaž Hrastnik
ryleung-solana
Lijun Wang