Federico Kunze
4420fe2d52
ibc: remove root from verification funcs ( #7780 )
...
* ibc: remove root from verification funcs
* fix VerifyClientConsensusState
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 17:16:22 +00:00
Aditya
e9801edb99
Async Ack Fixes ( #7735 )
...
* Add function to query ack proofs
* fix bugs
* fix swagger
* fix final queries
* docs and add test case
* Rename QueryUnrelayedAcks to more accurate QueryUnreceivedAcks
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
* address rest of reviews
* consistent spelling
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-11-02 15:13:48 +00:00
yihuang
aff88bbe99
Fix #7640 : tally calculation precision error ( #7641 )
...
Solution:
- change `(a / b) * c` to `a * b / c`
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-11-02 14:50:33 +00:00
Aditya
88e4acac6b
Don't claim channel capability on crossing hellos ( #7763 )
...
* don't claim capability on crossing hellos
* clarify comment
2020-11-02 14:32:32 +00:00
Amaury Martiny
194d2aa196
Fix fetch txs by height on legacy REST endpoint ( #7730 )
...
* Add test
* Fix potential flakiness in sequence
* Remove test with ?height
* Fix test
* Fix tests
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Zaki Manian <zaki@manian.org>
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
2020-11-02 11:52:52 +00:00
Alessio Treglia
cdc73ac605
cosmovisor: docs first draft ( #7608 )
...
Closes : #7118
2020-10-31 12:02:16 +00:00
Marie Gauthier
bd6c16b462
Handle ServiceMsg in StdTxBuilder.SetMsgs ( #7731 )
...
* Handle ServiceMsg in StdTxBuilder.SetMsgs
* Add test
2020-10-30 15:27:12 +00:00
Amaury Martiny
1961935fc7
Add GetTx gRPC endpoint ( #7688 )
...
* Add empty TxByHash
* Fix search & replace
* Renname to GetTx
* Make getTx grpc work
* Hash as string
* Add todo comment
* /tx
* Make tests pass
* Put into function
* Add changelog
* Fix lint
* RegisterTxService in server
* Remove comment
* Update proto/cosmos/tx/v1beta1/service.proto
Co-authored-by: Cory <cjlevinson@gmail.com>
* Create new protoCdc
* Move tx service to x/auth
* Small tweaks
* Link gh issue
* Fix lint
* Update x/auth/tx/service.go
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Cory <cjlevinson@gmail.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: SaReN <sahithnarahari@gmail.com>
2020-10-30 12:32:02 +00:00
Jack Zampolin
b2bc32f3c9
Add function to query ack proofs ( #7732 )
...
* Add function to query ack proofs
* Fix compilation issue
Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 22:19:01 +00:00
Robert Zaremba
e0e16f62f9
Remove duplicated Module.Route calls ( #7716 )
...
* Remove duplicated Module.Route calls
* make a proper test for registering empty route
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 22:01:09 +00:00
Amaury Martiny
9087ffc774
Throw an error on duplicate registration ( #7729 )
...
* Panic on registering a service twice
* Panic if we register twice
* Fix test
* Fix test
* Add clearer panic message
* Add comment
* Fix test
2020-10-29 15:32:47 +00:00
colin axnér
1a15713289
remove proof path from IBC queries ( #7725 )
...
* remove proof path
* make proto-all with old install
* fix build
2020-10-29 12:42:12 +00:00
Aditya
b7b925a1ac
Sort validators like tendermint in HistoricalInfo ( #7691 )
...
* sort validators like tendermint
* address comments
* switch ordering in tests
* change sort logic in error case
* don't change test validators array order
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 12:17:37 +00:00
Cory
536eb689dc
Add Deprecation headers for legacy rest endpoints ( #7686 )
...
* add deprecation headers for legacy rest endpoints
* add deprecation headers for missing tx routes
* rm handler-level deprecation headers
* switch to middleware Route.Use method for setting deprecation Headers
* set deprecation headers using subrouter
* cleanup gofmt
* goimports
* Update client/rest/rest.go
* update deprecation headers to be set on each module individually
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-29 11:37:46 +00:00
Amaury Martiny
82f15f306e
RegisterInterfaces registers service Msg type_urls ( #7671 )
...
* Add RegisterMsgServiceDesc
* Refactor newSendTxMsgServiceCmd
* Add test
* Register in all modules
* Remove RegisterMsgServiceDesc from baseapp
* Add explicit error message
* Add comment
* Update comment
* Add test
* Update comment
* Remove duplicate import
* Fix lint
* Forgot vesting
* Fix lint
* Fix test
* Put in types/module
* Put in types/msgservice
* Add comment about panic
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Update baseapp/msg_service_router.go
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Add comment
* Add better test
* Update baseapp/msg_service_router.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 19:20:45 +00:00
Federico Kunze
1b0d6540d8
ibc: internal audit part 1 ( #7704 )
...
* ibc: internal audit part 1
* Update x/ibc/core/02-client/keeper/client.go
* gofmt
* fix tests
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
2020-10-28 15:57:48 +00:00
dependabot[bot]
d83fc46b97
build(deps): bump codecov/codecov-action from v1.0.13 to v1.0.14 ( #7698 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-10-28 14:39:23 +01:00
colin axnér
dca9dcd276
Fix panic in context when setting nodeURI ( #7699 )
...
* Fix panic in context
Move URI parsing outside of context. WithNodeURI will only set the nodeURI. To set the Client in the context, WithClient must be called.
* add changelog
* add deleted space back
2020-10-28 13:31:22 +00:00
Amaury Martiny
a15bb7562e
docs: Basic/App-anatomy explains Msg Service by default ( #7670 )
...
* Add msg service
* Add handlers
* Small tweaks
* Remove todo
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 11:47:22 +00:00
Anil Kumar Kammari
51ac6f876b
Rename RegisterGRPCRoutes ( #7696 )
...
* Rename
* Fix missing
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 11:39:49 +00:00
Akhil Kumar P
c3638adddc
init: Implement ADR 032 typed events ( #7564 )
...
* Add EmitTypedEvent in events
* Add parseTypedEvent method
* Use jsonpb
* Modify unmarshal proto in events
* Add a test for typed events
* Fix reflect issue in parseTypedEvent
* Modify event tests and add comments
* Add EmitTypedEvents and refactor other methods
* Fix golangci-lint issues
* Update ProtoMarshalJSON params
* Address PR comments
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Jack Zampolin <jack.zampolin@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 11:02:39 +00:00
yihuang
afb6771726
fix inconsistent flag names in upgrade proposal command ( #7697 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 10:41:55 +00:00
Robert Zaremba
bd9af94174
Use embedded lib key type in sdk pub keys instead of bytes. ( #7672 )
...
* Remove duplicate print message on keys add command (#7654 )
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* ed25519: use stdlib/crypto types
* use standard package testing
* use crypto/ed25519 instead of golang.org/x/crypto/ed25519
In Go 1.13 the new crypto/ed25519 package implements the Ed25519 signature scheme.
This functionality was previously provided by the golang.org/x/crypto/ed25519 package,
which becomes a wrapper for crypto/ed25519 when used with Go 1.13+.
* use standard package testing for secp256k1 tests
* secp256k1: add cross packages signature checks
* ed25519: rollback the _test package name
* rename underlyingSecp256k1 to btcSecp256k1
* package update
Co-authored-by: Denis Fadeev <denis@fadeev.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 10:24:41 +00:00
Federico Kunze
426d195387
ibc: Connection Version changed from string to proto definition ( #7644 )
...
* ibc: Version to proto Any
* change version string to struct
* various version fixes
* fix build
* reorder code
* update spec
* rename to ProtoVersionsToExported and ExportedVersionsToProto
Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-28 09:41:54 +00:00
Marko
7792ccf342
docker fix ( #7692 )
2020-10-27 17:13:17 +00:00
Marko
db09e51613
ci: upload coverage once ( #7690 )
2020-10-27 16:46:57 +01:00
colin axnér
e306a852ff
update core IBC docs ( #7560 )
...
* update state
* add empty concept fields, update callbacks and messages
* update client creation, update and upgrade section
* add packet lifecycle concepts
* add host and proof section
* add connection handshake section
* add channel handshakes
* state transitions
* self review fixes
* Apply suggestions from code review
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* apply @fedekunze review suggestions
* packet data section
* Apply suggestions from code review
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
* add @cwgoes and @fedekunze review suggestions
* fix typos
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:51:47 +00:00
colin axnér
3d46c672f6
Fix Optimistic Channel Handshake bugs ( #7678 )
...
* fix optimistic handshake bugs and add crossing hello test
* fix tests
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:34:25 +00:00
Federico Kunze
7ccd2675d7
ibc: refactor proto files ( #7689 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 14:14:07 +00:00
Jack Zampolin
9befc6ced8
Wrap ProtoCodec in interface ( #7637 )
...
* WIP encoding change
* Add test that describes issue
* WIP debugging
* remove extra code
* Update codec/proto_codec.go
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
2020-10-27 13:53:54 +00:00
Aditya
48c72230f0
Create separate Write-Ack Event ( #7683 )
...
* use separate type for write ack
* change event-type
Co-authored-by: Christopher Goes <cwgoes@pluranimity.org>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 11:48:28 +00:00
Robert Zaremba
9bd42ace6b
simapp: rename MakeEncodingConfig to MakeTestEncodingConfig ( #7681 )
...
* simapp: rename MakeEncodingConfig to MakeTestEncodingConfig
* Updating the Changelog
+ Adding DEPRECATED attribute.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-27 11:33:48 +00:00
Akhil Kumar P
8014fc688e
Fix clang-format to specific version ( #7350 )
...
* Update clang-format install script
* Address PR comments
* Update clang-format install command
* Format makefile
* Use docker for formatting proto
* Comment out delimiter config
* Update contributing.md and .clang-format
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-10-27 10:04:34 +00:00
Marko
6688382f2e
ci: add pushing of tags and master ( #7617 )
2020-10-27 11:00:01 +01:00
Alessio Treglia
bd3a29bdc1
fix check-test-* targets ( #7675 )
...
Closes : #7673
2020-10-26 15:08:13 +00:00
dependabot[bot]
fc46423fcc
build(deps): bump gaurav-nelson/github-action-markdown-link-check ( #7612 )
...
Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check ) from 1.0.7 to 1.0.8.
- [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases )
- [Commits](https://github.com/gaurav-nelson/github-action-markdown-link-check/compare/1.0.7...e3c371c731b2f494f856dc5de7f61cea4d519907 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-10-26 07:44:22 -03:00
Denis Fadeev
d48d000195
Remove duplicate print message on keys add command ( #7654 )
...
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-24 05:17:07 +00:00
Aaron Craelius
93ec7bb785
Return an unsigned tx in legacy GET /tx endpoint when signature conversion fails ( #7649 )
...
* Return an unsigned tx in legacy GET /tx endpoint when signature conversion fails
* Add test
* add comment
* add comment
* add comment
2020-10-23 19:20:02 +00:00
colin axnér
e4378e747d
IBC: panic on GetSignBytes and remove SubModuleCdc ( #7645 )
...
* panic on GetSignBytes and remove SubModuleCdc where possible
* fix build
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-10-23 17:14:12 +00:00
colin axnér
c6cbe3a3db
Fix IBC Query cmds ( #7648 )
...
* fix query
* update comment
2020-10-23 16:31:32 +00:00
Aaron Craelius
73e7dad713
Use InterfaceRegistry as AnyResolver for grpc-gateway ( #7646 )
2020-10-23 13:49:18 +00:00
Robert Zaremba
6bc8ff2dfe
Use any as validator pubkey ( #7597 )
...
* protobuf pubkey type update
* wip2
* wip3
* solving types.NewValidator issues
* remove bech32 from validator type assignment
* update Validator interface
* Changelog update
* wip4
* update genutil
* fix simapp & x/ibc/testing tests
* update staking
* changelog update
* fix import cycle in tests
* fix amino panic on TestValidatorMarshalUnmarshalJSON
* fix TestValidatorMarshalUnmarshalJSON consensus_pubkey check
* Add UnpackInterfaces to HistoricalInfo
* fix TestHistoricalInfo
* update todos
* fix: Expecting ed25519.PubKey to implement proto.Message
* fix linter issues
* Fix migrate test
* Update CHANGELOG.md
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* review comments
* cosmetic changes
* add UnpackInterfaces got GenesisRandomized test
* Validator.Equal reuses Validator.MinEqual
* fix test
* use Validator.Equal in tests
* Fix staking simulation TestRandomizedGenState
* Remove TODO
* use HistoricalInfo.Equal
* use proto.Equal
* rename Validator.GetConsPubKey to TmConsPubKey
* prefer require.Equal over reflect.DeepEqual
* SetHistoricalInfo using a pointer
* Fix TestQueryDelegation test
* Fix TestQueryValidators test
* Fix TestSimulateMsgUnjail test
* experiement with LegacyAmino instances
* Register codecs in all simapp tests
* Fix cli_test compilation problems
* fix typo sdk -> std
* fix typo
* fix TestPlanStringer
* Rename to MakeEncodingConfig
* Remove RegisterCodecsTests
* Use gRPC in GetCmdQueryValidators
* Empty status
* fix info log check
* linter fixes
* rename simapparams to simappparams
* Update simapp/test_helpers.go
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
* comments updates
* use valAddr1 instead of sdk.ValAddress(pk1.Address().Bytes())
Co-authored-by: Cory Levinson <cjlevinson@gmail.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
2020-10-23 12:07:52 +00:00
Robert Zaremba
5bebf2bd39
ADR: add a process proposal ( #7621 )
...
* ADR: add a process proposal
* wording update
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Update docs/architecture/PROCESS.md
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* Add more details to status section and update the template
* Update docs/architecture/PROCESS.md
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
* add a note about ADR pruning
* use sequence numbers
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-22 22:40:44 +00:00
Robert Zaremba
55d7d0c9d1
tests: add command to compile all test files ( #7364 )
...
* tests: add command to compile all test files
test-build-check will compile and use go cache mechanism to
check if ALL files compiles without running any test.
ref: 7362
* update comment
* makefile: remove update-swagger-docs
* Makefile: redoing the test check command
* Update Makefile
* Update Makefile
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-21 20:51:15 +00:00
Aaron Craelius
f24ad5d00a
ADR 028: Public Key Addresses ( #7086 )
...
* ADR 028: Public Key Addresses
* Cleanup
* Address review comments
* wording update.
* Being more precise about nested addresses in multisig
* Apply suggestions from code review
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
* Address review comments
* Address review comments
* Address review comments
* Describe sorting
* Add abstract
* Update status
* Revert to sha256
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Ethan Buchman <ethan@coinculture.info>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-10-21 16:03:18 +00:00
Amaury Martiny
48bfd73aba
Add background for sequence change in ADR-020 ( #7616 )
2020-10-21 14:47:31 +00:00
Callum Waters
c0122ad1b8
update readme to link starport instead of scaffold ( #7613 )
2020-10-21 08:08:20 +00:00
yys
1542ecb18d
Bugfix gov votes querier to use votes params ( #7589 )
...
* bugfix gov votes querier to use votes params
* move partially used statement to the proper block
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-20 17:35:44 +00:00
Robert Zaremba
24e156bf62
gitignore: adding Emacs .dir-locals.el ( #7610 )
2020-10-20 17:18:20 +00:00
Amaury Martiny
3c43370d0c
Add CommunitySpendProposals in migration ( #7607 )
...
* Add CommunitySpendProposals in migration
* Fix lint
* Avoid double registration
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-10-20 13:19:04 +00:00