## Description
Added missing changelog and updated a `p256Order` comment to remove misleading part.
---
### Author Checklist
*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*
I have...
- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed
### Reviewers Checklist
*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*
I have...
- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
* added low-s normalization to ecdsa secp256r1 signing
* go fmt fixes
* removed else block as golint required
* implement raw signature encoding for secp256r1
* move the creation of signature to after the check for sig string length
* fake commit to re-run checks? (move the creation of signature to after the check for sig string length)
* added a signature test for high s signature that requires sig validation to fail after the valid signature was mutated by extracting and scalar negating its s value
* reordered code to prevent mutated message from being used in sig verify
* added test for successful high_s signature with the ecdsa portion of the publicKey
* Remove comment for self-explanatory code.
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Missing quote
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* Apply minor suggestions from code review
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
* normalize comments for godoc
* refactored p256Order functions as private vars
* Div -> Rsh optimizing time for division
* resolve two code coverage issues; fix some small review issues
* test using private signatureRaw function instead of copying code. Added tests to improve code coverage
Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Robert Zaremba <robert@zaremba.ch>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.
Fixes#8459
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Robert Zaremba
John Kemp
technicallyty
Cuong Manh Le
Emmanuel T Odeke
Marie Gauthier
SaReN