e6a56226a8
context: remove verifier & trust node ( #6805 )
...
* remove verifier
* more removal of trustnode flag
* add todo
* fix lint
* remove file
* remove viper and add link to issue
* remve mention of trustnode
2020-07-23 06:44:18 +00:00
ab664e9a43
Merge PR #6815 : Code & Doc Cleanup
2020-07-22 11:02:36 -04:00
470465d792
x/auth: cli gRPC migration ( #6809 )
...
* migrated auth cli to use grpc query client
* unpacker added for account command
* fxed tests
2020-07-21 17:48:37 +00:00
61d69a978f
Merge PR #6806 : Docs & Cleanup
2020-07-21 11:28:43 -04:00
61d0c4adcd
proto: Consistent naming for Params ( #6803 )
...
* Use consistent "Params" in proto
* Update comments
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-21 14:04:51 +00:00
0ccc48d2a3
CLI/Tests: Remove Fixtures ( #6799 )
...
* remove fixtures
* setup tests
* update x/mint
* cli: update x/staking commands
* tests: convert x/staking CLI tests
* tests: fix x/auth CLI tests
* cli updates
* fix buiild
* fix build
* Update x/gov/client/cli/cli_test.go
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
* remove GenerateOrBroadcastTx
* move TestCLIQueryConn
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Amaury Martiny <amaury.martiny@protonmail.com>
2020-07-21 13:54:07 +00:00
cde3f46d52
Add validation to prevent empty store keys ( #6754 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 18:05:01 +02:00
79fa06b26c
remove IBC ante handler in favor of using handler ( #6793 )
...
* remove IBC ante handler, add calls to handler
* move some events upstream to handler
* remove change log entry
* move ante handler tests to handler
* fix build
* update docs
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 15:25:57 +00:00
8e61ef86c3
x/{gov,params,upgrade,distribution} CLI: In-Process test & use grpc query service ( #6664 )
...
* refactor CLI to use grpc query service
* In process CLI for gov
* ReadQueryCommandFlags
* gov tx
* Fix compiler errors
* Formatting
* x/distribution: use gRPC query
* Consistent
* Fix x/distrib test
* Update x/gov
* Add ReadQueryCommandFlags
* Fix lint
* Revert x/params
* x/params use grpc query
* Fix tests
* Use page request
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-20 13:09:57 +00:00
5c0e3b4de5
x/auth/ante: Migrate tests to use the new client.TxConfig ( #6661 )
...
* WIP: using encoding config
* Make it compile, test fails
* test should be okay
* Make tests pass
* Add comments
* Convert more tests
* Make TestAnteHandlerSigErrors work
* Make first 2 tests pass
* TestAnteHandlerAccountNumbers
* Use table tests
* Remove print
* Use test table
* TestAnteHandlerSigErrors
* TestAnteHandlerAccountNumbers
* TestAnteHandlerAccountNumbers
* Refactor TestAccount
* Refactor getSignBytes
* TestAnteHandlerAccountNumbersAtBlockHeightZero
* TestAnteHandlerSequences
* TestAnteHandlerFees
* TestAnteHandlerMultiSigner
* TestAnteHandlerBadSignBytes
* TestAnteHandlerSetPubKey
* TestAnteHandlerSigLimitExceeded
* TestCustomSignatureVerificationGasConsumer
* TestAnteHandlerReCheck
* Make all tests pass
* Refactor a little bit more
* Fee test
* SetupTest
* All tests pass
* Refactor to RunTestCase
* Don't use StdFee
* Revert some little stuff
* Finish up last couple of test cases
* Less verbose
* s/TxGenerator/TxConfig
* Add comments
* Indent
* Move KeyTestPubAddr to testdata
* Move testdata to /testutil
* Revert to use signature: nil step in signing
* Add comments
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-20 08:30:12 -04:00
5a5a402518
Merge PR #6775 : x/auth/simulation/genesis.go: add unit tests
2020-07-18 13:46:56 -04:00
f59ea26941
Merge PR #6774 : x/auth/simulation/params.go: add unit tests
2020-07-18 13:23:37 -04:00
e59781eca7
Merge PR #6765 : x/auth: Finish CLI Refactor
2020-07-17 16:20:45 -04:00
32de79d0aa
refactor auths broadcast cmd in alignment with #6216 ( #6713 )
...
* refactor auths broadcast cmd in alignment with #6216
* add TxResponse proto definition, and related refactoring
* re-run make proto-gen, updating staking.pb.go
* cleanup TxResponse tests to handle nil return values
* properly handle nil Tx value in TxResponse's implementation of UnpackInterfaces
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-17 17:17:21 +00:00
1d711f537c
x/auth/signing/direct: increase test coverage to 100% from 83.3% ( #6731 )
...
Ensure that all known routes for GetSignBytes are explored for
DirectHandler.
2020-07-16 03:48:36 -04:00
351192aa0b
x/auth: in-process test refactor ( #6573 )
...
* remove unused functions
* create helper func to send tx
* refactor to use test help to send tx by client
* Commit before getting backend.
* Temporal commit
* temp commit
* remove the creation of txbuilder from cli
* fix imports
* update changelog
* Remove unused function.
* Add flag home into tx sign command.
* migrade TestCLIValidateSignatures to use new test suite
* migrate test one
* Add changes to make sign batch.
* make test pass
* refactor common logic
* First part of cli sign.
* Add test for sign batch.
* refactor a little and improve the test
* migrate broadcast command
* fix linter
* Remove printf for debug in bank module.
* Fix unused err var.
* fix linter
* fix test
* fix tests client
* Fix linter.
* Temp commit signature.
* encode tx
* migrate tests
* Fix imports.
* Remove changelog
* fix tests
* Fix tests.
* Update x/bank/client/testutil/cli_helpers.go
* Remove alias.
* Remove wait for N block func.
* export callCmd function into its own file.
* fix imports
* bring back to inner functions
* apply mock io
* the helpers use mockio
* fix bug
* Add Helpers.
* return to put the function in testutil package
* return BufferWriter in ExecTestCLICmd
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-07-14 18:37:14 +00:00
e7554bb3b0
Fix Gas Flag Usage + CLI Flag APIs ( #6685 )
...
* Use new APIs
* fix usage
* fix usage of gas flag
* tests: TestParseGasSetting
2020-07-11 08:13:46 +00:00
d23c779b87
Fix godocs for NewTxBuilderFromFlags ( #6676 )
2020-07-10 11:55:17 +02:00
6ceedc9e4f
Remove TxBuilder references to viper. ( #6653 )
...
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-07-10 11:05:35 +02:00
255ed06eb4
testutil: add ApplyMockIODiscardOutErr, simplify existing functions ( #6665 )
2020-07-10 08:55:48 +02:00
a940214a49
testutil cleanup and reorg ( #6658 )
...
Prepare migrating testing auxiliary functions from tests
to testutil.
Remove local duplicates on testutil.WriteToNewTempFile().
Always favor testutil.NewTestCaseDir() over ioutil.TempDir().
Add test cases for the testing auxiliary functions.
2020-07-09 14:21:20 +02:00
4536ca22bb
x/auth: gRPC query service ( #6565 )
...
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Anil Kumar Kammari <anil@vitwit.com>
2020-07-08 13:12:38 +02:00
57ffe14631
Makefile: build simd with ledger support ( #6629 )
...
Makefile: parse COSMOS_BUILD_OPTIONS
Look for build options in the make's COSMOS_BUILD_OPTIONS
variable. This allows one to build simd with ledger support.
References:
* https://github.com/cosmos/gaia/pull/363
* https://github.com/tendermint/tendermint/pull/4738
fix tiny typo in nolint: statement that causes golangci-lint to
misbehave.
2020-07-07 19:10:11 +02:00
8670a10564
Merge PR #6595 : Single Binary & Command Refactor
2020-07-07 11:40:46 -04:00
3c76084bf5
Merge PR #6596 : Genutil remove global viper
2020-07-06 17:48:54 -04:00
2f44fbf2ab
Add support for protobuf TxGenerator and SIGN_MODE_DIRECT ( #6385 )
...
* Add TxWrapper, encoder, decoder and DirectModeHandler
* fix pkg name
* Update API and leave test TODO's
* Update TxWrapper API
* tests for tx wrapper (#6410 )
* WIP: added test for direct mode handler
* updated code
* Add msg
* Update TxWrapper API
* Fix pubkey declaration
* Add pubkey for tests
* Fix SetFee
* Remove logs
* Avoid global var declaration for tests
* Add test for GetPubKeys
* Fix direct signing tests
* Add more test cases for GetSignBytes
* Revert SetFee API
* Remove logs
* Refactor tests
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
* Refactoring
* Refactoring
* Integrate SignatureV2 API
* Fix wrapper tests
* Fix tests
* Linting and API tweaks
* Update API
* WIP on updating API
* Fix tests
* Update to new SigVerifiableTx
* Rename
* Update docs to reflect ADR 020
* proto-gen
* proto docs
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* cleanup
* Add tests
* Refactor and improving test coverage
* WIP on test coverage
* WIP on test coverage
* proto-gen
* Fix CompactBitArray.Size() bug
* Rename
* Remove Builder interface
* Address review comments
* Update x/auth/tx/sigs.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Update x/auth/tx/encoder.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* Address review feedback
* Fix build issues
* Resolve conflicts
* Fix ValidateBasic test coverage
* Add test for malicious multisig
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-07-06 17:03:45 +00:00
feb69770ef
Merge PR #6609 : x/auth: CLI Remove Viper
2020-07-06 10:23:32 -04:00
dacbcef54d
cl & deps++ ( #6582 )
...
* cl & deps++
* Use PersistentPreRunE
* revert x/bank/client/cli/tx.go
* move to root level
* Use block mode by default
* Skip x/auth CLI tests
2020-07-02 19:35:42 +00:00
a0f9cc7627
vesting: remove alias.go ( #6579 )
2020-07-02 15:08:44 +02:00
6a52c5a569
Remove DefaultParamspace and simplify simapp creation. ( #6564 )
...
* Remove DefaultParamspace and simplify simapp creation.
* Update changelog.
* Create function that inits ParamsKeeper.
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-07-01 13:57:29 +00:00
d5049413ef
Merge PR #6525 : x/bank: Refactor CLI & Tests
2020-06-30 16:59:21 -04:00
c0e48e1c43
Update ante handlers to use SignatureV2 ( #6428 )
...
* Update ante handlers to use SignatureV2
* WIP on test fixes
* WIP on test fixes
* Debugging CLI Tests
* CHANGELOG.md
* CHANGELOG
* Add missing tests for ante
* Add tests for verify signatures
* Update verify tests
* Fix register codec issue
* debug
* Cleanup
* Fix verify signature tests
* Remove viper
* remove keyring usage
* Fix review changes
* Fix simapp
* Fix ante tests
* Add reference issue
* Add test for multisignature
* Wrap sign error with sig
* Fix verify sign test
* Fix CHANGELOG.md
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
2020-06-29 20:48:41 +00:00
74eb56dd2a
Add test suite for client TxBuilder ( #6460 )
...
* Add tests
* Fix gofmt
* typecast tests
* Fix review comments
* typecast SigVerificableTx
* cleanup
* Refactor
* Linting and move encode/decode tests to suite
* Fix lint
* Move test suite
* godoc
* Refactor
* Refactor
Co-authored-by: Aaron Craelius <aaronc@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-29 14:05:30 +00:00
712d23740f
Migrate x/auth cmd's to TxGenerator marshaling ( #6391 )
...
* Migrate encode, decode, and broadcast cmd's to use TxGenerator marshal methods
* Fix tests, add EncodingConfig
* Add simapp/encoding.go and wire up with simcli
* add godocs
* fix tests
* Debugging CLI Tests
* Fix integration test
* 6391 - lint issues and code coverage (#6414 )
* fixed lint issue of "txEncodeRespStr"
* added tests for encode.go
* WIP: added tests for decode.go
* added txEncoder at bytes
* updated decode test
* updated txBytes to use TxEncoder in decoder test
* added a require after TxEncoder
* removed file save
* debug decode command
* fixed decode tests
* added decode cli
* updated encode and decode in a single file
* separated decode test from encode test
* review changes
* removed register interface
* review change
* Fix tests
* WIP add test for tx sign
* removed commented code
* Fix flags
* WIP add test for sign
* Address review suggestions
* fixed command issue
* Add tests for TxEncoder
* Revert sign changes
* Fix TxEncoder tests
* Fix GetSign Cmd
* Add tx test
* Remove duplicate validation
* Add tests for TxDecoder
* Fix tests
* Fix tests
* Output to clientCtx.Output
* Fix cli_tests
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: atheesh <atheesh@vitwit.com>
Co-authored-by: anilCSE <anil@vitwit.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-18 20:29:41 +00:00
5040ff87c4
Merge PR #6449 : Initial Metrics
2020-06-18 14:12:44 -04:00
4e73e0f817
Update proto files & definitions in accordance with ADR023 ( #6413 )
...
* consolidate proto files into single directory, turn on PACKAGE_DIRECTORY_MATCH linting
* add third_party root for third party proto files
* move ibc proto files to top level folder, rename .proto files to types.proto as before
* update protocgen script, and run code generation
* move vesting proto definition to cosmos namespace, rename from types.proto in alignment with buf.build naming conventions
* update Makefile so proto dependencies are set with new structure when updated
* add comment for sed usage in makefile
* remove unused aliases of proto generated types
* add settings.json instructions to contributing.md for including protobuf paths
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Aaron Craelius <aaron@regen.network>
2020-06-18 10:04:26 -07:00
32278d9a2b
x/auth: remove alias.go usage ( #6440 )
...
* x/auth: remove alias.go usage
* Fix simd_test.go and formatting
* Fix app.go formatting
* Fix cli_test.go
* Fix lint warnings
* Undo accidental deletion during merge
Co-authored-by: colin axner <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-17 14:42:27 -04:00
c13809062a
Update TxBuilder to use SignatureV2 ( #6443 )
...
* Update TxBuilder to use SignatureV2
* Fix unit tests
* Lint
* lint
* Cleanup
* Address review feedback
* Add Sign tests
* Add more cases for sign tests
* Fix lint
* Fix gofmt
* Deprecate StdTx
* Undeprecate StdTx, but leave a comment to use the protobuf Tx
* Address review comment
Co-authored-by: anilCSE <anil@vitwit.com>
2020-06-16 19:57:37 +00:00
35312d098e
JSON Codec Updates ( #6444 )
...
* Initial commit
* More updates
* Fix tests
* CLI test updates
* Updates
* Updates
2020-06-16 00:20:50 +00:00
24b9be0ef8
x/bank: remove alias.go usage ( #6439 )
...
* x/bank: remove alias.go usage
* Fix simd_test.go
2020-06-14 23:06:16 +00:00
60f7edfe3d
Add SignatureV2 infrastructure ( #6373 )
...
* Updte tx generator
* Add sigv2, PublicKeyCodec
* revert changes
* revert changes
* updates
* Updates
* Integrate multisig support
* Undo move
* remove func
* undo
* godocs
* godocs, cleanup
* Cleanup
* godocs, tests
* lint
* Re-enable VerifyBytes
* Address comments
* Fix imports
* Update crypto/types/multisig/multisignature.go
* Add test for MultiSignatureData
* Add nested multisig case
* Add test for AddSignatureV2
* Add changelog
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: sahith-narahari <sahithnarahari@gmail.com>
2020-06-12 18:13:20 +00:00
49597b19ec
module: pass route by value ( #6404 )
...
* use instance
* add some comments
* Update types/router.go
* rename Nil to Empty
* run make mocks
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
2020-06-11 15:37:23 +00:00
79c308ae4a
Concept PR simplify Module ( #6231 )
...
* add test of alternative impl
* simplify query route too
* change name querier
* simplify register routes
* revert change
* add route
* add router
* first step refactor
* refactor
* update documentation
* update
* add format
* simplify appmodule
* update changelog
* rename vars
* remove interface
* Update CHANGELOG.md
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-10 18:48:16 +00:00
08b7557fe5
Add basic sign mode infrastructure ( #6371 )
...
* Add SignModeHandler and LegacyAminoJSONHandler
* Simplify, add tests
* Add godocs
* Add handler map
* Rename HandlerMap
* Don't use pointer
* Lint
* Lint
* Update x/auth/signing/amino/amino.go
Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Marko <marbar3778@yahoo.com>
2020-06-09 15:19:18 +00:00
65ea305336
x/auth: add sign-batch command ( #6350 )
...
The command processes list of transactions from file
(one StdTx each line), generate signed transactions
or signatures and print their JSON encoding, delimited
by '\n'. As the signatures are generated, the command
increments the sequence number automatically.
Author: @jgimeno
Reviewed-by: @alessio
2020-06-08 17:19:29 +02:00
b618e0a827
add comments to why its nolint ( #6366 )
...
* add comments to why its nolint
* fix spelling
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-08 13:47:18 +00:00
71374d0eca
add contextual info to sigverify err msg ( #6355 )
...
* update sigverify error message
* whoops, use get sequence
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 08:05:30 +00:00
43947ca2ef
Add RegisterQueryService to AppModule ( #6336 )
...
* Add RegisterQueryService to AppModule
* Update CHANGELOG.md
* Update CHANGELOG.md
* Wire up BaseApp, fix tests
* Add mock test
* add missing file
* Update types/module/module.go
* Update CHANGELOG.md
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2020-06-06 07:59:57 +00:00
e248693ac8
x/auth/client: remove duplicate flags ( #6348 )
2020-06-05 16:14:22 +02:00
81d647e505
Move codec.RegisterCrypto and codec.Cdc to new packages ( #6330 )
...
* Move codec.Cdc to legacy_global.Cdc
* Update CHANGELOG.md
* Updates
* nit
* Fix imports
* Updates
* Use cosmos multisig instead of tendermint multisig everywhere
* Fix tests
* Rename legacy_global -> legacy
* Add doc.go
* Linting, move all RegisterCrypto calls to crypto/codec
* Update crypto/codec/amino.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-04 10:38:24 +00:00
Marko
Alexander Bezobchuk
atheeshp
Amaury Martiny
billy rennekamp
colin axner
dauTT
Cory
Emmanuel T Odeke
Jonathan Gimeno
Alessio Treglia
Akhil Kumar P
Aaron Craelius
Anil Kumar Kammari
dauTT