Anton Kaliaev
fa60d8120e
fix TestFullRound1 race (Refs #846 )
...
```
==================
WARNING: DATA RACE
Write at 0x00c42d7605f0 by goroutine 844:
github.com/tendermint/tendermint/consensus.(*ConsensusState).updateToState()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:465 +0x59e
I[11-14|22:37:28.781] Added to prevote vote="Vote{0:646753DCE124 1/02/1(Prevote) E9B19636DCDB {/CAD5FA805E8C.../}}" prevotes="VoteSet{H:1 R:2 T:1 +2/3:<nil> BA{2:X_} map[]}"
github.com/tendermint/tendermint/consensus.(*ConsensusState).finalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1229 +0x16a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryFinalizeCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1135 +0x721
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit.func1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1087 +0x153
github.com/tendermint/tendermint/consensus.(*ConsensusState).enterCommit()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1114 +0xa34
github.com/tendermint/tendermint/consensus.(*ConsensusState).addVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1423 +0xdd6
github.com/tendermint/tendermint/consensus.(*ConsensusState).tryAddVote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:1317 +0x77
github.com/tendermint/tendermint/consensus.(*ConsensusState).handleMsg()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:565 +0x7a9
github.com/tendermint/tendermint/consensus.(*ConsensusState).receiveRoutine()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:523 +0x6d2
Previous read at 0x00c42d7605f0 by goroutine 654:
github.com/tendermint/tendermint/consensus.validatePrevote()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:149 +0x57
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:256 +0x3c5
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 844 (running) created at:
github.com/tendermint/tendermint/consensus.(*ConsensusState).startRoutines()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state.go:258 +0x8c
github.com/tendermint/tendermint/consensus.startTestRound()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/common_test.go:118 +0x63
github.com/tendermint/tendermint/consensus.TestFullRound1()
/home/vagrant/go/src/github.com/tendermint/tendermint/consensus/state_test.go:247 +0x1fb
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
Goroutine 654 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:789 +0x568
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1004 +0xa7
testing.tRunner()
/usr/local/go/src/testing/testing.go:746 +0x16c
testing.runTests()
/usr/local/go/src/testing/testing.go:1002 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:921 +0x206
main.main()
github.com/tendermint/tendermint/consensus/_test/_testmain.go:106 +0x1d3
==================
```
2017-11-14 17:41:30 -06:00
Ethan Buchman
30f675aafa
Merge pull request #839 from tendermint/bugfix/pubsub-failures
...
Fix nondeterministic tests failures related to pubsub
2017-11-14 18:13:47 +00:00
Ethan Buchman
695266e907
Merge pull request #844 from tendermint/bunch-up-p2p.AddrBook-wg-calls
...
p2p: comment on the wg.Add before go saveRoutine()
2017-11-14 17:18:27 +00:00
Ethan Buchman
3db44dacae
Merge pull request #840 from tendermint/fix/tests
...
Fix/tests
2017-11-14 15:48:17 +00:00
Emmanuel Odeke
62c1bc0a20
p2p: comment on the wg.Add before go saveRoutine()
...
Just noticed while auditing the code in p2p/addrbook.go,
wg.Add(1) but no subsequent defer.
@jaekwon and I had a discussion offline and we agreed to
comment about why the code was that way and why
we shouldn't move the wg.Add(1) into .saveRoutine() because
if go a.saveRoutine() isn't started before anyone invokes
a.Wait(), then we'd have raced a.saveRoutine().
2017-11-13 18:14:58 -07:00
Ethan Buchman
238e2b72ee
Merge pull request #834 from tendermint/829-enable-logs-by-default
...
Enable logs by default
2017-11-12 07:06:14 +00:00
Ethan Buchman
a65ab3b0e0
Merge pull request #838 from tendermint/docker
...
docker update || 0.12.0
2017-11-12 06:51:01 +00:00
Ethan Buchman
aba8a8f4fc
consensus: crank timeout in timeoutWaitGroup
2017-11-12 06:41:15 +00:00
Ethan Buchman
0448c2b437
consensus: fix LastCommit log
2017-11-12 06:40:27 +00:00
Ethan Buchman
0ada0cf525
certifiers: test uses WaitForHeight
2017-11-12 00:43:16 +00:00
Anton Kaliaev
7fa12662c4
check whatever we can read from the channel
...
```
panic: interface conversion: interface {} is nil, not types.TMEventData
goroutine 7690 [running]:
github.com/tendermint/tendermint/consensus.waitForAndValidateBlock.func1(0xc427727620, 0x3)
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:292 +0x62b
created by github.com/tendermint/tendermint/consensus.timeoutWaitGroup
/go/src/github.com/tendermint/tendermint/consensus/reactor_test.go:349 +0xa4
exit status 2
FAIL github.com/tendermint/tendermint/consensus 38.614s
```
2017-11-10 18:16:31 -05:00
Anton Kaliaev
bc9c4e8dee
update readme [ci skip]
2017-11-10 15:38:32 -05:00
Anton Kaliaev
8004af2519
update docker readme
2017-11-10 15:17:13 -05:00
Anton Kaliaev
21e87ebc11
update Go version to 1.9.2
2017-11-10 15:10:52 -05:00
Anton Kaliaev
70d8afa6e9
update Dockerfile
2017-11-10 15:09:38 -05:00
Ethan Buchman
847f865438
Merge pull request #836 from tendermint/fix/tests
...
consensus: make mempool_test deterministic
2017-11-10 05:08:54 +00:00
Ethan Buchman
2cda777900
consensus: make mempool_test deterministic
2017-11-09 23:54:02 +00:00
Anton Kaliaev
432a7276e2
[test_integrations] enable logs from peers by default (Refs #829 )
2017-11-09 15:19:49 -05:00
Anton Kaliaev
533f7c45eb
fix bash linter warnings for atomic_broadcast integration test
2017-11-09 14:58:16 -05:00
Anton Kaliaev
a1cdc2b68a
set logger for peer's MConnection
2017-11-09 14:57:40 -05:00
Ethan Buchman
9c4d533695
Merge pull request #833 from tendermint/fix/consensus-tests
...
consensus: fix for initializing block parts during catchup
2017-11-09 19:04:21 +00:00
Anton Kaliaev
ad03491ee6
remove duplicated key
2017-11-09 13:37:29 -05:00
Ethan Buchman
4b9dfc8990
consensus: fix for initializing block parts during catchup
2017-11-09 18:14:41 +00:00
Ethan Buchman
a46f64cd1e
Merge pull request #824 from tendermint/bugfix/node_test
...
rewrite node test to use new pubsub
2017-11-09 01:35:35 +00:00
Anton Kaliaev
b1e7163689
rewrite node test to use new pubsub
2017-11-08 13:12:48 -05:00
Ethan Buchman
c931279960
p2p: some fixes re @odeke-em issues #813,#816,#817
2017-11-08 17:54:29 +00:00
Ethan Buchman
12b25fdf6e
blockchain: add comment in AddPeer. closes #666
2017-11-08 02:42:27 +00:00
Ethan Buchman
c0e2649ed6
Merge pull request #788 from tendermint/feature/548-indexing-tags
...
new pubsub package
2017-11-08 01:02:48 +00:00
Ethan Buchman
593c127257
rpc/lib/types: RPCResponse.Result is not a pointer
2017-11-08 01:00:15 +00:00
Ethan Buchman
9f6a09277e
Merge pull request #812 from tendermint/808-make-connected-switches
...
MakeConnectedSwitches: connect first switch to others
2017-11-08 00:54:23 +00:00
Ethan Buchman
dd47884661
Merge pull request #820 from tendermint/790-use-tickers-instead-of-time-Sleep
...
prefer tickers to time.Sleep
2017-11-08 00:53:42 +00:00
Anton Kaliaev
a01c226dc4
wsConnection: call onDisconnect
2017-11-07 19:22:01 -05:00
Ethan Buchman
47f5e37205
copy RoundState for event
2017-11-07 23:57:23 +00:00
Petabyte Storage
51c9211cf4
add test for MConnection TrySend and Send
2017-11-07 23:35:25 +00:00
Anton Kaliaev
7869e541f6
change MakeConnectedSwitches to not connect to itself
...
and a test for it
2017-11-07 18:33:00 -05:00
Anton Kaliaev
e0daca5693
fixes from Bucky's review
2017-11-07 18:20:24 -05:00
Ethan Buchman
e8e512f1fa
Merge pull request #815 from tendermint/p2p-readme-tests
...
P2P: readme and tests
2017-11-07 23:01:15 +00:00
Ethan Buchman
37ce171061
p2p/connetion: remove panics, test error cases
2017-11-07 23:00:52 +00:00
Ethan Buchman
e01986e2b3
p2p: update readme, some minor things
2017-11-07 23:00:49 +00:00
Ethan Buchman
433416fef8
Merge pull request #818 from tendermint/fix/810-stuck-trailing-node
...
consensus: ensure prs.ProposalBlockParts is initialized. fixes #810
2017-11-07 21:52:08 +00:00
Anton Kaliaev
2d4ad02356
prefer tickers to time.Sleep (Refs #790 )
2017-11-07 15:38:25 -05:00
Ethan Buchman
3b81d3fea4
consensus: ensure prs.ProposalBlockParts is initialized. fixes #810
2017-11-07 17:14:40 +00:00
Anton Kaliaev
e785697a64
connect first switch to others (Refs #808 )
2017-11-06 23:43:40 -05:00
Anton Kaliaev
4ffe9304ba
unsubscribe from all subscriptions on WS disconnect
2017-11-02 14:00:18 -05:00
Anton Kaliaev
b1eec3a5d3
remove test_data/empty_block and test_data/small_blockN
2017-11-02 13:20:14 -05:00
Anton Kaliaev
fcdd30b2d3
fixes from Bucky's review 2
2017-11-02 13:20:05 -05:00
Ethan Buchman
ec87c740a7
Merge pull request #794 from tendermint/243-restart-app-via-os
...
Kill Tendermint when App dies
2017-10-31 16:27:23 -04:00
Ethan Buchman
6b737d2c1b
Merge pull request #745 from tendermint/test-rpc-server-handlers
...
rpc/lib/server: add handlers tests for params inclusion
2017-10-31 15:42:24 -04:00
Ethan Buchman
f7f4ba5e90
rpc/lib/server: minor changes to test
2017-10-31 15:41:25 -04:00
Ethan Buchman
5466720d75
minor changes from @odeke-em PR #725
2017-10-31 15:32:07 -04:00