Caught by an upgraded golangci-lint with the gosec linter:
::medium file=node/pkg/watchers/evm/connectors/batch_poller.go,line=226,col=8::G601: Implicit memory aliasing in for loop. (gosec)
::medium file=node/pkg/watchers/evm/connectors/batch_poller.go,line=285,col=8::G601: Implicit memory aliasing in for loop. (gosec)
::medium file=node/pkg/watchers/evm/connectors/batch_poller_test.go,line=128,col=37::G601: Implicit memory aliasing in for loop. (gosec)
See also: https://husni.dev/beware-of-implicit-memory-aliasing-in-go-foor-loop/
* Upgrade golangci-lint to a version built with go 1.21.x. The older
version was a binary version built with go 1.20.x and it was failing
against the newer code built with go 1.21.x
* print the golangci-lint version in each run to see what version of go
it was built with in case there are incompatibilties during the next
upgrade
* remove the linter config skipping over pkg/supervisor entirely and
instead put in an override to ignore the `unused` linter for the
pkg/supervisor testhelpers bits for unsed test functions necessary
to satisfy the test interface.
* deployments: update for guardian set index v4
Wormholescan returns vaas base64 encoded, but guardianSetVAAs.csv
has them in hex format. This is the correct command to download a
guardian set upgrade vaa and convert it to hex in one go:
curl -sq 0000000000000000000000000000000004/18252082506122526004 | \
jq .vaaBytes -r | \
base64 -d | \
xxd -p | \
tr -d '\n'
echo
Refs: wormhole-foundation/wormhole-networks#53
* node: update admin template gsti to 4
Refs: wormhole-foundation/wormhole-networks#53
* eth: deploy with forge
* Delete unused scripts
* Support upgrade, bytecode verify and publish tool
* Add script to register all chains on a new chain
When behind a private network such as in the case of a guardian running
in Kubernetes, or behind a NAT, the default p2p setup doesn't work. It
looks at all addresses that it is listening on and advertises them on p2p
as the addresses for contacting the guardian. This patch is the first
step towards allowing specifying a custom ip address to be advertised on
the gossip p2p network.
For example, a guardian running inside kubernetes can post a reserved ip
address of the incoming ingress/load balancer that sends the traffic in
to their guardian.
* CI: Change chain id for evm devnet node
* Set env file to match devnet configured ethereum chain id
* set evm chain id to ganache default
* update test evm chain ids in evm tests
* Add cspell configuration and custom dictionary
The goal is to cut down on both incoming tyops, and well meaning but
spammy tyop fix PRs.
To run cspell locally install it and run:
cspell '**/*.md' \
--config cspell.config.yaml \
--words-only \
--unique \
--quiet | sort --ignore-case
* docs: cspell updates
* wormchain: cspell updates
* aptos: cspell updates
* node: cspell updates
* algorand: cspell updates
* whitepapers: cspell updates
* near: cspell updates
* solana: cspell updates
* terra: cspell updates
* cosmwasm: cspell updates
* ethereum: cspell updates
* clients: cspell updates
* cspell updates for DEVELOP document
* github: run cspell github action
* sdk: cspell updates
* github: only run cspell on markdown files
* algorand: EMMITTER --> EMITTER
Suggested-by: @evan-gray
* cspell: removed from dictionary
Suggested-by: @evan-gray
* aptos and node: cspell updates
Suggested-by: @evan-gray
* cosmowasm: doc updates for terra2
Suggested-by: @evan-gray
* algorand: cspell updates
Suggested-by: @evan-gray
* algorand: cspell updates
Suggested-by: @evan-gray
* cspell: updated custom word dictionary
This resorts the dictionary and adds a few new words from the
algorand/MEMORY.md document around varints and integers.
* cspell: sort the dictionary how vscode does it
On macOS the sorting is locale dependent. To do this on macOS, you have
to invert the case, do a character insensitive sort, and then invert the
case again:
LC_COLLATE="en_US.UTF-8" cspell '**/*.md' --config cspell.config.yaml \
--words-only \
--unique \
--no-progress \
--quiet \
| tr 'a-zA-Z' 'A-Za-z' \
| sort --ignore-case \
| tr 'a-zA-Z' 'A-Za-z'
This requires the `LC_COLLATE` variable to be set to `en_US.UTF-8`, or it
will not do the right thing.
* docs: grammar clean up
---------
Co-authored-by: Evan Gray <battledingo@gmail.com>
Jeff Schroeder
Ryan Hamphrey
bruce-riley
Csongor Kiss
Nikhil Suri
Dirk Brink
djb15
Csongor Kiss
Evan Gray
Martin Vejmelka
Ben Guidarelli
A5 Pickle
scnale