Add a test for digest calculation that uses a hardcoded digest. The
digest for this test was calculated using the `worm` CLI to ensure
interoperability.
Add the payload as an explicit field to the `TransferWithPayload` enum
variant. This is a generic parameter that defaults to `Box<RawMessage>`
for maximum flexibility (and to avoid leaking lifetimes higher up the
stack) but users are encouraged to replace this default type parameter
with an explicit `&RawMessage` in places where the serde_wormhole data
format is used.
The main benefit of this change is that the payload is now included as
part of the actual message and no longer requires callers to awkwardly
append it after serialization. This is especially useful in human-
readable formats like JSON (see the `transfer_with_payload` test in
token.rs for an example of this simplification).
The main downside is that this now requires explicit type annotations
when using the non-payload3 variants so that the compiler will pick up
the default generic parameter. This is a relatively minor inconvenience
and the benefit appears to be worth the cost.
There should be no functional change.
The RawMessage type provides a more flexible way to handle trailing
payloads so replace all usage of the `*_with_payload` functions to use
`RawMessage` instead.
There should be no functional change.
Add a RawMessage type that can be used to defer parsing parts of a
payload, similar to the `json.RawMessage` from Go. The implementation
is inspired by `serde_json::RawValue`, which does a similar thing.
When serializing, RawMessage will serialize to a base64-encoded string
if it detects that the data format is human readable (like JSON).
Otherwise it will simply forward the raw bytes to the serializer.
RawMessage has both borrowed and boxed versions. The borrowed version
is the most efficient as it enables zero-copy handling of the input data
but also requires that the input data already contains raw bytes and is
not suitable when dealing with human-readable formats like JSON.
The boxed version is more flexible as it supports byte slices, base64-
encoded strings, and byte sequences but is slightly less efficient as it
requires copying or decoding the input data.
This field doesn't actually appear in `GuardianSetUpgrade` governance
messages and was already being skipped by serde so just remove it
completely. Contracts that need to keep track of this information can
encapsulate the `GuardianSetInfo` inside another struct that has an
`expiration_time` field.
Ensure that converting `Chain` to/from a u16 or to/from a string is
always isomorphic. This requires changing the `FromStr` impl so that in
can handle strings like "Unknown(27)".
Add a test to ensure that calculating the digest from the structured
body, serialized data, or partial body + serialized payload all give the
same result.
Add the `Body::with_payload` method, which can be used to change the
type of the payload for a `Body`. This is useful when parsing the
payload needs to be deferred until after the body is parsed.
Use the `Signature` type from the core SDK to avoid unnecessary
type conversions. Cosmwasm requires its message types to implement
`JsonSchema` so also derive that impl for the `Signature` type behind a
feature flag.
This change uncovered a separate issue where the fake `WormholeKeeper`
was using regular ecdsa signatures rather than recoverable signatures
so fix the signing and verification methods to use the recoverable
signatures.
The `de::Unexpected` enum from serde has a `Float(f64)` variant.
Referencing this enum anywhere in the code will cause the compiler to
emit its `fmt::Display` impl, which includes an `f64.load` instruction
on wasm targets. Even if this instruction is never executed, its mere
existence will cause cosmos chains to reject any cosmwasm contract that
has it.
Fix this by removing all references to `de::Unexpected`.
Refactor the core crate to add serde-based struct definitions for the
various messages used by the different wormhole smart contracts. This
will also make it easier to use alternate data formats (like json) for
client-side tooling.
Co-authored-by: Reisen <reisen@morphism.org>
The serde_wormhole crate implements the wormhole wire format as a serde
data format. This will let us replace all the hand-rolled
serialization with auto-generated code, which is less error-prone and
easier to review.
* node: inject wormchain cosmwasm governance messages
* Use nested hash for defense in depth
* Use keccak.Reset() instead of creating new hash objects
* fix msg_server_wasmd_test
* Updated based on jynnantonix comments
* Check return value of binary.Write
* Include actual error in binary.Write panic case
* sdk/js: Added repairVaa & test
* fixed unnecessary comments
* Separated rpc call from base repairVaa function. removed console logs and added throws
* removed unncessary else statement
* removed unnecessary async
* Skipping rpc call test for current guardian set
* Clean up minor formatting
* Optimism mainnet deploy
* node: added OP token to manual_tokens
* Add to readiness
* File should not have been committed
* Remove readiness since it goes with watcher
* Allow optimism watcher in mainnet
* Add to devnet config
Co-authored-by: Christine Eun <ceun@jumptrading.com>
* go sdk - BatchVAA structs
* make VAA body unmarshaling DRY
* implement binary encoding interfaces for VAAs
* validate observation length before unmarshaling
* move shared VerifySignatures logic to new function
* make SigningMsg a delegate call
* normalize ID of vaa types
* add BatchVAA version to signingBody
* add Attestation interface with shared VAA methods
* add data integrity checks to batchVAA unmarshal
* sdk/js: aptos
* sdk/aptos: change api interface to be more flexible
sdk/aptos: add attestToken
sdk/aptos: added createdWrapped
sdk/aptos: add getForeignAsset
sdk/aptos: stricter sanity check for fully qualified type
sdk/aptos: ensure addresses are left padded
sdk/aptos: check if asset exists in getForeignAsset
sdk/aptos: stricter sanity check - hex prefix can't be capital
sdk/aptos: add updatewrapped
sdk/aptos: update readme with token attestation example
sdk/aptos: added transfer
sdk/aptos: add getIsTransferCompleted
sdk/aptos: add isWrappedAsset and getOriginalAsset
sdk/aptos: add redeem
sdk/aptos: make init tokenbridge entry func
* sdk/aptos: separated signing/submitting txs from creating raw txs
* clients/js: hash aptos fully qualified type to get address
* sdk/aptos: return payload from api instead of rawtx
* sdk/aptos: derive token info from vaa
* sdk/aptos: fix getAssetFullyQualifiedType for native asset
* sdk/aptos: add min gas price
* sdk/aptos: bump aptos version
* sdk/aptos: dont require 0x in front of addresses
* sdk/aptos: progress on e2e tests
* sdk/aptos: upgrade resource address derivation
This was changed recently
25696fd266/aptos-move/framework/aptos-framework/sources/account.move (L90-L95)
* sdk/js: fix getForeignAssetAptos
* sdk/js: update testnet aptos address
* sdk/js: update aptos entry functions
* sdk/aptos: fix parsesequencefromlog
* sdk/aptos: throw errors instead of string literal
* sdk/aptos: update testnet/mainnet addresses
* sdk/aptos: fix completeTransfer and getOriginalAsset
* sdk/aptos: update transferTokens to take in type and remove wormholeFee param
* sdk/aptos: add typeToExternalAddress utility
* sdk/js: update parseSequenceFromLogAptos
* sdk/js: test version bump again
* sdk/aptos: make transfer param type consistent
* sdk/aptos: test transfer to another chain test done
* sdk/aptos: use completeTransferAndRegister
* sdk/aptos: allow tryNativeToHexString to take in account addresses
* sdk/aptos: finish e2e tests
* sdk/aptos: test all apis
* sdk/aptos: add registerCoin utility
* sdk/js: utility to submit script bytecode to chain
* sdk/aptos: update test to be idempotent
* sdk/aptos: stricter check on aptos type
* clients/js: remove unused imports from rebase
* sdk/aptos: change node and faucet urls in ci
Co-authored-by: aki <akshath@live.com>
Co-authored-by: Evan Gray <battledingo@gmail.com>
* Prepare to deploy Xpla to mainnet
* Update SDK version
* Fix messed up error message
* Allow tests to pass with no XPLA tokens
* Make deploy script support testnet
* Update token bridge addresses after redeploy
A5 Pickle
Bojan Angjelkoski
Chirantan Ekbote
tbjump
bruce-riley
Kevin Peters
Evan Gray
Chris Sentman
Jeff Schroeder
Jonathan Claudius
guibescos
Nikhil Suri
aki
jumpsiegel
kev1n-peters
Conor Patrick
Hendrik Hofstadt
ckeun
Josh Siegel
justinschuldt
Bruce Riley
Paul Noel
A5 Pickle
Csongor Kiss
Csongor Kiss
Paul Noel
Evan Gray