Parameters are 0.03125% for kP and kI, 0.00981% for kD. Increased output 4 times to give enought room for kP.
PID now ignore compute if input is zero to avoid overshoot, kI and kD part as well.
Added idlePID.Initialize() to crank part to start PID from a working condition.
Show idleLoad when cranking.
Fix TS numbers, increase max value
Co-authored-by: Josh Stewart <josh@noisymime.org>
* pointers to Idle pins must always be initialized. This is good practice. But this also gave problems with internal flash as EEPROM on STM32 otherwise.
* cleanup
* Cranking enrichment tapering to ASE (or run)
* Precision fix and better helptext
* Fixed calculation and added comments
* Small fix for the taper final values
* Styling
* runSecsX10 is now uint32_t, so modify accordingly
* Changed the soft limit from absolute value to retard by
* Added selection for fixed and relative retard
Co-authored-by: Pasi Kemppainen <pazi88@users.noreply.github.com>
* Added new Flash EEPROM emulation
# Conflicts:
# platformio.ini
# speeduino/board_stm32_official.ino
# speeduino/init.ino
# speeduino/src/SPIAsEEPROM/SPIAsEEPROM.cpp
# speeduino/src/SPIAsEEPROM/SPIAsEEPROM.h
* changes to storage to make SPI flash work again
* cleanup
* Check and update ignition count target before checking other conditions to avoid peramently disabling ego correction in case ignition count rolls over while ego correction is disabled.
* Fix previous commit. Ego was reset between update cycles.
Co-authored-by: bera-n <notrevealedbera-n@gmail.com>
* New README format
* Update README.md
* STM32F407 fixes (#338)
* Correct overflow for 32bit timers
* fix pins PA0-PA5 on some f407 boards
* Enable access to SRAM Backup domain at boot
* Add missing callback functions
* Change timer resolutions. Corrects idle/aux timer frequencies
* 32 bit overflow only for STM32F4
* Check and update ignition count target before checking other conditions to avoid peramently disabling ego correction in case ignition count rolls over while ego correction is disabled. (#344)
Co-authored-by: bera-n <notrevealedbera-n@gmail.com>
Fixes#343
* Setup memory for vss
* Update all dialog help links to the new wiki
* [DFCO] Add a minimum coolant (#353)
* [DFCO] Add a minimum coolant
On pure ethanol or E85 the engine need a lot fuel to return from DFCO when cold.
Add a minimum temp
Fixes copy-paste error
Fix sign error
* Add signed cast on the calibration offset
Co-authored-by: Josh Stewart <josh@noisymime.org>
* AE cold temp correction
Added possibility to increase AE amount on cold engine. Max cold modifier is tapered with clt.
* Added help texts and value limitation in speeduino.ini and overflow prevention in corrections.ino
* Terminology patch
* Unsigned long in calculation isn't really needed as AE max setting is 255 (+100). Changed to uint16_t.
* Comment revision for the previous
* Updated function description
* Fixes to make correction equal in MAP and TPS modes
* AE cold temp correction
Added possibility to increase AE amount on cold engine. Max cold modifier is tapered with clt.
* Added help texts and value limitation in speeduino.ini and overflow prevention in corrections.ino
* Terminology patch
* Unsigned long in calculation isn't really needed as AE max setting is 255 (+100). Changed to uint16_t.
* Comment revision for the previous
* Updated function description
* Fixes to make correction equal in MAP and TPS modes
Co-authored-by: Josh Stewart <josh@noisymime.org>
Co-authored-by: iLeeeZi <ilari.vehniainen@hotmail.fi>
Co-authored-by: bera-n <bjorn.nyhlen@gmail.com>
Co-authored-by: Vitor Moreno B. Sales <vitor_boss@yahoo.com.br>
* fix building with spi flash as config storage
* Fixing build with spi flash as EEPROM. Changed some pin numbers to match the board i am designing and testing now.
* Now cs pin for spi eeprom is settable by flag in build enviroment.
* Correct overflow for 32bit timers
* fix pins PA0-PA5 on some f407 boards
* Enable access to SRAM Backup domain at boot
* Add missing callback functions
* Change timer resolutions. Corrects idle/aux timer frequencies
* 32 bit overflow only for STM32F4
* Update platformio.ini
debug tool added as default
* fix building with spi flash as config storage
* Fixing build with spi flash as EEPROM. Changed some pin numbers to match the board i am designing and testing now.
* Now cs pin for spi eeprom is settable by flag in build enviroment.
* Update platformio.ini
debug tool added as default
* Update cancomms.ino
Removed CAN build on black_F407VE for now. It needs fixing the build fails otherwise.
Co-authored-by: hoogendijkta <tjeerdie@users.noreply.github.com>
Co-authored-by: iLeeeZi <ilari.vehniainen@hotmail.fi>
* [DFCO] Include a delay
* [DFCO] Fix - delay isn't working if conditions aren't met immidiatly
Co-Authored-By: muuris <55035659+muuris@users.noreply.github.com>
Co-authored-by: Josh Stewart <josh@noisymime.org>
Co-authored-by: muuris <55035659+muuris@users.noreply.github.com>
It's already with this higher resolution in TS, and tuning idle and low load area with big injectors really require more than just one decimal precision.
* [DFCO] Add a minimum coolant
On pure ethanol or E85 the engine need a lot fuel to return from DFCO when cold.
Add a minimum temp
Fixes copy-paste error
Fix sign error
* Add signed cast on the calibration offset
Co-authored-by: Josh Stewart <josh@noisymime.org>
Josh Stewart
metacomgd
Tjeerd
Vitor Moreno B. Sales
Antti Muurikainen
Pasi Kemppainen
celso acyr
bera-n
audaciousengineer