Commit Graph

2773 Commits

Author SHA1 Message Date
Josh Stewart 11024a2070 Matching product string for legacy comms 2022-09-17 09:46:07 +10:00
Josh Stewart 3c70531c75 Product string for 202207.1 2022-09-17 09:29:59 +10:00
Josh Stewart 34a74779ff Flush serial rx buffer if a CRC error is found 2022-09-17 09:25:22 +10:00
Josh Stewart 56fde7c3fc Tweaks to 2560 EEPROM burn during multi page writes 2022-09-17 09:24:56 +10:00
Jon Billings 94152b2968 Jeep2000 fix (#912)
* Fix Jeep2000 decoder

getCrankAngle_Jeep2000() sets crankangle = 146 if toothcurrentcount = 0, because last tooth was cam tooth  which is 146 ATDC, however, all the timing and angle calculations are not done on the cam tooth read, so crankangle should be set to 118 for previous crank tooth.

* fix the fix

@jaredsellers4 pointed out that to be consistent with the rest of the crank tooth timings, it should be the leading edge, 114, rather than 118.

* Further improvement to Jeep 2000 decoder

1) filter out secondary signals when primary tooth is not 12 or 13 (because it's noise)
2) scale the trigger filter gap according to whether the next gap is bigger, smaller or the same as the previous/current gap.

* Revert "Further improvement to Jeep 2000 decoder"

This reverts commit 3510aa49c3.

* fix Jeep2000 to address #897

getCrankAngle_Jeep2000() sets crankangle = 146 + triggerAngle when toothCurrentCount = 0, because toothCurrentCount was set to 0 on seeing the Cam tooth, and the cam tooth angle is 146.
However, the tooth timings that are subsequently used in calculations are from the previous crank tooth, which was at 114. Therefore 114 is the correct crankangle to work with.

Co-authored-by: Jon Billings <jon.billings@bbc.co.uk>
2022-09-15 10:00:44 +10:00
ric355 050a07ece3 Fix for uninitialised variable in OLCL and CL stepper idle control (#926)
* Fix problem of using an uninitialised variable when initialising the stepper
after power on.

* Fix faulty idle taper causing OLCL and CL stepper to get stuck in the cranking position.

Co-authored-by: Richard Metcalfe <richard@richmet.com>
2022-09-13 23:17:51 +10:00
Josh Stewart 351985cedc Do not run SD logging if overall setting is disabled 2022-08-31 14:49:03 +10:00
Dave Smith 9ad5825408 Fix improper log entries (#920)
Format typos that cause the data to not be logged
2022-08-28 21:54:32 +10:00
Pasi Kemppainen 9a49e059ef Disable automatic retransmission (#910) 2022-08-10 11:07:29 +10:00
Tjeerd b1ce0cadcd Fix for idle PWM on STM32. Enable idle timer when idle pwm is enabled. Fixes #907
Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
2022-08-02 17:11:10 +10:00
a32guy 92786fd1a6 Add OLCL mode to initBoard() for teensy (#903)
Co-authored-by: csmergs <christopher@smeraglinolo.com>
2022-07-28 10:23:10 +10:00
Daniel Tobias feb21be0be cl boost control above baro should use logical and/or (#901) 2022-07-27 10:26:22 +10:00
Jon Billings 91c62e6229 fix check for DFCO off in correctionAFRclosedLoop() (#899)
line 608 has bit-and of configpage6.egotype > 0  & DFCO off.
it should be logical and &&
2022-07-27 10:22:34 +10:00
DeionSi fe2ab29b99 Volatile decoder variables (#902)
* triggerToothAngle is modified by interrupts

* triggerActualTeeth is never modified in interrupts
2022-07-27 10:09:37 +10:00
Josh Stewart 4518bb6c40 Update signatures for 202207 in legacy comms 2022-07-11 07:10:14 +10:00
Josh Stewart 77eca577a3 Update README.md 2022-07-11 00:11:08 +10:00
Josh Stewart 722072e5fa Signatures for 202207 2022-07-10 23:45:49 +10:00
Afroboltski d527f173a8
Add necessary pin translations (#887). Fixes #867 2022-07-10 22:38:42 +10:00
Tjeerd ca2bab0725
bug fix EGO PID controller + some improvements. (#879)
* Fix for EGO pid

* Further improvements on ego PID

* Stop EGO controllers from calculating while DFCO is active. To prevent integrator windup.

* Fix bug in DFCO enable/disable of the controller

Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
2022-07-09 22:22:18 +10:00
Josh Stewart ce7ea412db Missing commas in ini 2022-07-09 16:56:26 +10:00
Josh Stewart 6af9265f70 Fix typo from last commit 2022-07-08 22:54:15 +00:00
Min 15d43db61a
TS option to display pressure in bar #842 (#864)
Adds options in TunerStudio project settings to have default units
for fuel and oil pressure in bar. Adds gauge in kPa. This only
adds convertion from psi to bar, not affecting firmware.

Co-authored-by: Min <min@infcof.com>
2022-07-08 14:35:15 +10:00
Josh Stewart c129fa3326 Add option for SD logging with external switch 2022-07-08 14:31:48 +10:00
Josh Stewart fcde4f795b Add engine protection flags to datalog 2022-07-08 13:27:38 +10:00
Josh Stewart 63b52a5037 Remove controller priority on trigger edge. Fixes #860
This was added for a specific FW update in 2018 and no longer needed.
2022-06-29 17:42:52 +10:00
Josh Stewart 4ab13299b5 Remove old unused corrections code 2022-06-29 17:39:18 +10:00
Daniel Tobias a330b78632
Don't try to run inappropriate CI on forked repositories (#871) 2022-06-29 17:11:42 +10:00
Vitor Moreno B. Sales c6d9fd7a10
Fix for semi-seq inj after #478 (#883) 2022-06-29 16:41:52 +10:00
Vitor Moreno B. Sales adaa6a227e
Enable use of disabled functions pins (#549)
* Enable use pins of disabled functions or unused ign channels

* Added new pins and functions to check
2022-06-29 16:37:50 +10:00
Josh Stewart bb49774d4e Further fixes to the ASE correction 2022-06-27 12:18:17 +10:00
Pasi Kemppainen 0c8ced22a9
Fix hanging on boot (#858) 2022-06-27 11:54:47 +10:00
tx_haggis 3009c39767
Narrow scope of EEPROM_MAX_WRITE_BLOCK to writeConfig (#881)
* EEPROM_MAX_WRITE_BLOCK can be local to writeConfig()
This saves a byte of memory ;-)

* Fix MISRA/lint warnings
Correctly cast address parameter of eeprom_read_block
Statically access table 3d type_key member

* Remove force burn code - unused

* Replace eepromWritesPending with bit set/check

* Refactor: chain write_location instances.
Clearer code.
2022-06-27 11:53:33 +10:00
Josh Stewart bf23114b13 Fix broken build on Teensy from #880 2022-06-27 11:48:12 +10:00
Daniel Tobias 540b3a4fa2
Correct typos found by codespell (#880) 2022-06-27 10:39:14 +10:00
Tjeerd dc87795718
bug fix. A workaround for failing emulated on internal flash writes + a root cause fix (#876)
* workaround for failing flash writes

* Root cause fix for EEPROM emulation on STM32

* Oops, remove some debugging functions.

Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
2022-06-27 09:30:40 +10:00
larmicfre ae3347f571
Fixed value mode for AFR protection (#877) 2022-06-27 09:21:11 +10:00
larmicfre d5fc16d97c
Corrected RPM to TPS (#878). Fixes #874 2022-06-26 17:43:35 +10:00
Josh Stewart 61708a5716 Prevent cranking and ASE corrections running at once. Alternative fix to #868 2022-06-20 15:03:31 +10:00
larmicfre 298d994ba1
AFR protection function (#861)
* Implementing AFR protection

* Update globals.h

* Bug fixes and code refactoring

* Moved variables to prevent ODR

* Dialog for AFR protection

* Data size and math corrections

* Possibility to use either AFR or lambda

* Updated default AFR protection values

* No need to do multiplications due to existing RPMdiv100 variable

* The X100 multiplier was wrongfully removed

* Add defaults in updates.ino, minor formatting cleanups

Co-authored-by: Josh Stewart <josh@noisymime.org>
2022-06-20 09:52:07 +10:00
Josh Stewart f64d9348dc Only set the idle up pin state on init if it's enabled 2022-06-06 14:33:41 +10:00
Josh Stewart 1d85100ea7 Add dynamic EEPROM block write limit based on RPM. Should fix #859 2022-06-03 18:23:22 +10:00
Josh Stewart 30139e89af Minor cleanup of boost dialog from previous PR 2022-06-03 16:14:30 +10:00
Tjeerd 20c5e17756
Improve closedloop boost control (#736)
* First try on updating closedloop boost control

* added eeprom updates for backward comp[atibility

* fix merge conflict

* Change updates to next release EEPROM version.

* Fix some issues after merging master

* some cleanup to minimize changes and speedup review

* cleanup updates

* chances on updates to alaign with new table format

* move LUT to new config page in eeprom

* little cleanup

* Update storage.h comments

* fix some ini warnings

Co-authored-by: Tjeerd <tjeerdie@users.noreply.github.com>
2022-06-03 15:44:09 +10:00
Josh Stewart 5fafa94056 Fix unit test value 2022-06-01 17:06:44 +10:00
Josh Stewart 7055accb5a Merge branch 'master' of https://github.com/noisymime/speeduino 2022-06-01 00:04:28 +00:00
Josh Stewart 6390040263 Disable SD on T4.1 temporarily to prevent lockups. See #847 2022-06-01 00:04:20 +00:00
RempageR1 c2de8737fc
Moved currentStatus.startRevolutions++ so it only increments every revolution instead of every tooth. (#855)
Co-authored-by: RempageR1 <unconfigured@null.spigotmc.org>
2022-05-27 08:07:12 +10:00
Josh Stewart ec2fcd906f Add more unit tests for TAE 2022-05-25 15:28:11 +10:00
Josh Stewart e16108d806 Prevent overflow of the AE RPM taper. Fixes #843 2022-05-25 11:03:33 +10:00
Josh Stewart 3bd945f546 Add unit test for basic TAE 2022-05-25 11:02:55 +10:00