* calculateInjector1Timeout proxies calculateInjectorNTimeout
Unit test still pass.
* Remove calculateInjector1Timeout,
Replace with call to calculateInjectorTimeout
All unit tests still pass.
* Remove unecassary unit test
* calculateIgnition1Timeout proxies calculateIgnitionNTimeout
Unit test all pass
* Remove calculateIgnition1Timeout,
Replace with call to calculateIgnitionTimeout
All unit tests still pass.
* Remove unecassary unit test
* calculateIgnitionAngle\d proxies
calculateIgnitionAngle
Unit tests all pass
* Remove calculateIgnitionAngle\d
Just call calculateIgnitionAngle() directly
* Route rotary ignition angle calcs
through generic calculateIgnitionTrailingRotary
function.
* Remove calculateIgnitionAngle\d
Just call calculateIgnitionTrailingRotary() directly
* calculateInjectorStartAngle: inject all parameters
Do not rely on global state
Easier unit testing.
* calculateIgnitionAngle: inject all parameters
Do not rely on global state
Easier unit testing.
* Pull all ignition global vars into schedule_calcs
* Conditional compile for schedule calc vars
Saves memory
* Optimize: break out angleToTimeIntervalRev
from angleToTime. The new function will
always be inlined.
* Optimize - simpler code path
when no channel offset (zero)
Some optimization of arithmetic operations.
* Fix unit tests
* Fix bug on injector angle calculations
Need while loops to correctly bring intermediate
values into range
---------
Co-authored-by: Josh Stewart <josh@noisymime.org>
Fix against possible condition that when fuel closeInjector assignments are changed, some injectors could remain open.
To prevent this, check was added to ensure that no fuel injection is ongoing when switching is done from halfsync to fullsync.
* Added a 1000Hz call for MAP reading on ARM cores
* Use 1kHz section for map reads on all MCUs
---------
Co-authored-by: Josh Stewart <josh@noisymime.org>
Flex pin is still not user selectable in TS, but maybe added at some point. This also allows use of this on board configs.
Also switch to using div100 in the fuel temp code.
* adding VVT logging and trigger edge editing
fix missing define (temp fix?)
Revert "fix missing define (temp fix?)"
This reverts commit c6280f38ff69cc41278148a79c888736a71754b1.
fixes
* Create an additional logger screen in tunerstudio
Changes to create a third high speed logger window in tuner studio.
* Change variable name
Discord discussion requested compositeLogEnabled didn't do a test for false as the type is now a byte. Variable renamed to be compositeTriggerUsed and false replaced with 0. Variable name and values used should now make more logical sense.
* added more logging
Log the primary, secondary and third inputs as well as engine cycle on all composite logs. Still have 3 different logs to allow you to visualise which is the best way to present the information.
* fix check for engine rpm below target
code is checking for RPM > target speed, but comment says checking for below target speed.
The comment makes sense, the old code doesn't
* improve idle advance enabling
revert to original (rpm > (target - 200)), to avoid excessive advance in transition from cranking to running with IAC control units.
But add exception if no other idle control mechanism to start it immediately (e.g. ITBs)
* Read analog values via CAN BUS
Allows reading of 16 analog signals via CAN-BUS. with selection of Edianness.
* Moved function
Function moved to improve data readability.
---------
Co-authored-by: Josh Stewart <josh@noisymime.org>
Decodes the 5 known Rover MEMS ECU patterns for Rover based engines. Covers A series, T series, O Series, K Series and V8. Doesn't currently cover sequential ignition for v6 or v8.
Co-authored-by: Josh Stewart <josh@noisymime.org>
Resolves#101
Josh Stewart
tx_haggis
vaiski
Teemo Vaas
Vitor Moreno B. Sales
Pasi Kemppainen
mike501
Jon Billings
celso acyr